diff options
author | 2009-01-22 10:21:52 +0000 | |
---|---|---|
committer | 2009-01-22 10:21:52 +0000 | |
commit | 325dadfdc0d0cd2afcad8d04e8c973793f4866fc (patch) | |
tree | bc88745544df69ba4eb523b8ac9f511168f9b193 /src/emu/sound/sn76496.c | |
parent | 58af175636d898f6bda49c9e119c9f4bce373ed0 (diff) |
On Mon, Jan 19, 2009 at 02:48:05PM +0100, Olivier Galibert wrote:
> On Mon, Jan 19, 2009 at 05:37:35AM -0800, R. Belmont wrote:
> > My mistake. I thought you were suggesting that we should actually
> > somehow handle malloc failures. Given that aborting is an OK way to
> > express failure, I'd suggest the return values be changed to DEFER
> > and DONT_DEFER to eliminate the conceptual imbalance of OK/DEFER.
>
> That's where comes the fact that we have 130 OK/DONT_DEFER and 1
> DEFER. It makes me think that the exceptional DEFER case should be
> handled by an exceptional function call.
>
> I know, code talks, but I'm at work right now :-)
Here we go.
OG.
Diffstat (limited to 'src/emu/sound/sn76496.c')
-rw-r--r-- | src/emu/sound/sn76496.c | 16 |
1 files changed, 7 insertions, 9 deletions
diff --git a/src/emu/sound/sn76496.c b/src/emu/sound/sn76496.c index bcc71ef2dc6..af6ed2eecb9 100644 --- a/src/emu/sound/sn76496.c +++ b/src/emu/sound/sn76496.c @@ -314,7 +314,7 @@ static int SN76496_init(const device_config *device, int clock, struct SN76496 * } -static device_start_err generic_start(const device_config *device, int clock, int feedbackmask, int noisetaps, int noiseinvert) +static void generic_start(const device_config *device, int clock, int feedbackmask, int noisetaps, int noiseinvert) { struct SN76496 *chip = device->token; @@ -334,39 +334,37 @@ static device_start_err generic_start(const device_config *device, int clock, in state_save_register_device_item_array(device, 0, chip->Period); state_save_register_device_item_array(device, 0, chip->Count); state_save_register_device_item_array(device, 0, chip->Output); - - return DEVICE_START_OK; } static SND_START( sn76489 ) { - return generic_start(device, clock, 0x4000, 0x03, TRUE); + generic_start(device, clock, 0x4000, 0x03, TRUE); } static SND_START( sn76489a ) { - return generic_start(device, clock, 0x8000, 0x06, FALSE); + generic_start(device, clock, 0x8000, 0x06, FALSE); } static SND_START( sn76494 ) { - return generic_start(device, clock, 0x8000, 0x06, FALSE); + generic_start(device, clock, 0x8000, 0x06, FALSE); } static SND_START( sn76496 ) { - return generic_start(device, clock, 0x8000, 0x06, FALSE); + generic_start(device, clock, 0x8000, 0x06, FALSE); } static SND_START( gamegear ) { - return generic_start(device, clock, 0x8000, 0x09, FALSE); + generic_start(device, clock, 0x8000, 0x09, FALSE); } static SND_START( smsiii ) { - return generic_start(device, clock, 0x8000, 0x09, FALSE); + generic_start(device, clock, 0x8000, 0x09, FALSE); } |