diff options
author | Aaron Giles <aaron@aarongiles.com> | 2009-01-22 10:21:52 +0000 |
---|---|---|
committer | Aaron Giles <aaron@aarongiles.com> | 2009-01-22 10:21:52 +0000 |
commit | 325dadfdc0d0cd2afcad8d04e8c973793f4866fc (patch) | |
tree | bc88745544df69ba4eb523b8ac9f511168f9b193 /src/emu/sound/gaelco.c | |
parent | 58af175636d898f6bda49c9e119c9f4bce373ed0 (diff) |
On Mon, Jan 19, 2009 at 02:48:05PM +0100, Olivier Galibert wrote:
> On Mon, Jan 19, 2009 at 05:37:35AM -0800, R. Belmont wrote:
> > My mistake. I thought you were suggesting that we should actually
> > somehow handle malloc failures. Given that aborting is an OK way to
> > express failure, I'd suggest the return values be changed to DEFER
> > and DONT_DEFER to eliminate the conceptual imbalance of OK/DEFER.
>
> That's where comes the fact that we have 130 OK/DONT_DEFER and 1
> DEFER. It makes me think that the exceptional DEFER case should be
> handled by an exceptional function call.
>
> I know, code talks, but I'm at work right now :-)
Here we go.
OG.
Diffstat (limited to 'src/emu/sound/gaelco.c')
-rw-r--r-- | src/emu/sound/gaelco.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/src/emu/sound/gaelco.c b/src/emu/sound/gaelco.c index 811b3e2f27f..ea03c086b2e 100644 --- a/src/emu/sound/gaelco.c +++ b/src/emu/sound/gaelco.c @@ -242,7 +242,7 @@ WRITE16_HANDLER( gaelcosnd_w ) CG-1V/GAE1 Init ============================================================================*/ -static device_start_err gaelcosnd_start(sound_type sndtype, const device_config *device, int clock) +static void gaelcosnd_start(sound_type sndtype, const device_config *device, int clock) { int j, vol; const gaelcosnd_interface *intf = device->static_config; @@ -269,18 +269,16 @@ static device_start_err gaelcosnd_start(sound_type sndtype, const device_config if (LOG_WAVE) wavraw = wav_open("gae1_snd.wav", 8000, 2); - - return DEVICE_START_OK; } static SND_START( gaelco_gae1 ) { - return gaelcosnd_start(SOUND_GAELCO_GAE1, device, clock); + gaelcosnd_start(SOUND_GAELCO_GAE1, device, clock); } static SND_START( gaelco_cg1v ) { - return gaelcosnd_start(SOUND_GAELCO_CG1V, device, clock); + gaelcosnd_start(SOUND_GAELCO_CG1V, device, clock); } |