summaryrefslogtreecommitdiffstatshomepage
path: root/src/emu/debug
diff options
context:
space:
mode:
author Vas Crabb <vas@vastheman.com>2020-11-30 12:01:14 +1100
committer Vas Crabb <vas@vastheman.com>2020-11-30 12:01:14 +1100
commit1bdf8d272a32d161e11c96984bf3614de3210003 (patch)
treeaca314836043ffb5303de52ceaba860bf0860133 /src/emu/debug
parentf3454cee2f5fbfff068f53c3716ba187ea4b1492 (diff)
frontend: Lua engine improvements.
Added methods for enabling and disabling breakpoints and watchpoints, and made debugger views update when breakpoints/watchpoints are manipulated from Lua. Made breakpoints and watchpoints objects rather than tables. (It’s not possible to enable/disable a breakpoint or watchpoint from the object itself, you have to go through its owners' debug interface.) Exposed more device_t members for dealing with child/sibling tags and devices. Also provided a way to get regions/shares/banks from a device using relative tags rather than going through the memory manager with absolute tags.
Diffstat (limited to 'src/emu/debug')
-rw-r--r--src/emu/debug/debugcpu.cpp3
-rw-r--r--src/emu/debug/points.h2
2 files changed, 3 insertions, 2 deletions
diff --git a/src/emu/debug/debugcpu.cpp b/src/emu/debug/debugcpu.cpp
index 3c325d3a841..e91a7801b3c 100644
--- a/src/emu/debug/debugcpu.cpp
+++ b/src/emu/debug/debugcpu.cpp
@@ -1669,7 +1669,7 @@ void device_debug::breakpoint_update_flags()
break;
}
- if ( ! ( m_flags & DEBUG_FLAG_LIVE_BP ) )
+ if (!(m_flags & DEBUG_FLAG_LIVE_BP))
{
// see if there are any enabled registerpoints
for (debug_registerpoint &rp : *m_rplist)
@@ -1677,6 +1677,7 @@ void device_debug::breakpoint_update_flags()
if (rp.m_enabled)
{
m_flags |= DEBUG_FLAG_LIVE_BP;
+ break;
}
}
}
diff --git a/src/emu/debug/points.h b/src/emu/debug/points.h
index 220b75728ce..84cdad7720b 100644
--- a/src/emu/debug/points.h
+++ b/src/emu/debug/points.h
@@ -47,7 +47,7 @@ public:
const char *action() const { return m_action.c_str(); }
// setters
- void setEnabled(bool value) { m_enabled = value; }
+ void setEnabled(bool value) { m_enabled = value; } // FIXME: need to update breakpoint flags but it's a private method
private:
// internals