summaryrefslogtreecommitdiffstatshomepage
path: root/src/devices/video
diff options
context:
space:
mode:
author Vas Crabb <vas@vastheman.com>2018-05-25 22:28:49 +1000
committer Vas Crabb <vas@vastheman.com>2018-05-25 22:28:49 +1000
commit106e27478414a80e0959be52e55b23742855646c (patch)
treebaff6778e3449f8f9f7fb33a6935eaeb0bc5f255 /src/devices/video
parentfada3dfc8b58b1209c6dcd4cf7837b4d23c88d82 (diff)
remove many mainly PCI-related MCFG macros in favour of constructor
overloads, remove some absolute device lookups, remove some absolute device tags, and generally clean up stuff fix incorrect device class for PCI APIC (nw) xbox machine config looks ugly now - the devices should expose proper constructor overloads that accept the parts of the PCI ID that are in system PROM or customisable by the OEM and hard-code the parts inherent to the device
Diffstat (limited to 'src/devices/video')
-rw-r--r--src/devices/video/gf7600gs.h8
-rw-r--r--src/devices/video/mga2064w.cpp1
-rw-r--r--src/devices/video/mga2064w.h3
3 files changed, 6 insertions, 6 deletions
diff --git a/src/devices/video/gf7600gs.h b/src/devices/video/gf7600gs.h
index 0242a5ec8a4..db13718c6da 100644
--- a/src/devices/video/gf7600gs.h
+++ b/src/devices/video/gf7600gs.h
@@ -7,11 +7,13 @@
#include "machine/pci.h"
-#define MCFG_GEFORCE_7600GS_ADD(_tag, _subdevice_id) \
- MCFG_AGP_DEVICE_ADD(_tag, GEFORCE_7600GS, 0x10de02e1, 0xa1, _subdevice_id)
-
class geforce_7600gs_device : public pci_device {
public:
+ geforce_7600gs_device(const machine_config &mconfig, const char *tag, device_t *owner, uint32_t clock, uint32_t subdevice_id)
+ : geforce_7600gs_device(mconfig, tag, owner, clock)
+ {
+ set_ids_agp(0x10de02e1, 0xa1, subdevice_id);
+ }
geforce_7600gs_device(const machine_config &mconfig, const char *tag, device_t *owner, uint32_t clock);
protected:
diff --git a/src/devices/video/mga2064w.cpp b/src/devices/video/mga2064w.cpp
index 7bc5816c942..6654aa9ec2e 100644
--- a/src/devices/video/mga2064w.cpp
+++ b/src/devices/video/mga2064w.cpp
@@ -8,6 +8,7 @@ DEFINE_DEVICE_TYPE(MGA2064W, mga2064w_device, "mga2064w", "Matrox Millennium")
mga2064w_device::mga2064w_device(const machine_config &mconfig, const char *tag, device_t *owner, uint32_t clock)
: pci_device(mconfig, MGA2064W, tag, owner, clock)
{
+ set_ids(0x102b0519, 0x01, 0x030000, 0x00000000);
}
void mga2064w_device::device_start()
diff --git a/src/devices/video/mga2064w.h b/src/devices/video/mga2064w.h
index 8da3bdb0527..6766bf304a9 100644
--- a/src/devices/video/mga2064w.h
+++ b/src/devices/video/mga2064w.h
@@ -7,9 +7,6 @@
#include "machine/pci.h"
-#define MCFG_MGA2064W_ADD(_tag) \
- MCFG_PCI_DEVICE_ADD(_tag, MGA2064W, 0x102b0519, 0x01, 0x030000, 0x00000000)
-
class mga2064w_device : public pci_device {
public:
mga2064w_device(const machine_config &mconfig, const char *tag, device_t *owner, uint32_t clock);