path: root/src/devices/video/saa5050.h
diff options
authorGravatarGravatar Vas Crabb <>2017-05-07 23:18:47 +1000
committerGravatarGravatar Vas Crabb <>2017-05-14 21:44:11 +1000
commit0f0d39ef81562c75e79176dd3bebb1e491ca39d5 (patch)
tree201cee7fdf55ee800f83859a92efd2cfe66cf2b3 /src/devices/video/saa5050.h
parente6c4be2b4d71c7a6c95be0bae111eb416ff0f9e7 (diff)
Move static data out of devices into the device types. This is a significant change, so please pay attention.
The core changes are: * Short name, full name and source file are no longer members of device_t, they are part of the device type * MACHINE_COFIG_START no longer needs a driver class * MACHINE_CONFIG_DERIVED_CLASS is no longer necessary * Specify the state class you want in the GAME/COMP/CONS line * The compiler will work out the base class where the driver init member is declared * There is one static device type object per driver rather than one per machine configuration Use DECLARE_DEVICE_TYPE or DECLARE_DEVICE_TYPE_NS to declare device type. * DECLARE_DEVICE_TYPE forward-declares teh device type and class, and declares extern object finders. * DECLARE_DEVICE_TYPE_NS is for devices classes in namespaces - it doesn't forward-declare the device type. Use DEFINE_DEVICE_TYPE or DEFINE_DEVICE_TYPE_NS to define device types. * These macros declare storage for the static data, and instantiate the device type and device finder templates. The rest of the changes are mostly just moving stuff out of headers that shouldn't be there, renaming stuff for consistency, and scoping stuff down where appropriate. Things I've actually messed with substantially: * More descriptive names for a lot of devices * Untangled the fantasy sound from the driver state, which necessitates breaking up sound/flip writes * Changed DECO BSMT2000 ready callback into a device delegate * Untangled Microprose 3D noise from driver state * Used object finders for CoCo multipak, KC85 D002, and Irem sound subdevices * Started to get TI-99 stuff out of the TI-990 directory and arrange bus devices properly * Started to break out common parts of Samsung ARM SoC devices * Turned some of FM, SID, SCSP DSP, EPIC12 and Voodoo cores into something resmbling C++ * Tried to make Z180 table allocation/setup a bit safer * Converted generic keyboard/terminal to not use WRITE8 - space/offset aren't relevant * Dynamically allocate generic terminal buffer so derived devices (e.g. teleprinter) can specify size * Imporved encapsulation of Z80DART channels * Refactored the SPC7110 bit table generator loop to make it more readable * Added wrappers for SNES PPU operations so members can be made protected * Factored out some boilerplate for YM chips with PSG * toaplan2 gfx * stic/intv resolution * Video System video * Out Run/Y-board sprite alignment * GIC video hookup * Amstrad CPC ROM box members * IQ151 ROM cart region * MSX cart IRQ callback resolution time * SMS passthrough control devices starting subslots I've smoke-tested several drivers, but I've probably missed something. Things I've missed will likely blow up spectacularly with failure to bind errors and the like. Let me know if there's more subtle breakage (could have happened in FM or Voodoo). And can everyone please, please try to keep stuff clean. In particular, please stop polluting the global namespace. Keep things out of headers that don't need to be there, and use things that can be scoped down rather than macros. It feels like an uphill battle trying to get this stuff under control while more of it's added.
Diffstat (limited to 'src/devices/video/saa5050.h')
1 files changed, 16 insertions, 17 deletions
diff --git a/src/devices/video/saa5050.h b/src/devices/video/saa5050.h
index c88d840227c..4d943cefd0b 100644
--- a/src/devices/video/saa5050.h
+++ b/src/devices/video/saa5050.h
@@ -23,10 +23,10 @@
-#pragma once
+#ifndef MAME_VIDEO_SAA5050_H
+#define MAME_VIDEO_SAA5050_H
-#ifndef __SAA5050__
-#define __SAA5050__
+#pragma once
@@ -54,12 +54,11 @@ class saa5050_device : public device_t
// construction/destruction
- saa5050_device(const machine_config &mconfig, device_type type, const char *name, const char *tag, device_t *owner, uint32_t clock, const char *shortname, const char *source);
saa5050_device(const machine_config &mconfig, const char *tag, device_t *owner, uint32_t clock);
static void static_set_screen_size(device_t &device, int cols, int rows, int size) { downcast<saa5050_device &>(device).m_cols = cols; downcast<saa5050_device &>(device).m_rows = rows; downcast<saa5050_device &>(device).m_size = size; }
- template<class _Object> static devcb_base &set_d_rd_callback(device_t &device, _Object object) { return downcast<saa5050_device &>(device).m_read_d.set_callback(object); }
+ template <class Object> static devcb_base &set_d_rd_callback(device_t &device, Object &&cb) { return downcast<saa5050_device &>(device).m_read_d.set_callback(std::forward<Object>(cb)); }
// optional information overrides
virtual const tiny_rom_entry *device_rom_region() const override;
@@ -78,6 +77,8 @@ public:
uint32_t screen_update(screen_device &screen, bitmap_rgb32 &bitmap, const rectangle &cliprect);
+ saa5050_device(const machine_config &mconfig, device_type type, const char *tag, device_t *owner, uint32_t clock);
// device-level overrides
virtual void device_start() override;
virtual void device_reset() override;
@@ -254,15 +255,13 @@ public:
// device type definition
-extern const device_type SAA5050; // English
-extern const device_type SAA5051; // German
-extern const device_type SAA5052; // Swedish/Finnish
-extern const device_type SAA5053; // Italian
-extern const device_type SAA5054; // Belgian
-extern const device_type SAA5055; // US ASCII
-extern const device_type SAA5056; // Hebrew
-extern const device_type SAA5057; // Cyrillic
+DECLARE_DEVICE_TYPE(SAA5050, saa5050_device) // English
+DECLARE_DEVICE_TYPE(SAA5051, saa5051_device) // German
+DECLARE_DEVICE_TYPE(SAA5052, saa5052_device) // Swedish/Finnish
+DECLARE_DEVICE_TYPE(SAA5053, saa5053_device) // Italian
+DECLARE_DEVICE_TYPE(SAA5054, saa5054_device) // Belgian
+DECLARE_DEVICE_TYPE(SAA5055, saa5055_device) // US ASCII
+DECLARE_DEVICE_TYPE(SAA5056, saa5056_device) // Hebrew
+DECLARE_DEVICE_TYPE(SAA5057, saa5057_device) // Cyrillic
+#endif // MAME_VIDEO_SAA5050_H