summaryrefslogtreecommitdiffstatshomepage
path: root/src/devices/machine
diff options
context:
space:
mode:
author Vas Crabb <vas@vastheman.com>2022-11-06 08:09:23 +1100
committer Vas Crabb <vas@vastheman.com>2022-11-06 08:09:23 +1100
commit0fab97a476409dc80fc15219529a860e4eaf2b06 (patch)
treeeff8d577e40fadd3455bdfbb0dfa30070bc8b7ca /src/devices/machine
parent185f734a6cb76e602d0460f3da4109d357f177ae (diff)
Fixed a few issues identified by Coverity:
* cpu/m6805: Removed unnecessary comparison that can't be true from 'HC05 timer handler. * machine/z80scc.cpp: Fixed flag test in logging. * emu/devdelegate.h: Fixed use-after-move in functoid constructor. * util/unzip.cpp: Fixed integer promotion issue in ZIP16 member header handling. * util/xmlfile.cpp: Got rid of custom allocator functions that have alignment issues and no longer provide value. * capcom/alien.cpp: Use machine().rand() for determinism. * ensoniq/esqpanel.cpp: I/O stream eof() returns whether a read stopped short due to EOF, not whether the file pointer is at EOF. * sega/sms.cpp: Fixed a few use-after-move errors. * osd/modules/monitor: Fixed an apparent bug in what appears to be a setter member function.
Diffstat (limited to 'src/devices/machine')
-rw-r--r--src/devices/machine/z80scc.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/devices/machine/z80scc.cpp b/src/devices/machine/z80scc.cpp
index 020b2678bfd..48415c9a683 100644
--- a/src/devices/machine/z80scc.cpp
+++ b/src/devices/machine/z80scc.cpp
@@ -1918,7 +1918,7 @@ void z80scc_channel::do_sccreg_wr1(uint8_t data)
LOG("- Receiver Interrupt on Special Conditions only\n");
break;
}
- if ((data & WR1_RX_INT_MODE_MASK) == WR1_PARITY_IS_SPEC_COND)
+ if (data & WR1_PARITY_IS_SPEC_COND)
LOG("- Parity error is a Special Condition\n");
m_uart->check_interrupts();
}