path: root/src/devices/machine/eepromser.h
diff options
author Vas Crabb <>2022-04-03 03:05:53 +1000
committer Vas Crabb <>2022-04-03 03:07:28 +1000
commit530c5abb5da585ac71f9c643c9d6a2171280fe67 (patch)
tree978357b74d3506db174181e74bb3f4d81c421f64 /src/devices/machine/eepromser.h
parentc4f9ff9790382c1c5b99a2ffbb2a14e04d4c7cea (diff)
Revert initialisation of device members in headers.
This is problematic in several ways: * Initialising things at construction that aren't needed until after start slows down -romident, -validate, -listxml, etc. Slot cards can be a particular drain on -listxml and -validate as they're instantiated for every compatible slot. It's more pronounced for array members, too. * Splitting member initialisation between declaration in headers and constructors in source files means you have to look at two places to check for the initial value, and you always need to check the constructor even if an initialiser is present in the header because the constructor initaliser list takes precedence. (This isn't as much of an issue for driver classes because the constructor is most often inlined at declaration, so it isn't far from the member declarations.) * Initialisers in headers for frequently-used devices increases the frequency of recompiling dependent devices/drivers as they're exposed to any changes in initialisers. * Initialisers in frequently-used headers increase build times because there's more for the compiler to parse/cache. (This affects as well for single-driver builds, but that's a single pass.) It's not a lot individually, but it adds up given the size of MAME, which keeps increasing. We've already had one contributor banned from GitHub actions for resource usage, we don't want to waste compiler time unnecessarily.
Diffstat (limited to 'src/devices/machine/eepromser.h')
1 files changed, 4 insertions, 4 deletions
diff --git a/src/devices/machine/eepromser.h b/src/devices/machine/eepromser.h
index ac61f8f4aa9..d3d33db19d6 100644
--- a/src/devices/machine/eepromser.h
+++ b/src/devices/machine/eepromser.h
@@ -198,10 +198,10 @@ protected:
void copy_ram_to_eeprom();
void copy_eeprom_to_ram();
void device_start() override;
- uint8_t m_ram_length = 0;
- uint16_t m_ram_data[16]{};
- uint16_t m_reading = 0;
- uint8_t m_store_latch = 0;
+ uint8_t m_ram_length;
+ uint16_t m_ram_data[16];
+ uint16_t m_reading;
+ uint8_t m_store_latch;