diff options
author | 2016-04-07 18:59:38 -0400 | |
---|---|---|
committer | 2016-04-07 18:59:38 -0400 | |
commit | c0f366c61374775f8f8b7661e84705b568134dea (patch) | |
tree | 626e95fa31e6e8480983abbe305c0415ded783d2 /src/devices/machine/ds1204.cpp | |
parent | 5933d47ed740fd08c2f66f37fdca4f95e08df3d4 (diff) |
Devfind revision phase 1, cleaning out some legacy stuff
- Eliminate the cached device_t::m_region pointer and its region() getter method. Devices that need to bind to a region with the same tag should use optional/required_memory_region or optional/required_region_ptr with DEVICE_SELF as the subtag; this improves error checking. (DEVICE_SELF has been moved to device.h for greater visibility in the source.)
- Allow required/optional_region_ptr to specify a specific length which must match that of the region found.
- Implement finder_base::finder_tag() getter for diagnostic purposes.
- Perform some (not very efficient) validity checks on memory region finders instead of allowing them to automatically pass.
- Privatize device_memory_interface::m_addrspace.
Diffstat (limited to 'src/devices/machine/ds1204.cpp')
-rw-r--r-- | src/devices/machine/ds1204.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/devices/machine/ds1204.cpp b/src/devices/machine/ds1204.cpp index 72029b2aecc..56d57267ad3 100644 --- a/src/devices/machine/ds1204.cpp +++ b/src/devices/machine/ds1204.cpp @@ -32,6 +32,7 @@ const device_type DS1204 = &device_creator<ds1204_device>; ds1204_device::ds1204_device( const machine_config &mconfig, const char *tag, device_t *owner, UINT32 clock ) : device_t( mconfig, DS1204, "DS1204", tag, owner, clock, "ds1204", __FILE__ ), device_nvram_interface(mconfig, *this), + m_region(*this, DEVICE_SELF), m_rst( 0 ), m_clk( 0 ), m_dqw( 0 ), m_dqr(0), m_state(0), m_bit(0) @@ -69,7 +70,7 @@ void ds1204_device::nvram_default() int expected_bytes = sizeof( m_unique_pattern ) + sizeof( m_identification ) + sizeof( m_security_match ) + sizeof( m_secure_memory ); - if( !m_region ) + if (!m_region.found()) { logerror( "ds1204(%s) region not found\n", tag() ); } |