diff options
author | 2023-03-30 20:23:35 -0400 | |
---|---|---|
committer | 2023-03-30 20:40:34 -0400 | |
commit | 6f7e4141ea14acaaf9cb973c66788fabb3457023 (patch) | |
tree | b7d89cfdacecbe34257c15c199a85b0a806850db /src/devices/imagedev/bitbngr.cpp | |
parent | 7579c2f89dbcd509e4083bd578d2864d342caad4 (diff) |
API change for device_image_interface
- Remove the seterror method for recording error messages and conditions. Condition codes have been made return values for call_load, call_create and various related callbacks. Error messages (which many devices weren't generating) are now displayed through osd_printf_error.
- Eliminate the image_init_result and image_verify_result pass/fail enumeration types. Update many functions that were returning these enumerations or simply bools to return std::error_condition instead. In some cases, this type is now passed down from internal parsing/loading functions which were already returning it. In various other cases, the former default UNSPECIFIED has been used as a catchall for I/O errors; anticipated future refactorings should make these error returns more specific.
- Expand the image_error categories to include INVALIDLENGTH, NOSOFTWARE and BADSOFTWARE. The first is largely self-explanatory. The second is generated by the core to indicate failure to find software items in lists. The third is provided for devices to indicate semantic errors in software list entries.
- Change the return type of floppy_image_device::identify to a pair so the potential error condition can be passed along to the UI without storing it in a member variable.
- Move device_image_interface::message down into snapshot_image_device and change its implementation to use string_format instead of printf.
- Correct a typo in the shortname of the generic snapshot device.
Diffstat (limited to 'src/devices/imagedev/bitbngr.cpp')
-rw-r--r-- | src/devices/imagedev/bitbngr.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/devices/imagedev/bitbngr.cpp b/src/devices/imagedev/bitbngr.cpp index dc31c4ccb83..07b88f41386 100644 --- a/src/devices/imagedev/bitbngr.cpp +++ b/src/devices/imagedev/bitbngr.cpp @@ -85,16 +85,16 @@ const software_list_loader &bitbanger_device::get_software_list_loader() const call_load -------------------------------------------------*/ -image_init_result bitbanger_device::call_load() +std::error_condition bitbanger_device::call_load() { // we don't need to do anything special - return image_init_result::PASS; + return std::error_condition(); } -image_init_result bitbanger_device::call_create(int format_type, util::option_resolution *format_options) +std::error_condition bitbanger_device::call_create(int format_type, util::option_resolution *format_options) { // we don't need to do anything special - return image_init_result::PASS; + return std::error_condition(); } /*------------------------------------------------- |