summaryrefslogtreecommitdiffstatshomepage
path: root/hash/fmtowns_flop.xml
diff options
context:
space:
mode:
author Vas Crabb <vas@vastheman.com>2020-04-16 05:05:16 +1000
committer Vas Crabb <vas@vastheman.com>2020-04-16 14:04:06 +1000
commit1a5c013c330fd1a6b3d21d9bbbaf512539ae4503 (patch)
treeb3ff6b9f247bdb2f721346a6adae7157d0a66c90 /hash/fmtowns_flop.xml
parent94ddd2d427700c5802e00adda0d3373941d06bba (diff)
(nw) softlist_dev.cpp: validate ROM labels
The free-for-all on labels in software lists is not working. There's no consistency, labels are getting excessively long, people are starting to use non-ASCII characters in labels making it harder for others to type them when manipulating files on the command line, and there's too much markup being put in labels. The length limit is 127 characters, same as for labels in MAME itself. This should be long enough to be descriptive. Remember that the Win32 path limit is 260 characters, and many applications and frameworks have issues with longer paths, including Windows Explorer and the .NET framework. Labels are used as filenames, so concessions need to be made for this. I have not abbreviated excessively long labels myself - they're currently causing 135 validity errors. Someone else can fix them. Printable ASCII characters are allowed, with a few exceptions. The exceptions are limited to characters most likely to cause issues for interactive shells and scripts: * ! - csh event substitution (very difficult to escape properly) * $ - sh varibale expansion * % - csh job control, cmd variable expansion * / - UNIX directory separator * : - sh path separator, Windows drive qualifier * \ - sh escape, Windows directory separator Most of the labels that had to be edited were using ! for markup, or using ! and % for titles in labels. Strangely, titles in labels are often forced to lower case, despite this never being enforced for software lists. There are also various other edits to titles used for labels, such as moving articles to the end (with or without a comma), or replacing spaces with underscores. As I already said, there's no consistency at all. There is far too much markup in labels. They're even being used for notes in some cases (e.g. at least one case where a dumper's name is in the label). The XML schema supports metadata - use it. For example, you can use part_id for an unrestricted display name for a software part. You can also use XML comments for notes. And while on the topic of metadata, vgmplay.xml is putting the same thing in the part_id as well as the label. The part_id should have the actual title, not the title mangled to make it more suitable for use as a filename. Addressing this would be a lot of work, given how large the file is. For now, empty data areas in software lists cause a verbose message rather than a validation warning. There are thousands of software lists using empty data areas to indicate the size/width of cartridge RAM/EEPROM/etc.
Diffstat (limited to 'hash/fmtowns_flop.xml')
-rw-r--r--hash/fmtowns_flop.xml10
1 files changed, 5 insertions, 5 deletions
diff --git a/hash/fmtowns_flop.xml b/hash/fmtowns_flop.xml
index d980ac7c744..59f437cdccd 100644
--- a/hash/fmtowns_flop.xml
+++ b/hash/fmtowns_flop.xml
@@ -493,19 +493,19 @@ Zurukamashi Ver 2.0 Nikkonren Kikaku
<part name="flop1" interface="floppy_3_5">
<feature name="part_id" value="Disk A" />
<dataarea name="flop" size="1261568">
- <rom name="asuka 120% burning fest. (disk a).hdm" size="1261568" crc="46a5074d" sha1="8efb863ea0878f9236082f7d7935f494c4522899"/>
+ <rom name="asuka 120 burning fest. (disk a).hdm" size="1261568" crc="46a5074d" sha1="8efb863ea0878f9236082f7d7935f494c4522899"/>
</dataarea>
</part>
<part name="flop2" interface="floppy_3_5">
<feature name="part_id" value="Disk B" />
<dataarea name="flop" size="1261568">
- <rom name="asuka 120% burning fest. (disk b).hdm" size="1261568" crc="2a448e8f" sha1="3b57fd0a2fecec56a3362884de0770ec4538f5eb"/>
+ <rom name="asuka 120 burning fest. (disk b).hdm" size="1261568" crc="2a448e8f" sha1="3b57fd0a2fecec56a3362884de0770ec4538f5eb"/>
</dataarea>
</part>
<part name="flop3" interface="floppy_3_5">
<feature name="part_id" value="Disk C" />
<dataarea name="flop" size="1261568">
- <rom name="asuka 120% burning fest. (disk c).hdm" size="1261568" crc="ac9a582e" sha1="726b05d573e0776006cee6aa8c71009b1e66b5cc"/>
+ <rom name="asuka 120 burning fest. (disk c).hdm" size="1261568" crc="ac9a582e" sha1="726b05d573e0776006cee6aa8c71009b1e66b5cc"/>
</dataarea>
</part>
</software>
@@ -889,13 +889,13 @@ Zurukamashi Ver 2.0 Nikkonren Kikaku
<part name="flop1" interface="floppy_3_5">
<feature name="part_id" value="Disk A" />
<dataarea name="flop" size="1261568">
- <rom name="dr. stop! (disk a).hdm" size="1261568" crc="622bc757" sha1="7b0e12a71c8b531ac355d733239d72a4223a5bd6"/>
+ <rom name="dr. stop (disk a).hdm" size="1261568" crc="622bc757" sha1="7b0e12a71c8b531ac355d733239d72a4223a5bd6"/>
</dataarea>
</part>
<part name="flop2" interface="floppy_3_5">
<feature name="part_id" value="Disk B" />
<dataarea name="flop" size="1261568">
- <rom name="dr. stop! (disk b).hdm" size="1261568" crc="faf6169c" sha1="c1cf3ecbcda6da2e581b0b00f481abef33c0c626"/>
+ <rom name="dr. stop (disk b).hdm" size="1261568" crc="faf6169c" sha1="c1cf3ecbcda6da2e581b0b00f481abef33c0c626"/>
</dataarea>
</part>
</software>