summaryrefslogtreecommitdiffstatshomepage
diff options
context:
space:
mode:
author npwoods <npwoods@alumni.carnegiemellon.edu>2017-04-15 16:33:05 -0400
committer Olivier Galibert <galibert@pobox.com>2017-04-15 22:33:05 +0200
commitf81389dcfa3a63961d6ac82d9a51ea3f797d914b (patch)
tree3ff014725713a1af292175e961d4ac8d8d30950c
parent02ea4fd43cb42ffdbba6f87a93c03b697c426269 (diff)
Changed validity_checker to keep a fresh emu_options for validation purposes (#2232)
* Changed validity_checker to keep a fresh emu_options for validation purposes This seems to solve the performance problems introduced by PR#2221 while keeping with that PR's goals of not using the "runtime" emu_options for purposes of validation. * Sorry, I can't spell apparently...
-rw-r--r--src/emu/validity.cpp3
-rw-r--r--src/emu/validity.h4
2 files changed, 5 insertions, 2 deletions
diff --git a/src/emu/validity.cpp b/src/emu/validity.cpp
index 79c10cad412..3a70385b3e1 100644
--- a/src/emu/validity.cpp
+++ b/src/emu/validity.cpp
@@ -298,8 +298,7 @@ void validity_checker::validate_one(const game_driver &driver)
// wrap in try/except to catch fatalerrors
try
{
- emu_options options;
- machine_config config(driver, options);
+ machine_config config(driver, m_blank_options);
m_current_config = &config;
validate_driver();
validate_roms();
diff --git a/src/emu/validity.h b/src/emu/validity.h
index 05b2ac5cf63..a845bac4610 100644
--- a/src/emu/validity.h
+++ b/src/emu/validity.h
@@ -14,6 +14,7 @@
#pragma once
#include "drivenum.h"
+#include "emuopts.h"
//**************************************************************************
@@ -98,6 +99,9 @@ private:
// internal driver list
driver_enumerator m_drivlist;
+ // blank options for use during validation
+ emu_options m_blank_options;
+
// error tracking
int m_errors;
int m_warnings;