summaryrefslogtreecommitdiffstatshomepage
diff options
context:
space:
mode:
author R. Belmont <rb6502@users.noreply.github.com>2017-03-10 11:46:03 -0500
committer GitHub <noreply@github.com>2017-03-10 11:46:03 -0500
commitcfda3b1ffdbc961121f45cef6e752422c6d362b9 (patch)
tree7a909d8ddf182f7109d530e6d26ecf5842236388
parent4c1b4196a97a84f64d8c4d414667790e6141ec28 (diff)
parent3a3520e916aca63457dd668fdb696884254cf62f (diff)
Merge pull request #2125 from npwoods/new_addrmap_validation
Adds a new addrmap.cpp validation intended to catch AM_REGION declarations not tied to anything meaningful
-rw-r--r--src/emu/addrmap.cpp4
1 files changed, 4 insertions, 0 deletions
diff --git a/src/emu/addrmap.cpp b/src/emu/addrmap.cpp
index 31fabbea1a5..5b12f139026 100644
--- a/src/emu/addrmap.cpp
+++ b/src/emu/addrmap.cpp
@@ -665,6 +665,10 @@ void address_map::map_validity_check(validity_checker &valid, address_spacenum s
// if this entry references a memory region, validate it
if (entry.m_region != nullptr && entry.m_share == nullptr)
{
+ // address map entries that reference regions but are NOPs are pointless
+ if (entry.m_read.m_type == AMH_NONE && entry.m_write.m_type == AMH_NONE)
+ osd_printf_error("%s space references memory region %s, but is AM_NOP\n", spaceconfig.m_name, entry.m_region);
+
// make sure we can resolve the full path to the region
bool found = false;
std::string entry_region = entry.m_devbase.subtag(entry.m_region);