diff options
| author | 2026-01-14 10:53:14 +0100 | |
|---|---|---|
| committer | 2026-01-14 10:53:42 +0100 | |
| commit | 8451c206b88ae3de75751b5d981fed4ca7d5eed2 (patch) | |
| tree | 8fbacda385dbeb255c21162b86a8ed9b51640103 | |
| parent | fbaa979fc54f8f0c0c371e13d754a5c1667081b1 (diff) | |
20pacgal: update note, small cleanup
| -rw-r--r-- | src/mame/namco/20pacgal.cpp | 18 | ||||
| -rw-r--r-- | src/mame/namco/20pacgal.h | 4 |
2 files changed, 7 insertions, 15 deletions
diff --git a/src/mame/namco/20pacgal.cpp b/src/mame/namco/20pacgal.cpp index f332bea2e5c..6c88b7333fe 100644 --- a/src/mame/namco/20pacgal.cpp +++ b/src/mame/namco/20pacgal.cpp @@ -87,8 +87,8 @@ Graphics: CY37256P160-83AC x 2 (Ultra37000 CPLD family - 160 pin TQFP, 256 Macro VSync: 60.60175Hz The DAC (of the Namco sound chip, apparently combined with the generic DAC) - is the same as on the old Pac-Man hardware, digital output is 8 lines from - a CPLD. + is the same as on the old Pac-Man hardware, controlled by 8 lines from a + CPLD (4 for sound, 4 for volume). ***************************************************************************/ @@ -126,7 +126,7 @@ void _20pacgal_state::timer_pulse_w(uint8_t data) * *************************************/ -void _20pacgal_state::_20pacgal_coin_counter_w(uint8_t data) +void _20pacgal_state::coin_counter_w(uint8_t data) { machine().bookkeeping().coin_counter_w(0, data & 1); } @@ -229,11 +229,6 @@ void _20pacgal_state::_20pacgal_map(address_map &map) * *************************************/ -uint8_t _25pacman_state::_25pacman_io_87_r() -{ - return 0xff; -} - void _25pacman_state::_25pacman_io_map(address_map &map) { map.global_mask(0xff); @@ -247,14 +242,13 @@ void _25pacman_state::_25pacman_io_map(address_map &map) map(0x82, 0x82).w(FUNC(_25pacman_state::irqack_w)); // map(0x84, 0x84).noprw(); // ?? map(0x85, 0x86).writeonly().share("stars_seed"); // stars: rng seed (lo/hi) - map(0x87, 0x87).r(FUNC(_25pacman_state::_25pacman_io_87_r)); // not eeprom on this - map(0x87, 0x87).nopw(); + map(0x87, 0x87).lr8(NAME([] () { return 0xff; })).nopw(); // not eeprom on this // map(0x88, 0x88).w(FUNC(_25pacman_state::ram_bank_select_w)); map(0x89, 0x89).w("dac", FUNC(dac_byte_interface::data_w)); map(0x8a, 0x8a).writeonly().share("stars_ctrl"); // stars: bits 3-4 = active set; bit 5 = enable map(0x8b, 0x8b).writeonly().share("flip"); map(0x8c, 0x8c).nopw(); - map(0x8f, 0x8f).w(FUNC(_25pacman_state::_20pacgal_coin_counter_w)); + map(0x8f, 0x8f).w(FUNC(_25pacman_state::coin_counter_w)); } void _20pacgal_state::_20pacgal_io_map(address_map &map) @@ -275,7 +269,7 @@ void _20pacgal_state::_20pacgal_io_map(address_map &map) map(0x89, 0x89).w("dac", FUNC(dac_byte_interface::data_w)); map(0x8a, 0x8a).writeonly().share("stars_ctrl"); // stars: bits 3-4 = active set; bit 5 = enable map(0x8b, 0x8b).writeonly().share("flip"); - map(0x8f, 0x8f).w(FUNC(_20pacgal_state::_20pacgal_coin_counter_w)); + map(0x8f, 0x8f).w(FUNC(_20pacgal_state::coin_counter_w)); } diff --git a/src/mame/namco/20pacgal.h b/src/mame/namco/20pacgal.h index abb9a0edc65..e14a4e19645 100644 --- a/src/mame/namco/20pacgal.h +++ b/src/mame/namco/20pacgal.h @@ -79,7 +79,7 @@ protected: uint8_t m_irq_mask = 0; void irqack_w(uint8_t data); void timer_pulse_w(uint8_t data); - void _20pacgal_coin_counter_w(uint8_t data); + void coin_counter_w(uint8_t data); void ram_bank_select_w(uint8_t data); void ram_48000_w(offs_t offset, uint8_t data); void sprite_gfx_w(offs_t offset, uint8_t data); @@ -113,8 +113,6 @@ public: void _25pacman(machine_config &config); private: - uint8_t _25pacman_io_87_r(); - virtual void machine_start() override ATTR_COLD; void _25pacman_io_map(address_map &map) ATTR_COLD; |
