summaryrefslogtreecommitdiffstatshomepage
diff options
context:
space:
mode:
author AJR <ajrhacker@users.noreply.github.com>2017-06-14 07:58:51 -0400
committer AJR <ajrhacker@users.noreply.github.com>2017-06-14 07:58:51 -0400
commit7f901c154f28c70a4cc1b4e0262068a86de03819 (patch)
treecb4c4087e191d6c5697ea99376ec6fa680f56ff8
parent916ec15e53b7b1b4f59b811568d4f3ece088b5e8 (diff)
Use the new 8255 tristate callbacks to remove some workarounds (nw)
-rw-r--r--src/mame/drivers/subsino.cpp5
-rw-r--r--src/mame/drivers/suprloco.cpp1
-rw-r--r--src/mame/video/suprloco.cpp3
3 files changed, 3 insertions, 6 deletions
diff --git a/src/mame/drivers/subsino.cpp b/src/mame/drivers/subsino.cpp
index b9c859903f1..86bdbfdc614 100644
--- a/src/mame/drivers/subsino.cpp
+++ b/src/mame/drivers/subsino.cpp
@@ -666,9 +666,6 @@ WRITE8_MEMBER(subsino_state::subsino_out_a_w)
*/
- if (data == 0xff)
- return;
-
output().set_lamp_value(8, (data) & 1); /* Lamp 8 */
output().set_lamp_value(9, (data >> 1) & 1); /* Lamp 9 */
output().set_lamp_value(10, (data >> 2) & 1); /* Lamp 10 */
@@ -2759,7 +2756,9 @@ static MACHINE_CONFIG_START( victor21 )
MCFG_DEVICE_ADD("ppi", I8255A, 0)
MCFG_I8255_OUT_PORTA_CB(WRITE8(subsino_state, subsino_out_a_w))
+ MCFG_I8255_TRISTATE_PORTA_CB(CONSTANT(0))
MCFG_I8255_OUT_PORTB_CB(WRITE8(subsino_state, subsino_out_b_w))
+ MCFG_I8255_TRISTATE_PORTB_CB(CONSTANT(0))
MCFG_I8255_IN_PORTC_CB(IOPORT("INC"))
MCFG_TICKET_DISPENSER_ADD("hopper", attotime::from_msec(200), TICKET_MOTOR_ACTIVE_HIGH, TICKET_STATUS_ACTIVE_LOW)
diff --git a/src/mame/drivers/suprloco.cpp b/src/mame/drivers/suprloco.cpp
index f5bc3e4413f..4eb2794319b 100644
--- a/src/mame/drivers/suprloco.cpp
+++ b/src/mame/drivers/suprloco.cpp
@@ -188,6 +188,7 @@ static MACHINE_CONFIG_START( suprloco )
MCFG_DEVICE_ADD("ppi", I8255A, 0)
MCFG_I8255_OUT_PORTB_CB(WRITE8(suprloco_state, control_w))
+ MCFG_I8255_TRISTATE_PORTB_CB(CONSTANT(0))
MCFG_I8255_OUT_PORTC_CB(WRITELINE(suprloco_state, pc0_w)) MCFG_DEVCB_BIT(0)
MCFG_DEVCB_CHAIN_OUTPUT(INPUTLINE("audiocpu", INPUT_LINE_NMI)) MCFG_DEVCB_BIT(7) MCFG_DEVCB_INVERT
diff --git a/src/mame/video/suprloco.cpp b/src/mame/video/suprloco.cpp
index 6e310c2cf8e..19401afaf4f 100644
--- a/src/mame/video/suprloco.cpp
+++ b/src/mame/video/suprloco.cpp
@@ -128,9 +128,6 @@ WRITE8_MEMBER(suprloco_state::scrollram_w)
WRITE8_MEMBER(suprloco_state::control_w)
{
- if (data == 0xff)
- return;
-
/* There is probably a palette select in here */
/* Bit 0 - coin counter A */