summaryrefslogtreecommitdiffstatshomepage
diff options
context:
space:
mode:
author AJR <ajrhacker@users.noreply.github.com>2018-11-26 14:30:18 -0500
committer AJR <ajrhacker@users.noreply.github.com>2018-11-26 14:30:34 -0500
commit63bbb5608b0ab8a5e1103b0e14b1ff86f6619b3e (patch)
treef2d21dd5a08077b145bc0734cdca904a4379b3cd
parent956a095784f1a3b9d1672f99103b4b3cb5ce16ea (diff)
dimemory: Make validity checker warn about configured maps for nonexistent spaces (nw)
-rw-r--r--src/emu/dimemory.cpp4
-rw-r--r--src/mame/drivers/rvoice.cpp7
2 files changed, 3 insertions, 8 deletions
diff --git a/src/emu/dimemory.cpp b/src/emu/dimemory.cpp
index 5b8b79569a7..d95b650b8ea 100644
--- a/src/emu/dimemory.cpp
+++ b/src/emu/dimemory.cpp
@@ -94,7 +94,7 @@ void device_memory_interface::interface_config_complete()
void device_memory_interface::interface_validity_check(validity_checker &valid) const
{
// loop over all address spaces
- for (int spacenum = 0; spacenum < int(m_address_config.size()); ++spacenum)
+ for (int spacenum = 0; spacenum < int(m_address_map.size()); ++spacenum)
{
if (space_config(spacenum))
{
@@ -104,5 +104,7 @@ void device_memory_interface::interface_validity_check(validity_checker &valid)
// let the map check itself
addrmap.map_validity_check(valid, spacenum);
}
+ else if (!m_address_map[spacenum].isnull())
+ osd_printf_warning("Map configured for nonexistent memory space %d\n", spacenum);
}
}
diff --git a/src/mame/drivers/rvoice.cpp b/src/mame/drivers/rvoice.cpp
index f2cabc9ed8c..f4c17174833 100644
--- a/src/mame/drivers/rvoice.cpp
+++ b/src/mame/drivers/rvoice.cpp
@@ -91,7 +91,6 @@ private:
void null_kbd_put(u8 data);
required_device<cpu_device> m_maincpu;
required_device<generic_terminal_device> m_terminal;
- void hd63701_main_io(address_map &map);
void hd63701_main_mem(address_map &map);
};
@@ -347,11 +346,6 @@ void rvoice_state::hd63701_main_mem(address_map &map)
map(0x8000, 0xffff).rom(); // 27512 EPROM
}
-void rvoice_state::hd63701_main_io(address_map &map)
-{
- map.unmap_value_high();
-}
-
/******************************************************************************
Input Ports
@@ -370,7 +364,6 @@ MACHINE_CONFIG_START(rvoice_state::rvoicepc)
/* basic machine hardware */
MCFG_DEVICE_ADD("maincpu", HD63701, XTAL(7'372'800))
MCFG_DEVICE_PROGRAM_MAP(hd63701_main_mem)
- MCFG_DEVICE_IO_MAP(hd63701_main_io)
//MCFG_DEVICE_ADD("playercpu", HD63701, XTAL(7'372'800)) // not dumped yet
//MCFG_DEVICE_PROGRAM_MAP(hd63701_slave_mem)