summaryrefslogtreecommitdiffstatshomepage
diff options
context:
space:
mode:
author Joakim Larsson Edström <joakimlarsson42@gmail.com>2019-10-30 00:27:48 +0100
committer ajrhacker <ajrhacker@users.noreply.github.com>2019-10-29 19:27:48 -0400
commit58c86eb73cd140a574ba12b0084bf77c11a81386 (patch)
treec8690b94d016f1e27f011c5fa3bbb5c68ae7871d
parentcebd828fcd1a85c79bc2b031b93891fd22f28865 (diff)
i8251a initilization changed (#5825)
* i8251.cpp: required initial state to enable receiver of a 8251a and also to avoid sending start bit to diserial on reset and get framing error * eispc_kb.cpp: removed need for scheduler abuse as problem is fixed by correcting the init of the i8251 USART on host side instead * eispc.cpp: removed an obsolete TODO
-rw-r--r--src/devices/machine/i8251.cpp2
-rw-r--r--src/mame/drivers/eispc.cpp2
-rw-r--r--src/mame/machine/eispc_kb.cpp5
3 files changed, 2 insertions, 7 deletions
diff --git a/src/devices/machine/i8251.cpp b/src/devices/machine/i8251.cpp
index 5c1638acffd..2ef674ec1c0 100644
--- a/src/devices/machine/i8251.cpp
+++ b/src/devices/machine/i8251.cpp
@@ -67,7 +67,7 @@ i8251_device::i8251_device(
m_syndet_handler(*this),
m_cts(1),
m_dsr(1),
- m_rxd(0),
+ m_rxd(1),
m_rxc(0),
m_txc(0)
{
diff --git a/src/mame/drivers/eispc.cpp b/src/mame/drivers/eispc.cpp
index a26462103d4..73ac0c415f2 100644
--- a/src/mame/drivers/eispc.cpp
+++ b/src/mame/drivers/eispc.cpp
@@ -996,7 +996,7 @@ INPUT_PORTS_END
ROM_START( epc )
ROM_REGION(0x10000,"bios", 0)
ROM_DEFAULT_BIOS("p860110")
- ROM_SYSTEM_BIOS(0, "p840705", "P840705") // TODO: Fix "Keyboard error" for this bios
+ ROM_SYSTEM_BIOS(0, "p840705", "P840705")
ROMX_LOAD("ericsson_8088.bin", 0xe000, 0x2000, CRC(3953c38d) SHA1(2bfc1f1d11d0da5664c3114994fc7aa3d6dd010d), ROM_BIOS(0))
ROM_SYSTEM_BIOS(1, "p860110", "P860110")
ROMX_LOAD("epcbios1.bin", 0xe000, 0x02000, CRC(79a83706) SHA1(33528c46a24d7f65ef5a860fbed05afcf797fc55), ROM_BIOS(1))
diff --git a/src/mame/machine/eispc_kb.cpp b/src/mame/machine/eispc_kb.cpp
index 09031c65bd1..1befb833bc7 100644
--- a/src/mame/machine/eispc_kb.cpp
+++ b/src/mame/machine/eispc_kb.cpp
@@ -267,23 +267,18 @@ WRITE_LINE_MEMBER(eispc_keyboard_device::hold_w)
m_hold = CLEAR_LINE == state;
}
-// TODO: Fix proper HOLD of reset line for MCU until released by hist CPU
WRITE_LINE_MEMBER(eispc_keyboard_device::rst_line_w)
{
if (state == CLEAR_LINE)
{
- //m_mcu->resume(SUSPEND_REASON_RESET);
m_mcu->set_input_line(INPUT_LINE_RESET, CLEAR_LINE);
LOGRST("KBD: Keyboard mcu reset line is cleared\n");
}
else
{
- // set_input_line suspends with a true argument which causes "Keyboard error"
- //m_mcu->suspend(SUSPEND_REASON_RESET, false); // This causes an assert later when DEBUG==1
m_mcu->set_input_line(INPUT_LINE_RESET, ASSERT_LINE);
LOGRST("KBD: Keyboard mcu reset line is asserted\n");
}
-
}
//-------------------------------------------------