diff options
author | Oliver Stöneberg <firewave@users.noreply.github.com> | 2020-01-31 03:45:34 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-01-30 21:45:34 -0500 |
commit | 4a102057779ece1b11431ff0b7787249ce0ad3ad (patch) | |
tree | e4911a5cb1a4286dd1547213c4f5eaf993b6adf4 | |
parent | 059243f68ec0c2e327a3105a9480f50e5e0b4abf (diff) |
fixed some modernize-use-equals-default clang-tidy warnings (nw) (#6237)
68 files changed, 57 insertions, 290 deletions
diff --git a/src/lib/util/avhuff.cpp b/src/lib/util/avhuff.cpp index 50eea9f24dc..73a41df50d7 100644 --- a/src/lib/util/avhuff.cpp +++ b/src/lib/util/avhuff.cpp @@ -679,18 +679,6 @@ uint16_t *avhuff_encoder::deltarle_encoder::rle_and_histo_bitmap(const uint8_t * //************************************************************************** /** - * @fn avhuff_decoder::avhuff_decoder() - * - * @brief ------------------------------------------------- - * avhuff_decoder - constructor - * -------------------------------------------------. - */ - -avhuff_decoder::avhuff_decoder() -{ -} - -/** * @fn void avhuff_decoder::configure(const avhuff_decompress_config &config) * * @brief ------------------------------------------------- diff --git a/src/lib/util/avhuff.h b/src/lib/util/avhuff.h index 90ef43e977f..d14046e1f62 100644 --- a/src/lib/util/avhuff.h +++ b/src/lib/util/avhuff.h @@ -144,7 +144,7 @@ class avhuff_decoder { public: // construction/destruction - avhuff_decoder(); + avhuff_decoder() = default; // configuration void configure(const avhuff_decompress_config &config); diff --git a/src/lib/util/aviio.cpp b/src/lib/util/aviio.cpp index c66f706b6e2..99958577d57 100644 --- a/src/lib/util/aviio.cpp +++ b/src/lib/util/aviio.cpp @@ -3803,13 +3803,3 @@ const char *avi_file::error_string(error err) default: return "undocumented error"; } } - - -avi_file::avi_file() -{ -} - - -avi_file::~avi_file() -{ -} diff --git a/src/lib/util/aviio.h b/src/lib/util/aviio.h index c951f71b22f..8aa36d80b8b 100644 --- a/src/lib/util/aviio.h +++ b/src/lib/util/aviio.h @@ -111,7 +111,7 @@ public: static error open(std::string const &filename, ptr &file); static error create(std::string const &filename, movie_info const &info, ptr &file); - virtual ~avi_file(); + virtual ~avi_file() = default; virtual void printf_chunks() = 0; static const char *error_string(error err); @@ -128,7 +128,7 @@ public: virtual error append_sound_samples(int channel, std::int16_t const *samples, std::uint32_t numsamples, std::uint32_t sampleskip) = 0; protected: - avi_file(); + avi_file() = default; }; #endif // MAME_LIB_UTIL_AVIIO_H diff --git a/src/lib/util/chdcodec.cpp b/src/lib/util/chdcodec.cpp index 9785929d0bd..026393b60a2 100644 --- a/src/lib/util/chdcodec.cpp +++ b/src/lib/util/chdcodec.cpp @@ -124,7 +124,7 @@ class chd_lzma_compressor : public chd_compressor public: // construction/destruction chd_lzma_compressor(chd_file &chd, uint32_t hunkbytes, bool lossy); - ~chd_lzma_compressor(); + ~chd_lzma_compressor() = default; // core functionality virtual uint32_t compress(const uint8_t *src, uint32_t srclen, uint8_t *dest) override; @@ -497,15 +497,6 @@ chd_codec::chd_codec(chd_file &chd, uint32_t hunkbytes, bool lossy) //------------------------------------------------- -// ~chd_codec - destructor -//------------------------------------------------- - -chd_codec::~chd_codec() -{ -} - - -//------------------------------------------------- // configure - configuration //------------------------------------------------- @@ -1054,15 +1045,6 @@ chd_lzma_compressor::chd_lzma_compressor(chd_file &chd, uint32_t hunkbytes, bool //------------------------------------------------- -// ~chd_lzma_compressor - destructor -//------------------------------------------------- - -chd_lzma_compressor::~chd_lzma_compressor() -{ -} - - -//------------------------------------------------- // compress - compress data using the LZMA codec //------------------------------------------------- diff --git a/src/lib/util/chdcodec.h b/src/lib/util/chdcodec.h index e688b41a108..8be99b2e710 100644 --- a/src/lib/util/chdcodec.h +++ b/src/lib/util/chdcodec.h @@ -50,7 +50,7 @@ protected: public: // allow public deletion - virtual ~chd_codec(); + virtual ~chd_codec() = default; // accessors chd_file &chd() const { return m_chd; } diff --git a/src/lib/util/corefile.cpp b/src/lib/util/corefile.cpp index 9357f1cdb36..148ac24c14b 100644 --- a/src/lib/util/corefile.cpp +++ b/src/lib/util/corefile.cpp @@ -143,7 +143,7 @@ class core_proxy_file : public core_file { public: core_proxy_file(core_file &file) : m_file(file) { } - virtual ~core_proxy_file() override { } + virtual ~core_proxy_file() override = default; virtual osd_file::error compress(int level) override { return m_file.compress(level); } virtual int seek(std::int64_t offset, int whence) override { return m_file.seek(offset, whence); } @@ -1162,15 +1162,6 @@ osd_file::error core_file::open_proxy(core_file &file, ptr &proxy) /*------------------------------------------------- - closes a file --------------------------------------------------*/ - -core_file::~core_file() -{ -} - - -/*------------------------------------------------- load - open a file with the specified filename, read it into memory, and return a pointer @@ -1233,15 +1224,6 @@ osd_file::error core_file::load(std::string const &filename, std::vector<uint8_t return osd_file::error::NONE; } - -/*------------------------------------------------- - protected constructor --------------------------------------------------*/ - -core_file::core_file() -{ -} - } // namespace util diff --git a/src/lib/util/corefile.h b/src/lib/util/corefile.h index d286cb866ac..cfbe57227d3 100644 --- a/src/lib/util/corefile.h +++ b/src/lib/util/corefile.h @@ -61,7 +61,7 @@ public: static osd_file::error open_proxy(core_file &file, ptr &proxy); // close an open file - virtual ~core_file(); + virtual ~core_file() = default; // enable/disable streaming file compression via zlib; level is 0 to disable compression, or up to 9 for max compression virtual osd_file::error compress(int level) = 0; @@ -128,7 +128,7 @@ public: protected: - core_file(); + core_file() = default; }; diff --git a/src/lib/util/huffman.cpp b/src/lib/util/huffman.cpp index 1d531fdd634..d8900b45e17 100644 --- a/src/lib/util/huffman.cpp +++ b/src/lib/util/huffman.cpp @@ -678,14 +678,6 @@ void huffman_context_base::build_lookup_table() // 8-BIT ENCODER //************************************************************************** -//------------------------------------------------- -// huffman_8bit_encoder - constructor -//------------------------------------------------- - -huffman_8bit_encoder::huffman_8bit_encoder() -{ -} - //------------------------------------------------- // encode - encode a full buffer @@ -722,14 +714,6 @@ huffman_error huffman_8bit_encoder::encode(const uint8_t *source, uint32_t sleng // 8-BIT DECODER //************************************************************************** -//------------------------------------------------- -// huffman_8bit_decoder - constructor -//------------------------------------------------- - -huffman_8bit_decoder::huffman_8bit_decoder() -{ -} - /** * @fn huffman_error huffman_8bit_decoder::decode(const uint8_t *source, uint32_t slength, uint8_t *dest, uint32_t dlength) * diff --git a/src/lib/util/huffman.h b/src/lib/util/huffman.h index 0eac393f380..233146e8e20 100644 --- a/src/lib/util/huffman.h +++ b/src/lib/util/huffman.h @@ -149,7 +149,7 @@ class huffman_8bit_encoder : public huffman_encoder<> { public: // construction/destruction - huffman_8bit_encoder(); + huffman_8bit_encoder() = default; // operations huffman_error encode(const uint8_t *source, uint32_t slength, uint8_t *dest, uint32_t destlength, uint32_t &complength); @@ -163,7 +163,7 @@ class huffman_8bit_decoder : public huffman_decoder<> { public: // construction/destruction - huffman_8bit_decoder(); + huffman_8bit_decoder() = default; // operations huffman_error decode(const uint8_t *source, uint32_t slength, uint8_t *dest, uint32_t destlength); diff --git a/src/lib/util/opresolv.cpp b/src/lib/util/opresolv.cpp index 034f9418426..210dde4f224 100644 --- a/src/lib/util/opresolv.cpp +++ b/src/lib/util/opresolv.cpp @@ -63,15 +63,6 @@ option_resolution::option_resolution(const option_guide &guide) // ------------------------------------------------- -// dtor -// ------------------------------------------------- - -option_resolution::~option_resolution() -{ -} - - -// ------------------------------------------------- // lookup_in_specification // ------------------------------------------------- diff --git a/src/lib/util/opresolv.h b/src/lib/util/opresolv.h index 3781b602393..a102dcd8c83 100644 --- a/src/lib/util/opresolv.h +++ b/src/lib/util/opresolv.h @@ -243,7 +243,7 @@ public: // ctor/dtor option_resolution(const option_guide &guide); - ~option_resolution(); + ~option_resolution() = default; // sets a specification void set_specification(const std::string &specification); diff --git a/src/lib/util/options.cpp b/src/lib/util/options.cpp index 3e5cb001378..cbc9c817dbf 100644 --- a/src/lib/util/options.cpp +++ b/src/lib/util/options.cpp @@ -126,15 +126,6 @@ core_options::entry::entry(std::string &&name, core_options::option_type type, c //------------------------------------------------- -// entry - destructor -//------------------------------------------------- - -core_options::entry::~entry() -{ -} - - -//------------------------------------------------- // entry::value //------------------------------------------------- @@ -337,15 +328,6 @@ core_options::simple_entry::simple_entry(std::vector<std::string> &&names, const //------------------------------------------------- -// simple_entry - destructor -//------------------------------------------------- - -core_options::simple_entry::~simple_entry() -{ -} - - -//------------------------------------------------- // simple_entry::value //------------------------------------------------- @@ -423,24 +405,6 @@ const char *core_options::simple_entry::maximum() const noexcept //************************************************************************** //------------------------------------------------- -// core_options - constructor -//------------------------------------------------- - -core_options::core_options() -{ -} - - -//------------------------------------------------- -// ~core_options - destructor -//------------------------------------------------- - -core_options::~core_options() -{ -} - - -//------------------------------------------------- // add_entry - adds an entry //------------------------------------------------- diff --git a/src/lib/util/options.h b/src/lib/util/options.h index 457ec08dd1d..dc86786fed1 100644 --- a/src/lib/util/options.h +++ b/src/lib/util/options.h @@ -111,7 +111,7 @@ public: entry(entry &&) = delete; entry& operator=(const entry &) = delete; entry& operator=(entry &&) = delete; - virtual ~entry(); + virtual ~entry() = default; // accessors const std::vector<std::string> &names() const noexcept { return m_names; } @@ -147,12 +147,12 @@ public: }; // construction/destruction - core_options(); + core_options() = default; core_options(const core_options &) = delete; core_options(core_options &&) = default; core_options& operator=(const core_options &) = delete; core_options& operator=(core_options &&) = default; - virtual ~core_options(); + virtual ~core_options() = default; // getters const std::string &command() const noexcept { return m_command; } @@ -213,7 +213,7 @@ private: simple_entry(simple_entry &&) = delete; simple_entry& operator=(const simple_entry &) = delete; simple_entry& operator=(simple_entry &&) = delete; - ~simple_entry(); + ~simple_entry() = default; // getters virtual const char *value() const noexcept override; diff --git a/src/lib/util/palette.cpp b/src/lib/util/palette.cpp index 59a63b2c8f5..47fa06c05bd 100644 --- a/src/lib/util/palette.cpp +++ b/src/lib/util/palette.cpp @@ -256,15 +256,6 @@ palette_t::palette_t(uint32_t numcolors, uint32_t numgroups) // palette_t - destructor //------------------------------------------------- -palette_t::~palette_t() -{ -} - - -//------------------------------------------------- -// palette_t - destructor -//------------------------------------------------- - void palette_t::deref() { if (--m_refcount == 0) diff --git a/src/lib/util/palette.h b/src/lib/util/palette.h index ff2c7bb80c9..0407a87c29b 100644 --- a/src/lib/util/palette.h +++ b/src/lib/util/palette.h @@ -191,7 +191,7 @@ public: private: // construction/destruction palette_t(uint32_t numcolors, uint32_t numgroups = 1); - ~palette_t(); + ~palette_t() = default; // internal helpers rgb_t adjust_palette_entry(rgb_t entry, float brightness, float contrast, const uint8_t *gamma_map); diff --git a/src/lib/util/unzip.cpp b/src/lib/util/unzip.cpp index a659445e1cc..2fb3da55c3c 100644 --- a/src/lib/util/unzip.cpp +++ b/src/lib/util/unzip.cpp @@ -1479,9 +1479,4 @@ void archive_file::cache_clear() m7z_file_cache_clear(); } - -archive_file::~archive_file() -{ -} - } // namespace util diff --git a/src/lib/util/unzip.h b/src/lib/util/unzip.h index a1388cd0b4c..28d348a5738 100644 --- a/src/lib/util/unzip.h +++ b/src/lib/util/unzip.h @@ -57,7 +57,7 @@ public: static error open_7z(const std::string &filename, ptr &result); // close an archive file (may actually be left open due to caching) - virtual ~archive_file(); + virtual ~archive_file() = default; // clear out all open files from the cache static void cache_clear(); diff --git a/src/lib/util/xmlfile.cpp b/src/lib/util/xmlfile.cpp index 012080c8335..430de1f7c38 100644 --- a/src/lib/util/xmlfile.cpp +++ b/src/lib/util/xmlfile.cpp @@ -68,9 +68,6 @@ static void expat_element_end(void *data, const XML_Char *name); XML FILE OBJECTS ***************************************************************************/ -file::file() { } -file::~file() { } - /*------------------------------------------------- create - create a new, empty XML file diff --git a/src/lib/util/xmlfile.h b/src/lib/util/xmlfile.h index 8d09b2b7e1e..659ad59ae31 100644 --- a/src/lib/util/xmlfile.h +++ b/src/lib/util/xmlfile.h @@ -215,7 +215,7 @@ public: using ptr = std::unique_ptr<file>; - ~file(); + ~file() = default; // create a new, empty XML file static ptr create(); @@ -231,7 +231,7 @@ public: private: - file(); + file() = default; }; diff --git a/src/lib/util/zippath.cpp b/src/lib/util/zippath.cpp index 760c64fd066..3dcccd5ee30 100644 --- a/src/lib/util/zippath.cpp +++ b/src/lib/util/zippath.cpp @@ -615,16 +615,6 @@ osd_file::error zippath_directory::open(std::string const &path, ptr &directory) // ------------------------------------------------- -// zippath_directory::~zippath_directory - closes -// a directory -// ------------------------------------------------- - -zippath_directory::~zippath_directory() -{ -} - - -// ------------------------------------------------- // zippath_parent - retrieves the parent directory // ------------------------------------------------- diff --git a/src/lib/util/zippath.h b/src/lib/util/zippath.h index cf6c2249f9c..bbaf21af8b1 100644 --- a/src/lib/util/zippath.h +++ b/src/lib/util/zippath.h @@ -34,7 +34,7 @@ public: static osd_file::error open(std::string const &path, ptr &directory); // closes a directory - virtual ~zippath_directory(); + virtual ~zippath_directory() = default; // reads a directory entry virtual osd::directory::entry const *readdir() = 0; diff --git a/src/osd/modules/debugger/debuggdbstub.cpp b/src/osd/modules/debugger/debuggdbstub.cpp index 63dbd420184..c993eaa5c66 100644 --- a/src/osd/modules/debugger/debuggdbstub.cpp +++ b/src/osd/modules/debugger/debuggdbstub.cpp @@ -327,7 +327,7 @@ public: { } - virtual ~debug_gdbstub() { } + virtual ~debug_gdbstub() = default; virtual int init(const osd_options &options) override; virtual void exit() override; diff --git a/src/osd/modules/debugger/debugimgui.cpp b/src/osd/modules/debugger/debugimgui.cpp index 3586b6d8d52..18d7bad316f 100644 --- a/src/osd/modules/debugger/debugimgui.cpp +++ b/src/osd/modules/debugger/debugimgui.cpp @@ -116,7 +116,7 @@ public: { } - virtual ~debug_imgui() { } + virtual ~debug_imgui() = default; virtual int init(const osd_options &options) override { return 0; } virtual void exit() override {}; diff --git a/src/osd/modules/debugger/debugwin.cpp b/src/osd/modules/debugger/debugwin.cpp index 975e7ba6bc6..2b1fb212ef0 100644 --- a/src/osd/modules/debugger/debugwin.cpp +++ b/src/osd/modules/debugger/debugwin.cpp @@ -44,7 +44,7 @@ public: { } - virtual ~debugger_windows() { } + virtual ~debugger_windows() = default; virtual int init(const osd_options &options) override { return 0; } virtual void exit() override; diff --git a/src/osd/modules/debugger/none.cpp b/src/osd/modules/debugger/none.cpp index 3ce8d6572bc..1ef02c98fa7 100644 --- a/src/osd/modules/debugger/none.cpp +++ b/src/osd/modules/debugger/none.cpp @@ -22,7 +22,7 @@ public: { } - virtual ~debug_none() { } + virtual ~debug_none() = default; virtual int init(const osd_options &options) override { return 0; } virtual void exit() override { } diff --git a/src/osd/modules/debugger/win/consolewininfo.cpp b/src/osd/modules/debugger/win/consolewininfo.cpp index 9610cf68e78..1df1cb3ddb0 100644 --- a/src/osd/modules/debugger/win/consolewininfo.cpp +++ b/src/osd/modules/debugger/win/consolewininfo.cpp @@ -91,10 +91,6 @@ cleanup: } -consolewin_info::~consolewin_info() -{ -} - void consolewin_info::set_cpu(device_t &device) { // exit if this cpu is already selected diff --git a/src/osd/modules/debugger/win/consolewininfo.h b/src/osd/modules/debugger/win/consolewininfo.h index e391100ed33..49d40d01b90 100644 --- a/src/osd/modules/debugger/win/consolewininfo.h +++ b/src/osd/modules/debugger/win/consolewininfo.h @@ -19,7 +19,7 @@ class consolewin_info : public disasmbasewin_info { public: consolewin_info(debugger_windows_interface &debugger); - virtual ~consolewin_info(); + virtual ~consolewin_info() = default; void set_cpu(device_t &device); diff --git a/src/osd/modules/debugger/win/debugwininfo.cpp b/src/osd/modules/debugger/win/debugwininfo.cpp index ac60b980439..61bf8f64be6 100644 --- a/src/osd/modules/debugger/win/debugwininfo.cpp +++ b/src/osd/modules/debugger/win/debugwininfo.cpp @@ -48,11 +48,6 @@ debugwin_info::debugwin_info(debugger_windows_interface &debugger, bool is_main_ } -debugwin_info::~debugwin_info() -{ -} - - void debugwin_info::destroy() { for (int curview = 0; curview < MAX_VIEWS; curview++) diff --git a/src/osd/modules/debugger/win/debugwininfo.h b/src/osd/modules/debugger/win/debugwininfo.h index b930189fffa..4da52691478 100644 --- a/src/osd/modules/debugger/win/debugwininfo.h +++ b/src/osd/modules/debugger/win/debugwininfo.h @@ -19,7 +19,7 @@ class debugwin_info : protected debugbase_info { public: debugwin_info(debugger_windows_interface &debugger, bool is_main_console, LPCSTR title, WNDPROC handler); - virtual ~debugwin_info(); + virtual ~debugwin_info() = default; bool is_valid() const { return m_wnd != nullptr; } diff --git a/src/osd/modules/debugger/win/disasmbasewininfo.cpp b/src/osd/modules/debugger/win/disasmbasewininfo.cpp index cfd9683ae9c..3e1886cea90 100644 --- a/src/osd/modules/debugger/win/disasmbasewininfo.cpp +++ b/src/osd/modules/debugger/win/disasmbasewininfo.cpp @@ -49,11 +49,6 @@ disasmbasewin_info::disasmbasewin_info(debugger_windows_interface &debugger, boo } -disasmbasewin_info::~disasmbasewin_info() -{ -} - - bool disasmbasewin_info::handle_key(WPARAM wparam, LPARAM lparam) { if (GetAsyncKeyState(VK_CONTROL) & 0x8000) diff --git a/src/osd/modules/debugger/win/disasmbasewininfo.h b/src/osd/modules/debugger/win/disasmbasewininfo.h index c22f7f08e78..83031b242f5 100644 --- a/src/osd/modules/debugger/win/disasmbasewininfo.h +++ b/src/osd/modules/debugger/win/disasmbasewininfo.h @@ -19,7 +19,7 @@ class disasmbasewin_info : public editwin_info { public: disasmbasewin_info(debugger_windows_interface &debugger, bool is_main_console, LPCSTR title, WNDPROC handler); - virtual ~disasmbasewin_info(); + virtual ~disasmbasewin_info() = default; virtual bool handle_key(WPARAM wparam, LPARAM lparam) override; diff --git a/src/osd/modules/debugger/win/disasmviewinfo.cpp b/src/osd/modules/debugger/win/disasmviewinfo.cpp index 8884bee5195..418f3f2f9f3 100644 --- a/src/osd/modules/debugger/win/disasmviewinfo.cpp +++ b/src/osd/modules/debugger/win/disasmviewinfo.cpp @@ -16,11 +16,6 @@ disasmview_info::disasmview_info(debugger_windows_interface &debugger, debugwin_ } -disasmview_info::~disasmview_info() -{ -} - - disasm_right_column disasmview_info::right_column() const { return view<debug_view_disasm>()->right_column(); diff --git a/src/osd/modules/debugger/win/disasmviewinfo.h b/src/osd/modules/debugger/win/disasmviewinfo.h index a032475af7f..f5ca6b5dde6 100644 --- a/src/osd/modules/debugger/win/disasmviewinfo.h +++ b/src/osd/modules/debugger/win/disasmviewinfo.h @@ -21,7 +21,7 @@ class disasmview_info : public debugview_info { public: disasmview_info(debugger_windows_interface &debugger, debugwin_info &owner, HWND parent); - virtual ~disasmview_info(); + virtual ~disasmview_info() = default; disasm_right_column right_column() const; offs_t selected_address() const; diff --git a/src/osd/modules/debugger/win/disasmwininfo.cpp b/src/osd/modules/debugger/win/disasmwininfo.cpp index b94eadbba03..835448ec1f1 100644 --- a/src/osd/modules/debugger/win/disasmwininfo.cpp +++ b/src/osd/modules/debugger/win/disasmwininfo.cpp @@ -45,11 +45,6 @@ disasmwin_info::disasmwin_info(debugger_windows_interface &debugger) : } -disasmwin_info::~disasmwin_info() -{ -} - - void disasmwin_info::recompute_children() { // compute a client rect diff --git a/src/osd/modules/debugger/win/disasmwininfo.h b/src/osd/modules/debugger/win/disasmwininfo.h index 71764bab0ef..6ee7eabd7e5 100644 --- a/src/osd/modules/debugger/win/disasmwininfo.h +++ b/src/osd/modules/debugger/win/disasmwininfo.h @@ -19,7 +19,7 @@ class disasmwin_info : public disasmbasewin_info { public: disasmwin_info(debugger_windows_interface &debugger); - virtual ~disasmwin_info(); + virtual ~disasmwin_info() = default; protected: virtual void recompute_children() override; diff --git a/src/osd/modules/debugger/win/editwininfo.cpp b/src/osd/modules/debugger/win/editwininfo.cpp index 1b9f88c6d68..20286705752 100644 --- a/src/osd/modules/debugger/win/editwininfo.cpp +++ b/src/osd/modules/debugger/win/editwininfo.cpp @@ -51,11 +51,6 @@ editwin_info::editwin_info(debugger_windows_interface &debugger, bool is_main_co } -editwin_info::~editwin_info() -{ -} - - bool editwin_info::restore_field(HWND wnd) { if (wnd == m_editwnd) diff --git a/src/osd/modules/debugger/win/editwininfo.h b/src/osd/modules/debugger/win/editwininfo.h index 2156d8ba68d..661b89b91dc 100644 --- a/src/osd/modules/debugger/win/editwininfo.h +++ b/src/osd/modules/debugger/win/editwininfo.h @@ -22,7 +22,7 @@ class editwin_info : public debugwin_info { public: editwin_info(debugger_windows_interface &debugger, bool is_main_console, LPCSTR title, WNDPROC handler); - virtual ~editwin_info(); + virtual ~editwin_info() = default; virtual bool restore_field(HWND wnd) override; diff --git a/src/osd/modules/debugger/win/logviewinfo.cpp b/src/osd/modules/debugger/win/logviewinfo.cpp index affd4acd17a..58f49be9ddb 100644 --- a/src/osd/modules/debugger/win/logviewinfo.cpp +++ b/src/osd/modules/debugger/win/logviewinfo.cpp @@ -18,11 +18,6 @@ logview_info::logview_info(debugger_windows_interface &debugger, debugwin_info & } -logview_info::~logview_info() -{ -} - - void logview_info::clear() { view<debug_view_log>()->clear(); diff --git a/src/osd/modules/debugger/win/logviewinfo.h b/src/osd/modules/debugger/win/logviewinfo.h index e2fa9d31643..58008f19f88 100644 --- a/src/osd/modules/debugger/win/logviewinfo.h +++ b/src/osd/modules/debugger/win/logviewinfo.h @@ -19,7 +19,7 @@ class logview_info : public debugview_info { public: logview_info(debugger_windows_interface &debugger, debugwin_info &owner, HWND parent); - virtual ~logview_info(); + virtual ~logview_info() = default; void clear(); }; diff --git a/src/osd/modules/debugger/win/logwininfo.cpp b/src/osd/modules/debugger/win/logwininfo.cpp index 6d2cd59b554..cac9e76e385 100644 --- a/src/osd/modules/debugger/win/logwininfo.cpp +++ b/src/osd/modules/debugger/win/logwininfo.cpp @@ -49,10 +49,6 @@ logwin_info::logwin_info(debugger_windows_interface &debugger) : } -logwin_info::~logwin_info() -{ -} - bool logwin_info::handle_command(WPARAM wparam, LPARAM lparam) { if ((HIWORD(wparam) == 0) && (LOWORD(wparam) == ID_CLEAR_LOG)) diff --git a/src/osd/modules/debugger/win/logwininfo.h b/src/osd/modules/debugger/win/logwininfo.h index b40d184485e..c74825b38cb 100644 --- a/src/osd/modules/debugger/win/logwininfo.h +++ b/src/osd/modules/debugger/win/logwininfo.h @@ -19,7 +19,7 @@ class logwin_info : public debugwin_info { public: logwin_info(debugger_windows_interface &debugger); - virtual ~logwin_info(); + virtual ~logwin_info() = default; protected: virtual bool handle_command(WPARAM wparam, LPARAM lparam) override; diff --git a/src/osd/modules/debugger/win/memoryviewinfo.cpp b/src/osd/modules/debugger/win/memoryviewinfo.cpp index 423679f26a9..6cdf4e4911d 100644 --- a/src/osd/modules/debugger/win/memoryviewinfo.cpp +++ b/src/osd/modules/debugger/win/memoryviewinfo.cpp @@ -18,11 +18,6 @@ memoryview_info::memoryview_info(debugger_windows_interface &debugger, debugwin_ } -memoryview_info::~memoryview_info() -{ -} - - uint8_t memoryview_info::data_format() const { return view<debug_view_memory>()->get_data_format(); diff --git a/src/osd/modules/debugger/win/memoryviewinfo.h b/src/osd/modules/debugger/win/memoryviewinfo.h index a897698f0bd..52d1a20947d 100644 --- a/src/osd/modules/debugger/win/memoryviewinfo.h +++ b/src/osd/modules/debugger/win/memoryviewinfo.h @@ -19,7 +19,7 @@ class memoryview_info : public debugview_info { public: memoryview_info(debugger_windows_interface &debugger, debugwin_info &owner, HWND parent); - virtual ~memoryview_info(); + virtual ~memoryview_info() = default; uint8_t data_format() const; uint32_t chunks_per_row() const; diff --git a/src/osd/modules/debugger/win/pointswininfo.cpp b/src/osd/modules/debugger/win/pointswininfo.cpp index 24a8f865e6f..602aac1bc9d 100644 --- a/src/osd/modules/debugger/win/pointswininfo.cpp +++ b/src/osd/modules/debugger/win/pointswininfo.cpp @@ -51,11 +51,6 @@ pointswin_info::pointswin_info(debugger_windows_interface &debugger) : } -pointswin_info::~pointswin_info() -{ -} - - bool pointswin_info::handle_key(WPARAM wparam, LPARAM lparam) { if (GetAsyncKeyState(VK_CONTROL) & 0x8000) diff --git a/src/osd/modules/debugger/win/pointswininfo.h b/src/osd/modules/debugger/win/pointswininfo.h index 4e36155105e..e9701b02ab6 100644 --- a/src/osd/modules/debugger/win/pointswininfo.h +++ b/src/osd/modules/debugger/win/pointswininfo.h @@ -19,7 +19,7 @@ class pointswin_info : public debugwin_info { public: pointswin_info(debugger_windows_interface &debugger); - virtual ~pointswin_info(); + virtual ~pointswin_info() = default; virtual bool handle_key(WPARAM wparam, LPARAM lparam) override; diff --git a/src/osd/modules/diagnostics/diagnostics_win32.cpp b/src/osd/modules/diagnostics/diagnostics_win32.cpp index 677cd93bff7..00175d3f70b 100644 --- a/src/osd/modules/diagnostics/diagnostics_win32.cpp +++ b/src/osd/modules/diagnostics/diagnostics_win32.cpp @@ -77,7 +77,7 @@ class symbol_manager public: // construction/destruction symbol_manager(const char *argv0); - ~symbol_manager(); + ~symbol_manager() = default; // getters uintptr_t last_base() const { return m_last_base; } @@ -128,7 +128,7 @@ class sampling_profiler { public: sampling_profiler(uint32_t max_seconds, uint8_t stack_depth); - ~sampling_profiler(); + ~sampling_profiler() = default; void start(); void stop(); @@ -322,15 +322,6 @@ symbol_manager::symbol_manager(const char *argv0) //------------------------------------------------- -// ~symbol_manager - destructor -//------------------------------------------------- - -symbol_manager::~symbol_manager() -{ -} - - -//------------------------------------------------- // symbol_for_address - return a symbol by looking // it up either in the cache or by scanning the // file @@ -655,15 +646,6 @@ sampling_profiler::sampling_profiler(uint32_t max_seconds, uint8_t stack_depth = //------------------------------------------------- -// sampling_profiler - destructor -//------------------------------------------------- - -sampling_profiler::~sampling_profiler() -{ -} - - -//------------------------------------------------- // start - begin gathering profiling information //------------------------------------------------- diff --git a/src/osd/modules/diagnostics/none.cpp b/src/osd/modules/diagnostics/none.cpp index 8a731fe9009..e4028124514 100644 --- a/src/osd/modules/diagnostics/none.cpp +++ b/src/osd/modules/diagnostics/none.cpp @@ -11,9 +11,7 @@ class diagnostics_none : public diagnostics_module { public: - diagnostics_none() - { - } + diagnostics_none() = default; int init_crash_diagnostics() override { diff --git a/src/osd/modules/font/font_none.cpp b/src/osd/modules/font/font_none.cpp index dc6116625a8..a36514899a2 100644 --- a/src/osd/modules/font/font_none.cpp +++ b/src/osd/modules/font/font_none.cpp @@ -11,7 +11,7 @@ class osd_font_none : public osd_font { public: - virtual ~osd_font_none() { } + virtual ~osd_font_none() = default; virtual bool open(std::string const &font_path, std::string const &name, int &height) override { return false; } virtual void close() override { } diff --git a/src/osd/modules/midi/none.cpp b/src/osd/modules/midi/none.cpp index 822de79bd08..72fc07fb4e2 100644 --- a/src/osd/modules/midi/none.cpp +++ b/src/osd/modules/midi/none.cpp @@ -21,7 +21,7 @@ public: : osd_module(OSD_MIDI_PROVIDER, "pm"), midi_module() { } - virtual ~none_module() { } + virtual ~none_module() = default; virtual int init(const osd_options &options) override; virtual void exit() override; @@ -34,7 +34,7 @@ public: class osd_midi_device_none : public osd_midi_device { public: - virtual ~osd_midi_device_none() { } + virtual ~osd_midi_device_none() = default; virtual bool open_input(const char *devname) override; virtual bool open_output(const char *devname) override; virtual void close() override; diff --git a/src/osd/modules/midi/portmidi.cpp b/src/osd/modules/midi/portmidi.cpp index 64f71ca6689..e5c35c91162 100644 --- a/src/osd/modules/midi/portmidi.cpp +++ b/src/osd/modules/midi/portmidi.cpp @@ -24,7 +24,7 @@ public: : osd_module(OSD_MIDI_PROVIDER, "pm"), midi_module() { } - virtual ~pm_module() { } + virtual ~pm_module() = default; virtual int init(const osd_options &options)override; virtual void exit()override; @@ -43,7 +43,7 @@ class osd_midi_device_pm : public osd_midi_device { public: osd_midi_device_pm(): pmStream(nullptr), xmit_cnt(0), last_status(0), rx_sysex(false) { } - virtual ~osd_midi_device_pm() { } + virtual ~osd_midi_device_pm() = default; virtual bool open_input(const char *devname) override; virtual bool open_output(const char *devname) override; virtual void close() override; diff --git a/src/osd/modules/netdev/none.cpp b/src/osd/modules/netdev/none.cpp index a5b520f26a5..97bc3d435da 100644 --- a/src/osd/modules/netdev/none.cpp +++ b/src/osd/modules/netdev/none.cpp @@ -16,7 +16,7 @@ public: { } - virtual ~netdev_none() { } + virtual ~netdev_none() = default; virtual int init(const osd_options &options) override { return 0; } }; diff --git a/src/osd/modules/netdev/pcap.cpp b/src/osd/modules/netdev/pcap.cpp index 68e9512b14a..d672e7b9302 100644 --- a/src/osd/modules/netdev/pcap.cpp +++ b/src/osd/modules/netdev/pcap.cpp @@ -46,7 +46,7 @@ public: { } - virtual ~pcap_module() { } + virtual ~pcap_module() = default; virtual int init(const osd_options &options) override; virtual void exit() override; diff --git a/src/osd/modules/netdev/taptun.cpp b/src/osd/modules/netdev/taptun.cpp index df3ab7bf38d..88f873a3a70 100644 --- a/src/osd/modules/netdev/taptun.cpp +++ b/src/osd/modules/netdev/taptun.cpp @@ -40,7 +40,7 @@ public: taptun_module() : osd_module(OSD_NETDEV_PROVIDER, "taptun"), netdev_module() { } - virtual ~taptun_module() { } + virtual ~taptun_module() = default; virtual int init(const osd_options &options); virtual void exit(); diff --git a/src/osd/modules/output/console.cpp b/src/osd/modules/output/console.cpp index c9983736fb0..58896737829 100644 --- a/src/osd/modules/output/console.cpp +++ b/src/osd/modules/output/console.cpp @@ -18,7 +18,7 @@ public: : osd_module(OSD_OUTPUT_PROVIDER, "console"), output_module() { } - virtual ~output_console() { } + virtual ~output_console() = default; virtual int init(const osd_options &options) override { return 0; } virtual void exit() override { } diff --git a/src/osd/modules/output/network.cpp b/src/osd/modules/output/network.cpp index 4fc4b382da6..eafbf7b95e2 100644 --- a/src/osd/modules/output/network.cpp +++ b/src/osd/modules/output/network.cpp @@ -26,7 +26,7 @@ class output_client { public: - virtual ~output_client() {} + virtual ~output_client() = default; virtual void deliver(std::string &msg) = 0; }; @@ -197,9 +197,7 @@ public: { } - virtual ~output_network() - { - } + virtual ~output_network() = default; virtual int init(const osd_options &options) override { diff --git a/src/osd/modules/output/none.cpp b/src/osd/modules/output/none.cpp index a4a613ef29f..a5f142c9766 100644 --- a/src/osd/modules/output/none.cpp +++ b/src/osd/modules/output/none.cpp @@ -18,7 +18,7 @@ public: : osd_module(OSD_OUTPUT_PROVIDER, "none"), output_module() { } - virtual ~output_none() { } + virtual ~output_none() = default; virtual int init(const osd_options &options) override { return 0; } virtual void exit() override { } diff --git a/src/osd/modules/output/win32_output.cpp b/src/osd/modules/output/win32_output.cpp index 199219ac5ef..95c42bede77 100644 --- a/src/osd/modules/output/win32_output.cpp +++ b/src/osd/modules/output/win32_output.cpp @@ -69,7 +69,7 @@ public: : osd_module(OSD_OUTPUT_PROVIDER, "windows"), output_module(), m_output_hwnd(nullptr), m_clientlist(nullptr) { } - virtual ~output_win32() { } + virtual ~output_win32() = default; virtual int init(const osd_options &options) override; virtual void exit() override; diff --git a/src/osd/modules/render/bgfx/inputpair.cpp b/src/osd/modules/render/bgfx/inputpair.cpp index 9fd2b0e6855..f5d0ab3c867 100644 --- a/src/osd/modules/render/bgfx/inputpair.cpp +++ b/src/osd/modules/render/bgfx/inputpair.cpp @@ -40,10 +40,6 @@ bgfx_input_pair::bgfx_input_pair(int index, std::string sampler, std::string tex } } -bgfx_input_pair::~bgfx_input_pair() -{ -} - void bgfx_input_pair::bind(bgfx_effect *effect, const int32_t screen) const { if (effect->uniform(m_sampler) == nullptr) diff --git a/src/osd/modules/render/bgfx/inputpair.h b/src/osd/modules/render/bgfx/inputpair.h index fb3fc58e1f7..bdccaa1a20a 100644 --- a/src/osd/modules/render/bgfx/inputpair.h +++ b/src/osd/modules/render/bgfx/inputpair.h @@ -27,7 +27,7 @@ class bgfx_input_pair : public slider_changed_notifier { public: bgfx_input_pair(int index, std::string sampler, std::string texture, std::vector<std::string> available_textures, std::string selection, chain_manager& chains, uint32_t screen_index); - ~bgfx_input_pair(); + ~bgfx_input_pair() = default; void bind(bgfx_effect *effect, const int32_t screen) const; int32_t texture_changed(int32_t index, std::string *str, int32_t newval); diff --git a/src/osd/modules/sound/direct_sound.cpp b/src/osd/modules/sound/direct_sound.cpp index 05333674541..c7943362e61 100644 --- a/src/osd/modules/sound/direct_sound.cpp +++ b/src/osd/modules/sound/direct_sound.cpp @@ -60,7 +60,7 @@ public: m_buffer_overflows(0) { } - virtual ~sound_direct_sound() { } + virtual ~sound_direct_sound() = default; virtual int init(osd_options const &options) override; virtual void exit() override; diff --git a/src/osd/modules/sound/none.cpp b/src/osd/modules/sound/none.cpp index 685cdc884c2..c13a1951e27 100644 --- a/src/osd/modules/sound/none.cpp +++ b/src/osd/modules/sound/none.cpp @@ -18,7 +18,7 @@ public: : osd_module(OSD_SOUND_PROVIDER, "none"), sound_module() { } - virtual ~sound_none() { } + virtual ~sound_none() = default; virtual int init(const osd_options &options) override { return 0; } virtual void exit() override { } diff --git a/src/osd/modules/sound/pa_sound.cpp b/src/osd/modules/sound/pa_sound.cpp index 41645318672..0f67d86d828 100644 --- a/src/osd/modules/sound/pa_sound.cpp +++ b/src/osd/modules/sound/pa_sound.cpp @@ -38,7 +38,7 @@ public: : osd_module(OSD_SOUND_PROVIDER, "portaudio"), sound_module() { } - virtual ~sound_pa() { } + virtual ~sound_pa() = default; virtual int init(osd_options const &options) override; virtual void exit() override; diff --git a/src/osd/modules/sound/xaudio2_sound.cpp b/src/osd/modules/sound/xaudio2_sound.cpp index 1d9e1036f9a..da78dfb3aa7 100644 --- a/src/osd/modules/sound/xaudio2_sound.cpp +++ b/src/osd/modules/sound/xaudio2_sound.cpp @@ -226,7 +226,7 @@ public: { } - virtual ~sound_xaudio2() { } + virtual ~sound_xaudio2() = default; bool probe() override; int init(osd_options const &options) override; diff --git a/src/osd/osdnet.cpp b/src/osd/osdnet.cpp index 070b4e96a2d..a1d71ebae36 100644 --- a/src/osd/osdnet.cpp +++ b/src/osd/osdnet.cpp @@ -42,10 +42,6 @@ osd_netdev::osd_netdev(class device_network_interface *ifdev, int rate) m_timer->adjust(attotime::from_hz(rate), 0, attotime::from_hz(rate)); } -osd_netdev::~osd_netdev() -{ -} - void osd_netdev::start() { m_timer->enable(true); diff --git a/src/osd/osdnet.h b/src/osd/osdnet.h index 226ae2319a9..fecf65e1935 100644 --- a/src/osd/osdnet.h +++ b/src/osd/osdnet.h @@ -21,7 +21,7 @@ public: create_netdev func; }; osd_netdev(class device_network_interface *ifdev, int rate); - virtual ~osd_netdev(); + virtual ~osd_netdev() = default; void start(); void stop(); diff --git a/src/osd/windows/winmain.cpp b/src/osd/windows/winmain.cpp index 45d3486a2af..c0eae44dc66 100644 --- a/src/osd/windows/winmain.cpp +++ b/src/osd/windows/winmain.cpp @@ -490,15 +490,6 @@ windows_osd_interface::windows_osd_interface(windows_options &options) //============================================================ -// destructor -//============================================================ - -windows_osd_interface::~windows_osd_interface() -{ -} - - -//============================================================ // video_register //============================================================ diff --git a/src/osd/windows/winmain.h b/src/osd/windows/winmain.h index faca28e5bca..c5c75a7dfae 100644 --- a/src/osd/windows/winmain.h +++ b/src/osd/windows/winmain.h @@ -275,7 +275,7 @@ class windows_osd_interface : public osd_common_t public: // construction/destruction windows_osd_interface(windows_options &options); - virtual ~windows_osd_interface(); + virtual ~windows_osd_interface() = default; // general overridables virtual void init(running_machine &machine) override; |