summaryrefslogtreecommitdiffstatshomepage
diff options
context:
space:
mode:
author Ivan Vangelista <mesgnet@yahoo.it>2021-07-20 17:46:53 +0200
committer Ivan Vangelista <mesgnet@yahoo.it>2021-07-20 17:46:53 +0200
commit43543ccccff5a667d7cb85417ae64b0feb93a085 (patch)
tree08d9500e193ac9fa4ee397fd878db3261378e5b6
parent1d106ea414122e5329a016b8b3e55c01790aebac (diff)
ichiban.cpp: very minor comment updates
-rw-r--r--src/mame/drivers/ichiban.cpp33
1 files changed, 20 insertions, 13 deletions
diff --git a/src/mame/drivers/ichiban.cpp b/src/mame/drivers/ichiban.cpp
index 56dd3eabd80..96590843914 100644
--- a/src/mame/drivers/ichiban.cpp
+++ b/src/mame/drivers/ichiban.cpp
@@ -29,9 +29,12 @@ Notes:
Z80 clock - 6.144MHz [18.432/3]
YM2149 clock - 1.536MHz [18.432/12]
YM2413 clock - 3.072MHz [18.432/6]
+M6378 - OKI MSM6378A Voice Synthesis IC with 256Kbit OTP ROM (DIP16) - not populated
VSync - 60.5686Hz
HSync - 15.510kHz
+Notes / TODO:
+- where and how are the opcodes at 0x8000 and the data at 0x18000 banked?
***************************************************************************/
#include "emu.h"
@@ -44,7 +47,7 @@ HSync - 15.510kHz
#include "speaker.h"
-#define MAIN_CLOCK XTAL(18'432'000)
+namespace {
class ichibanjyan_state : public driver_device
{
@@ -56,15 +59,16 @@ public:
void ichibanjyan(machine_config &config);
-private:
- // devices
- required_device<cpu_device> m_maincpu;
-
+protected:
// driver_device overrides
virtual void machine_start() override;
virtual void machine_reset() override;
-
virtual void video_start() override;
+
+private:
+ // devices
+ required_device<cpu_device> m_maincpu;
+
uint32_t screen_update(screen_device &screen, bitmap_ind16 &bitmap, const rectangle &cliprect);
void mem_map(address_map &map);
void io_map(address_map &map);
@@ -132,17 +136,17 @@ void ichibanjyan_state::machine_reset()
void ichibanjyan_state::ichibanjyan(machine_config &config)
{
- /* basic machine hardware */
- Z80(config, m_maincpu, MAIN_CLOCK/3);
+ // basic machine hardware
+ Z80(config, m_maincpu, 18.432_MHz_XTAL / 3);
m_maincpu->set_addrmap(AS_PROGRAM, &ichibanjyan_state::mem_map);
m_maincpu->set_addrmap(AS_IO, &ichibanjyan_state::io_map);
m_maincpu->set_addrmap(AS_OPCODES, &ichibanjyan_state::opcodes_map);
NVRAM(config, "nvram", nvram_device::DEFAULT_ALL_0);
- /* video hardware */
+ // video hardware
screen_device &screen(SCREEN(config, "screen", SCREEN_TYPE_RASTER));
- screen.set_raw(MAIN_CLOCK/3, 396, 0, 320, 256, 0, 224); // dimensions guessed
+ screen.set_raw(18.432_MHz_XTAL / 3, 396, 0, 320, 256, 0, 224); // dimensions guessed
screen.set_screen_update(FUNC(ichibanjyan_state::screen_update));
screen.set_palette("palette");
@@ -150,11 +154,11 @@ void ichibanjyan_state::ichibanjyan(machine_config &config)
PALETTE(config, "palette", palette_device::RGB_444_PROMS, "proms", 512);
- /* sound hardware */
+ // sound hardware
SPEAKER(config, "mono").front_center();
- YM2149(config, "aysnd", MAIN_CLOCK/12).add_route(ALL_OUTPUTS, "mono", 0.30);
+ YM2149(config, "aysnd", 18.432_MHz_XTAL / 12).add_route(ALL_OUTPUTS, "mono", 0.30);
- YM2413(config, "ymsnd", MAIN_CLOCK/6).add_route(ALL_OUTPUTS, "mono", 0.5);
+ YM2413(config, "ymsnd", 18.432_MHz_XTAL / 6).add_route(ALL_OUTPUTS, "mono", 0.5);
}
@@ -180,4 +184,7 @@ ROM_START( ichiban )
ROM_LOAD( "mjb.u38", 0x400, 0x200, CRC(0ef881cb) SHA1(44b61a443d683f5cb2d1b1a4f74d8a8f41021de5) )
ROM_END
+} // Anonymous namespace
+
+
GAME( 199?, ichiban, 0, ichibanjyan, ichibanjyan, ichibanjyan_state, empty_init, ROT0, "Excel", "Ichi Ban Jyan", MACHINE_NOT_WORKING | MACHINE_NO_SOUND )