summaryrefslogtreecommitdiffstatshomepage
diff options
context:
space:
mode:
author Robbbert <Robbbert@users.noreply.github.com>2019-04-20 01:11:49 +1000
committer Robbbert <Robbbert@users.noreply.github.com>2019-04-20 01:11:49 +1000
commit42c8adb4e257818fa3995d6722485ab804d0e2c1 (patch)
treecd81e5f7e6a85d84154855b03dff2761a0b12abd
parenta89e6f3cc48d0dc03be574a762c95ffc43bb1adf (diff)
(nw) 6522 cleanups
-rw-r--r--src/mame/drivers/ec65.cpp18
-rw-r--r--src/mame/drivers/ssystem3.cpp9
-rw-r--r--src/mame/machine/lisa.cpp9
-rw-r--r--src/mame/machine/microtan.cpp27
-rw-r--r--src/mame/machine/rmnimbus.cpp9
5 files changed, 8 insertions, 64 deletions
diff --git a/src/mame/drivers/ec65.cpp b/src/mame/drivers/ec65.cpp
index 8a67d6ef703..0b3c7751239 100644
--- a/src/mame/drivers/ec65.cpp
+++ b/src/mame/drivers/ec65.cpp
@@ -100,14 +100,7 @@ void ec65_state::kbd_put(u8 data)
{
if (data)
{
- m_via_0->write_pa0(BIT(data, 0));
- m_via_0->write_pa1(BIT(data, 1));
- m_via_0->write_pa2(BIT(data, 2));
- m_via_0->write_pa3(BIT(data, 3));
- m_via_0->write_pa4(BIT(data, 4));
- m_via_0->write_pa5(BIT(data, 5));
- m_via_0->write_pa6(BIT(data, 6));
- m_via_0->write_pa7(BIT(data, 7));
+ m_via_0->write_pa(data);
m_via_0->write_ca1(1);
m_via_0->write_ca1(0);
}
@@ -115,14 +108,7 @@ void ec65_state::kbd_put(u8 data)
void ec65_state::machine_reset()
{
- m_via_1->write_pb0(1);
- m_via_1->write_pb1(1);
- m_via_1->write_pb2(1);
- m_via_1->write_pb3(1);
- m_via_1->write_pb4(1);
- m_via_1->write_pb5(1);
- m_via_1->write_pb6(1);
- m_via_1->write_pb7(1);
+ m_via_1->write_pb(0xff);
}
MC6845_UPDATE_ROW( ec65_state::crtc_update_row )
diff --git a/src/mame/drivers/ssystem3.cpp b/src/mame/drivers/ssystem3.cpp
index b9cf3fe3cdb..737536a1caf 100644
--- a/src/mame/drivers/ssystem3.cpp
+++ b/src/mame/drivers/ssystem3.cpp
@@ -202,14 +202,7 @@ WRITE8_MEMBER(ssystem3_state::ssystem3_via_write_b)
uint8_t d = ssystem3_via_read_b(space, 0, mem_mask) & ~0x40;
if (data & 0x80) d |= 0x40;
// d&=~0x8f;
- m_via6522_0->write_pb0((d >> 0) & 1);
- m_via6522_0->write_pb1((d >> 1) & 1);
- m_via6522_0->write_pb2((d >> 2) & 1);
- m_via6522_0->write_pb3((d >> 3) & 1);
- m_via6522_0->write_pb4((d >> 4) & 1);
- m_via6522_0->write_pb5((d >> 5) & 1);
- m_via6522_0->write_pb6((d >> 6) & 1);
- m_via6522_0->write_pb7((d >> 7) & 1);
+ m_via6522_0->write_pb(d);
}
void ssystem3_state::init_ssystem3()
diff --git a/src/mame/machine/lisa.cpp b/src/mame/machine/lisa.cpp
index 14734386d7c..c547c07293f 100644
--- a/src/mame/machine/lisa.cpp
+++ b/src/mame/machine/lisa.cpp
@@ -203,14 +203,7 @@ void lisa_state::COPS_send_data_if_possible()
// printf("COPsim: sending %02x to VIA\n", m_fifo_data[m_fifo_head]);
uint8_t data = m_fifo_data[m_fifo_head];/* output data */
- m_via0->write_pa0((data>>0)&1);
- m_via0->write_pa1((data>>1)&1);
- m_via0->write_pa2((data>>2)&1);
- m_via0->write_pa3((data>>3)&1);
- m_via0->write_pa4((data>>4)&1);
- m_via0->write_pa5((data>>5)&1);
- m_via0->write_pa6((data>>6)&1);
- m_via0->write_pa7((data>>7)&1);
+ m_via0->write_pa(data);
if (m_fifo_head == m_mouse_data_offset)
m_mouse_data_offset = -1; /* we just phased out the mouse data in buffer */
diff --git a/src/mame/machine/microtan.cpp b/src/mame/machine/microtan.cpp
index 8868e8ca959..6a696635128 100644
--- a/src/mame/machine/microtan.cpp
+++ b/src/mame/machine/microtan.cpp
@@ -438,36 +438,15 @@ void microtan_state::init_microtan()
m_via6522[0]->write_ca1(1);
m_via6522[0]->write_ca2(1);
- m_via6522[0]->write_pb0(1);
- m_via6522[0]->write_pb1(1);
- m_via6522[0]->write_pb2(1);
- m_via6522[0]->write_pb3(1);
- m_via6522[0]->write_pb4(1);
- m_via6522[0]->write_pb5(1);
- m_via6522[0]->write_pb6(1);
- m_via6522[0]->write_pb7(1);
+ m_via6522[0]->write_pb(0xff);
m_via6522[0]->write_cb1(1);
m_via6522[0]->write_cb2(1);
- m_via6522[1]->write_pa0(1);
- m_via6522[1]->write_pa1(1);
- m_via6522[1]->write_pa2(1);
- m_via6522[1]->write_pa3(1);
- m_via6522[1]->write_pa4(1);
- m_via6522[1]->write_pa5(1);
- m_via6522[1]->write_pa6(1);
- m_via6522[1]->write_pa7(1);
+ m_via6522[1]->write_pa(0xff);
m_via6522[1]->write_ca1(1);
m_via6522[1]->write_ca2(1);
- m_via6522[1]->write_pb0(1);
- m_via6522[1]->write_pb1(1);
- m_via6522[1]->write_pb2(1);
- m_via6522[1]->write_pb3(1);
- m_via6522[1]->write_pb4(1);
- m_via6522[1]->write_pb5(1);
- m_via6522[1]->write_pb6(1);
- m_via6522[1]->write_pb7(1);
+ m_via6522[1]->write_pb(0xff);
m_via6522[1]->write_cb1(1);
m_via6522[1]->write_cb2(1);
}
diff --git a/src/mame/machine/rmnimbus.cpp b/src/mame/machine/rmnimbus.cpp
index 3448ed17146..bf6df08bb29 100644
--- a/src/mame/machine/rmnimbus.cpp
+++ b/src/mame/machine/rmnimbus.cpp
@@ -206,14 +206,7 @@ void rmnimbus_state::machine_reset()
mouse_js_reset();
/* USER VIA 6522 port B is connected to the BBC user port */
- m_via->write_pb0(1);
- m_via->write_pb1(1);
- m_via->write_pb2(1);
- m_via->write_pb3(1);
- m_via->write_pb4(1);
- m_via->write_pb5(1);
- m_via->write_pb6(1);
- m_via->write_pb7(1);
+ m_via->write_pb(0xff);
}
void rmnimbus_state::machine_start()