summaryrefslogtreecommitdiffstatshomepage
diff options
context:
space:
mode:
author ajrhacker <ajrhacker@users.noreply.github.com>2021-04-26 12:17:50 -0400
committer hap <happppp@users.noreply.github.com>2021-04-26 18:31:21 +0200
commit169c46fcd20db5b495be05f23d4d3364925fee06 (patch)
tree56a31fadfab0123d93ff8b993c35e70618e64f8d
parent82e6b70f5f05cfd3cb3b4cf06b0f7ac6d780fa86 (diff)
Merge pull request #8003 from DavidHaywood/250421
fix gigandes sprite offsets (regressed around december) (cherry picked from commit 73f578124c520e94c70a6d1efee9c86a6a0be68e)
-rw-r--r--src/mame/drivers/taito_x.cpp2
-rw-r--r--src/mame/video/seta001.cpp8
2 files changed, 10 insertions, 0 deletions
diff --git a/src/mame/drivers/taito_x.cpp b/src/mame/drivers/taito_x.cpp
index fd0fe48339b..b2ed469d0af 100644
--- a/src/mame/drivers/taito_x.cpp
+++ b/src/mame/drivers/taito_x.cpp
@@ -921,6 +921,8 @@ void taitox_state::gigandes(machine_config &config)
MCFG_MACHINE_START_OVERRIDE(taitox_state,taitox)
SETA001_SPRITE(config, m_seta001, 16000000, m_palette, gfx_taito_x);
+ m_seta001->set_fg_yoffsets(-0xa, 0xe);
+ m_seta001->set_bg_yoffsets(0x1, -0x1);
/* video hardware */
screen_device &screen(SCREEN(config, "screen", SCREEN_TYPE_RASTER));
diff --git a/src/mame/video/seta001.cpp b/src/mame/video/seta001.cpp
index 583020c9389..9e463c121cb 100644
--- a/src/mame/video/seta001.cpp
+++ b/src/mame/video/seta001.cpp
@@ -32,6 +32,14 @@
This should implement device_video_interface, since it generates the vertical
and horizontal blanking and sync signals from a master clock.
+
+ understand sprite limits / how sprite 0 sometimes must be skipped, maybe
+ layers being enabled counts against limits? maybe some chip revisions skip
+ the first sprite? see note in device_start
+
+ understand why we need offset kludges for some games, they can even differ
+ from layer to layer
+
*/
#include "emu.h"