diff options
author | 2020-10-16 15:13:51 +0200 | |
---|---|---|
committer | 2020-10-17 00:13:51 +1100 | |
commit | 8b595339529ff8776c4f1e28557e2f6c392dec39 (patch) | |
tree | aef6f95d9658a133b3e6a151221bff72985ebf50 | |
parent | b95bc8727561b74339b9fa45b0b3f344cc35c32c (diff) |
Create GitHub Action to validate hash XML files (#7323)
* Create GitHub Action to validate hash XML files
This GitHub Action will run on any commit or pull request that changes a file in the "hash" directory. It will do a simple xmllint run for the HSI files and will check the softwarelist XML files against their DTD.
* Delete c64_flop_clcracked.xml
No content, can be recreated if needed.
* Remove references to removed softwarelist c64_flop_clcracked.xml
-rw-r--r-- | .github/workflows/hash.yml | 23 | ||||
-rw-r--r-- | hash/c64_flop_clcracked.xml | 8 | ||||
-rw-r--r-- | src/mame/drivers/c128.cpp | 3 | ||||
-rw-r--r-- | src/mame/drivers/c64.cpp | 6 |
4 files changed, 26 insertions, 14 deletions
diff --git a/.github/workflows/hash.yml b/.github/workflows/hash.yml new file mode 100644 index 00000000000..cec7fca734b --- /dev/null +++ b/.github/workflows/hash.yml @@ -0,0 +1,23 @@ +name: XML validation + +on: + push: + paths: + - 'hash/*' + pull_request: + paths: + - 'hash/*' + +jobs: + validate: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@master + - name: Install dependencies + run: | + sudo apt-get update + sudo apt-get install -y libxml2-utils + - name: Validate (HSI) + run: for x in hash/*.hsi ; do xmllint --noout "$x" ; done + - name: Validate (XML) + run: for x in hash/*.xml ; do xmllint --noout --valid "$x" ; done diff --git a/hash/c64_flop_clcracked.xml b/hash/c64_flop_clcracked.xml deleted file mode 100644 index d1c6c38233d..00000000000 --- a/hash/c64_flop_clcracked.xml +++ /dev/null @@ -1,8 +0,0 @@ -<?xml version="1.0"?> -<!DOCTYPE softwarelist SYSTEM "softwarelist.dtd"> -<!-- -license:CC0 ---> -<softwarelist name="c64_flop_clcracked" description="Commodore 64 cleanly cracked disks"> - -</softwarelist> diff --git a/src/mame/drivers/c128.cpp b/src/mame/drivers/c128.cpp index 47843515c0c..71d24a0ceb6 100644 --- a/src/mame/drivers/c128.cpp +++ b/src/mame/drivers/c128.cpp @@ -1756,9 +1756,8 @@ void c128_state::ntsc(machine_config &config) SOFTWARE_LIST(config, "cart_list_c64").set_original("c64_cart").set_filter("NTSC"); SOFTWARE_LIST(config, "cass_list_c64").set_original("c64_cass").set_filter("NTSC"); SOFTWARE_LIST(config, "cart_list_vic10").set_original("vic10").set_filter("NTSC"); - // disk softlist split into originals, cleanly cracked, and misc (homebrew and defaced cracks) + // disk softlist split into originals and misc (homebrew and cracks) SOFTWARE_LIST(config, "flop525_orig").set_original("c64_flop_orig").set_filter("NTSC"); - SOFTWARE_LIST(config, "flop525_clean").set_compatible("c64_flop_clcracked").set_filter("NTSC"); SOFTWARE_LIST(config, "flop525_misc").set_compatible("c64_flop_misc").set_filter("NTSC"); // function ROM diff --git a/src/mame/drivers/c64.cpp b/src/mame/drivers/c64.cpp index 58363439f44..cf09c234d03 100644 --- a/src/mame/drivers/c64.cpp +++ b/src/mame/drivers/c64.cpp @@ -1563,9 +1563,8 @@ void c64_state::ntsc(machine_config &config) SOFTWARE_LIST(config, "cart_list_vic10").set_original("vic10").set_filter("NTSC"); SOFTWARE_LIST(config, "cart_list_c64").set_original("c64_cart").set_filter("NTSC"); SOFTWARE_LIST(config, "cass_list").set_original("c64_cass").set_filter("NTSC"); - // disk softlist split into originals, cleanly cracked, and misc (homebrew and defaced cracks) + // disk softlist split into originals and misc (homebrew and cracks) SOFTWARE_LIST(config, "flop525_orig").set_original("c64_flop_orig").set_filter("NTSC"); - SOFTWARE_LIST(config, "flop525_clean").set_compatible("c64_flop_clcracked").set_filter("NTSC"); SOFTWARE_LIST(config, "flop525_misc").set_compatible("c64_flop_misc").set_filter("NTSC"); // internal ram @@ -1737,9 +1736,8 @@ void c64_state::pal(machine_config &config) SOFTWARE_LIST(config, "cart_list_vic10").set_original("vic10").set_filter("PAL"); SOFTWARE_LIST(config, "cart_list_c64").set_original("c64_cart").set_filter("PAL"); SOFTWARE_LIST(config, "cass_list").set_original("c64_cass").set_filter("PAL"); - // disk softlist split into originals, cleanly cracked, and misc (homebrew and defaced cracks) + // disk softlist split into originals and misc (homebrew and cracks) SOFTWARE_LIST(config, "flop525_orig").set_original("c64_flop_orig").set_filter("PAL"); - SOFTWARE_LIST(config, "flop525_clean").set_compatible("c64_flop_clcracked").set_filter("PAL"); SOFTWARE_LIST(config, "flop525_misc").set_compatible("c64_flop_misc").set_filter("PAL"); // internal ram |