summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--src/devices/cpu/hcd62121/hcd62121_ops.h1
-rw-r--r--src/devices/cpu/upd7810/upd7810.cpp24
-rw-r--r--src/devices/cpu/v810/v810.cpp7
-rw-r--r--src/devices/video/ef9345.cpp2
-rw-r--r--src/devices/video/h63484.cpp1
-rw-r--r--src/devices/video/i8244.cpp1
-rw-r--r--src/devices/video/mc6845.cpp1
-rw-r--r--src/devices/video/psx.cpp6
-rw-r--r--src/devices/video/scn2674.cpp109
-rw-r--r--src/emu/render.cpp3
-rw-r--r--src/emu/ui/selgame.cpp1
-rw-r--r--src/lib/netlist/devices/nld_system.cpp2
-rw-r--r--src/mame/drivers/bfm_ad5.cpp14
-rw-r--r--src/mame/drivers/bfm_sc5sw.cpp18
-rw-r--r--src/mame/machine/deco146.cpp5
-rw-r--r--src/mame/machine/pgmprot_igs027a_type1.cpp3
-rw-r--r--src/osd/modules/debugger/debugint.cpp25
17 files changed, 105 insertions, 118 deletions
diff --git a/src/devices/cpu/hcd62121/hcd62121_ops.h b/src/devices/cpu/hcd62121/hcd62121_ops.h
index 7ede44b3105..27bd988e650 100644
--- a/src/devices/cpu/hcd62121/hcd62121_ops.h
+++ b/src/devices/cpu/hcd62121/hcd62121_ops.h
@@ -185,7 +185,6 @@
{ \
UINT16 res = ( m_temp1[i] & 0x0f ) + ( m_temp2[i] & 0x0f ) + carry; \
\
- carry = 0; \
if ( res > 9 ) \
{ \
res += 6; \
diff --git a/src/devices/cpu/upd7810/upd7810.cpp b/src/devices/cpu/upd7810/upd7810.cpp
index f22ccb07b4f..bf699d70fa9 100644
--- a/src/devices/cpu/upd7810/upd7810.cpp
+++ b/src/devices/cpu/upd7810/upd7810.cpp
@@ -1735,20 +1735,20 @@ void upd7810_device::device_reset()
m_tm.d = 0;
m_ecnt.d = 0;
m_etm.d = 0;
- m_ma = 0;
- m_mb = 0;
+ MA = 0xff;
+ MB = 0xff;
m_mcc = 0;
- m_mc = 0;
+ MC = 0xff;
m_mm = 0;
- m_mf = 0;
- m_tmm = 0;
- m_etmm = 0;
+ MF = 0xff;
+ TMM = 0xff;
+ ETMM = 0xff;
m_eom = 0;
m_sml = 0;
m_smh = 0;
m_anm = 0;
- m_mkl = 0;
- m_mkh = 0;
+ MKL = 0xFF;
+ MKH = 0xFF; // ??
m_zcm = 0;
m_pa_in = 0;
m_pb_in = 0;
@@ -1802,14 +1802,6 @@ void upd7810_device::device_reset()
m_adrange = 0;
PANM = 0xff;
- ETMM = 0xff;
- TMM = 0xff;
- MA = 0xff;
- MB = 0xff;
- MC = 0xff;
- MF = 0xff;
- MKL = 0xff;
- MKH = 0xff; //?
}
void upd7801_device::device_reset()
diff --git a/src/devices/cpu/v810/v810.cpp b/src/devices/cpu/v810/v810.cpp
index fa41ce71986..84293a990ae 100644
--- a/src/devices/cpu/v810/v810.cpp
+++ b/src/devices/cpu/v810/v810.cpp
@@ -1247,16 +1247,13 @@ const v810_device::opcode_func v810_device::s_OpCodeTable[64] =
void v810_device::device_start()
{
- m_irq_state = CLEAR_LINE;
- m_irq_line = 0;
- m_nmi_line = CLEAR_LINE;
m_program = &space(AS_PROGRAM);
m_direct = &m_program->direct();
m_io = &space(AS_IO);
m_irq_line = 0;
- m_irq_state = 0;
- m_nmi_line = 0;
+ m_irq_state = CLEAR_LINE;
+ m_nmi_line = CLEAR_LINE;
memset(m_reg, 0x00, sizeof(m_reg));
save_item(NAME(m_reg));
diff --git a/src/devices/video/ef9345.cpp b/src/devices/video/ef9345.cpp
index ca8062bbb95..921611d695f 100644
--- a/src/devices/video/ef9345.cpp
+++ b/src/devices/video/ef9345.cpp
@@ -860,7 +860,7 @@ void ef9345_device::ef9345_exec(UINT8 cmd)
set_busy_flag(3.5);
switch(cmd&7)
{
- case 0: m_registers[1] = m_charset->u8(indexrom(7) & 0x1fff);
+ case 0: m_registers[1] = m_charset->u8(indexrom(7) & 0x1fff); break;
case 1: m_registers[1] = m_tgs; break;
case 2: m_registers[1] = m_mat; break;
case 3: m_registers[1] = m_pat; break;
diff --git a/src/devices/video/h63484.cpp b/src/devices/video/h63484.cpp
index 906c01573e4..1fd79e565f5 100644
--- a/src/devices/video/h63484.cpp
+++ b/src/devices/video/h63484.cpp
@@ -2016,7 +2016,6 @@ void h63484_device::device_reset()
m_hc = m_hds = m_hdw = m_hws = m_hww = 0;
m_vc = m_vws = m_vww = m_vds = m_vsw = 0;
m_sp[0] = m_sp[1] = m_sp[2] = 0;
- m_ppx = m_ppy = 0;
m_cl0 = m_cl1 = 0;
m_xmin = m_ymin = m_xmax = m_ymax = 0;
m_ppx = m_pzcx = m_psx = m_pzx = m_pex = 0;
diff --git a/src/devices/video/i8244.cpp b/src/devices/video/i8244.cpp
index a074b676e64..82ddeed4e43 100644
--- a/src/devices/video/i8244.cpp
+++ b/src/devices/video/i8244.cpp
@@ -746,7 +746,6 @@ void i8244_device::sound_stream_update(sound_stream &stream, stream_sample_t **i
{
for( ii = 0; ii < samples; ii++, buffer++ )
{
- *buffer = 0;
*buffer = signal & 0x1;
period = (m_vdc.s.sound & 0x20) ? 1 : 4;
if( ++m_sh_count >= period )
diff --git a/src/devices/video/mc6845.cpp b/src/devices/video/mc6845.cpp
index e934fc447ce..553728e8412 100644
--- a/src/devices/video/mc6845.cpp
+++ b/src/devices/video/mc6845.cpp
@@ -1047,7 +1047,6 @@ void mc6845_device::device_start()
m_vert_sync_pos = 1;
m_de = 0;
m_sync_width = 1;
- m_vert_disp = 0;
m_horiz_pix_total = m_vert_pix_total = 0;
m_max_visible_x = m_max_visible_y = 0;
m_hsync_on_pos = m_vsync_on_pos = 0;
diff --git a/src/devices/video/psx.cpp b/src/devices/video/psx.cpp
index fae5adaf923..24af56ee05b 100644
--- a/src/devices/video/psx.cpp
+++ b/src/devices/video/psx.cpp
@@ -2312,9 +2312,9 @@ void psxgpu_device::GouraudLine( void )
n_xend = SINT11( COORD_X( m_packet.GouraudLine.vertex[ 1 ].n_coord ) );
n_yend = SINT11( COORD_Y( m_packet.GouraudLine.vertex[ 1 ].n_coord ) );
- n_cr2.w.h = BGR_R( m_packet.GouraudLine.vertex[ 1 ].n_bgr ); n_cr1.w.l = 0;
- n_cg2.w.h = BGR_G( m_packet.GouraudLine.vertex[ 1 ].n_bgr ); n_cg1.w.l = 0;
- n_cb2.w.h = BGR_B( m_packet.GouraudLine.vertex[ 1 ].n_bgr ); n_cb1.w.l = 0;
+ n_cr2.w.h = BGR_R( m_packet.GouraudLine.vertex[ 1 ].n_bgr ); n_cr2.w.l = 0;
+ n_cg2.w.h = BGR_G( m_packet.GouraudLine.vertex[ 1 ].n_bgr ); n_cg2.w.l = 0;
+ n_cb2.w.h = BGR_B( m_packet.GouraudLine.vertex[ 1 ].n_bgr ); n_cb2.w.l = 0;
n_x.sw.h = n_xstart; n_x.sw.l = 0;
n_y.sw.h = n_ystart; n_y.sw.l = 0;
diff --git a/src/devices/video/scn2674.cpp b/src/devices/video/scn2674.cpp
index fc2f5e23512..d448c02161b 100644
--- a/src/devices/video/scn2674.cpp
+++ b/src/devices/video/scn2674.cpp
@@ -44,61 +44,60 @@ void scn2674_device::device_start()
void scn2674_device::device_reset()
{
- m_IR_pointer= 0;
- m_screen1_l= 0;
- m_screen1_h= 0;
- m_cursor_l= 0;
- m_cursor_h= 0;
- m_screen2_l= 0;
- m_screen2_h= 0;
- m_irq_register= 0;
- m_status_register= 0;
- m_irq_mask= 0;
- m_gfx_enabled= 0;
- m_display_enabled= 0;
- m_display_enabled_field= 0;
- m_display_enabled_scanline= 0;
- m_cursor_enabled= 0;
- m_IR0_double_ht_wd= 0;
- m_IR0_scanline_per_char_row= 1;
- m_IR0_sync_select= 0;
- m_IR0_buffer_mode_select= 0;
- m_IR1_interlace_enable= 0;
- m_IR1_equalizing_constant= 0;
- m_IR2_row_table= 0;
- m_IR2_horz_sync_width= 0;
- m_IR2_horz_back_porch= 0;
- m_IR3_vert_front_porch= 0;
- m_IR3_vert_back_porch= 0;
- m_IR4_rows_per_screen= 0;
- m_IR4_character_blink_rate_divisor= 0;
- m_IR5_character_per_row= 0;
- m_IR6_cursor_first_scanline= 0;
- m_IR6_cursor_last_scanline= 0;
- m_IR7_cursor_underline_position= 0;
- m_IR7_cursor_rate_divisor= 0;
- m_IR7_cursor_blink= 0;
- m_IR7_vsync_width= 0;
- m_IR8_display_buffer_first_address_LSB= 0;
- m_IR9_display_buffer_first_address_MSB= 0;
- m_IR9_display_buffer_last_address= 0;
- m_IR10_display_pointer_address_lower= 0;
- m_IR11_display_pointer_address_upper= 0;
- m_IR11_reset_scanline_counter_on_scrollup= 0;
- m_IR11_reset_scanline_counter_on_scrolldown= 0;
- m_IR12_scroll_start= 0;
- m_IR12_split_register_1= 0;
- m_IR13_scroll_end= 0;
- m_IR13_split_register_2= 0;
- m_IR14_scroll_lines= 0;
- m_IR14_double_1= 0;
- m_IR14_double_2= 0;
- m_spl1= 0;
- m_spl2= 0;
- m_dbl1= 0;
- m_buffer= 0;
- m_linecounter= 0;
- m_irq_state= 0;
+ m_screen1_l = 0;
+ m_screen1_h = 0;
+ m_cursor_l = 0;
+ m_cursor_h = 0;
+ m_screen2_l = 0;
+ m_screen2_h = 0;
+ m_irq_register = 0;
+ m_status_register = 0;
+ m_irq_mask = 0;
+ m_gfx_enabled = 0;
+ m_display_enabled = 0;
+ m_display_enabled_field = 0;
+ m_display_enabled_scanline = 0;
+ m_cursor_enabled = 0;
+ m_IR0_double_ht_wd = 0;
+ m_IR0_scanline_per_char_row = 1;
+ m_IR0_sync_select = 0;
+ m_IR0_buffer_mode_select = 0;
+ m_IR1_interlace_enable = 0;
+ m_IR1_equalizing_constant = 0;
+ m_IR2_row_table = 0;
+ m_IR2_horz_sync_width = 0;
+ m_IR2_horz_back_porch = 0;
+ m_IR3_vert_front_porch = 0;
+ m_IR3_vert_back_porch = 0;
+ m_IR4_rows_per_screen = 0;
+ m_IR4_character_blink_rate_divisor = 0;
+ m_IR5_character_per_row = 0;
+ m_IR6_cursor_first_scanline = 0;
+ m_IR6_cursor_last_scanline = 0;
+ m_IR7_cursor_underline_position = 0;
+ m_IR7_cursor_rate_divisor = 0;
+ m_IR7_cursor_blink = 0;
+ m_IR7_vsync_width = 0;
+ m_IR8_display_buffer_first_address_LSB = 0;
+ m_IR9_display_buffer_first_address_MSB = 0;
+ m_IR9_display_buffer_last_address = 0;
+ m_IR10_display_pointer_address_lower = 0;
+ m_IR11_display_pointer_address_upper = 0;
+ m_IR11_reset_scanline_counter_on_scrollup = 0;
+ m_IR11_reset_scanline_counter_on_scrolldown = 0;
+ m_IR12_scroll_start = 0;
+ m_IR12_split_register_1 = 0;
+ m_IR13_scroll_end = 0;
+ m_IR13_split_register_2 = 0;
+ m_IR14_scroll_lines = 0;
+ m_IR14_double_1 = 0;
+ m_IR14_double_2 = 0;
+ m_spl1 = 0;
+ m_spl2 = 0;
+ m_dbl1 = 0;
+ m_buffer = 0;
+ m_linecounter = 0;
+ m_irq_state = 0;
m_IR_pointer = 0;
m_address = 0;
m_start1change = 0;
diff --git a/src/emu/render.cpp b/src/emu/render.cpp
index 6ee9e871c43..f9e55bf9abe 100644
--- a/src/emu/render.cpp
+++ b/src/emu/render.cpp
@@ -935,7 +935,6 @@ render_target::render_target(render_manager &manager, const char *layoutfile, UI
m_base_layerconfig.set_zoom_to_screen(manager.machine().options().artwork_crop());
// determine the base orientation based on options
- m_orientation = ROT0;
if (!manager.machine().options().rotate())
m_base_orientation = orientation_reverse(manager.machine().system().flags & ORIENTATION_MASK);
@@ -1353,7 +1352,7 @@ render_primitive_list &render_target::get_primitives()
ui_xform.yoffs = 0;
ui_xform.xscale = (float)m_width;
ui_xform.yscale = (float)m_height;
- ui_xform.color.r = ui_xform.color.g = ui_xform.color.b = ui_xform.color.a = 1.0f;
+ ui_xform.color.r = ui_xform.color.g = ui_xform.color.b = 1.0f;
ui_xform.color.a = 0.9f;
ui_xform.orientation = m_orientation;
ui_xform.no_center = true;
diff --git a/src/emu/ui/selgame.cpp b/src/emu/ui/selgame.cpp
index 107328e796e..54fcc4b8fbf 100644
--- a/src/emu/ui/selgame.cpp
+++ b/src/emu/ui/selgame.cpp
@@ -311,7 +311,6 @@ void ui_menu_select_game::custom_render(void *selectedref, float top, float bott
x1 += UI_BOX_LR_BORDER;
x2 -= UI_BOX_LR_BORDER;
y1 += UI_BOX_TB_BORDER;
- y2 -= UI_BOX_TB_BORDER;
// draw the text within it
machine().ui().draw_text_full(container, tempbuf[0].c_str(), x1, y1, x2 - x1, JUSTIFY_CENTER, WRAP_TRUNCATE,
diff --git a/src/lib/netlist/devices/nld_system.cpp b/src/lib/netlist/devices/nld_system.cpp
index 628ec617cb1..ca96f776aac 100644
--- a/src/lib/netlist/devices/nld_system.cpp
+++ b/src/lib/netlist/devices/nld_system.cpp
@@ -316,8 +316,6 @@ NETLIB_START(function)
rc.m_cmd = MULT;
else if (cmd == "/")
rc.m_cmd = DIV;
- else if (cmd == "/")
- rc.m_cmd = DIV;
else if (cmd.startsWith("A"))
{
rc.m_cmd = PUSH_INPUT;
diff --git a/src/mame/drivers/bfm_ad5.cpp b/src/mame/drivers/bfm_ad5.cpp
index cf4f4501c0f..be650aba75b 100644
--- a/src/mame/drivers/bfm_ad5.cpp
+++ b/src/mame/drivers/bfm_ad5.cpp
@@ -38,17 +38,25 @@ DRIVER_INIT_MEMBER(adder5_state,ad5)
// find it.
int found = find_project_string(machine(), 3, 0);
if (!found)
+ {
printf("Normal rom pair string not found, checking mismatched / missing rom string\n");
+ }
// help identify roms where one of the pair is missing too
if (!found)
{
- found = find_project_string(machine(), 3, 1);
- found = find_project_string(machine(), 3, 2);
+ found = find_project_string(machine(), 3, 1);
}
- if (!found)
+ if (!found)
+ {
+ found = find_project_string(machine(), 3, 2);
+ }
+
+ if (!found)
+ {
printf("No suitable string found\n");
+ }
}
diff --git a/src/mame/drivers/bfm_sc5sw.cpp b/src/mame/drivers/bfm_sc5sw.cpp
index 04fc77c13fc..b2d826fafee 100644
--- a/src/mame/drivers/bfm_sc5sw.cpp
+++ b/src/mame/drivers/bfm_sc5sw.cpp
@@ -13135,17 +13135,25 @@ DRIVER_INIT_MEMBER(bfm_sc5_state,sc5)
// find it.
int found = find_project_string(machine(), 3, 0);
if (!found)
+ {
printf("Normal rom pair string not found, checking mismatched / missing rom string\n");
+ }
// help identify roms where one of the pair is missing too
if (!found)
{
- found = find_project_string(machine(), 3, 1);
- found = find_project_string(machine(), 3, 2);
+ found = find_project_string(machine(), 3, 1);
}
-
- if (!found)
- printf("No suitable string found\n");
+
+ if (!found)
+ {
+ found = find_project_string(machine(), 3, 2);
+ }
+
+ if (!found)
+ {
+ printf("No suitable string found\n");
+ }
}
diff --git a/src/mame/machine/deco146.cpp b/src/mame/machine/deco146.cpp
index 873764c1c3c..d0ba7bd27e3 100644
--- a/src/mame/machine/deco146.cpp
+++ b/src/mame/machine/deco146.cpp
@@ -1449,8 +1449,6 @@ void deco_146_base_device::device_reset()
m_current_rambank = 0;
- m_nand = 0x0000;
- m_xor = 0x0000;
m_soundlatch = 0x0000;
m_latchaddr = 0xffff;
@@ -1460,9 +1458,6 @@ void deco_146_base_device::device_reset()
m_xor=0;
// m_nand=0xffff;
m_nand=0x0; // wizard fire doesn't initialize it, but accesses addresses rohga needs the mask applied on
-
-
-
}
diff --git a/src/mame/machine/pgmprot_igs027a_type1.cpp b/src/mame/machine/pgmprot_igs027a_type1.cpp
index 1a27910739d..096d1135c2b 100644
--- a/src/mame/machine/pgmprot_igs027a_type1.cpp
+++ b/src/mame/machine/pgmprot_igs027a_type1.cpp
@@ -1846,8 +1846,6 @@ int pgm_arm_type1_state::puzzli2_take_leveldata_value(UINT8 datvalue)
{
if (stage==-1)
{
- tableoffs = 0;
- tableoffs2 = 0;
entries_left = 0;
currentcolumn = 0;
currentrow = 0;
@@ -2114,7 +2112,6 @@ DRIVER_INIT_MEMBER(pgm_arm_type1_state,puzzli2)
hackcount2 = 0;
hack_47_value = 0;
hack_31_table_offset = 0;
- hack_31_table_offset = 0;
//#define PUZZLI2_LEVEL_STRUCTURE_LOG
#ifdef PUZZLI2_LEVEL_STRUCTURE_LOG
diff --git a/src/osd/modules/debugger/debugint.cpp b/src/osd/modules/debugger/debugint.cpp
index 54ffea19ee9..e8ac5891766 100644
--- a/src/osd/modules/debugger/debugint.cpp
+++ b/src/osd/modules/debugger/debugint.cpp
@@ -1437,22 +1437,21 @@ void debug_internal::wait_for_debugger(device_t &device, bool firststop)
{
if (firststop && list == NULL)
{
- DView *dv;
- render_target *target;
-
- target = &device.machine().render().ui_target();
+ render_target *target = &device.machine().render().ui_target();
//set_view_by_name(target, "Debug");
- dv = dview_alloc(target, device.machine(), DVT_DISASSEMBLY, VIEW_STATE_FOLLOW_CPU);
- dv->editor.active = TRUE;
- dv->editor.container = &device.machine().render().ui_container();
- dv = dview_alloc(target, device.machine(), DVT_STATE, VIEW_STATE_FOLLOW_CPU);
- dv = dview_alloc(target, device.machine(), DVT_CONSOLE, VIEW_STATE_FOLLOW_CPU);
- dview_set_title(dv, "Console");
- dv->editor.active = TRUE;
- dv->editor.container = &device.machine().render().ui_container();
- set_focus_view(dv);
+ DView *disassembly = dview_alloc(target, device.machine(), DVT_DISASSEMBLY, VIEW_STATE_FOLLOW_CPU);
+ disassembly->editor.active = TRUE;
+ disassembly->editor.container = &device.machine().render().ui_container();
+
+ dview_alloc(target, device.machine(), DVT_STATE, VIEW_STATE_FOLLOW_CPU);
+
+ DView *console = dview_alloc(target, device.machine(), DVT_CONSOLE, VIEW_STATE_FOLLOW_CPU);
+ dview_set_title(console, "Console");
+ console->editor.active = TRUE;
+ console->editor.container = &device.machine().render().ui_container();
+ set_focus_view(console);
}
followers_set_cpu(&device);