diff options
author | 2017-08-10 09:59:20 +1000 | |
---|---|---|
committer | 2017-08-10 10:07:31 +1000 | |
commit | bc4bfb40051f912b8afe78bc99ab98383b2e7c15 (patch) | |
tree | 2a8cc876c501c78bb3ddccd6f67206d8c9590bee /src/frontend/mame/ui/utils.h | |
parent | 147f1d89b0a42ddd33c4f89abaed2765bc86dd8f (diff) |
Remove a whole lot of I64 from format strings.
There are a couple of issues here:
* Firstly, the determining factor for whether I64 or ll is needed as the
size qualifier doesn't depend entirely on whether you're using MSVC or
not, it depends on the the C runtime library. The msys64 C runtime
apes the Microsoft runtime and requires I64 as well, so a lot of files
where LLFORMAT had been copy/pasted wouldn't work right if you
depeneded on it anyway.
* Secondly, one of the major benefits of util::string_format,
util::stream_format and logerror in their current forms is that you
don't need size specifiers for integers at all (unless you're using
them to truncate a value, but in that case you're better off casting
the argument for clarity). If you do use them, logerror and friends
will accept both Microsoft- and SUS-style independently of the C
runtime.
So please everyone, don't go gratuitously throwing these around, and if
you must use them (e.g. for osd_printf_* functions), make sure your
conditionals are actually correct. Also, conisder using
util::string_format to do the formatting into a temporary string and
just feeding that to the output function so you can avoid the mess.
Diffstat (limited to 'src/frontend/mame/ui/utils.h')
-rw-r--r-- | src/frontend/mame/ui/utils.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/frontend/mame/ui/utils.h b/src/frontend/mame/ui/utils.h index 0942728152c..6ccc4394857 100644 --- a/src/frontend/mame/ui/utils.h +++ b/src/frontend/mame/ui/utils.h @@ -219,7 +219,6 @@ DECLARE_ENUM_INCDEC_OPERATORS(software_filter::type) } // namespace ui #define MAX_CHAR_INFO 256 -#define MAX_CUST_FILTER 8 enum { |