From eb80c98fcd5d21fc0da75ce0598d12b5f35ffe7b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Oliver=20St=C3=B6neberg?= Date: Sat, 1 Nov 2014 11:50:26 +0100 Subject: updated comments/TODOs about invalid vptr warnings (nw) --- src/build/flags_clang.mak | 2 +- src/emu/bus/isa/s3virge.c | 1 + src/emu/bus/isa/trident.c | 1 + src/emu/video/pc_vga.c | 1 + 4 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/build/flags_clang.mak b/src/build/flags_clang.mak index 5aaa56d1c8b..782ac524b45 100644 --- a/src/build/flags_clang.mak +++ b/src/build/flags_clang.mak @@ -20,7 +20,7 @@ ifeq ($(findstring 3.5,$(TEST_CLANG)),3.5) CCOMFLAGS += -Wno-inline-new-delete # caused by src/mess/drivers/x07.c, src/osd/sdl/window.c, src/emu/sound/disc_mth.inc CCOMFLAGS += -Wno-absolute-value -# caused by src/emu/bus/isa/s3virge.c, src/emu/cpu/drcfe.c, src/emu/video/pc_vga.c +# caused by src/emu/bus/isa/s3virge.c, src/emu/bus/isa/trident.c, src/emu/video/pc_vga.c CCOMFLAGS +=-Wno-dynamic-class-memaccess # these were disabled because of bugs in older clang versions CCOMFLAGS += -Wformat-security diff --git a/src/emu/bus/isa/s3virge.c b/src/emu/bus/isa/s3virge.c index 2e6ba49e279..e3162392831 100644 --- a/src/emu/bus/isa/s3virge.c +++ b/src/emu/bus/isa/s3virge.c @@ -45,6 +45,7 @@ s3virgedx_rev1_vga_device::s3virgedx_rev1_vga_device(const machine_config &mconf void s3virge_vga_device::device_start() { + // FIXME: this kills the vptr of vga.memory memset(&vga, 0, sizeof(vga)); memset(&svga, 0, sizeof(svga)); diff --git a/src/emu/bus/isa/trident.c b/src/emu/bus/isa/trident.c index a4afa62d9f8..2ac306a0d7d 100644 --- a/src/emu/bus/isa/trident.c +++ b/src/emu/bus/isa/trident.c @@ -155,6 +155,7 @@ void trident_vga_device::WRITEPIXEL(INT16 x,INT16 y, UINT32 data) void trident_vga_device::device_start() { + // FIXME: this kill the vga.memory vptr memset(&vga, 0, sizeof(vga)); memset(&svga, 0, sizeof(svga)); diff --git a/src/emu/video/pc_vga.c b/src/emu/video/pc_vga.c index 93e7e2a6354..54458c9338d 100644 --- a/src/emu/video/pc_vga.c +++ b/src/emu/video/pc_vga.c @@ -208,6 +208,7 @@ TIMER_CALLBACK_MEMBER(vga_device::vblank_timer_cb) void vga_device::device_start() { + // FIXME: this kills the vga.memory vptr memset(&vga, 0, sizeof(vga)); int i; -- cgit v1.2.3