From e8bae53e6ed2da3b84b3d5a774d0811e20ae8103 Mon Sep 17 00:00:00 2001 From: hap Date: Tue, 25 Apr 2017 19:38:38 +0200 Subject: novagmcs48: clear mux data after updating leds (nw) --- src/mame/drivers/fidelz80.cpp | 6 +++--- src/mame/drivers/novagmcs48.cpp | 9 ++++----- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/src/mame/drivers/fidelz80.cpp b/src/mame/drivers/fidelz80.cpp index 503699bbf8b..4c472929ec2 100644 --- a/src/mame/drivers/fidelz80.cpp +++ b/src/mame/drivers/fidelz80.cpp @@ -1059,15 +1059,15 @@ WRITE8_MEMBER(fidelz80_state::vbrc_ioexp_port_w) WRITE8_MEMBER(fidelz80_state::vbrc_mcu_p1_w) { - // d0-d7: select digits, input mux + // P10-P17: select digits, input mux m_inp_mux = m_led_select = data; vbrc_prepare_display(); } READ8_MEMBER(fidelz80_state::vbrc_mcu_p2_r) { - // d0-d3: I8243 P2 - // d4-d7: multiplexed inputs (active low) + // P20-P23: I8243 P2 + // P24-P27: multiplexed inputs (active low) return (m_i8243->i8243_p2_r(space, offset) & 0x0f) | (read_inputs(8) << 4 ^ 0xf0); } diff --git a/src/mame/drivers/novagmcs48.cpp b/src/mame/drivers/novagmcs48.cpp index 3894bad3714..c45b81f82e9 100644 --- a/src/mame/drivers/novagmcs48.cpp +++ b/src/mame/drivers/novagmcs48.cpp @@ -11,8 +11,8 @@ such as Arena(in editmode). TODO: - - is presto led handling correct? led data needs to be auto cleared - similar to novag6502 sforte/sexpert + - is presto led handling correct? mux data needs to be auto cleared + similar to diablo/sexpert ****************************************************************************** @@ -65,7 +65,6 @@ WRITE8_MEMBER(novagmcs48_state::presto_mux_w) { // D0-D7: input mux low, led data m_inp_mux = (m_inp_mux & ~0xff) | (~data & 0xff); - m_led_data = ~data & 0xff; } WRITE8_MEMBER(novagmcs48_state::presto_control_w) @@ -78,8 +77,8 @@ WRITE8_MEMBER(novagmcs48_state::presto_control_w) // P24-P26: led select m_led_select = ~data >> 4 & 7; - display_matrix(8, 3, m_led_data, m_led_select); - m_led_data = 0; // ? + display_matrix(8, 3, m_inp_mux, m_led_select); + m_inp_mux &= ~0xff; // ? } READ8_MEMBER(novagmcs48_state::presto_input_r) -- cgit v1.2.3