From e4640f7cc370f91858e18e21f9bc2f81f386504c Mon Sep 17 00:00:00 2001 From: hap Date: Wed, 17 Jan 2018 23:19:22 +0100 Subject: carjmbre: add notes (nw) --- src/mame/drivers/carjmbre.cpp | 9 ++++++--- src/mame/drivers/popper.cpp | 4 ++-- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/src/mame/drivers/carjmbre.cpp b/src/mame/drivers/carjmbre.cpp index d2eb759239e..afa62d69032 100644 --- a/src/mame/drivers/carjmbre.cpp +++ b/src/mame/drivers/carjmbre.cpp @@ -6,8 +6,11 @@ Omori Electric CAD (OEC) 1983 TODO: - - colors are wrong - - sprite priorities? + - colors are probably wrong + - sprite priorities? (eg. player car jumping on the ramp, 1 part disappears) + - first 2 letters on titlescreen look misaligned with the tilemap + - The spriteram holds 2 sprite lists (00-7f and 80-ff), they are identical. + Is it an unused feature? Or a RAM access speed workaround? ---------------------------------------------------------------------------- @@ -179,7 +182,7 @@ uint32_t carjmbre_state::screen_update(screen_device &screen, bitmap_ind16 &bitm void carjmbre_state::draw_sprites(bitmap_ind16 &bitmap, const rectangle &cliprect) { - for (int offs = m_spriteram.bytes() - 4; offs >= 0; offs -= 4) + for (int offs = 0x80 - 4; offs >= 0; offs -= 4) { int sy = m_spriteram[offs]; int code = m_spriteram[offs + 1]; diff --git a/src/mame/drivers/popper.cpp b/src/mame/drivers/popper.cpp index fdc14405b3a..edf3edfaf10 100644 --- a/src/mame/drivers/popper.cpp +++ b/src/mame/drivers/popper.cpp @@ -326,13 +326,13 @@ uint32_t popper_state::screen_update(screen_device &screen, bitmap_ind16 &bitmap // draw the sprites for (int offs = 0; offs < 0x800; offs += 4) { - // 0 76653210 Y coordinate + // 0 76543210 Y coordinate // 1 76543210 Code // 2 7------- Flip Y // 2 -6------ Flip X // 2 --54---- Not used // 2 ----3210 Color - // 3 76653210 X coordinate + // 3 76543210 X coordinate int sx = m_sprite_ram[offs + 3]; int sy = m_sprite_ram[offs + 0]; -- cgit v1.2.3