From d4f41cc101a5be73c88a5600c8d767f1079519e1 Mon Sep 17 00:00:00 2001 From: hap Date: Wed, 24 Aug 2022 23:37:57 +0200 Subject: bombjack: small cleanup --- src/mame/tecmo/bombjack.cpp | 53 ++++++++++++++++++++------------------------- 1 file changed, 23 insertions(+), 30 deletions(-) diff --git a/src/mame/tecmo/bombjack.cpp b/src/mame/tecmo/bombjack.cpp index 73b41a67ef3..47ef395cdb8 100644 --- a/src/mame/tecmo/bombjack.cpp +++ b/src/mame/tecmo/bombjack.cpp @@ -1,6 +1,5 @@ // license:BSD-3-Clause // copyright-holders:Mirko Buffoni - /*************************************************************************** Bomb Jack @@ -172,7 +171,11 @@ private: }; -// video +/************************************* + * + * Video + * + *************************************/ void bombjack_state::videoram_w(offs_t offset, uint8_t data) { @@ -235,19 +238,19 @@ void bombjack_state::draw_sprites(bitmap_ind16 &bitmap, const rectangle &cliprec { for (int offs = m_spriteram.bytes() - 4; offs >= 0; offs -= 4) { -/* - abbbbbbb cdefgggg hhhhhhhh iiiiiiii - - a use big sprites (32x32 instead of 16x16) - bbbbbbb sprite code - c x flip - d y flip (used only in death sequence?) - e ? (set when big sprites are selected) - f ? (set only when the bonus (B) materializes?) - gggg color - hhhhhhhh x position - iiiiiiii y position -*/ + /* + abbbbbbb cdefgggg hhhhhhhh iiiiiiii + + a use big sprites (32x32 instead of 16x16) + bbbbbbb sprite code + c x flip + d y flip (used only in death sequence?) + e ? (set when big sprites are selected) + f ? (set only when the bonus (B) materializes?) + gggg color + hhhhhhhh x position + iiiiiiii y position + */ int sx = m_spriteram[offs + 3]; int sy; @@ -293,7 +296,11 @@ uint32_t bombjack_state::screen_update(screen_device &screen, bitmap_ind16 &bitm } -// machine +/************************************* + * + * Address maps + * + *************************************/ uint8_t bombjack_state::soundlatch_read_and_clear() { @@ -305,13 +312,6 @@ uint8_t bombjack_state::soundlatch_read_and_clear() return res; } - -/************************************* - * - * Address maps - * - *************************************/ - void bombjack_state::irq_mask_w(uint8_t data) { m_nmi_mask = BIT(data, 0); @@ -564,14 +564,11 @@ void bombjack_state::bombjack(machine_config &config) GFXDECODE(config, m_gfxdecode, m_palette, gfx_bombjack); PALETTE(config, m_palette).set_format(palette_device::xBGR_444, 128); - // sound hardware SPEAKER(config, "mono").front_center(); AY8910(config, "ay1", XTAL(12'000'000) / 8).add_route(ALL_OUTPUTS, "mono", 0.13); // Confirmed from PCB - AY8910(config, "ay2", XTAL(12'000'000) / 8).add_route(ALL_OUTPUTS, "mono", 0.13); - AY8910(config, "ay3", XTAL(12'000'000) / 8).add_route(ALL_OUTPUTS, "mono", 0.13); } @@ -643,8 +640,6 @@ ROM_START( bombjack2 ) ROM_LOAD( "02_p04t.bin", 0x0000, 0x1000, CRC(398d4a02) SHA1(ac18a8219f99ba9178b96c9564de3978e39c59fd) ) ROM_END - - ROM_START( bombjackt ) ROM_REGION( 0x10000, "maincpu", 0 ) ROM_LOAD( "9.1j", 0x0000, 0x4000, CRC(4b59a3bb) SHA1(dae45985d2575821c86757ead14b8313e922570d) ) // == 09_j01b.bin + 10_l01b.bin @@ -666,8 +661,6 @@ ROM_START( bombjackt ) ROM_LOAD( "4.1h", 0x2000, 0x2000, CRC(05e428ab) SHA1(0b2cae76aba8372482a4e315a9f49fd15cb94625) ) ROM_LOAD( "5.1k", 0x4000, 0x2000, CRC(f282f29a) SHA1(521a110213d6ecdf54be0f50f41c3c266d65d84c) ) - - ROM_REGION( 0x6000, "bgtiles1", 0 ) // ok ROM_LOAD( "6.1l", 0x0000, 0x2000, CRC(51eebd89) SHA1(515128a3971fcb97b60c5b6bdd2b03026aec1921) ) ROM_LOAD( "7.1n", 0x2000, 0x2000, CRC(9dd98e9d) SHA1(6db6006a6e20ff7c243d88293ca53681c4703ea5) ) -- cgit v1.2.3