From 89f5aaef852d7d17f8fcc22fd5419e2a18ee44fb Mon Sep 17 00:00:00 2001 From: hap Date: Sat, 14 Nov 2020 18:31:36 +0100 Subject: tlcs90: this fallthrough at opcode must be wrong --- src/devices/cpu/e0c6200/e0c6200.cpp | 3 +-- src/devices/cpu/tlcs90/tlcs90.cpp | 2 +- src/devices/cpu/tlcs90/tlcs90d.cpp | 3 ++- src/devices/sound/namco.cpp | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/devices/cpu/e0c6200/e0c6200.cpp b/src/devices/cpu/e0c6200/e0c6200.cpp index fa8a241f9ec..0cd9f4ef2cb 100644 --- a/src/devices/cpu/e0c6200/e0c6200.cpp +++ b/src/devices/cpu/e0c6200/e0c6200.cpp @@ -288,8 +288,7 @@ void e0c6200_cpu_device::execute_one() case 0x100: m_icount -= 7; pop_pc(); - // fall through! - + [[fallthrough]]; // LBPX MX,e: load memory with 8-bit immediate data, increment X by 2 case 0x900: write_mx(m_op & 0xf); inc_x(); diff --git a/src/devices/cpu/tlcs90/tlcs90.cpp b/src/devices/cpu/tlcs90/tlcs90.cpp index eb07f5a8839..c86353a5ac3 100644 --- a/src/devices/cpu/tlcs90/tlcs90.cpp +++ b/src/devices/cpu/tlcs90/tlcs90.cpp @@ -1022,7 +1022,7 @@ void tlcs90_device::decode() if (b0 == 0xfe) { OPCC( LDI+b1-0x58,14,18 ) NONE( 1 ) NONE( 2 ) return; } - [[fallthrough]]; // FIXME: really? + return; case 0x60: // ADD A,g case 0x61: // ADC A,g diff --git a/src/devices/cpu/tlcs90/tlcs90d.cpp b/src/devices/cpu/tlcs90/tlcs90d.cpp index d39ddc13325..c4ddbb03ccf 100644 --- a/src/devices/cpu/tlcs90/tlcs90d.cpp +++ b/src/devices/cpu/tlcs90/tlcs90d.cpp @@ -877,7 +877,8 @@ void tlcs90_disassembler::decode() if (b0 == 0xfe) { OPCC( LDI+b1-0x58,14,18 ) NONE( 1 ) NONE( 2 ) return; } - [[fallthrough]]; // FIXME: really? + return; + case 0x60: // ADD A,g case 0x61: // ADC A,g case 0x62: // SUB A,g diff --git a/src/devices/sound/namco.cpp b/src/devices/sound/namco.cpp index 5eaa04c7fae..27a540872c2 100644 --- a/src/devices/sound/namco.cpp +++ b/src/devices/sound/namco.cpp @@ -452,7 +452,7 @@ void namco_device::polepos_sound_w(offs_t offset, uint8_t data) case 0x23: voice->waveform_select = data & 7; - /* fall through */ + [[fallthrough]]; case 0x02: case 0x03: voice->volume[0] = voice->volume[1] = 0; -- cgit v1.2.3