From 876d4f1a58c2b8c8a95fecbd4fdd4c2801e62465 Mon Sep 17 00:00:00 2001 From: Robbbert Date: Sun, 3 Apr 2022 02:03:40 +1100 Subject: fixed a couple of reportedly uninitiated variables in the tools. --- src/tools/image_handler.h | 4 ++-- src/tools/imgtool/modules/hp85_tape.cpp | 4 ++-- src/tools/regrep.cpp | 2 +- src/tools/unidasm.cpp | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/tools/image_handler.h b/src/tools/image_handler.h index 8360d7e5206..0ee7bf01c05 100644 --- a/src/tools/image_handler.h +++ b/src/tools/image_handler.h @@ -107,10 +107,10 @@ private: floppy_image m_floppy_image; - const floppy_image_format_t *m_floppy_fs_converter; + const floppy_image_format_t *m_floppy_fs_converter = nullptr; std::vector m_sector_image; std::unique_ptr m_fsblk; - const fs::manager_t *m_fsm; + const fs::manager_t *m_fsm = nullptr; std::unique_ptr m_fs; }; diff --git a/src/tools/imgtool/modules/hp85_tape.cpp b/src/tools/imgtool/modules/hp85_tape.cpp index 14103fc3975..09590f81973 100644 --- a/src/tools/imgtool/modules/hp85_tape.cpp +++ b/src/tools/imgtool/modules/hp85_tape.cpp @@ -115,9 +115,9 @@ private: // Content std::vector content; // First file on track 1 - file_no_t file_track_1; + file_no_t file_track_1{}; // No. of first record on track 1 - uint16_t record_track_1; + uint16_t record_track_1 = 0; bool dec_rec_header(const tape_word_t *hdr , file_no_t& file_no , uint16_t& rec_no , bool& has_body , unsigned& body_len); bool load_whole_tape(); diff --git a/src/tools/regrep.cpp b/src/tools/regrep.cpp index b18b6b1383e..11f1fb861dc 100644 --- a/src/tools/regrep.cpp +++ b/src/tools/regrep.cpp @@ -727,7 +727,7 @@ static void output_report(std::string &dirname, std::string &tempheader, std::st static int compare_screenshots(summary_file *curfile) { bitmap_argb32 bitmaps[MAX_COMPARES]; - int unique[MAX_COMPARES]; + int unique[MAX_COMPARES]{}; int numunique = 0; /* iterate over all files and load their bitmaps */ diff --git a/src/tools/unidasm.cpp b/src/tools/unidasm.cpp index 10dc53b06bf..e58e5ed22f2 100644 --- a/src/tools/unidasm.cpp +++ b/src/tools/unidasm.cpp @@ -679,7 +679,7 @@ class unidasm_data_buffer : public util::disasm_interface::data_buffer { public: std::vector data; - offs_t base_pc; + offs_t base_pc = 0; u32 size; unidasm_data_buffer(util::disasm_interface *disasm, const dasm_table_entry *entry); -- cgit v1.2.3