From 6cf3bc983e37d05f7678f2eac37b800aa37bfbe7 Mon Sep 17 00:00:00 2001 From: Olivier Galibert Date: Fri, 31 Mar 2017 18:36:49 +0200 Subject: bbc: the direct update handler is supposed not to be useful anymore [N. Barnes, O. Galibert] --- src/mame/includes/bbc.h | 2 -- src/mame/machine/bbc.cpp | 61 ------------------------------------------------ 2 files changed, 63 deletions(-) diff --git a/src/mame/includes/bbc.h b/src/mame/includes/bbc.h index 5969e4c7e4b..2899c8c88be 100644 --- a/src/mame/includes/bbc.h +++ b/src/mame/includes/bbc.h @@ -139,8 +139,6 @@ public: DECLARE_WRITE8_MEMBER(bbcm_wd1772l_write); DECLARE_WRITE8_MEMBER(bbc_videoULA_w); DECLARE_READ8_MEMBER(bbc_fe_r); - DECLARE_DIRECT_UPDATE_MEMBER(bbcbp_direct_handler); - DECLARE_DIRECT_UPDATE_MEMBER(bbcm_direct_handler); DECLARE_DRIVER_INIT(bbc); DECLARE_VIDEO_START(bbc); diff --git a/src/mame/machine/bbc.cpp b/src/mame/machine/bbc.cpp index 44cca181e29..24cbe1bfeaa 100644 --- a/src/mame/machine/bbc.cpp +++ b/src/mame/machine/bbc.cpp @@ -145,41 +145,6 @@ WRITE8_MEMBER(bbc_state::bbc_memorybp1_w) } -/* the next two function handle reads and write to the shadow video ram area - between 0x3000 and 0x7fff - - when vdusel is set high the video display uses the shadow ram memory - the processor only reads and write to the shadow ram when vdusel is set - and when the instruction being executed is stored in a set range of memory - addresses known as the VDU driver instructions. -*/ - - -DIRECT_UPDATE_MEMBER(bbc_state::bbcbp_direct_handler) -{ - uint8_t *RAM = m_region_maincpu->base(); - if (m_vdusel == 0) - { - // not in shadow ram mode so just read normal ram - m_bank2->set_base(RAM + 0x3000); - } - else - { - if (vdudriverset()) - { - // if VDUDriver set then read from shadow ram - m_bank2->set_base(RAM + 0xb000); - } - else - { - // else read from normal ram - m_bank2->set_base(RAM + 0x3000); - } - } - return address; -} - - WRITE8_MEMBER(bbc_state::bbc_memorybp2_w) { uint8_t *RAM = m_region_maincpu->base(); @@ -401,28 +366,6 @@ WRITE8_MEMBER(bbc_state::bbc_memorybm1_w) } -DIRECT_UPDATE_MEMBER(bbc_state::bbcm_direct_handler) -{ - if (m_ACCCON_X) - { - m_bank2->set_base(m_region_maincpu->base() + 0xb000); - } - else - { - if (m_ACCCON_E && bbcm_vdudriverset()) - { - m_bank2->set_base(m_region_maincpu->base() + 0xb000); - } - else - { - m_bank2->set_base(m_region_maincpu->base() + 0x3000); - } - } - - return address; -} - - WRITE8_MEMBER(bbc_state::bbc_memorybm2_w) { @@ -1788,8 +1731,6 @@ MACHINE_START_MEMBER(bbc_state, bbcbp) m_machinetype = BPLUS; m_mc6850_clock = 0; - m_maincpu->space(AS_PROGRAM).set_direct_update_handler(direct_update_delegate(&bbc_state::bbcbp_direct_handler, this)); - bbc_setup_banks(m_bank4, 16, 0, 0x3000); m_bank4->configure_entries(16, 1, m_region_maincpu->base() + 0x8000, 0x3000); // additional bank for paged ram bbc_setup_banks(m_bank6, 16, 0x3000, 0x1000); @@ -1816,8 +1757,6 @@ MACHINE_START_MEMBER(bbc_state, bbcm) m_machinetype = MASTER; m_mc6850_clock = 0; - m_maincpu->space(AS_PROGRAM).set_direct_update_handler(direct_update_delegate(&bbc_state::bbcm_direct_handler, this)); - bbcm_setup_banks(m_bank4, 16, 0, 0x1000); m_bank4->configure_entries(16, 1, m_region_maincpu->base() + 0x8000, 0x1000); // additional bank for paged ram bbcm_setup_banks(m_bank5, 16, 0x1000, 0x3000); -- cgit v1.2.3