From 5b1123c6e2090de7e17dc6220fd28d9099407689 Mon Sep 17 00:00:00 2001 From: Patrick Mackinlay Date: Sat, 18 May 2019 14:37:37 +0700 Subject: interpro_kbd: housekeeping (nw) --- src/devices/bus/interpro/keyboard/keyboard.h | 2 +- src/devices/bus/interpro/keyboard/lle.cpp | 8 ++++---- src/devices/bus/interpro/keyboard/lle.h | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/devices/bus/interpro/keyboard/keyboard.h b/src/devices/bus/interpro/keyboard/keyboard.h index 83347f17114..05c672a0ad7 100644 --- a/src/devices/bus/interpro/keyboard/keyboard.h +++ b/src/devices/bus/interpro/keyboard/keyboard.h @@ -46,7 +46,7 @@ class device_interpro_keyboard_port_interface : public device_slot_card_interfac public: // input lines - virtual DECLARE_WRITE_LINE_MEMBER(input_txd) { } + virtual DECLARE_WRITE_LINE_MEMBER(input_txd) = 0; DECLARE_WRITE_LINE_MEMBER(output_rxd) { m_port->m_rxd_handler(state); } protected: diff --git a/src/devices/bus/interpro/keyboard/lle.cpp b/src/devices/bus/interpro/keyboard/lle.cpp index dab60a49768..595130b4c74 100644 --- a/src/devices/bus/interpro/keyboard/lle.cpp +++ b/src/devices/bus/interpro/keyboard/lle.cpp @@ -465,7 +465,7 @@ void lle_device_base::device_start() void lle_device_base::device_reset() { - m_txd = 0; + m_txd = 1; } void lle_device_base::io_map(address_map &map) @@ -489,7 +489,7 @@ void lle_device_base::ext_map(address_map &map) READ_LINE_MEMBER(lle_device_base::t0_r) { - if ((VERBOSE & LOG_RXTX) && (m_mcu->pc() == 0x8e) && m_txd == 0) + if ((VERBOSE & LOG_RXTX) && (m_mcu->pc() == 0x8e) && m_txd) { auto const suppressor(machine().disable_side_effects()); @@ -499,7 +499,7 @@ READ_LINE_MEMBER(lle_device_base::t0_r) LOGMASKED(LOG_RXTX, "received byte 0x%02x\n", input); } - return m_txd; + return !m_txd; } READ_LINE_MEMBER(lle_device_base::t1_r) @@ -561,7 +561,7 @@ WRITE8_MEMBER(lle_device_base::p2_w) m_count++; // serial transmit - output_rxd(BIT(data, 5) ? CLEAR_LINE : ASSERT_LINE); + output_rxd(!BIT(data, 5)); // BIT(data, 4)? if (!BIT(m_p2, 4) && BIT(data, 4)) diff --git a/src/devices/bus/interpro/keyboard/lle.h b/src/devices/bus/interpro/keyboard/lle.h index d1e3d65f941..ef288bb0da6 100644 --- a/src/devices/bus/interpro/keyboard/lle.h +++ b/src/devices/bus/interpro/keyboard/lle.h @@ -30,7 +30,7 @@ protected: virtual void io_map(address_map &map); virtual void ext_map(address_map &map); - DECLARE_WRITE_LINE_MEMBER(input_txd) override { m_txd = (state == ASSERT_LINE) ? 0 : 1; } + DECLARE_WRITE_LINE_MEMBER(input_txd) override { m_txd = state; } DECLARE_READ_LINE_MEMBER(t0_r); DECLARE_READ_LINE_MEMBER(t1_r); -- cgit v1.2.3