From 5a2981950604164eb8a6ea10831df5caa62c6dd5 Mon Sep 17 00:00:00 2001 From: Robbbert Date: Sat, 2 Apr 2022 00:34:10 +1100 Subject: init vars for coverity (bus/a-l) --- src/devices/bus/a2bus/a2echoii.cpp | 6 +-- src/devices/bus/a2bus/a2hsscsi.h | 2 +- src/devices/bus/a2bus/a2iwm.h | 2 +- src/devices/bus/a2bus/a2mockingboard.cpp | 4 +- src/devices/bus/a2bus/a2sd.h | 2 +- src/devices/bus/a2bus/agat7langcard.h | 2 +- src/devices/bus/a2bus/agat7ports.h | 2 +- src/devices/bus/a2bus/agat840k_hle.h | 22 +++++----- src/devices/bus/a2bus/agat_fdc.h | 32 +++++++------- src/devices/bus/a2bus/computereyes2.cpp | 8 ++-- src/devices/bus/a2bus/pc_xporter.cpp | 36 ++++++++-------- src/devices/bus/a2bus/prodosromdrive.cpp | 2 +- src/devices/bus/a2bus/suprterminal.cpp | 2 +- src/devices/bus/a2bus/titan3plus2.h | 2 +- src/devices/bus/a2bus/transwarp.h | 6 +-- src/devices/bus/a2gameio/computereyes.cpp | 4 +- src/devices/bus/abcbus/db4106.h | 2 +- src/devices/bus/abcbus/db4107.h | 2 +- src/devices/bus/abcbus/db4112.h | 2 +- src/devices/bus/abcbus/unidisk.h | 2 +- src/devices/bus/acorn/system/cass.h | 6 +-- src/devices/bus/adb/a9m0330.h | 6 +-- src/devices/bus/adb/adbhle.h | 2 +- src/devices/bus/apricot/video/mono.h | 6 +-- src/devices/bus/astrocde/accessory.h | 2 +- src/devices/bus/astrocde/cassette.h | 10 ++--- src/devices/bus/ata/atapicdr.h | 2 +- src/devices/bus/ata/cr589.h | 6 +-- src/devices/bus/ata/idehd.h | 6 +-- src/devices/bus/bbc/1mhzbus/scsi.h | 4 +- src/devices/bus/bbc/fdc/acorn.h | 2 +- src/devices/bus/bbc/fdc/cumana.h | 4 +- src/devices/bus/bbc/internal/aries.h | 8 ++-- src/devices/bus/bbc/internal/atpl.h | 4 +- src/devices/bus/bbc/internal/overlay.h | 2 +- src/devices/bus/bbc/internal/peartree.h | 4 +- src/devices/bus/bbc/internal/raven20.h | 2 +- src/devices/bus/bbc/internal/romex.h | 2 +- src/devices/bus/bbc/internal/stl4m32.h | 6 +-- src/devices/bus/bbc/internal/stlswr.h | 4 +- src/devices/bus/bbc/internal/we32kram.h | 2 +- src/devices/bus/bbc/internal/werom.h | 2 +- src/devices/bus/bbc/internal/weromram.h | 4 +- src/devices/bus/bbc/modem/scsiaiv.h | 4 +- src/devices/bus/bbc/rom/slot.h | 4 +- src/devices/bus/bbc/tube/tube_rc6502.h | 8 ++-- src/devices/bus/bbc/userport/usersplit.h | 2 +- src/devices/bus/bml3/bml3mp1805.h | 2 +- src/devices/bus/bml3/bml3rtc.h | 4 +- src/devices/bus/c64/dela_ep256.h | 4 +- src/devices/bus/c64/dela_ep7x8.h | 2 +- src/devices/bus/c64/rex_ep256.h | 4 +- src/devices/bus/cbus/pc9801_118.h | 2 +- src/devices/bus/cbus/pc9801_26.h | 2 +- src/devices/bus/cbus/pc9801_86.h | 10 ++--- src/devices/bus/cbus/pc9801_amd98.h | 2 +- src/devices/bus/cbus/pc9801_snd.h | 4 +- src/devices/bus/centronics/epson_lx810l.h | 2 +- src/devices/bus/centronics/printer.h | 4 +- src/devices/bus/coco/coco_fdc.h | 6 +-- src/devices/bus/coco/coco_psg.h | 4 +- src/devices/bus/coco/coco_ssc.cpp | 12 +++--- src/devices/bus/compis/hrg.h | 2 +- src/devices/bus/compucolor/floppy.h | 2 +- src/devices/bus/electron/cart/peg400.h | 2 +- src/devices/bus/electron/cart/romp144.h | 4 +- src/devices/bus/gba/gba_slot.h | 4 +- src/devices/bus/gba/rom.h | 6 +-- src/devices/bus/gio64/gio64.h | 2 +- src/devices/bus/gio64/newport.h | 54 +++++++++++------------ src/devices/bus/hexbus/hexbus.h | 2 +- src/devices/bus/hexbus/hx5102.h | 8 ++-- src/devices/bus/hp80_io/82900.h | 4 +- src/devices/bus/hp9845_io/98032.h | 24 +++++------ src/devices/bus/hp9845_io/98035.h | 44 +++++++++---------- src/devices/bus/hp9845_io/hp9885.h | 48 ++++++++++----------- src/devices/bus/hp_dio/hp98550.h | 2 +- src/devices/bus/hp_dio/hp98603a.h | 2 +- src/devices/bus/hp_dio/hp98643.h | 4 +- src/devices/bus/hp_dio/hp_dio.h | 2 +- src/devices/bus/hp_hil/hp_hil.h | 2 +- src/devices/bus/ieee488/grid2102.h | 16 +++---- src/devices/bus/ieee488/remote488.h | 44 +++++++++---------- src/devices/bus/interpro/keyboard/lle.h | 12 +++--- src/devices/bus/interpro/sr/edge.h | 38 ++++++++-------- src/devices/bus/interpro/sr/gt.h | 68 ++++++++++++++--------------- src/devices/bus/intv_ctrl/ecs_ctrl.h | 2 +- src/devices/bus/isa/3c503.h | 26 +++++------ src/devices/bus/isa/chessmdr.h | 2 +- src/devices/bus/isa/chessmsr.h | 6 +-- src/devices/bus/isa/ega.h | 40 ++++++++--------- src/devices/bus/isa/eis_hgb107x.h | 10 ++--- src/devices/bus/isa/ex1280.h | 2 +- src/devices/bus/isa/fdc.h | 4 +- src/devices/bus/isa/finalchs.h | 2 +- src/devices/bus/isa/mach32.h | 26 +++++------ src/devices/bus/isa/mcd.h | 44 +++++++++---------- src/devices/bus/isa/myb3k_com.h | 4 +- src/devices/bus/isa/myb3k_fdc.h | 6 +-- src/devices/bus/isa/p1_sound.h | 4 +- src/devices/bus/isa/pgc.h | 6 +-- src/devices/bus/isa/s3virge.h | 72 +++++++++++++++---------------- src/devices/bus/isa/sblaster.h | 50 ++++++++++----------- src/devices/bus/isa/svga_s3.h | 6 +-- src/devices/bus/isa/trident.h | 56 ++++++++++++------------ src/devices/bus/isbx/isbc_218a.h | 2 +- src/devices/bus/lpci/i82439tx.h | 14 +++--- src/mame/drivers/s7.cpp | 1 + 108 files changed, 551 insertions(+), 550 deletions(-) diff --git a/src/devices/bus/a2bus/a2echoii.cpp b/src/devices/bus/a2bus/a2echoii.cpp index 604dc7ae1c6..1af618a1017 100644 --- a/src/devices/bus/a2bus/a2echoii.cpp +++ b/src/devices/bus/a2bus/a2echoii.cpp @@ -72,9 +72,9 @@ protected: private: //DECLARE_WRITE_LINE_MEMBER(tms_irq_callback); DECLARE_WRITE_LINE_MEMBER(tms_readyq_callback); - uint8_t m_writelatch_data; // 74ls373 latch - bool m_readlatch_flag; // 74c74 1st half - bool m_writelatch_flag; // 74c74 2nd half + uint8_t m_writelatch_data = 0; // 74ls373 latch + bool m_readlatch_flag = false; // 74c74 1st half + bool m_writelatch_flag = false; // 74c74 2nd half }; /*************************************************************************** diff --git a/src/devices/bus/a2bus/a2hsscsi.h b/src/devices/bus/a2bus/a2hsscsi.h index be200ccde0d..4a7e36c84aa 100644 --- a/src/devices/bus/a2bus/a2hsscsi.h +++ b/src/devices/bus/a2bus/a2hsscsi.h @@ -57,7 +57,7 @@ private: int m_rambank, m_rombank; uint8_t m_drq; uint8_t m_bank; - uint8_t m_dma_control; + uint8_t m_dma_control = 0; uint8_t m_c0ne, m_c0nf; uint16_t m_dma_addr, m_dma_size; }; diff --git a/src/devices/bus/a2bus/a2iwm.h b/src/devices/bus/a2bus/a2iwm.h index 3f0fe974d3a..69a738cfdbc 100644 --- a/src/devices/bus/a2bus/a2iwm.h +++ b/src/devices/bus/a2bus/a2iwm.h @@ -64,7 +64,7 @@ public: virtual uint8_t read_cnxx(uint8_t offset) override; private: - uint8_t *m_rom; + uint8_t *m_rom = nullptr; }; // device type definition diff --git a/src/devices/bus/a2bus/a2mockingboard.cpp b/src/devices/bus/a2bus/a2mockingboard.cpp index 0968d55c9a0..458e553d480 100644 --- a/src/devices/bus/a2bus/a2mockingboard.cpp +++ b/src/devices/bus/a2bus/a2mockingboard.cpp @@ -92,8 +92,8 @@ protected: private: DECLARE_WRITE_LINE_MEMBER(write_via1_cb2); - u8 m_portb1; - int m_last_cb2_state; + u8 m_portb1 = 0; + int m_last_cb2_state = 0; }; class a2bus_phasor_device : public a2bus_ayboard_device diff --git a/src/devices/bus/a2bus/a2sd.h b/src/devices/bus/a2bus/a2sd.h index 85165248319..1b675934bcc 100644 --- a/src/devices/bus/a2bus/a2sd.h +++ b/src/devices/bus/a2bus/a2sd.h @@ -58,7 +58,7 @@ private: int m_in_bit; int m_shift_count; - emu_timer *m_shift_timer; + emu_timer *m_shift_timer = nullptr; }; // device type definition diff --git a/src/devices/bus/a2bus/agat7langcard.h b/src/devices/bus/a2bus/agat7langcard.h index e7dae54ebfb..97729969260 100644 --- a/src/devices/bus/a2bus/agat7langcard.h +++ b/src/devices/bus/a2bus/agat7langcard.h @@ -49,7 +49,7 @@ private: int m_dxxx_bank; int m_main_bank; uint8_t m_ram[32 * 1024]; - uint8_t m_mode; + uint8_t m_mode = 0; uint8_t m_csr; }; diff --git a/src/devices/bus/a2bus/agat7ports.h b/src/devices/bus/a2bus/agat7ports.h index 2ee4f38b4dd..7d1a2e512fc 100644 --- a/src/devices/bus/a2bus/agat7ports.h +++ b/src/devices/bus/a2bus/agat7ports.h @@ -55,7 +55,7 @@ protected: DECLARE_WRITE_LINE_MEMBER(write_centronics_busy); private: - bool m_centronics_busy; + bool m_centronics_busy = false; }; // device type definition diff --git a/src/devices/bus/a2bus/agat840k_hle.h b/src/devices/bus/a2bus/agat840k_hle.h index f51bda3324f..c655f2c28d0 100644 --- a/src/devices/bus/a2bus/agat840k_hle.h +++ b/src/devices/bus/a2bus/agat840k_hle.h @@ -75,21 +75,21 @@ protected: required_device m_d15; private: - legacy_floppy_image_device *m_floppy; - bool m_side; + legacy_floppy_image_device *m_floppy = nullptr; + bool m_side = false; std::unique_ptr m_tracks[160]; - int m_count_read; - int m_count_write; - bool m_seen_magic; - int m_current_track; + int m_count_read = 0; + int m_count_write = 0; + bool m_seen_magic = false; + int m_current_track = 0; - u8 m_mxcs; - int m_unit; - int m_state; + u8 m_mxcs = 0; + int m_unit = 0; + int m_state = 0; - int m_seektime; - int m_waittime; + int m_seektime = 0; + int m_waittime = 0; emu_timer *m_timer_wait = nullptr; emu_timer *m_timer_seek = nullptr; diff --git a/src/devices/bus/a2bus/agat_fdc.h b/src/devices/bus/a2bus/agat_fdc.h index e209902c709..3bfc413c188 100644 --- a/src/devices/bus/a2bus/agat_fdc.h +++ b/src/devices/bus/a2bus/agat_fdc.h @@ -78,22 +78,22 @@ private: void lss_start(); void lss_sync(); - floppy_image_device *floppy; - int active, bits; - uint8_t data_reg; - uint16_t address; - uint64_t cycles; - - u8 m_mxcs; - int m_unit; - int m_state; - - int m_seektime; - int m_waittime; - - emu_timer *m_timer_lss; - emu_timer *m_timer_seek; - emu_timer *m_timer_motor; + floppy_image_device *floppy = nullptr; + int active = 0, bits = 0; + uint8_t data_reg = 0; + uint16_t address = 0; + uint64_t cycles = 0; + + u8 m_mxcs = 0; + int m_unit = 0; + int m_state = 0; + + int m_seektime = 0; + int m_waittime = 0; + + emu_timer *m_timer_lss = nullptr; + emu_timer *m_timer_seek = nullptr; + emu_timer *m_timer_motor = nullptr; uint8_t *m_rom; uint8_t *m_rom_d6; diff --git a/src/devices/bus/a2bus/computereyes2.cpp b/src/devices/bus/a2bus/computereyes2.cpp index 979472d00ef..c0d3acf99a4 100644 --- a/src/devices/bus/a2bus/computereyes2.cpp +++ b/src/devices/bus/a2bus/computereyes2.cpp @@ -43,10 +43,10 @@ protected: private: required_device m_picture; - int m_x, m_y, m_cer0, m_cer1, m_cer2; - u8 m_a2_bitmap[280*193]; - u8 m_threshold; - bool m_bActive; + int m_x = 0, m_y = 0, m_cer0 = 0, m_cer1 = 0, m_cer2 = 0; + u8 m_a2_bitmap[280*193]{}; + u8 m_threshold = 0; + bool m_bActive = false; }; /*************************************************************************** diff --git a/src/devices/bus/a2bus/pc_xporter.cpp b/src/devices/bus/a2bus/pc_xporter.cpp index 06a87cc1820..44733738da7 100644 --- a/src/devices/bus/a2bus/pc_xporter.cpp +++ b/src/devices/bus/a2bus/pc_xporter.cpp @@ -135,24 +135,24 @@ private: required_device m_isabus; optional_device m_pc_kbdc; - uint8_t m_u73_q2; - uint8_t m_out1; - int m_dma_channel; - uint8_t m_dma_offset[4]; - uint8_t m_pc_spkrdata; - uint8_t m_pit_out2; - bool m_cur_eop; - - uint8_t m_nmi_enabled; - - uint8_t m_ram[768*1024]; - uint8_t m_c800_ram[0x400]; - uint8_t m_regs[0x400]; - uint32_t m_offset; - address_space *m_pcmem_space, *m_pcio_space; - bool m_reset_during_halt; - - uint8_t m_6845_reg; + uint8_t m_u73_q2 = 0; + uint8_t m_out1 = 0; + int m_dma_channel = 0; + uint8_t m_dma_offset[4]{}; + uint8_t m_pc_spkrdata = 0; + uint8_t m_pit_out2 = 0; + bool m_cur_eop = false; + + uint8_t m_nmi_enabled = 0; + + uint8_t m_ram[768*1024]{}; + uint8_t m_c800_ram[0x400]{}; + uint8_t m_regs[0x400]{}; + uint32_t m_offset = 0; + address_space *m_pcmem_space = nullptr, *m_pcio_space = nullptr; + bool m_reset_during_halt = false; + + uint8_t m_6845_reg = 0; // interface to the keyboard DECLARE_WRITE_LINE_MEMBER( keyboard_clock_w ); diff --git a/src/devices/bus/a2bus/prodosromdrive.cpp b/src/devices/bus/a2bus/prodosromdrive.cpp index d9275384a00..f4d442b85a0 100644 --- a/src/devices/bus/a2bus/prodosromdrive.cpp +++ b/src/devices/bus/a2bus/prodosromdrive.cpp @@ -49,7 +49,7 @@ protected: private: required_region_ptr m_rom; - u16 m_latch; + u16 m_latch = 0; }; //************************************************************************** diff --git a/src/devices/bus/a2bus/suprterminal.cpp b/src/devices/bus/a2bus/suprterminal.cpp index 796937bebcb..e1d38179a58 100644 --- a/src/devices/bus/a2bus/suprterminal.cpp +++ b/src/devices/bus/a2bus/suprterminal.cpp @@ -74,7 +74,7 @@ private: std::unique_ptr m_vram; std::unique_ptr m_fontram; // u8 m_fontram[0x400]; - bool m_bRasterRAM, m_bCharBank1, m_bC800IsRAM; + bool m_bRasterRAM = false, m_bCharBank1 = false, m_bC800IsRAM = false; }; //------------------------------------------------- diff --git a/src/devices/bus/a2bus/titan3plus2.h b/src/devices/bus/a2bus/titan3plus2.h index f162f115d8e..7b67b4a87ef 100644 --- a/src/devices/bus/a2bus/titan3plus2.h +++ b/src/devices/bus/a2bus/titan3plus2.h @@ -55,7 +55,7 @@ private: u8 m_ram[128*1024]; bool m_enabled; - double m_joystick_x1_time, m_joystick_y1_time, m_joystick_x2_time, m_joystick_y2_time, m_x_calibration, m_y_calibration; + double m_joystick_x1_time = 0, m_joystick_y1_time = 0, m_joystick_x2_time = 0, m_joystick_y2_time = 0, m_x_calibration = 0, m_y_calibration = 0; }; // device type definition diff --git a/src/devices/bus/a2bus/transwarp.h b/src/devices/bus/a2bus/transwarp.h index 1401f61776b..f2b089b1b0b 100644 --- a/src/devices/bus/a2bus/transwarp.h +++ b/src/devices/bus/a2bus/transwarp.h @@ -41,9 +41,9 @@ protected: private: bool m_bEnabled; - bool m_bReadA2ROM; - bool m_bIn1MHzMode; - emu_timer *m_timer; + bool m_bReadA2ROM = false; + bool m_bIn1MHzMode = false; + emu_timer *m_timer = nullptr; required_device m_ourcpu; required_region_ptr m_rom; diff --git a/src/devices/bus/a2gameio/computereyes.cpp b/src/devices/bus/a2gameio/computereyes.cpp index 38b100586e4..2130e0b66de 100644 --- a/src/devices/bus/a2gameio/computereyes.cpp +++ b/src/devices/bus/a2gameio/computereyes.cpp @@ -40,8 +40,8 @@ protected: private: required_device m_picture; - int m_x, m_y, m_an1, m_an2, m_an3, m_level; - u8 m_a2_bitmap[280*192]; + int m_x = 0, m_y = 0, m_an1 = 0, m_an2 = 0, m_an3 = 0, m_level = 0; + u8 m_a2_bitmap[280*192]{}; }; //************************************************************************** diff --git a/src/devices/bus/abcbus/db4106.h b/src/devices/bus/abcbus/db4106.h index 74e49631dbe..1ae560915a4 100644 --- a/src/devices/bus/abcbus/db4106.h +++ b/src/devices/bus/abcbus/db4106.h @@ -50,7 +50,7 @@ protected: private: required_device m_maincpu; - bool m_cs; + bool m_cs = false; void databoard_4106_io(address_map &map); void databoard_4106_mem(address_map &map); diff --git a/src/devices/bus/abcbus/db4107.h b/src/devices/bus/abcbus/db4107.h index 4ae301084ca..20c381e7d53 100644 --- a/src/devices/bus/abcbus/db4107.h +++ b/src/devices/bus/abcbus/db4107.h @@ -52,7 +52,7 @@ private: required_device m_maincpu; required_device m_dma; - bool m_cs; + bool m_cs = false; void databoard_4107_io(address_map &map); void databoard_4107_mem(address_map &map); diff --git a/src/devices/bus/abcbus/db4112.h b/src/devices/bus/abcbus/db4112.h index c28da004297..fecb82a7a14 100644 --- a/src/devices/bus/abcbus/db4112.h +++ b/src/devices/bus/abcbus/db4112.h @@ -50,7 +50,7 @@ protected: private: required_device m_maincpu; - bool m_cs; + bool m_cs = false; void databoard_4112_io(address_map &map); void databoard_4112_mem(address_map &map); diff --git a/src/devices/bus/abcbus/unidisk.h b/src/devices/bus/abcbus/unidisk.h index 6d95e34208e..3f8f96c36ae 100644 --- a/src/devices/bus/abcbus/unidisk.h +++ b/src/devices/bus/abcbus/unidisk.h @@ -50,7 +50,7 @@ protected: private: required_device m_maincpu; - bool m_cs; + bool m_cs = false; void unidisk_io(address_map &map); void unidisk_mem(address_map &map); diff --git a/src/devices/bus/acorn/system/cass.h b/src/devices/bus/acorn/system/cass.h index 02a323bb994..942dab48e23 100644 --- a/src/devices/bus/acorn/system/cass.h +++ b/src/devices/bus/acorn/system/cass.h @@ -44,9 +44,9 @@ private: required_device m_cass; - uint8_t m_cass_data[4]; - bool m_cass_state; - bool m_cassold; + uint8_t m_cass_data[4]{}; + bool m_cass_state = false; + bool m_cassold = false; }; diff --git a/src/devices/bus/adb/a9m0330.h b/src/devices/bus/adb/a9m0330.h index 1d44a28bba8..a8c334ebc17 100644 --- a/src/devices/bus/adb/a9m0330.h +++ b/src/devices/bus/adb/a9m0330.h @@ -38,9 +38,9 @@ private: DECLARE_READ_LINE_MEMBER(t0_r); DECLARE_READ_LINE_MEMBER(t1_r); - int m_adb_state; - int m_kbd_row; - int m_our_last_adb_state; + int m_adb_state = 0; + int m_kbd_row = 0; + int m_our_last_adb_state = 0; }; DECLARE_DEVICE_TYPE(ADB_A9M0330, a9m0330_device) diff --git a/src/devices/bus/adb/adbhle.h b/src/devices/bus/adb/adbhle.h index 24dff3ad2fe..2cd722b1975 100644 --- a/src/devices/bus/adb/adbhle.h +++ b/src/devices/bus/adb/adbhle.h @@ -24,7 +24,7 @@ protected: virtual void adb_w(int state) override; private: - bool m_last_state; + bool m_last_state = false; attotime m_last_state_time; }; diff --git a/src/devices/bus/apricot/video/mono.h b/src/devices/bus/apricot/video/mono.h index 36885bcb768..29baa17c453 100644 --- a/src/devices/bus/apricot/video/mono.h +++ b/src/devices/bus/apricot/video/mono.h @@ -54,9 +54,9 @@ private: std::unique_ptr m_vram; - uint8_t m_portb; - uint8_t m_portc; - uint8_t m_portx; + uint8_t m_portb = 0; + uint8_t m_portc = 0; + uint8_t m_portx = 0; }; // device type definition diff --git a/src/devices/bus/astrocde/accessory.h b/src/devices/bus/astrocde/accessory.h index 5386cd1362a..ce72cf9d24d 100644 --- a/src/devices/bus/astrocde/accessory.h +++ b/src/devices/bus/astrocde/accessory.h @@ -73,7 +73,7 @@ protected: virtual void interface_pre_start() override; void set_screen(screen_device *screen) { m_screen = screen; } - screen_device *m_screen; + screen_device *m_screen = nullptr; private: astrocade_accessory_port_device *const m_port; diff --git a/src/devices/bus/astrocde/cassette.h b/src/devices/bus/astrocde/cassette.h index d36e8a1bfd7..06a116fe18a 100644 --- a/src/devices/bus/astrocde/cassette.h +++ b/src/devices/bus/astrocde/cassette.h @@ -43,11 +43,11 @@ protected: private: required_device m_cassette; - double m_cass_wave; - double m_cass_delta; - uint32_t m_cass_wave_ticks; - uint32_t m_cass_cycles; - bool m_cass_mark; + double m_cass_wave = 0; + double m_cass_delta = 0; + uint32_t m_cass_wave_ticks = 0; + uint32_t m_cass_cycles = 0; + bool m_cass_mark = false; std::queue m_cass_data; }; diff --git a/src/devices/bus/ata/atapicdr.h b/src/devices/bus/ata/atapicdr.h index c2ffbb92fee..5a164da35cc 100644 --- a/src/devices/bus/ata/atapicdr.h +++ b/src/devices/bus/ata/atapicdr.h @@ -37,7 +37,7 @@ protected: virtual void identify_packet_device() override; virtual void process_buffer() override; virtual void ExecCommand() override; - bool m_media_change; + bool m_media_change = false; uint16_t ultra_dma_mode; }; diff --git a/src/devices/bus/ata/cr589.h b/src/devices/bus/ata/cr589.h index 9b2f89d172c..9c1f629cd8f 100644 --- a/src/devices/bus/ata/cr589.h +++ b/src/devices/bus/ata/cr589.h @@ -38,9 +38,9 @@ protected: virtual bool nvram_write(util::write_stream &file) override; private: - int download; - uint8_t buffer[ 65536 ]; - int bufferOffset; + int download = 0; + uint8_t buffer[ 65536 ]{}; + int bufferOffset = 0; }; // device type definition diff --git a/src/devices/bus/ata/idehd.h b/src/devices/bus/ata/idehd.h index 4eb0edd3671..23ca61b8b7a 100644 --- a/src/devices/bus/ata/idehd.h +++ b/src/devices/bus/ata/idehd.h @@ -106,8 +106,8 @@ protected: virtual int write_sector(uint32_t lba, const void *buffer) override { return !m_disk ? 0 : m_disk->write(lba, buffer); } virtual uint8_t calculate_status() override; - chd_file *m_handle; - hard_disk_file *m_disk; + chd_file *m_handle = nullptr; + hard_disk_file *m_disk = nullptr; enum { @@ -117,7 +117,7 @@ protected: private: required_device m_image; - emu_timer * m_last_status_timer; + emu_timer * m_last_status_timer = nullptr; }; // device type definition diff --git a/src/devices/bus/bbc/1mhzbus/scsi.h b/src/devices/bus/bbc/1mhzbus/scsi.h index 8a4dabbe113..57f2dc432f8 100644 --- a/src/devices/bus/bbc/1mhzbus/scsi.h +++ b/src/devices/bus/bbc/1mhzbus/scsi.h @@ -44,8 +44,8 @@ protected: private: required_device m_scsi; - int m_irq_enable; - int m_irq_state; + int m_irq_enable = 0; + int m_irq_state = 0; }; diff --git a/src/devices/bus/bbc/fdc/acorn.h b/src/devices/bus/bbc/fdc/acorn.h index 347368ff29f..6bb0e335b57 100644 --- a/src/devices/bus/bbc/fdc/acorn.h +++ b/src/devices/bus/bbc/fdc/acorn.h @@ -79,7 +79,7 @@ private: required_device m_fdc; required_device_array m_floppy; - int m_fdc_ie; + int m_fdc_ie = 0; }; diff --git a/src/devices/bus/bbc/fdc/cumana.h b/src/devices/bus/bbc/fdc/cumana.h index d775a68e622..83ad6ca453e 100644 --- a/src/devices/bus/bbc/fdc/cumana.h +++ b/src/devices/bus/bbc/fdc/cumana.h @@ -45,11 +45,11 @@ protected: required_device m_fdc; required_device_array m_floppy; - bool m_invert; + bool m_invert = false; private: int m_drive_control; - int m_fdc_ie; + int m_fdc_ie = 0; }; class bbc_cumana1_device : public bbc_cumanafdc_device diff --git a/src/devices/bus/bbc/internal/aries.h b/src/devices/bus/bbc/internal/aries.h index 9dc7383ff21..6bae19cde89 100644 --- a/src/devices/bus/bbc/internal/aries.h +++ b/src/devices/bus/bbc/internal/aries.h @@ -48,7 +48,7 @@ protected: optional_device_array m_rom; - uint8_t m_romsel; + uint8_t m_romsel = 0; }; @@ -73,7 +73,7 @@ protected: private: void control_w(offs_t offset, uint8_t data); - bool m_shadow; + bool m_shadow = false; std::unique_ptr m_ram; }; @@ -102,9 +102,9 @@ protected: private: required_memory_region m_aries_rom; - bool m_shadow; + bool m_shadow = false; std::unique_ptr m_ram; - uint8_t m_ramsel; + uint8_t m_ramsel = 0; }; diff --git a/src/devices/bus/bbc/internal/atpl.h b/src/devices/bus/bbc/internal/atpl.h index fe10ebb3a76..0c0ebade65e 100644 --- a/src/devices/bus/bbc/internal/atpl.h +++ b/src/devices/bus/bbc/internal/atpl.h @@ -46,7 +46,7 @@ private: optional_device_array m_rom; required_ioport m_wp; - uint8_t m_romsel; + uint8_t m_romsel = 0; }; @@ -73,7 +73,7 @@ protected: private: optional_device_array m_rom; - uint8_t m_romsel; + uint8_t m_romsel = 0; }; diff --git a/src/devices/bus/bbc/internal/overlay.h b/src/devices/bus/bbc/internal/overlay.h index 3800687f5ac..9c667321ba3 100644 --- a/src/devices/bus/bbc/internal/overlay.h +++ b/src/devices/bus/bbc/internal/overlay.h @@ -46,7 +46,7 @@ private: required_device_array m_rom; required_ioport_array<3> m_link_rom; - uint8_t m_romsel; + uint8_t m_romsel = 0; }; diff --git a/src/devices/bus/bbc/internal/peartree.h b/src/devices/bus/bbc/internal/peartree.h index 9f9ed683396..4ba6573e9ab 100644 --- a/src/devices/bus/bbc/internal/peartree.h +++ b/src/devices/bus/bbc/internal/peartree.h @@ -43,7 +43,7 @@ protected: virtual uint8_t paged_r(offs_t offset) override; virtual void paged_w(offs_t offset, uint8_t data) override; - uint8_t m_romsel; + uint8_t m_romsel = 0; }; @@ -90,7 +90,7 @@ protected: virtual uint8_t paged_r(offs_t offset) override; virtual void paged_w(offs_t offset, uint8_t data) override; - uint8_t m_romsel; + uint8_t m_romsel = 0; }; diff --git a/src/devices/bus/bbc/internal/raven20.h b/src/devices/bus/bbc/internal/raven20.h index 0e04137afa6..e716d617554 100644 --- a/src/devices/bus/bbc/internal/raven20.h +++ b/src/devices/bus/bbc/internal/raven20.h @@ -40,7 +40,7 @@ private: void enable_w(offs_t offset, uint8_t data); void disable_w(offs_t offset, uint8_t data); - bool m_shadow; + bool m_shadow = false; std::unique_ptr m_ram; }; diff --git a/src/devices/bus/bbc/internal/romex.h b/src/devices/bus/bbc/internal/romex.h index b9542937ebf..59931349be7 100644 --- a/src/devices/bus/bbc/internal/romex.h +++ b/src/devices/bus/bbc/internal/romex.h @@ -42,7 +42,7 @@ protected: private: optional_device_array m_rom; - uint8_t m_romsel; + uint8_t m_romsel = 0; }; diff --git a/src/devices/bus/bbc/internal/stl4m32.h b/src/devices/bus/bbc/internal/stl4m32.h index ac939d6d4ff..5ba7a2e38ee 100644 --- a/src/devices/bus/bbc/internal/stl4m32.h +++ b/src/devices/bus/bbc/internal/stl4m32.h @@ -54,9 +54,9 @@ protected: std::unique_ptr m_ram; - uint8_t m_romsel; - uint8_t m_ramsel; - uint8_t m_shadow; + uint8_t m_romsel = 0; + uint8_t m_ramsel = 0; + uint8_t m_shadow = 0; }; diff --git a/src/devices/bus/bbc/internal/stlswr.h b/src/devices/bus/bbc/internal/stlswr.h index db7e263ce28..b0779723412 100644 --- a/src/devices/bus/bbc/internal/stlswr.h +++ b/src/devices/bus/bbc/internal/stlswr.h @@ -44,8 +44,8 @@ protected: optional_device_array m_rom; - uint8_t m_romsel; - uint8_t m_ramsel; + uint8_t m_romsel = 0; + uint8_t m_ramsel = 0; }; diff --git a/src/devices/bus/bbc/internal/we32kram.h b/src/devices/bus/bbc/internal/we32kram.h index aa10005292b..65beb897ed5 100644 --- a/src/devices/bus/bbc/internal/we32kram.h +++ b/src/devices/bus/bbc/internal/we32kram.h @@ -42,7 +42,7 @@ protected: private: void control_w(offs_t offset, uint8_t data); - uint8_t m_shadow; + uint8_t m_shadow = 0; std::unique_ptr m_ram; }; diff --git a/src/devices/bus/bbc/internal/werom.h b/src/devices/bus/bbc/internal/werom.h index 4e95ba120d8..12c7e51febe 100644 --- a/src/devices/bus/bbc/internal/werom.h +++ b/src/devices/bus/bbc/internal/werom.h @@ -37,7 +37,7 @@ protected: virtual bool overrides_rom() override { return true; } virtual void romsel_w(offs_t offset, uint8_t data) override { m_romsel = data & 0x0f; } - uint8_t m_romsel; + uint8_t m_romsel = 0; }; diff --git a/src/devices/bus/bbc/internal/weromram.h b/src/devices/bus/bbc/internal/weromram.h index b85c9d031ab..657eb712d62 100644 --- a/src/devices/bus/bbc/internal/weromram.h +++ b/src/devices/bus/bbc/internal/weromram.h @@ -44,8 +44,8 @@ private: void ramsel_w(offs_t offset, uint8_t data); - uint8_t m_romsel; - uint8_t m_ramsel; + uint8_t m_romsel = 0; + uint8_t m_ramsel = 0; }; diff --git a/src/devices/bus/bbc/modem/scsiaiv.h b/src/devices/bus/bbc/modem/scsiaiv.h index 0b244bb71e3..c28a9578677 100644 --- a/src/devices/bus/bbc/modem/scsiaiv.h +++ b/src/devices/bus/bbc/modem/scsiaiv.h @@ -44,8 +44,8 @@ protected: private: required_device m_scsi; - int m_irq_enable; - int m_irq_state; + int m_irq_enable = 0; + int m_irq_state = 0; }; diff --git a/src/devices/bus/bbc/rom/slot.h b/src/devices/bus/bbc/rom/slot.h index 986d796dd0d..6565b2799eb 100644 --- a/src/devices/bus/bbc/rom/slot.h +++ b/src/devices/bus/bbc/rom/slot.h @@ -58,7 +58,7 @@ protected: // device-level overrides virtual void device_start() override; - uint32_t m_slot_size; + uint32_t m_slot_size = 0; private: device_bbc_rom_interface* m_cart; @@ -136,7 +136,7 @@ public: protected: device_bbc_rom_interface(const machine_config &mconfig, device_t &device); - bbc_romslot_device *m_slot; + bbc_romslot_device *m_slot = nullptr; private: // internal state diff --git a/src/devices/bus/bbc/tube/tube_rc6502.h b/src/devices/bus/bbc/tube/tube_rc6502.h index 5636e8694ef..89e2949894f 100644 --- a/src/devices/bus/bbc/tube/tube_rc6502.h +++ b/src/devices/bus/bbc/tube/tube_rc6502.h @@ -66,10 +66,10 @@ protected: private: void tube_rc6502_mem(address_map &map); - uint8_t m_default; - uint8_t m_divider; - uint8_t m_banking; - uint8_t m_banknum; + uint8_t m_default = 0; + uint8_t m_divider = 0; + uint8_t m_banking = 0; + uint8_t m_banknum = 0; }; diff --git a/src/devices/bus/bbc/userport/usersplit.h b/src/devices/bus/bbc/userport/usersplit.h index 27ce11a9fde..c1da2da51f0 100644 --- a/src/devices/bus/bbc/userport/usersplit.h +++ b/src/devices/bus/bbc/userport/usersplit.h @@ -50,7 +50,7 @@ private: DECLARE_WRITE_LINE_MEMBER(cb2b_w); required_device_array m_userport; - uint8_t m_selected; + uint8_t m_selected = 0; }; diff --git a/src/devices/bus/bml3/bml3mp1805.h b/src/devices/bus/bml3/bml3mp1805.h index f3c4de448d3..81709579e3a 100644 --- a/src/devices/bus/bml3/bml3mp1805.h +++ b/src/devices/bus/bml3/bml3mp1805.h @@ -47,7 +47,7 @@ protected: private: uint8_t *m_rom; - uint8_t m_control; + uint8_t m_control = 0; static void floppy_drives(device_slot_interface &device); }; diff --git a/src/devices/bus/bml3/bml3rtc.h b/src/devices/bus/bml3/bml3rtc.h index 16c6cbd0e9c..19f416bec27 100644 --- a/src/devices/bus/bml3/bml3rtc.h +++ b/src/devices/bus/bml3/bml3rtc.h @@ -42,8 +42,8 @@ protected: private: required_device m_rtc; - uint8_t m_addr_latch; - uint8_t m_data_latch; + uint8_t m_addr_latch = 0; + uint8_t m_data_latch = 0; }; // device type definition diff --git a/src/devices/bus/c64/dela_ep256.h b/src/devices/bus/c64/dela_ep256.h index bb6806f4d8e..a412e903033 100644 --- a/src/devices/bus/c64/dela_ep256.h +++ b/src/devices/bus/c64/dela_ep256.h @@ -46,8 +46,8 @@ protected: private: required_device_array m_eproms; - uint8_t m_bank, m_socket; - int m_reset; + uint8_t m_bank = 0, m_socket = 0; + int m_reset = 0; }; diff --git a/src/devices/bus/c64/dela_ep7x8.h b/src/devices/bus/c64/dela_ep7x8.h index 50e1b3af01e..f39340a43a0 100644 --- a/src/devices/bus/c64/dela_ep7x8.h +++ b/src/devices/bus/c64/dela_ep7x8.h @@ -46,7 +46,7 @@ protected: private: required_device_array m_eprom; - uint8_t m_bank; + uint8_t m_bank = 0; }; diff --git a/src/devices/bus/c64/rex_ep256.h b/src/devices/bus/c64/rex_ep256.h index e06a2c71d17..25198bd9ee1 100644 --- a/src/devices/bus/c64/rex_ep256.h +++ b/src/devices/bus/c64/rex_ep256.h @@ -46,8 +46,8 @@ protected: private: required_device_array m_eproms; - uint8_t m_bank, m_socket; - int m_reset; + uint8_t m_bank = 0, m_socket = 0; + int m_reset = 0; }; diff --git a/src/devices/bus/cbus/pc9801_118.h b/src/devices/bus/cbus/pc9801_118.h index 94ac3bfe24c..dace4e9496e 100644 --- a/src/devices/bus/cbus/pc9801_118.h +++ b/src/devices/bus/cbus/pc9801_118.h @@ -50,7 +50,7 @@ private: required_device m_bus; required_device m_opn3; - uint8_t m_ext_reg; + uint8_t m_ext_reg = 0; DECLARE_WRITE_LINE_MEMBER(sound_irq); }; diff --git a/src/devices/bus/cbus/pc9801_26.h b/src/devices/bus/cbus/pc9801_26.h index 80cd57a20cd..a7681395e3b 100644 --- a/src/devices/bus/cbus/pc9801_26.h +++ b/src/devices/bus/cbus/pc9801_26.h @@ -46,7 +46,7 @@ private: required_device m_opn; DECLARE_WRITE_LINE_MEMBER(sound_irq); - u32 m_rom_base; + u32 m_rom_base = 0; }; diff --git a/src/devices/bus/cbus/pc9801_86.h b/src/devices/bus/cbus/pc9801_86.h index 858a1193c75..f3b6a2516ae 100644 --- a/src/devices/bus/cbus/pc9801_86.h +++ b/src/devices/bus/cbus/pc9801_86.h @@ -57,19 +57,19 @@ protected: u8 pcm_r(offs_t offset); void pcm_w(offs_t offset, u8 data); - u8 m_mask; + u8 m_mask = 0; private: int queue_count(); u8 queue_pop(); - u8 m_pcm_mode, m_vol[7], m_pcm_ctrl, m_pcm_mute; - uint16_t m_head, m_tail, m_count, m_irq_rate; - bool m_pcmirq, m_fmirq, m_pcm_clk, m_init; + u8 m_pcm_mode = 0, m_vol[7]{}, m_pcm_ctrl = 0, m_pcm_mute = 0; + uint16_t m_head = 0, m_tail = 0, m_count = 0, m_irq_rate = 0; + bool m_pcmirq = 0, m_fmirq = 0, m_pcm_clk = 0, m_init = 0; required_device m_ldac; required_device m_rdac; std::vector m_queue; - emu_timer *m_dac_timer; + emu_timer *m_dac_timer = nullptr; }; class pc9801_speakboard_device : public pc9801_86_device diff --git a/src/devices/bus/cbus/pc9801_amd98.h b/src/devices/bus/cbus/pc9801_amd98.h index f26246c768b..3a8e407bd0d 100644 --- a/src/devices/bus/cbus/pc9801_amd98.h +++ b/src/devices/bus/cbus/pc9801_amd98.h @@ -44,7 +44,7 @@ private: void ay3_address_w(uint8_t data); void ay3_data_latch_w(uint8_t data); - uint8_t m_ay3_latch; + uint8_t m_ay3_latch = 0; required_device m_bus; required_device m_ay1; diff --git a/src/devices/bus/cbus/pc9801_snd.h b/src/devices/bus/cbus/pc9801_snd.h index 0c9c694a4e3..5c431831eb5 100644 --- a/src/devices/bus/cbus/pc9801_snd.h +++ b/src/devices/bus/cbus/pc9801_snd.h @@ -20,11 +20,11 @@ public: protected: u8 opn_porta_r(); void opn_portb_w(u8 data); - u16 m_io_base; + u16 m_io_base = 0; virtual u16 read_io_base() = 0; private: - u8 m_joy_sel; + u8 m_joy_sel = 0; }; //DECLARE_DEVICE_TYPE(PC9801_SND, pc9801_snd_device) diff --git a/src/devices/bus/centronics/epson_lx810l.h b/src/devices/bus/centronics/epson_lx810l.h index 82ec40cc1c2..4f69711736d 100644 --- a/src/devices/bus/centronics/epson_lx810l.h +++ b/src/devices/bus/centronics/epson_lx810l.h @@ -142,7 +142,7 @@ private: TIMER_CR }; - emu_timer *m_cr_timer; + emu_timer *m_cr_timer = nullptr; }; // ======================> epson_ap2000_t diff --git a/src/devices/bus/centronics/printer.h b/src/devices/bus/centronics/printer.h index 7d2e1623ae9..1d2f1ca4927 100644 --- a/src/devices/bus/centronics/printer.h +++ b/src/devices/bus/centronics/printer.h @@ -45,8 +45,8 @@ private: TIMER_BUSY }; - emu_timer *m_ack_timer; - emu_timer *m_busy_timer; + emu_timer *m_ack_timer = nullptr; + emu_timer *m_busy_timer = nullptr; int m_strobe; uint8_t m_data; diff --git a/src/devices/bus/coco/coco_fdc.h b/src/devices/bus/coco/coco_fdc.h index 786d30c2f68..ccf3dcd522c 100644 --- a/src/devices/bus/coco/coco_fdc.h +++ b/src/devices/bus/coco/coco_fdc.h @@ -56,9 +56,9 @@ protected: private: // registers - u8 m_dskreg; - bool m_intrq; - bool m_drq; + u8 m_dskreg = 0; + bool m_intrq = false; + bool m_drq = false; }; // device type definitions - CoCo FDC diff --git a/src/devices/bus/coco/coco_psg.h b/src/devices/bus/coco/coco_psg.h index 34c344c26e7..a0aa73a819c 100644 --- a/src/devices/bus/coco/coco_psg.h +++ b/src/devices/bus/coco/coco_psg.h @@ -47,8 +47,8 @@ private: void flash5555_w(offs_t offset, u8 data); std::unique_ptr m_sram; - u8 m_bank[2]; - u8 m_control; + u8 m_bank[2]{}; + u8 m_control = 0; }; diff --git a/src/devices/bus/coco/coco_ssc.cpp b/src/devices/bus/coco/coco_ssc.cpp index 7c8d497a224..94a946cb82e 100644 --- a/src/devices/bus/coco/coco_ssc.cpp +++ b/src/devices/bus/coco/coco_ssc.cpp @@ -107,12 +107,12 @@ namespace virtual void set_sound_enable(bool sound_enable) override; private: - u8 m_reset_line; - bool m_tms7000_busy; - u8 m_tms7000_porta; - u8 m_tms7000_portb; - u8 m_tms7000_portc; - u8 m_tms7000_portd; + u8 m_reset_line = 0; + bool m_tms7000_busy = false; + u8 m_tms7000_porta = 0; + u8 m_tms7000_portb = 0; + u8 m_tms7000_portc = 0; + u8 m_tms7000_portd = 0; required_device m_tms7040; required_device m_staticram; required_device m_ay; diff --git a/src/devices/bus/compis/hrg.h b/src/devices/bus/compis/hrg.h index 98ef784df14..28c781416a2 100644 --- a/src/devices/bus/compis/hrg.h +++ b/src/devices/bus/compis/hrg.h @@ -48,7 +48,7 @@ protected: required_device m_palette; required_shared_ptr m_video_ram; - uint8_t m_unk_video; + uint8_t m_unk_video = 0; private: UPD7220_DISPLAY_PIXELS_MEMBER( display_pixels ); diff --git a/src/devices/bus/compucolor/floppy.h b/src/devices/bus/compucolor/floppy.h index 8342a3668ed..b3237661aa5 100644 --- a/src/devices/bus/compucolor/floppy.h +++ b/src/devices/bus/compucolor/floppy.h @@ -104,7 +104,7 @@ private: compucolor_floppy_port_device *m_owner; - emu_timer *m_timer; + emu_timer *m_timer = nullptr; }; diff --git a/src/devices/bus/electron/cart/peg400.h b/src/devices/bus/electron/cart/peg400.h index 141cc1fe02f..89e7034f339 100644 --- a/src/devices/bus/electron/cart/peg400.h +++ b/src/devices/bus/electron/cart/peg400.h @@ -46,7 +46,7 @@ private: required_device m_floppy0; required_device m_floppy1; - int m_fdc_ie; + int m_fdc_ie = 0; }; diff --git a/src/devices/bus/electron/cart/romp144.h b/src/devices/bus/electron/cart/romp144.h index 45916a3ab38..5eed4caa375 100644 --- a/src/devices/bus/electron/cart/romp144.h +++ b/src/devices/bus/electron/cart/romp144.h @@ -48,8 +48,8 @@ private: required_device_array m_romslot; - uint8_t m_rom_select; - uint8_t m_rom_latch; + uint8_t m_rom_select = 0; + uint8_t m_rom_latch = 0; }; diff --git a/src/devices/bus/gba/gba_slot.h b/src/devices/bus/gba/gba_slot.h index 70fad8e4581..115082a5b8d 100644 --- a/src/devices/bus/gba/gba_slot.h +++ b/src/devices/bus/gba/gba_slot.h @@ -70,8 +70,8 @@ protected: // internal state uint32_t *m_rom; // this points to the cart rom region uint32_t m_rom_size; // this is the actual game size, not the rom region size! - uint32_t *m_romhlp; - uint32_t m_romhlp_size; + uint32_t *m_romhlp = nullptr; + uint32_t m_romhlp_size = 0; std::vector m_nvram; }; diff --git a/src/devices/bus/gba/rom.h b/src/devices/bus/gba/rom.h index 3a1ac4005a1..c5272cc0e5f 100644 --- a/src/devices/bus/gba/rom.h +++ b/src/devices/bus/gba/rom.h @@ -107,8 +107,8 @@ protected: virtual void device_reset() override; private: - uint16_t m_gpio_regs[4]; - uint8_t m_gpio_write_only, m_gpio_dirs; + uint16_t m_gpio_regs[4]{}; + uint8_t m_gpio_write_only = 0, m_gpio_dirs = 0; }; @@ -380,7 +380,7 @@ protected: virtual void device_reset() override; private: - uint32_t m_src, m_dst, m_nblock; + uint32_t m_src = 0, m_dst = 0, m_nblock = 0; }; diff --git a/src/devices/bus/gio64/gio64.h b/src/devices/bus/gio64/gio64.h index df99dc70dd9..48592c7eef4 100644 --- a/src/devices/bus/gio64/gio64.h +++ b/src/devices/bus/gio64/gio64.h @@ -120,7 +120,7 @@ protected: virtual void device_start() override; // internal state - device_gio64_card_interface *m_device_list[3]; + device_gio64_card_interface *m_device_list[3]{}; private: devcb_write_line::array<3> m_interrupt_cb; diff --git a/src/devices/bus/gio64/newport.h b/src/devices/bus/gio64/newport.h index 3dd1a27ba40..78b940310a0 100644 --- a/src/devices/bus/gio64/newport.h +++ b/src/devices/bus/gio64/newport.h @@ -56,14 +56,14 @@ private: // Initializers void set_revision(uint32_t revision) { m_revision = revision; } - uint32_t m_config; - uint32_t m_revision; - uint32_t m_fifo_available; - //uint32_t m_entries; - uint32_t m_cursor_cmap; - uint32_t m_popup_cmap; - uint32_t m_mode_table_idx; - uint32_t m_mode_table[0x20]; + uint32_t m_config = 0; + uint32_t m_revision = 0; + uint32_t m_fifo_available = 0; + //uint32_t m_entries = 0; + uint32_t m_cursor_cmap = 0; + uint32_t m_popup_cmap = 0; + uint32_t m_mode_table_idx = 0; + uint32_t m_mode_table[0x20]{}; }; DECLARE_DEVICE_TYPE(XMAP9, xmap9_device) @@ -107,10 +107,10 @@ private: // Initializers void set_revision(uint32_t revision) { m_revision = revision; } - uint32_t m_status; - uint32_t m_revision; - uint16_t m_palette_idx; - uint32_t m_palette[0x10000]; + uint32_t m_status = 0; + uint32_t m_revision = 0; + uint16_t m_palette_idx = 0; + uint32_t m_palette[0x10000]{}; }; DECLARE_DEVICE_TYPE(CMAP, cmap_device) @@ -255,21 +255,21 @@ private: void set_global_mask(uint32_t global_mask) { m_global_mask = global_mask; } - uint32_t m_global_mask; - uint32_t m_write_mask; - bool m_blend; - bool m_fast_clear; - bool m_rgbmode; - bool m_dblsrc; - uint8_t m_plane_enable; - uint8_t m_draw_depth; - uint32_t m_draw_bpp; - uint8_t m_logicop; - uint8_t m_src_shift; - uint8_t m_dst_shift; - - uint32_t *m_dest_buf; - uint32_t *m_buf_ptr; + uint32_t m_global_mask = 0; + uint32_t m_write_mask = 0; + bool m_blend = false; + bool m_fast_clear = false; + bool m_rgbmode = false; + bool m_dblsrc = false; + uint8_t m_plane_enable = 0; + uint8_t m_draw_depth = 0; + uint32_t m_draw_bpp = 0; + uint8_t m_logicop = 0; + uint8_t m_src_shift = 0; + uint8_t m_dst_shift = 0; + + uint32_t *m_dest_buf = nullptr; + uint32_t *m_buf_ptr = nullptr; std::unique_ptr m_rgbci; std::unique_ptr m_cidaux; diff --git a/src/devices/bus/hexbus/hexbus.h b/src/devices/bus/hexbus/hexbus.h index 1d225c55749..c7e1fe73a2b 100644 --- a/src/devices/bus/hexbus/hexbus.h +++ b/src/devices/bus/hexbus/hexbus.h @@ -69,7 +69,7 @@ protected: hexbus_device *m_hexbus_outbound; // Common AND of all private values - uint8_t m_current_bus_value; + uint8_t m_current_bus_value = 0; // From device_ti_hexbus_interface virtual uint8_t bus_read(int dir) override; diff --git a/src/devices/bus/hexbus/hx5102.h b/src/devices/bus/hexbus/hx5102.h index 15d717bd028..e28c4bba096 100644 --- a/src/devices/bus/hexbus/hx5102.h +++ b/src/devices/bus/hexbus/hx5102.h @@ -89,7 +89,7 @@ private: bool m_mspeed_on; bool m_pending_int; - bool m_pending_drq; + bool m_pending_drq = false; bool m_dcs; @@ -101,7 +101,7 @@ private: void update_readyff_input(); // Link to the attached floppy drives - floppy_image_device* m_floppy[2]; + floppy_image_device* m_floppy[2]{}; floppy_image_device* m_current_floppy; int m_floppy_select, m_floppy_select_last; @@ -117,8 +117,8 @@ private: required_device m_ram2; // System ROM - uint8_t* m_rom1; - uint8_t* m_rom2; + uint8_t* m_rom1 = nullptr; + uint8_t* m_rom2 = nullptr; }; } // end namespace bus::hexbus diff --git a/src/devices/bus/hp80_io/82900.h b/src/devices/bus/hp80_io/82900.h index 613783cbc3f..9ace998f4cd 100644 --- a/src/devices/bus/hp80_io/82900.h +++ b/src/devices/bus/hp80_io/82900.h @@ -48,8 +48,8 @@ private: // RAM std::unique_ptr m_ram; - bool m_rom_enabled; - uint8_t m_addr_latch; + bool m_rom_enabled = 0; + uint8_t m_addr_latch = 0; DECLARE_WRITE_LINE_MEMBER(reset_w); uint8_t cpu_mem_r(offs_t offset); diff --git a/src/devices/bus/hp9845_io/98032.h b/src/devices/bus/hp9845_io/98032.h index 059b0248ae9..37f78038ac2 100644 --- a/src/devices/bus/hp9845_io/98032.h +++ b/src/devices/bus/hp9845_io/98032.h @@ -38,15 +38,15 @@ protected: private: required_device m_gpio; - uint16_t m_output; - uint16_t m_input; - bool m_int_en; - bool m_dma_en; - bool m_busy; // U5B - bool m_pready; - bool m_flag; - bool m_auto_ah; - bool m_eir; + uint16_t m_output = 0; + uint16_t m_input = 0; + bool m_int_en = false; + bool m_dma_en = false; + bool m_busy = false; // U5B + bool m_pready = false; + bool m_flag = false; + bool m_auto_ah = false; + bool m_eir = false; DECLARE_WRITE_LINE_MEMBER(pflg_w); DECLARE_WRITE_LINE_MEMBER(psts_w); @@ -181,9 +181,9 @@ protected: virtual void device_reset() override; private: - uint16_t m_output; - uint8_t m_ext_control; - bool m_io; + uint16_t m_output = 0; + uint8_t m_ext_control = 0; + bool m_io = false; }; // device type definitions diff --git a/src/devices/bus/hp9845_io/98035.h b/src/devices/bus/hp9845_io/98035.h index 48091cf24e3..7c783c67ed4 100644 --- a/src/devices/bus/hp9845_io/98035.h +++ b/src/devices/bus/hp9845_io/98035.h @@ -63,27 +63,27 @@ private: required_device m_cpu; // Internal RAM & I/F - uint8_t m_np_ram[ 256 ]; - uint8_t m_ram_addr; - uint8_t m_ram_data_in; + uint8_t m_np_ram[ 256 ]{}; + uint8_t m_ram_addr = 0; + uint8_t m_ram_data_in = 0; // DC lines - uint8_t m_dc; + uint8_t m_dc = 0; // NP interrupt - bool m_np_irq; + bool m_np_irq = false; // Periodic interrupt - emu_timer *m_msec_timer; + emu_timer *m_msec_timer = nullptr; // Interface state - bool m_flg; - bool m_inten; - bool m_intflag; - bool m_irq; - bool m_idr_full; - uint8_t m_idr; // Input Data Register - uint8_t m_odr; // Output Data Register + bool m_flg = false; + bool m_inten = false; + bool m_intflag = false; + bool m_irq = false; + bool m_idr_full = false; + uint8_t m_idr = 0; // Input Data Register + uint8_t m_odr = 0; // Output Data Register // Clock chip emulation typedef enum { @@ -96,15 +96,15 @@ private: CLOCK_DOM, // Show :DD } clock_state_t; - emu_timer *m_clock_timer; - unsigned m_clock_1s_div; - clock_state_t m_clock_state; - uint8_t m_clock_digits[ 3 ]; - uint8_t m_clock_mux; - bool m_clock_segh; - uint8_t m_clock_keys; - uint8_t m_prev_clock_keys; - unsigned m_clock_key_cnt; + emu_timer *m_clock_timer = nullptr; + unsigned m_clock_1s_div = 0; + clock_state_t m_clock_state{}; + uint8_t m_clock_digits[ 3 ]{}; + uint8_t m_clock_mux = 0; + bool m_clock_segh = false; + uint8_t m_clock_keys = 0; + uint8_t m_prev_clock_keys = 0; + unsigned m_clock_key_cnt = 0; void half_init(); void set_flg(bool value); diff --git a/src/devices/bus/hp9845_io/hp9885.h b/src/devices/bus/hp9845_io/hp9885.h index a782df5d7df..eedae889e5c 100644 --- a/src/devices/bus/hp9845_io/hp9885.h +++ b/src/devices/bus/hp9845_io/hp9885.h @@ -76,32 +76,32 @@ private: }; required_device m_drive_connector; - floppy_image_device *m_drive; - uint16_t m_input; - uint16_t m_output; - uint16_t m_status; - int m_fsm_state; - int m_head_state; - int m_op; - bool m_pctl; - bool m_ibf; - bool m_obf; - bool m_outputting; - bool m_had_transition; - bool m_dskchg; - unsigned m_track; - unsigned m_seek_track; - unsigned m_seek_sector; - unsigned m_sector_cnt; - unsigned m_word_cnt; - unsigned m_rev_cnt; - uint32_t m_am_detector; - uint16_t m_crc; // x^15 is stored in LSB + floppy_image_device *m_drive = nullptr; + uint16_t m_input = 0; + uint16_t m_output = 0; + uint16_t m_status = 0; + int m_fsm_state = 0; + int m_head_state = 0; + int m_op = 0; + bool m_pctl = false; + bool m_ibf = false; + bool m_obf = false; + bool m_outputting = false; + bool m_had_transition = false; + bool m_dskchg = false; + unsigned m_track = 0; + unsigned m_seek_track = 0; + unsigned m_seek_sector = 0; + unsigned m_sector_cnt = 0; + unsigned m_word_cnt = 0; + unsigned m_rev_cnt = 0; + uint32_t m_am_detector = 0; + uint16_t m_crc = 0; // x^15 is stored in LSB // Timers - emu_timer *m_fsm_timer; - emu_timer *m_head_timer; - emu_timer *m_bit_byte_timer; + emu_timer *m_fsm_timer = nullptr; + emu_timer *m_head_timer = nullptr; + emu_timer *m_bit_byte_timer = nullptr; // PLL fdc_pll_t m_pll; diff --git a/src/devices/bus/hp_dio/hp98550.h b/src/devices/bus/hp_dio/hp98550.h index eca4da5bed6..c0fcb5c2286 100644 --- a/src/devices/bus/hp_dio/hp98550.h +++ b/src/devices/bus/hp_dio/hp98550.h @@ -62,7 +62,7 @@ protected: required_region_ptr m_rom; required_shared_ptr_array m_vram; - uint16_t m_plane_mask; + uint16_t m_plane_mask = 0; uint8_t m_intreg; uint8_t m_ints; }; diff --git a/src/devices/bus/hp_dio/hp98603a.h b/src/devices/bus/hp_dio/hp98603a.h index 15cccb7ab3d..e97eedcada1 100644 --- a/src/devices/bus/hp_dio/hp98603a.h +++ b/src/devices/bus/hp_dio/hp98603a.h @@ -32,7 +32,7 @@ protected: virtual const tiny_rom_entry *device_rom_region() const override; private: - uint8_t *m_rom; + uint8_t *m_rom = nullptr; }; } // namespace bus::hp_dio diff --git a/src/devices/bus/hp_dio/hp98643.h b/src/devices/bus/hp_dio/hp98643.h index c1944bb1b8f..ed173731ae9 100644 --- a/src/devices/bus/hp_dio/hp98643.h +++ b/src/devices/bus/hp_dio/hp98643.h @@ -79,8 +79,8 @@ private: std::array m_ram; - uint16_t m_sc; - bool m_installed_io; + uint16_t m_sc = 0; + bool m_installed_io = false; }; } // namespace bus::hp_dio diff --git a/src/devices/bus/hp_dio/hp_dio.h b/src/devices/bus/hp_dio/hp_dio.h index c3ad5e0d178..37aa6af3c21 100644 --- a/src/devices/bus/hp_dio/hp_dio.h +++ b/src/devices/bus/hp_dio/hp_dio.h @@ -222,7 +222,7 @@ protected: private: void set_bus(dio16_device & bus); device_dio16_card_interface *m_next; - unsigned int m_index; + unsigned int m_index = 0; }; class dio32_device; diff --git a/src/devices/bus/hp_hil/hp_hil.h b/src/devices/bus/hp_hil/hp_hil.h index c50c4742340..7aaa6845c8b 100644 --- a/src/devices/bus/hp_hil/hp_hil.h +++ b/src/devices/bus/hp_hil/hp_hil.h @@ -178,7 +178,7 @@ protected: hp_hil_mlc_device *m_hp_hil_mlc; - hp_hil_slot_device *m_slot; + hp_hil_slot_device *m_slot = nullptr; int m_device_id; uint16_t m_device_id16; diff --git a/src/devices/bus/ieee488/grid2102.h b/src/devices/bus/ieee488/grid2102.h index 8bc475d6f84..c99f4715587 100644 --- a/src/devices/bus/ieee488/grid2102.h +++ b/src/devices/bus/ieee488/grid2102.h @@ -59,21 +59,21 @@ protected: private: int m_gpib_loop_state; int m_floppy_loop_state; - uint8_t m_last_recv_byte; - int m_last_recv_eoi; - int m_last_recv_atn; - uint8_t m_byte_to_send; - int m_send_eoi; + uint8_t m_last_recv_byte = 0; + int m_last_recv_eoi = 0; + int m_last_recv_atn = 0; + uint8_t m_byte_to_send = 0; + int m_send_eoi = 0; bool listening, talking, serial_polling; bool has_srq; uint8_t serial_poll_byte; - uint32_t floppy_sector_number; + uint32_t floppy_sector_number = 0; int bus_addr; uint8_t *identify_response_ptr; std::vector m_data_buffer; std::queue m_output_data_buffer; - uint16_t io_size; - emu_timer *m_delay_timer; + uint16_t io_size = 0; + emu_timer *m_delay_timer = nullptr; protected: attotime read_delay; }; diff --git a/src/devices/bus/ieee488/remote488.h b/src/devices/bus/ieee488/remote488.h index 9832c7d1d76..7651ebc9d07 100644 --- a/src/devices/bus/ieee488/remote488.h +++ b/src/devices/bus/ieee488/remote488.h @@ -80,28 +80,28 @@ private: }; required_device m_stream; - uint8_t m_in_signals; - uint8_t m_out_signals; - bool m_no_propagation; - int m_sh_state; - int m_ah_state; - int m_rx_state; - char m_rx_ch; - uint8_t m_rx_data; - bool m_flush_bytes; - bool m_ibf; - uint8_t m_ib; - bool m_ib_eoi; - emu_timer *m_poll_timer; - emu_timer *m_hb_timer; - emu_timer *m_ah_timer; - unsigned m_connect_cnt; - bool m_connected; - uint8_t m_pp_data; - bool m_pp_requested; - uint8_t m_pp_dio; - uint8_t m_sh_dio; - bool m_waiting_cp; + uint8_t m_in_signals = 0; + uint8_t m_out_signals = 0; + bool m_no_propagation = false; + int m_sh_state = 0; + int m_ah_state = 0; + int m_rx_state = 0; + char m_rx_ch = 0; + uint8_t m_rx_data = 0; + bool m_flush_bytes = false; + bool m_ibf = false; + uint8_t m_ib = 0; + bool m_ib_eoi = false; + emu_timer *m_poll_timer = nullptr; + emu_timer *m_hb_timer = nullptr; + emu_timer *m_ah_timer = nullptr; + unsigned m_connect_cnt = 0; + bool m_connected = false; + uint8_t m_pp_data = 0; + bool m_pp_requested = false; + uint8_t m_pp_dio = 0; + uint8_t m_sh_dio = 0; + bool m_waiting_cp = false; void bus_reset(); void process_input_msgs(); diff --git a/src/devices/bus/interpro/keyboard/lle.h b/src/devices/bus/interpro/keyboard/lle.h index 385f2484fab..d2a91ee41a5 100644 --- a/src/devices/bus/interpro/keyboard/lle.h +++ b/src/devices/bus/interpro/keyboard/lle.h @@ -48,13 +48,13 @@ private: output_finder<8> m_leds; - u8 m_txd; - u8 m_p1; - u8 m_p2; - u8 m_bus; + u8 m_txd = 0; + u8 m_p1 = 0; + u8 m_p2 = 0; + u8 m_bus = 0; - u8 m_row; - u8 m_count; + u8 m_row = 0; + u8 m_count = 0; }; class lle_en_us_device : public lle_device_base diff --git a/src/devices/bus/interpro/sr/edge.h b/src/devices/bus/interpro/sr/edge.h index d96896dd187..63a3d9d0aa4 100644 --- a/src/devices/bus/interpro/sr/edge.h +++ b/src/devices/bus/interpro/sr/edge.h @@ -60,18 +60,18 @@ protected: required_device m_scc; private: - u32 m_reg0; + u32 m_reg0 = 0; - u32 m_control; - u32 m_status; - u32 m_fifo; - u32 m_kernel; - u32 m_attention; + u32 m_control = 0; + u32 m_status = 0; + u32 m_fifo = 0; + u32 m_kernel = 0; + u32 m_attention = 0; - u32 m_ififo_lwm; - u32 m_ififo_hwm; + u32 m_ififo_lwm = 0; + u32 m_ififo_hwm = 0; - u32 m_srx_master_control; + u32 m_srx_master_control = 0; }; class edge2_processor_device_base : public device_t, public device_srx_card_interface @@ -130,16 +130,16 @@ protected: private: - u32 m_control; - u32 m_status; - u32 m_attention; - u32 m_mapping; - u32 m_kernel; + u32 m_control = 0; + u32 m_status = 0; + u32 m_attention = 0; + u32 m_mapping = 0; + u32 m_kernel = 0; - u32 m_ififo_lwm; - u32 m_ififo_hwm; + u32 m_ififo_lwm = 0; + u32 m_ififo_hwm = 0; - u32 m_reg0; + u32 m_reg0 = 0; screen_device *m_screen; ram_device *m_sram; @@ -172,8 +172,8 @@ protected: required_device_array m_ramdac; private: - u32 m_unk_304; - u32 m_select; + u32 m_unk_304 = 0; + u32 m_select = 0; }; class mpcb828_device : public edge1_device_base diff --git a/src/devices/bus/interpro/sr/gt.h b/src/devices/bus/interpro/sr/gt.h index aeeb70941ea..fd4ce7c244d 100644 --- a/src/devices/bus/interpro/sr/gt.h +++ b/src/devices/bus/interpro/sr/gt.h @@ -208,38 +208,38 @@ protected: u16 m_bsga_width; u16 m_bsga_tmp; - u16 m_bsga_xmin; // clipping boundary minimum x (left) - u16 m_bsga_ymin; // clipping boundary minimum y (top) - u16 m_bsga_xmax; // clipping boundary maximum x (right) - u16 m_bsga_ymax; // clipping boundary maximum y (bottom) - - u16 m_bsga_status; - - u16 m_bsga_xin1; - u16 m_bsga_yin1; - u16 m_bsga_xin2; - u16 m_bsga_yin2; - - u16 m_bsga_xin; // most recently written xin1/xin2 - u16 m_bsga_yin; // most recently written yin1/yin2 - - u32 m_ri_initial_distance; - u32 m_ri_distance_both; - u32 m_ri_distance_major; - u32 m_ri_initial_address; - u32 m_ri_address_both; - u32 m_ri_address_major; - u32 m_ri_initial_error; - u32 m_ri_error_both; - u32 m_ri_error_major; - u32 m_ri_stop_count; - u32 m_ri_control; - u32 m_ri_xfer; + u16 m_bsga_xmin = 0; // clipping boundary minimum x (left) + u16 m_bsga_ymin = 0; // clipping boundary minimum y (top) + u16 m_bsga_xmax = 0; // clipping boundary maximum x (right) + u16 m_bsga_ymax = 0; // clipping boundary maximum y (bottom) + + u16 m_bsga_status = 0; + + u16 m_bsga_xin1 = 0; + u16 m_bsga_yin1 = 0; + u16 m_bsga_xin2 = 0; + u16 m_bsga_yin2 = 0; + + u16 m_bsga_xin = 0; // most recently written xin1/xin2 + u16 m_bsga_yin = 0; // most recently written yin1/yin2 + + u32 m_ri_initial_distance = 0; + u32 m_ri_distance_both = 0; + u32 m_ri_distance_major = 0; + u32 m_ri_initial_address = 0; + u32 m_ri_address_both = 0; + u32 m_ri_address_major = 0; + u32 m_ri_initial_error = 0; + u32 m_ri_error_both = 0; + u32 m_ri_error_major = 0; + u32 m_ri_stop_count = 0; + u32 m_ri_control = 0; + u32 m_ri_xfer = 0; private: - emu_timer *m_blit_timer; - emu_timer *m_line_timer; - emu_timer *m_done_timer; + emu_timer *m_blit_timer = nullptr; + emu_timer *m_line_timer = nullptr; + emu_timer *m_done_timer = nullptr; const bool m_double_buffered; const bool m_masked_reads; @@ -296,11 +296,11 @@ protected: required_device m_scc; private: - u8 m_mouse_int; - u32 m_fifo_control; + u8 m_mouse_int = 0; + u32 m_fifo_control = 0; - u8 m_mouse_x; - u8 m_mouse_y; + u8 m_mouse_x = 0; + u8 m_mouse_y = 0; }; class mpcb963_device : public gt_device diff --git a/src/devices/bus/intv_ctrl/ecs_ctrl.h b/src/devices/bus/intv_ctrl/ecs_ctrl.h index 77fdfc72a92..10db91f0118 100644 --- a/src/devices/bus/intv_ctrl/ecs_ctrl.h +++ b/src/devices/bus/intv_ctrl/ecs_ctrl.h @@ -152,7 +152,7 @@ protected: virtual void write_portA(uint8_t data) override; private: - uint8_t m_psg_portA; + uint8_t m_psg_portA = 0; required_ioport_array<7> m_synth; }; diff --git a/src/devices/bus/isa/3c503.h b/src/devices/bus/isa/3c503.h index f9597f00137..4c24b9c4688 100644 --- a/src/devices/bus/isa/3c503.h +++ b/src/devices/bus/isa/3c503.h @@ -44,19 +44,19 @@ private: void set_drq(int state); struct { - uint8_t pstr; - uint8_t pspr; - uint8_t dqtr; - uint8_t bcfr; - uint8_t pcfr; - uint8_t gacfr; - uint8_t ctrl; - uint8_t streg; - uint8_t idcfr; - uint16_t da; - uint32_t vptr; - uint8_t rfmsb; - uint8_t rflsb; + uint8_t pstr = 0; + uint8_t pspr = 0; + uint8_t dqtr = 0; + uint8_t bcfr = 0; + uint8_t pcfr = 0; + uint8_t gacfr = 0; + uint8_t ctrl = 0; + uint8_t streg = 0; + uint8_t idcfr = 0; + uint16_t da = 0; + uint32_t vptr = 0; + uint8_t rfmsb = 0; + uint8_t rflsb = 0; } m_regs; }; diff --git a/src/devices/bus/isa/chessmdr.h b/src/devices/bus/isa/chessmdr.h index 9f5d1bf270f..536f72ebb4e 100644 --- a/src/devices/bus/isa/chessmdr.h +++ b/src/devices/bus/isa/chessmdr.h @@ -34,7 +34,7 @@ protected: private: required_device m_chessm; - bool m_installed; + bool m_installed = false; uint8_t chessmdr_r(offs_t offset); void chessmdr_w(offs_t offset, uint8_t data); diff --git a/src/devices/bus/isa/chessmsr.h b/src/devices/bus/isa/chessmsr.h index 6d4becc4b64..cfbb56ea662 100644 --- a/src/devices/bus/isa/chessmsr.h +++ b/src/devices/bus/isa/chessmsr.h @@ -39,9 +39,9 @@ private: required_device m_sublatch; std::unique_ptr m_ram; - u8 m_ram_offset; - bool m_suspended; - bool m_installed; + u8 m_ram_offset = 0; + bool m_suspended = false; + bool m_installed = false; uint8_t chessmsr_r(offs_t offset); void chessmsr_w(offs_t offset, uint8_t data); diff --git a/src/devices/bus/isa/ega.h b/src/devices/bus/isa/ega.h index 04ff53fc055..d7ee83e4b01 100644 --- a/src/devices/bus/isa/ega.h +++ b/src/devices/bus/isa/ega.h @@ -67,44 +67,44 @@ public: /* Video memory and related variables */ std::unique_ptr m_vram; - uint8_t *m_plane[4]; - uint8_t m_read_latch[4]; - uint8_t *m_videoram; - uint8_t *m_charA; - uint8_t *m_charB; + uint8_t *m_plane[4]{}; + uint8_t m_read_latch[4]{}; + uint8_t *m_videoram = nullptr; + uint8_t *m_charA = nullptr; + uint8_t *m_charB = nullptr; /* Registers */ - uint8_t m_misc_output; - uint8_t m_feature_control; + uint8_t m_misc_output = 0; + uint8_t m_feature_control = 0; /* Attribute registers AR00 - AR14 */ struct { - uint8_t index; - uint8_t data[32]; - uint8_t index_write; + uint8_t index = 0; + uint8_t data[32]{}; + uint8_t index_write = 0; } m_attribute; /* Sequencer registers SR00 - SR04 */ struct { - uint8_t index; - uint8_t data[8]; + uint8_t index = 0; + uint8_t data[8]{}; } m_sequencer; /* Graphics controller registers GR00 - GR08 */ struct { - uint8_t index; - uint8_t data[16]; + uint8_t index = 0; + uint8_t data[16]{}; } m_graphics_controller; - uint8_t m_frame_cnt; - uint8_t m_hsync; - uint8_t m_vsync; - uint8_t m_vblank; - uint8_t m_display_enable; - int m_video_mode; + uint8_t m_frame_cnt = 0; + uint8_t m_hsync = 0; + uint8_t m_vsync = 0; + uint8_t m_vblank = 0; + uint8_t m_display_enable = 0; + int m_video_mode = 0; required_device m_palette; }; diff --git a/src/devices/bus/isa/eis_hgb107x.h b/src/devices/bus/isa/eis_hgb107x.h index 6689e7db0a8..fba9e1b7758 100644 --- a/src/devices/bus/isa/eis_hgb107x.h +++ b/src/devices/bus/isa/eis_hgb107x.h @@ -87,12 +87,12 @@ private: required_ioport m_io_monitor; required_region_ptr m_chargen; - uint8_t m_vmode; - rgb_t (*m_pal)[4]; - rgb_t m_3111_pal[4]; - rgb_t m_371x_pal[4]; + uint8_t m_vmode = 0; + rgb_t (*m_pal)[4]{}; + rgb_t m_3111_pal[4]{}; + rgb_t m_371x_pal[4]{}; bool m_installed; - hd6845s_device *m_hd6845s; + hd6845s_device *m_hd6845s = nullptr; public: int m_framecnt; diff --git a/src/devices/bus/isa/ex1280.h b/src/devices/bus/isa/ex1280.h index a9637a1b1f6..4b725a6defb 100644 --- a/src/devices/bus/isa/ex1280.h +++ b/src/devices/bus/isa/ex1280.h @@ -52,7 +52,7 @@ protected: void main_map(address_map &map); std::vector m_vram; - uint16_t m_flags; + uint16_t m_flags = 0; }; diff --git a/src/devices/bus/isa/fdc.h b/src/devices/bus/isa/fdc.h index 00431ef3e5c..ff4ba2b83f1 100644 --- a/src/devices/bus/isa/fdc.h +++ b/src/devices/bus/isa/fdc.h @@ -61,10 +61,10 @@ protected: DECLARE_WRITE_LINE_MEMBER( fdc_drq_w ); private: - bool irq, drq, fdc_drq, fdc_irq; + bool irq = false, drq = false, fdc_drq = false, fdc_irq = false; uint8_t dor; - floppy_image_device *floppy[4]; + floppy_image_device *floppy[4]{}; void check_irq(); void check_drq(); diff --git a/src/devices/bus/isa/finalchs.h b/src/devices/bus/isa/finalchs.h index 2b04f69ec6b..2b77a4efb08 100644 --- a/src/devices/bus/isa/finalchs.h +++ b/src/devices/bus/isa/finalchs.h @@ -39,7 +39,7 @@ private: required_device m_mainlatch; required_device m_sublatch; - bool m_installed; + bool m_installed = false; uint8_t finalchs_r(offs_t offset); void finalchs_w(offs_t offset, uint8_t data); diff --git a/src/devices/bus/isa/mach32.h b/src/devices/bus/isa/mach32.h index 38b4f673530..58148c7ade3 100644 --- a/src/devices/bus/isa/mach32.h +++ b/src/devices/bus/isa/mach32.h @@ -42,7 +42,7 @@ protected: uint16_t m_chip_ID; uint16_t m_membounds; - bool display_mode_change; + bool display_mode_change = false; }; @@ -170,18 +170,18 @@ protected: virtual uint16_t offset() override; // hardware pointer - bool m_cursor_enable; - uint32_t m_cursor_address; - uint16_t m_cursor_horizontal; - uint16_t m_cursor_vertical; - uint8_t m_cursor_colour0_b; - uint8_t m_cursor_colour0_r; - uint8_t m_cursor_colour0_g; - uint8_t m_cursor_colour1_b; - uint8_t m_cursor_colour1_r; - uint8_t m_cursor_colour1_g; - uint8_t m_cursor_offset_horizontal; - uint8_t m_cursor_offset_vertical; + bool m_cursor_enable = false; + uint32_t m_cursor_address = 0; + uint16_t m_cursor_horizontal = 0; + uint16_t m_cursor_vertical = 0; + uint8_t m_cursor_colour0_b = 0; + uint8_t m_cursor_colour0_r = 0; + uint8_t m_cursor_colour0_g = 0; + uint8_t m_cursor_colour1_b = 0; + uint8_t m_cursor_colour1_r = 0; + uint8_t m_cursor_colour1_g = 0; + uint8_t m_cursor_offset_horizontal = 0; + uint8_t m_cursor_offset_vertical = 0; }; diff --git a/src/devices/bus/isa/mcd.h b/src/devices/bus/isa/mcd.h index 4c2b7a0e636..e134e4d0dce 100644 --- a/src/devices/bus/isa/mcd.h +++ b/src/devices/bus/isa/mcd.h @@ -39,28 +39,28 @@ private: bool read_sector(bool first = false); - bool m_change; - bool m_newstat; - bool m_data; - uint8_t m_stat; - uint8_t m_buf[2352]; - int m_buf_count; - int m_buf_idx; - uint8_t m_cmdbuf[16]; - int m_cmdbuf_count; - int m_cmdrd_count; - int m_cmdbuf_idx; - uint8_t m_mode; - uint8_t m_cmd; - uint8_t m_conf; - uint8_t m_irq; - uint8_t m_dma; - uint16_t m_dmalen; - uint32_t m_readmsf; - uint32_t m_readcount; - bool m_locked; - int m_drvmode; - int m_curtoctrk; + bool m_change = false; + bool m_newstat = false; + bool m_data = false; + uint8_t m_stat = 0; + uint8_t m_buf[2352]{}; + int m_buf_count = 0; + int m_buf_idx = 0; + uint8_t m_cmdbuf[16]{}; + int m_cmdbuf_count = 0; + int m_cmdrd_count = 0; + int m_cmdbuf_idx = 0; + uint8_t m_mode = 0; + uint8_t m_cmd = 0; + uint8_t m_conf = 0; + uint8_t m_irq = 0; + uint8_t m_dma = 0; + uint16_t m_dmalen = 0; + uint32_t m_readmsf = 0; + uint32_t m_readcount = 0; + bool m_locked = false; + int m_drvmode = 0; + int m_curtoctrk = 0; enum { STAT_CMD_CHECK = 0x01, STAT_PLAY_CDDA = 0x02, diff --git a/src/devices/bus/isa/myb3k_com.h b/src/devices/bus/isa/myb3k_com.h index bdd591b5291..563f4f8793d 100644 --- a/src/devices/bus/isa/myb3k_com.h +++ b/src/devices/bus/isa/myb3k_com.h @@ -69,8 +69,8 @@ protected: required_device m_usart; bool m_installed; int m_irq; - int m_irq_tx; - int m_irq_rx; + int m_irq_tx = 0; + int m_irq_rx = 0; int m_control; int m_status; }; diff --git a/src/devices/bus/isa/myb3k_fdc.h b/src/devices/bus/isa/myb3k_fdc.h index b2a645423d6..5ec79b42fbd 100644 --- a/src/devices/bus/isa/myb3k_fdc.h +++ b/src/devices/bus/isa/myb3k_fdc.h @@ -44,10 +44,10 @@ protected: required_device m_fdc; optional_device_array m_floppy_connectors; - offs_t io_base; - int dma_channel; + offs_t io_base = 0; + int dma_channel = 0; - bool has_motor_control; + bool has_motor_control = false; enum FDC_COMMAND { FDC_DRIVE_SEL = 0x03, diff --git a/src/devices/bus/isa/p1_sound.h b/src/devices/bus/isa/p1_sound.h index 3b7f1c40af9..608c2d5f4bc 100644 --- a/src/devices/bus/isa/p1_sound.h +++ b/src/devices/bus/isa/p1_sound.h @@ -51,8 +51,8 @@ protected: private: DECLARE_WRITE_LINE_MEMBER(sampler_sync); - uint8_t m_dac_data[16]; - int m_dac_ptr; + uint8_t m_dac_data[16]{}; + int m_dac_ptr = 0; required_device m_dac; optional_device m_filter; diff --git a/src/devices/bus/isa/pgc.h b/src/devices/bus/isa/pgc.h index d560dbdda09..dace5a076c5 100644 --- a/src/devices/bus/isa/pgc.h +++ b/src/devices/bus/isa/pgc.h @@ -64,9 +64,9 @@ private: std::unique_ptr m_vram; std::unique_ptr m_eram; - uint8_t m_stateparam[16]; - uint8_t m_lut[256 * 3]; - int m_accel; + uint8_t m_stateparam[16]{}; + uint8_t m_lut[256 * 3]{}; + int m_accel = 0; }; diff --git a/src/devices/bus/isa/s3virge.h b/src/devices/bus/isa/s3virge.h index 89023e3bafc..960667365e9 100644 --- a/src/devices/bus/isa/s3virge.h +++ b/src/devices/bus/isa/s3virge.h @@ -137,50 +137,50 @@ protected: struct { - uint32_t linear_address; - uint8_t linear_address_size; - uint32_t linear_address_size_full; - bool linear_address_enable; - uint32_t interrupt_enable; + uint32_t linear_address = 0; + uint8_t linear_address_size = 0; + uint32_t linear_address_size_full = 0; + bool linear_address_enable = false; + uint32_t interrupt_enable = 0; struct { - int state; - bool busy; + int state = 0; + bool busy = false; struct { - uint32_t reg[256]; - int op_type; + uint32_t reg[256]{}; + int op_type = 0; } cmd_fifo[16]; - int cmd_fifo_next_ptr; // command added here in FIFO - int cmd_fifo_current_ptr; // command currently being processed in FIFO - int cmd_fifo_slots_free; + int cmd_fifo_next_ptr = 0; // command added here in FIFO + int cmd_fifo_current_ptr = 0; // command currently being processed in FIFO + int cmd_fifo_slots_free = 0; - uint8_t pattern[0xc0]; - uint32_t reg[5][256]; + uint8_t pattern[0xc0]{}; + uint32_t reg[5][256]{}; // BitBLT command state - uint16_t bitblt_x_src; - uint16_t bitblt_y_src; - uint16_t bitblt_x_dst; - uint16_t bitblt_y_dst; - int16_t bitblt_x_current; - int16_t bitblt_y_current; - int16_t bitblt_x_src_current; - int16_t bitblt_y_src_current; - int8_t bitblt_pat_x; - int8_t bitblt_pat_y; - uint16_t bitblt_height; - uint16_t bitblt_width; - uint32_t bitblt_step_count; - uint64_t bitblt_mono_pattern; - uint32_t bitblt_current_pixel; - uint32_t bitblt_pixel_pos; // current position in a pixel (for packed 24bpp colour image transfers) - uint32_t image_xfer; // source data via image transfer ports - uint16_t clip_l; - uint16_t clip_r; - uint16_t clip_t; - uint16_t clip_b; + uint16_t bitblt_x_src = 0; + uint16_t bitblt_y_src = 0; + uint16_t bitblt_x_dst = 0; + uint16_t bitblt_y_dst = 0; + int16_t bitblt_x_current = 0; + int16_t bitblt_y_current = 0; + int16_t bitblt_x_src_current = 0; + int16_t bitblt_y_src_current = 0; + int8_t bitblt_pat_x = 0; + int8_t bitblt_pat_y = 0; + uint16_t bitblt_height = 0; + uint16_t bitblt_width = 0; + uint32_t bitblt_step_count = 0; + uint64_t bitblt_mono_pattern = 0; + uint32_t bitblt_current_pixel = 0; + uint32_t bitblt_pixel_pos = 0; // current position in a pixel (for packed 24bpp colour image transfers) + uint32_t image_xfer = 0; // source data via image transfer ports + uint16_t clip_l = 0; + uint16_t clip_r = 0; + uint16_t clip_t = 0; + uint16_t clip_b = 0; } s3d; } s3virge; @@ -243,7 +243,7 @@ protected: devcb_write_line m_linear_config_changed_cb; private: - emu_timer* m_draw_timer; + emu_timer* m_draw_timer = nullptr; void bitblt_step(); void bitblt_colour_step(); void bitblt_monosrc_step(); diff --git a/src/devices/bus/isa/sblaster.h b/src/devices/bus/isa/sblaster.h index 7d5d5775f91..a73b569dc7b 100644 --- a/src/devices/bus/isa/sblaster.h +++ b/src/devices/bus/isa/sblaster.h @@ -73,35 +73,35 @@ protected: struct sb8_mixer { - uint8_t status; - uint8_t main_vol; - uint8_t dac_vol; - uint8_t fm_vol; - uint8_t mic_vol; - uint8_t in_filter; - uint8_t stereo_sel; - uint8_t cd_vol; - uint8_t line_vol; + uint8_t status = 0; + uint8_t main_vol = 0; + uint8_t dac_vol = 0; + uint8_t fm_vol = 0; + uint8_t mic_vol = 0; + uint8_t in_filter = 0; + uint8_t stereo_sel = 0; + uint8_t cd_vol = 0; + uint8_t line_vol = 0; }; struct sb16_mixer { - uint8_t data; - uint8_t status; - uint8_t main_vol[2]; - uint8_t dac_vol[2]; - uint8_t fm_vol[2]; - uint8_t cd_vol[2]; - uint8_t line_vol[2]; - uint8_t mic_vol; - uint8_t pc_speaker_vol; - uint8_t output_ctl; - uint8_t input_ctl[2]; - uint8_t input_gain[2]; - uint8_t output_gain[2]; - uint8_t agc; - uint8_t treble[2]; - uint8_t bass[2]; + uint8_t data = 0; + uint8_t status = 0; + uint8_t main_vol[2]{}; + uint8_t dac_vol[2]{}; + uint8_t fm_vol[2]{}; + uint8_t cd_vol[2]{}; + uint8_t line_vol[2]{}; + uint8_t mic_vol = 0; + uint8_t pc_speaker_vol = 0; + uint8_t output_ctl = 0; + uint8_t input_ctl[2]{}; + uint8_t input_gain[2]{}; + uint8_t output_gain[2]{}; + uint8_t agc = 0; + uint8_t treble[2]{}; + uint8_t bass[2]{}; }; // construction/destruction diff --git a/src/devices/bus/isa/svga_s3.h b/src/devices/bus/isa/svga_s3.h index a07b0e039c6..d6dea54ec0d 100644 --- a/src/devices/bus/isa/svga_s3.h +++ b/src/devices/bus/isa/svga_s3.h @@ -87,9 +87,9 @@ protected: private: required_device m_vga; - bool m_lfb_enable; - uint32_t m_lfb_start; - uint32_t m_lfb_end; + bool m_lfb_enable = false; + uint32_t m_lfb_start = 0; + uint32_t m_lfb_end = 0; }; class isa16_stealth3d2kpro_device : diff --git a/src/devices/bus/isa/trident.h b/src/devices/bus/isa/trident.h index 3dc8f63947c..7ce6853c778 100644 --- a/src/devices/bus/isa/trident.h +++ b/src/devices/bus/isa/trident.h @@ -87,35 +87,35 @@ protected: uint8_t cursor_ctrl; // 2D acceleration - uint16_t accel_opermode; - uint8_t accel_command; - uint8_t accel_fmix; - uint32_t accel_drawflags; - uint32_t accel_fgcolour; - uint32_t accel_bgcolour; - uint16_t accel_pattern_loc; - int16_t accel_source_x; - int16_t accel_source_y; - int16_t accel_dest_x; - int16_t accel_dest_y; - int16_t accel_dim_x; - int16_t accel_dim_y; - uint32_t accel_style; - uint32_t accel_ckey; - int16_t accel_source_x_clip; - int16_t accel_source_y_clip; - int16_t accel_dest_x_clip; - int16_t accel_dest_y_clip; - uint32_t accel_fg_pattern_colour; - uint32_t accel_bg_pattern_colour; - uint8_t accel_pattern[0x80]; - bool accel_busy; - bool accel_memwrite_active; // true when writing to VRAM will push data to an ongoing command (SRCMONO/PATMONO) - int16_t accel_mem_x; - int16_t accel_mem_y; - uint32_t accel_transfer; + uint16_t accel_opermode = 0; + uint8_t accel_command = 0; + uint8_t accel_fmix = 0; + uint32_t accel_drawflags = 0; + uint32_t accel_fgcolour = 0; + uint32_t accel_bgcolour = 0; + uint16_t accel_pattern_loc = 0; + int16_t accel_source_x = 0; + int16_t accel_source_y = 0; + int16_t accel_dest_x = 0; + int16_t accel_dest_y = 0; + int16_t accel_dim_x = 0; + int16_t accel_dim_y = 0; + uint32_t accel_style = 0; + uint32_t accel_ckey = 0; + int16_t accel_source_x_clip = 0; + int16_t accel_source_y_clip = 0; + int16_t accel_dest_x_clip = 0; + int16_t accel_dest_y_clip = 0; + uint32_t accel_fg_pattern_colour = 0; + uint32_t accel_bg_pattern_colour = 0; + uint8_t accel_pattern[0x80]{}; + bool accel_busy = false; + bool accel_memwrite_active = false; // true when writing to VRAM will push data to an ongoing command (SRCMONO/PATMONO) + int16_t accel_mem_x = 0; + int16_t accel_mem_y = 0; + uint32_t accel_transfer = 0; } tri; - uint8_t m_version; + uint8_t m_version = 0; private: uint8_t trident_seq_reg_read(uint8_t index); void trident_seq_reg_write(uint8_t index, uint8_t data); diff --git a/src/devices/bus/isbx/isbc_218a.h b/src/devices/bus/isbx/isbc_218a.h index c654c74aae8..597b80d07fb 100644 --- a/src/devices/bus/isbx/isbc_218a.h +++ b/src/devices/bus/isbx/isbc_218a.h @@ -56,7 +56,7 @@ private: required_device m_fdc; required_device m_floppy0; - bool m_reset, m_motor, m_fd8; + bool m_reset, m_motor, m_fd8 = false; }; diff --git a/src/devices/bus/lpci/i82439tx.h b/src/devices/bus/lpci/i82439tx.h index af5a0dcf757..c3e124860f9 100644 --- a/src/devices/bus/lpci/i82439tx.h +++ b/src/devices/bus/lpci/i82439tx.h @@ -51,14 +51,14 @@ private: // system management ram setup struct { int tseg_en; - int tseg_sz; - int e_smerr; + int tseg_sz = 0; + int e_smerr = 0; int h_smrame; - int c_base_seg; - int g_smrame; - int d_lck; - int d_cls; - int d_open; + int c_base_seg = 0; + int g_smrame = 0; + int d_lck = 0; + int d_cls = 0; + int d_open = 0; int smiact_n; int tseg_size; int mapping; diff --git a/src/mame/drivers/s7.cpp b/src/mame/drivers/s7.cpp index dce45e9e33f..d5bd588067a 100644 --- a/src/mame/drivers/s7.cpp +++ b/src/mame/drivers/s7.cpp @@ -48,6 +48,7 @@ Thunderball 508 1 unknown HyperBall 509 1 unknown Barracora 510 ASD hit 1 ASD Varkon 512 AX hit 1 AX +Spellbinder (unreleased) 513 Reflex (unreleased) 514 Time Fantasy 515 1 X Warlok 516 1 X -- cgit v1.2.3