From 530c5abb5da585ac71f9c643c9d6a2171280fe67 Mon Sep 17 00:00:00 2001 From: Vas Crabb Date: Sun, 3 Apr 2022 03:05:53 +1000 Subject: Revert initialisation of device members in headers. This is problematic in several ways: * Initialising things at construction that aren't needed until after start slows down -romident, -validate, -listxml, etc. Slot cards can be a particular drain on -listxml and -validate as they're instantiated for every compatible slot. It's more pronounced for array members, too. * Splitting member initialisation between declaration in headers and constructors in source files means you have to look at two places to check for the initial value, and you always need to check the constructor even if an initialiser is present in the header because the constructor initaliser list takes precedence. (This isn't as much of an issue for driver classes because the constructor is most often inlined at declaration, so it isn't far from the member declarations.) * Initialisers in headers for frequently-used devices increases the frequency of recompiling dependent devices/drivers as they're exposed to any changes in initialisers. * Initialisers in frequently-used headers increase build times because there's more for the compiler to parse/cache. (This affects makedep.py as well for single-driver builds, but that's a single pass.) It's not a lot individually, but it adds up given the size of MAME, which keeps increasing. We've already had one contributor banned from GitHub actions for resource usage, we don't want to waste compiler time unnecessarily. --- src/devices/bus/a2bus/a2echoii.cpp | 6 +- src/devices/bus/a2bus/a2hsscsi.h | 2 +- src/devices/bus/a2bus/a2iwm.h | 2 +- src/devices/bus/a2bus/a2mockingboard.cpp | 4 +- src/devices/bus/a2bus/a2sd.h | 2 +- src/devices/bus/a2bus/agat7langcard.h | 2 +- src/devices/bus/a2bus/agat7ports.h | 2 +- src/devices/bus/a2bus/agat840k_hle.h | 22 +++---- src/devices/bus/a2bus/agat_fdc.h | 32 +++++------ src/devices/bus/a2bus/computereyes2.cpp | 8 +-- src/devices/bus/a2bus/pc_xporter.cpp | 36 ++++++------ src/devices/bus/a2bus/prodosromdrive.cpp | 2 +- src/devices/bus/a2bus/suprterminal.cpp | 2 +- src/devices/bus/a2bus/titan3plus2.h | 2 +- src/devices/bus/a2bus/transwarp.h | 6 +- src/devices/bus/a2gameio/computereyes.cpp | 4 +- src/devices/bus/abcbus/db4106.h | 2 +- src/devices/bus/abcbus/db4107.h | 2 +- src/devices/bus/abcbus/db4112.h | 2 +- src/devices/bus/abcbus/unidisk.h | 2 +- src/devices/bus/acorn/system/cass.h | 6 +- src/devices/bus/adb/a9m0330.h | 6 +- src/devices/bus/adb/adbhle.h | 2 +- src/devices/bus/apricot/video/mono.h | 6 +- src/devices/bus/astrocde/accessory.h | 2 +- src/devices/bus/astrocde/cassette.h | 10 ++-- src/devices/bus/ata/atapicdr.h | 2 +- src/devices/bus/ata/cr589.h | 6 +- src/devices/bus/ata/idehd.h | 6 +- src/devices/bus/bbc/1mhzbus/scsi.h | 4 +- src/devices/bus/bbc/fdc/acorn.h | 2 +- src/devices/bus/bbc/fdc/cumana.h | 4 +- src/devices/bus/bbc/internal/aries.h | 8 +-- src/devices/bus/bbc/internal/atpl.h | 4 +- src/devices/bus/bbc/internal/overlay.h | 2 +- src/devices/bus/bbc/internal/peartree.h | 4 +- src/devices/bus/bbc/internal/raven20.h | 2 +- src/devices/bus/bbc/internal/romex.h | 2 +- src/devices/bus/bbc/internal/stl4m32.h | 6 +- src/devices/bus/bbc/internal/stlswr.h | 4 +- src/devices/bus/bbc/internal/we32kram.h | 2 +- src/devices/bus/bbc/internal/werom.h | 2 +- src/devices/bus/bbc/internal/weromram.h | 4 +- src/devices/bus/bbc/modem/scsiaiv.h | 4 +- src/devices/bus/bbc/rom/slot.h | 4 +- src/devices/bus/bbc/tube/tube_rc6502.h | 8 +-- src/devices/bus/bbc/userport/usersplit.h | 2 +- src/devices/bus/bml3/bml3mp1805.h | 2 +- src/devices/bus/bml3/bml3rtc.h | 4 +- src/devices/bus/c64/dela_ep256.h | 4 +- src/devices/bus/c64/dela_ep7x8.h | 2 +- src/devices/bus/c64/rex_ep256.h | 4 +- src/devices/bus/cbus/pc9801_118.h | 2 +- src/devices/bus/cbus/pc9801_26.h | 2 +- src/devices/bus/cbus/pc9801_86.h | 10 ++-- src/devices/bus/cbus/pc9801_amd98.h | 2 +- src/devices/bus/cbus/pc9801_snd.h | 4 +- src/devices/bus/centronics/epson_lx810l.h | 2 +- src/devices/bus/centronics/printer.h | 4 +- src/devices/bus/coco/coco_fdc.h | 6 +- src/devices/bus/coco/coco_psg.h | 4 +- src/devices/bus/coco/coco_ssc.cpp | 12 ++-- src/devices/bus/compis/hrg.h | 2 +- src/devices/bus/compucolor/floppy.h | 2 +- src/devices/bus/electron/cart/peg400.h | 2 +- src/devices/bus/electron/cart/romp144.h | 4 +- src/devices/bus/gba/gba_slot.h | 4 +- src/devices/bus/gba/rom.h | 6 +- src/devices/bus/gio64/gio64.h | 2 +- src/devices/bus/gio64/newport.h | 54 ++++++++--------- src/devices/bus/hexbus/hexbus.h | 2 +- src/devices/bus/hexbus/hx5102.h | 8 +-- src/devices/bus/hp80_io/82900.h | 4 +- src/devices/bus/hp9845_io/98032.h | 24 ++++---- src/devices/bus/hp9845_io/98035.h | 44 +++++++------- src/devices/bus/hp9845_io/hp9885.h | 48 ++++++++-------- src/devices/bus/hp_dio/hp98550.h | 2 +- src/devices/bus/hp_dio/hp98603a.h | 2 +- src/devices/bus/hp_dio/hp98643.h | 4 +- src/devices/bus/hp_dio/hp_dio.h | 2 +- src/devices/bus/hp_hil/hp_hil.h | 2 +- src/devices/bus/ieee488/grid2102.h | 16 +++--- src/devices/bus/ieee488/remote488.h | 44 +++++++------- src/devices/bus/interpro/keyboard/lle.h | 12 ++-- src/devices/bus/interpro/sr/edge.h | 38 ++++++------ src/devices/bus/interpro/sr/gt.h | 68 +++++++++++----------- src/devices/bus/intv_ctrl/ecs_ctrl.h | 2 +- src/devices/bus/isa/3c503.h | 26 ++++----- src/devices/bus/isa/chessmdr.h | 2 +- src/devices/bus/isa/chessmsr.h | 6 +- src/devices/bus/isa/ega.h | 40 ++++++------- src/devices/bus/isa/eis_hgb107x.h | 10 ++-- src/devices/bus/isa/ex1280.h | 2 +- src/devices/bus/isa/fdc.h | 4 +- src/devices/bus/isa/finalchs.h | 2 +- src/devices/bus/isa/mach32.h | 26 ++++----- src/devices/bus/isa/mcd.h | 44 +++++++------- src/devices/bus/isa/myb3k_com.h | 4 +- src/devices/bus/isa/myb3k_fdc.h | 6 +- src/devices/bus/isa/p1_sound.h | 4 +- src/devices/bus/isa/pgc.h | 6 +- src/devices/bus/isa/s3virge.h | 72 +++++++++++------------ src/devices/bus/isa/sblaster.h | 50 ++++++++-------- src/devices/bus/isa/svga_s3.h | 6 +- src/devices/bus/isa/trident.h | 56 +++++++++--------- src/devices/bus/isbx/isbc_218a.h | 2 +- src/devices/bus/lpci/i82439tx.h | 14 ++--- src/devices/bus/lpci/southbridge.h | 2 +- src/devices/bus/mc10/mcx128.cpp | 4 +- src/devices/bus/megadrive/eeprom.h | 26 ++++----- src/devices/bus/megadrive/rom.h | 2 +- src/devices/bus/msx_slot/ram_mm.h | 2 +- src/devices/bus/multibus/isbc202.h | 52 ++++++++--------- src/devices/bus/neogeo/boot_kof10th.h | 8 +-- src/devices/bus/neogeo/prot_kof2k3bl.h | 6 +- src/devices/bus/neogeo/slot.h | 2 +- src/devices/bus/neogeo_ctrl/kizuna4p.h | 2 +- src/devices/bus/nes/disksys.h | 2 +- src/devices/bus/nes/jy.h | 38 ++++++------ src/devices/bus/nes/kaiser.h | 16 +++--- src/devices/bus/nes/mmc3_clones.h | 4 +- src/devices/bus/nes/nes_slot.h | 6 +- src/devices/bus/nes/pirate.h | 12 ++-- src/devices/bus/nes/vrc_clones.h | 6 +- src/devices/bus/newbrain/fdc.h | 12 ++-- src/devices/bus/nscsi/cd.h | 12 ++-- src/devices/bus/nscsi/cw7501.h | 2 +- src/devices/bus/nubus/laserview.h | 4 +- src/devices/bus/nubus/nubus_image.h | 8 +-- src/devices/bus/pc_kbd/pcat101.h | 4 +- src/devices/bus/pce/pce_rom.h | 2 +- src/devices/bus/pofo/hpc102.h | 2 +- src/devices/bus/pofo/hpc104.h | 4 +- src/devices/bus/qbus/dvk_kgd.h | 10 ++-- src/devices/bus/qbus/pc11.h | 16 +++--- src/devices/bus/rs232/mboardd.cpp | 4 +- src/devices/bus/rtpc/kbd.h | 8 +-- src/devices/bus/sat_ctrl/ctrl.h | 2 +- src/devices/bus/sbus/cgsix.h | 56 +++++++++--------- src/devices/bus/sbus/sbus.h | 6 +- src/devices/bus/scsi/omti5100.h | 2 +- src/devices/bus/scsi/scsi.h | 2 +- src/devices/bus/scsi/scsicd512.h | 2 +- src/devices/bus/sega8/rom.h | 8 +-- src/devices/bus/sg1000_exp/sg1000exp.h | 2 +- src/devices/bus/snes/sa1.h | 4 +- src/devices/bus/snes/sdd1.h | 14 ++--- src/devices/bus/spectrum/beta.h | 6 +- src/devices/bus/spectrum/d40.h | 6 +- src/devices/bus/spectrum/kempdisc.h | 4 +- src/devices/bus/spectrum/lprint.h | 16 +++--- src/devices/bus/spectrum/mface.h | 14 ++--- src/devices/bus/spectrum/mgt.h | 2 +- src/devices/bus/spectrum/sixword.h | 8 +-- src/devices/bus/ss50/piaide.cpp | 4 +- src/devices/bus/tanbus/radisc.h | 4 +- src/devices/bus/tanbus/tanbus.h | 2 +- src/devices/bus/ti99/gromport/cartridges.h | 6 +- src/devices/bus/ti99/gromport/gromport.h | 2 +- src/devices/bus/ti99/gromport/multiconn.h | 4 +- src/devices/bus/ti99/internal/998board.h | 6 +- src/devices/bus/ti99/internal/genkbd.h | 26 ++++----- src/devices/bus/ti99/peb/bwg.h | 2 +- src/devices/bus/ti99/peb/cc_fdc.h | 2 +- src/devices/bus/ti99/peb/evpc.h | 12 ++-- src/devices/bus/ti99/peb/hfdc.h | 4 +- src/devices/bus/ti99/peb/horizon.h | 4 +- src/devices/bus/ti99/peb/memex.h | 2 +- src/devices/bus/ti99/peb/myarcfdc.h | 2 +- src/devices/bus/ti99/peb/peribox.h | 2 +- src/devices/bus/ti99/peb/pgram.h | 6 +- src/devices/bus/ti99/peb/scsicard.h | 6 +- src/devices/bus/ti99/peb/ti_fdc.h | 4 +- src/devices/bus/ti99/peb/tipi.h | 20 +++---- src/devices/bus/ti99/peb/tn_ide.h | 4 +- src/devices/bus/tmc600/euro.h | 2 +- src/devices/bus/vcs/dpc.h | 14 ++--- src/devices/bus/vme/vme.h | 10 ++-- src/devices/bus/vme/vme_cp31.h | 8 +-- src/devices/bus/vme/vme_fccpu20.h | 8 +-- src/devices/bus/vme/vme_fcisio.h | 2 +- src/devices/bus/vme/vme_fcscsi.h | 6 +- src/devices/bus/vme/vme_hcpu30.h | 14 ++--- src/devices/bus/vsmile/rom.h | 2 +- src/devices/bus/vtech/ioexp/ioexp.h | 2 +- src/devices/bus/vtech/memexp/memexp.h | 2 +- src/devices/bus/wswan/rom.h | 18 +++--- src/devices/machine/53c810.h | 60 +++++++++---------- src/devices/machine/68340ser.h | 10 ++-- src/devices/machine/acorn_memc.h | 40 ++++++------- src/devices/machine/acorn_vidc.h | 12 ++-- src/devices/machine/adc083x.h | 2 +- src/devices/machine/adc1213x.h | 22 +++---- src/devices/machine/aic6250.h | 48 ++++++++-------- src/devices/machine/am9517a.h | 38 ++++++------ src/devices/machine/appldriv.h | 8 +-- src/devices/machine/applefdc.h | 10 ++-- src/devices/machine/at28c16.h | 2 +- src/devices/machine/at28c64b.h | 2 +- src/devices/machine/at29x.h | 30 +++++----- src/devices/machine/at45dbxx.h | 38 ++++++------ src/devices/machine/ataflash.h | 8 +-- src/devices/machine/bl_handhelds_menucontrol.h | 14 ++--- src/devices/machine/bq4847.h | 2 +- src/devices/machine/cop452.h | 24 ++++---- src/devices/machine/corvushd.h | 8 +-- src/devices/machine/cs8221.h | 6 +- src/devices/machine/dp8573.h | 10 ++-- src/devices/machine/ds1302.h | 26 ++++----- src/devices/machine/ds1994.h | 2 +- src/devices/machine/ds2404.h | 2 +- src/devices/machine/ds6417.h | 26 ++++----- src/devices/machine/edlc.h | 30 +++++----- src/devices/machine/eepromser.h | 8 +-- src/devices/machine/er1400.h | 2 +- src/devices/machine/f3853.h | 6 +- src/devices/machine/generalplus_gpl16250soc.h | 80 +++++++++++++------------- src/devices/machine/glukrs.h | 2 +- src/devices/machine/gt64xxx.h | 2 +- src/devices/machine/gt913_io.h | 14 ++--- src/devices/machine/gt913_snd.h | 2 +- src/devices/machine/i82439hx.h | 12 ++-- src/devices/machine/i8251.h | 42 +++++++------- src/devices/machine/i82586.h | 8 +-- src/devices/machine/i82875p.h | 14 ++--- src/devices/machine/ie15.h | 40 ++++++------- src/devices/machine/ie15_kbd.h | 4 +- src/devices/machine/im6402.h | 28 ++++----- src/devices/machine/ins8250.h | 18 +++--- src/devices/machine/iopcdvd.h | 10 ++-- src/devices/machine/iopdma.h | 10 ++-- src/devices/machine/iopintc.h | 6 +- src/devices/machine/iopsio2.h | 28 ++++----- src/devices/machine/iwm.h | 18 +++--- src/devices/machine/k054321.h | 4 +- src/devices/machine/laserdsc.h | 2 +- src/devices/machine/ldp1000.h | 12 ++-- src/devices/machine/ldp1450.h | 22 +++---- src/devices/machine/ldpr8210.h | 18 +++--- src/devices/machine/locomo.h | 8 +-- src/devices/machine/lpc-acpi.h | 10 ++-- src/devices/machine/lpci.h | 10 ++-- src/devices/machine/m950x0.h | 6 +- src/devices/machine/mb87030.h | 52 ++++++++--------- src/devices/machine/mc14411.h | 6 +- src/devices/machine/mc68681.h | 20 +++---- src/devices/machine/mcf5206e.h | 36 ++++++------ src/devices/machine/mm58174.h | 28 ++++----- src/devices/machine/mm58274c.cpp | 2 +- src/devices/machine/mm58274c.h | 40 ++++++------- src/devices/machine/mos6526.h | 52 ++++++++--------- src/devices/machine/msm6242.h | 12 ++-- src/devices/machine/myb3k_kbd.h | 6 +- src/devices/machine/ncr5380.h | 20 +++---- src/devices/machine/ncr5390.h | 4 +- src/devices/machine/nmc9306.h | 20 +++---- src/devices/machine/ns32081.h | 22 +++---- src/devices/machine/ns32082.h | 18 +++--- src/devices/machine/ns32382.h | 32 +++++------ src/devices/machine/nscsi_bus.h | 20 +++---- src/devices/machine/pcf8593.h | 22 +++---- src/devices/machine/pci-smbus.h | 8 +-- src/devices/machine/pci.h | 16 +++--- src/devices/machine/pckeybrd.h | 2 +- src/devices/machine/pit8253.h | 50 ++++++++-------- src/devices/machine/ps2dma.h | 16 +++--- src/devices/machine/ps2intc.h | 4 +- src/devices/machine/ps2mc.h | 22 +++---- src/devices/machine/ps2pad.h | 18 +++--- src/devices/machine/ps2sif.h | 12 ++-- src/mame/drivers/s7.cpp | 1 - 271 files changed, 1615 insertions(+), 1616 deletions(-) diff --git a/src/devices/bus/a2bus/a2echoii.cpp b/src/devices/bus/a2bus/a2echoii.cpp index 1af618a1017..604dc7ae1c6 100644 --- a/src/devices/bus/a2bus/a2echoii.cpp +++ b/src/devices/bus/a2bus/a2echoii.cpp @@ -72,9 +72,9 @@ protected: private: //DECLARE_WRITE_LINE_MEMBER(tms_irq_callback); DECLARE_WRITE_LINE_MEMBER(tms_readyq_callback); - uint8_t m_writelatch_data = 0; // 74ls373 latch - bool m_readlatch_flag = false; // 74c74 1st half - bool m_writelatch_flag = false; // 74c74 2nd half + uint8_t m_writelatch_data; // 74ls373 latch + bool m_readlatch_flag; // 74c74 1st half + bool m_writelatch_flag; // 74c74 2nd half }; /*************************************************************************** diff --git a/src/devices/bus/a2bus/a2hsscsi.h b/src/devices/bus/a2bus/a2hsscsi.h index 4a7e36c84aa..be200ccde0d 100644 --- a/src/devices/bus/a2bus/a2hsscsi.h +++ b/src/devices/bus/a2bus/a2hsscsi.h @@ -57,7 +57,7 @@ private: int m_rambank, m_rombank; uint8_t m_drq; uint8_t m_bank; - uint8_t m_dma_control = 0; + uint8_t m_dma_control; uint8_t m_c0ne, m_c0nf; uint16_t m_dma_addr, m_dma_size; }; diff --git a/src/devices/bus/a2bus/a2iwm.h b/src/devices/bus/a2bus/a2iwm.h index 69a738cfdbc..3f0fe974d3a 100644 --- a/src/devices/bus/a2bus/a2iwm.h +++ b/src/devices/bus/a2bus/a2iwm.h @@ -64,7 +64,7 @@ public: virtual uint8_t read_cnxx(uint8_t offset) override; private: - uint8_t *m_rom = nullptr; + uint8_t *m_rom; }; // device type definition diff --git a/src/devices/bus/a2bus/a2mockingboard.cpp b/src/devices/bus/a2bus/a2mockingboard.cpp index 458e553d480..0968d55c9a0 100644 --- a/src/devices/bus/a2bus/a2mockingboard.cpp +++ b/src/devices/bus/a2bus/a2mockingboard.cpp @@ -92,8 +92,8 @@ protected: private: DECLARE_WRITE_LINE_MEMBER(write_via1_cb2); - u8 m_portb1 = 0; - int m_last_cb2_state = 0; + u8 m_portb1; + int m_last_cb2_state; }; class a2bus_phasor_device : public a2bus_ayboard_device diff --git a/src/devices/bus/a2bus/a2sd.h b/src/devices/bus/a2bus/a2sd.h index 1b675934bcc..85165248319 100644 --- a/src/devices/bus/a2bus/a2sd.h +++ b/src/devices/bus/a2bus/a2sd.h @@ -58,7 +58,7 @@ private: int m_in_bit; int m_shift_count; - emu_timer *m_shift_timer = nullptr; + emu_timer *m_shift_timer; }; // device type definition diff --git a/src/devices/bus/a2bus/agat7langcard.h b/src/devices/bus/a2bus/agat7langcard.h index 97729969260..e7dae54ebfb 100644 --- a/src/devices/bus/a2bus/agat7langcard.h +++ b/src/devices/bus/a2bus/agat7langcard.h @@ -49,7 +49,7 @@ private: int m_dxxx_bank; int m_main_bank; uint8_t m_ram[32 * 1024]; - uint8_t m_mode = 0; + uint8_t m_mode; uint8_t m_csr; }; diff --git a/src/devices/bus/a2bus/agat7ports.h b/src/devices/bus/a2bus/agat7ports.h index 7d1a2e512fc..2ee4f38b4dd 100644 --- a/src/devices/bus/a2bus/agat7ports.h +++ b/src/devices/bus/a2bus/agat7ports.h @@ -55,7 +55,7 @@ protected: DECLARE_WRITE_LINE_MEMBER(write_centronics_busy); private: - bool m_centronics_busy = false; + bool m_centronics_busy; }; // device type definition diff --git a/src/devices/bus/a2bus/agat840k_hle.h b/src/devices/bus/a2bus/agat840k_hle.h index c655f2c28d0..f51bda3324f 100644 --- a/src/devices/bus/a2bus/agat840k_hle.h +++ b/src/devices/bus/a2bus/agat840k_hle.h @@ -75,21 +75,21 @@ protected: required_device m_d15; private: - legacy_floppy_image_device *m_floppy = nullptr; - bool m_side = false; + legacy_floppy_image_device *m_floppy; + bool m_side; std::unique_ptr m_tracks[160]; - int m_count_read = 0; - int m_count_write = 0; - bool m_seen_magic = false; - int m_current_track = 0; + int m_count_read; + int m_count_write; + bool m_seen_magic; + int m_current_track; - u8 m_mxcs = 0; - int m_unit = 0; - int m_state = 0; + u8 m_mxcs; + int m_unit; + int m_state; - int m_seektime = 0; - int m_waittime = 0; + int m_seektime; + int m_waittime; emu_timer *m_timer_wait = nullptr; emu_timer *m_timer_seek = nullptr; diff --git a/src/devices/bus/a2bus/agat_fdc.h b/src/devices/bus/a2bus/agat_fdc.h index 3bfc413c188..e209902c709 100644 --- a/src/devices/bus/a2bus/agat_fdc.h +++ b/src/devices/bus/a2bus/agat_fdc.h @@ -78,22 +78,22 @@ private: void lss_start(); void lss_sync(); - floppy_image_device *floppy = nullptr; - int active = 0, bits = 0; - uint8_t data_reg = 0; - uint16_t address = 0; - uint64_t cycles = 0; - - u8 m_mxcs = 0; - int m_unit = 0; - int m_state = 0; - - int m_seektime = 0; - int m_waittime = 0; - - emu_timer *m_timer_lss = nullptr; - emu_timer *m_timer_seek = nullptr; - emu_timer *m_timer_motor = nullptr; + floppy_image_device *floppy; + int active, bits; + uint8_t data_reg; + uint16_t address; + uint64_t cycles; + + u8 m_mxcs; + int m_unit; + int m_state; + + int m_seektime; + int m_waittime; + + emu_timer *m_timer_lss; + emu_timer *m_timer_seek; + emu_timer *m_timer_motor; uint8_t *m_rom; uint8_t *m_rom_d6; diff --git a/src/devices/bus/a2bus/computereyes2.cpp b/src/devices/bus/a2bus/computereyes2.cpp index c0d3acf99a4..979472d00ef 100644 --- a/src/devices/bus/a2bus/computereyes2.cpp +++ b/src/devices/bus/a2bus/computereyes2.cpp @@ -43,10 +43,10 @@ protected: private: required_device m_picture; - int m_x = 0, m_y = 0, m_cer0 = 0, m_cer1 = 0, m_cer2 = 0; - u8 m_a2_bitmap[280*193]{}; - u8 m_threshold = 0; - bool m_bActive = false; + int m_x, m_y, m_cer0, m_cer1, m_cer2; + u8 m_a2_bitmap[280*193]; + u8 m_threshold; + bool m_bActive; }; /*************************************************************************** diff --git a/src/devices/bus/a2bus/pc_xporter.cpp b/src/devices/bus/a2bus/pc_xporter.cpp index 44733738da7..06a87cc1820 100644 --- a/src/devices/bus/a2bus/pc_xporter.cpp +++ b/src/devices/bus/a2bus/pc_xporter.cpp @@ -135,24 +135,24 @@ private: required_device m_isabus; optional_device m_pc_kbdc; - uint8_t m_u73_q2 = 0; - uint8_t m_out1 = 0; - int m_dma_channel = 0; - uint8_t m_dma_offset[4]{}; - uint8_t m_pc_spkrdata = 0; - uint8_t m_pit_out2 = 0; - bool m_cur_eop = false; - - uint8_t m_nmi_enabled = 0; - - uint8_t m_ram[768*1024]{}; - uint8_t m_c800_ram[0x400]{}; - uint8_t m_regs[0x400]{}; - uint32_t m_offset = 0; - address_space *m_pcmem_space = nullptr, *m_pcio_space = nullptr; - bool m_reset_during_halt = false; - - uint8_t m_6845_reg = 0; + uint8_t m_u73_q2; + uint8_t m_out1; + int m_dma_channel; + uint8_t m_dma_offset[4]; + uint8_t m_pc_spkrdata; + uint8_t m_pit_out2; + bool m_cur_eop; + + uint8_t m_nmi_enabled; + + uint8_t m_ram[768*1024]; + uint8_t m_c800_ram[0x400]; + uint8_t m_regs[0x400]; + uint32_t m_offset; + address_space *m_pcmem_space, *m_pcio_space; + bool m_reset_during_halt; + + uint8_t m_6845_reg; // interface to the keyboard DECLARE_WRITE_LINE_MEMBER( keyboard_clock_w ); diff --git a/src/devices/bus/a2bus/prodosromdrive.cpp b/src/devices/bus/a2bus/prodosromdrive.cpp index f4d442b85a0..d9275384a00 100644 --- a/src/devices/bus/a2bus/prodosromdrive.cpp +++ b/src/devices/bus/a2bus/prodosromdrive.cpp @@ -49,7 +49,7 @@ protected: private: required_region_ptr m_rom; - u16 m_latch = 0; + u16 m_latch; }; //************************************************************************** diff --git a/src/devices/bus/a2bus/suprterminal.cpp b/src/devices/bus/a2bus/suprterminal.cpp index e1d38179a58..796937bebcb 100644 --- a/src/devices/bus/a2bus/suprterminal.cpp +++ b/src/devices/bus/a2bus/suprterminal.cpp @@ -74,7 +74,7 @@ private: std::unique_ptr m_vram; std::unique_ptr m_fontram; // u8 m_fontram[0x400]; - bool m_bRasterRAM = false, m_bCharBank1 = false, m_bC800IsRAM = false; + bool m_bRasterRAM, m_bCharBank1, m_bC800IsRAM; }; //------------------------------------------------- diff --git a/src/devices/bus/a2bus/titan3plus2.h b/src/devices/bus/a2bus/titan3plus2.h index 7b67b4a87ef..f162f115d8e 100644 --- a/src/devices/bus/a2bus/titan3plus2.h +++ b/src/devices/bus/a2bus/titan3plus2.h @@ -55,7 +55,7 @@ private: u8 m_ram[128*1024]; bool m_enabled; - double m_joystick_x1_time = 0, m_joystick_y1_time = 0, m_joystick_x2_time = 0, m_joystick_y2_time = 0, m_x_calibration = 0, m_y_calibration = 0; + double m_joystick_x1_time, m_joystick_y1_time, m_joystick_x2_time, m_joystick_y2_time, m_x_calibration, m_y_calibration; }; // device type definition diff --git a/src/devices/bus/a2bus/transwarp.h b/src/devices/bus/a2bus/transwarp.h index f2b089b1b0b..1401f61776b 100644 --- a/src/devices/bus/a2bus/transwarp.h +++ b/src/devices/bus/a2bus/transwarp.h @@ -41,9 +41,9 @@ protected: private: bool m_bEnabled; - bool m_bReadA2ROM = false; - bool m_bIn1MHzMode = false; - emu_timer *m_timer = nullptr; + bool m_bReadA2ROM; + bool m_bIn1MHzMode; + emu_timer *m_timer; required_device m_ourcpu; required_region_ptr m_rom; diff --git a/src/devices/bus/a2gameio/computereyes.cpp b/src/devices/bus/a2gameio/computereyes.cpp index 2130e0b66de..38b100586e4 100644 --- a/src/devices/bus/a2gameio/computereyes.cpp +++ b/src/devices/bus/a2gameio/computereyes.cpp @@ -40,8 +40,8 @@ protected: private: required_device m_picture; - int m_x = 0, m_y = 0, m_an1 = 0, m_an2 = 0, m_an3 = 0, m_level = 0; - u8 m_a2_bitmap[280*192]{}; + int m_x, m_y, m_an1, m_an2, m_an3, m_level; + u8 m_a2_bitmap[280*192]; }; //************************************************************************** diff --git a/src/devices/bus/abcbus/db4106.h b/src/devices/bus/abcbus/db4106.h index 1ae560915a4..74e49631dbe 100644 --- a/src/devices/bus/abcbus/db4106.h +++ b/src/devices/bus/abcbus/db4106.h @@ -50,7 +50,7 @@ protected: private: required_device m_maincpu; - bool m_cs = false; + bool m_cs; void databoard_4106_io(address_map &map); void databoard_4106_mem(address_map &map); diff --git a/src/devices/bus/abcbus/db4107.h b/src/devices/bus/abcbus/db4107.h index 20c381e7d53..4ae301084ca 100644 --- a/src/devices/bus/abcbus/db4107.h +++ b/src/devices/bus/abcbus/db4107.h @@ -52,7 +52,7 @@ private: required_device m_maincpu; required_device m_dma; - bool m_cs = false; + bool m_cs; void databoard_4107_io(address_map &map); void databoard_4107_mem(address_map &map); diff --git a/src/devices/bus/abcbus/db4112.h b/src/devices/bus/abcbus/db4112.h index fecb82a7a14..c28da004297 100644 --- a/src/devices/bus/abcbus/db4112.h +++ b/src/devices/bus/abcbus/db4112.h @@ -50,7 +50,7 @@ protected: private: required_device m_maincpu; - bool m_cs = false; + bool m_cs; void databoard_4112_io(address_map &map); void databoard_4112_mem(address_map &map); diff --git a/src/devices/bus/abcbus/unidisk.h b/src/devices/bus/abcbus/unidisk.h index 3f8f96c36ae..6d95e34208e 100644 --- a/src/devices/bus/abcbus/unidisk.h +++ b/src/devices/bus/abcbus/unidisk.h @@ -50,7 +50,7 @@ protected: private: required_device m_maincpu; - bool m_cs = false; + bool m_cs; void unidisk_io(address_map &map); void unidisk_mem(address_map &map); diff --git a/src/devices/bus/acorn/system/cass.h b/src/devices/bus/acorn/system/cass.h index 942dab48e23..02a323bb994 100644 --- a/src/devices/bus/acorn/system/cass.h +++ b/src/devices/bus/acorn/system/cass.h @@ -44,9 +44,9 @@ private: required_device m_cass; - uint8_t m_cass_data[4]{}; - bool m_cass_state = false; - bool m_cassold = false; + uint8_t m_cass_data[4]; + bool m_cass_state; + bool m_cassold; }; diff --git a/src/devices/bus/adb/a9m0330.h b/src/devices/bus/adb/a9m0330.h index a8c334ebc17..1d44a28bba8 100644 --- a/src/devices/bus/adb/a9m0330.h +++ b/src/devices/bus/adb/a9m0330.h @@ -38,9 +38,9 @@ private: DECLARE_READ_LINE_MEMBER(t0_r); DECLARE_READ_LINE_MEMBER(t1_r); - int m_adb_state = 0; - int m_kbd_row = 0; - int m_our_last_adb_state = 0; + int m_adb_state; + int m_kbd_row; + int m_our_last_adb_state; }; DECLARE_DEVICE_TYPE(ADB_A9M0330, a9m0330_device) diff --git a/src/devices/bus/adb/adbhle.h b/src/devices/bus/adb/adbhle.h index 2cd722b1975..24dff3ad2fe 100644 --- a/src/devices/bus/adb/adbhle.h +++ b/src/devices/bus/adb/adbhle.h @@ -24,7 +24,7 @@ protected: virtual void adb_w(int state) override; private: - bool m_last_state = false; + bool m_last_state; attotime m_last_state_time; }; diff --git a/src/devices/bus/apricot/video/mono.h b/src/devices/bus/apricot/video/mono.h index 29baa17c453..36885bcb768 100644 --- a/src/devices/bus/apricot/video/mono.h +++ b/src/devices/bus/apricot/video/mono.h @@ -54,9 +54,9 @@ private: std::unique_ptr m_vram; - uint8_t m_portb = 0; - uint8_t m_portc = 0; - uint8_t m_portx = 0; + uint8_t m_portb; + uint8_t m_portc; + uint8_t m_portx; }; // device type definition diff --git a/src/devices/bus/astrocde/accessory.h b/src/devices/bus/astrocde/accessory.h index ce72cf9d24d..5386cd1362a 100644 --- a/src/devices/bus/astrocde/accessory.h +++ b/src/devices/bus/astrocde/accessory.h @@ -73,7 +73,7 @@ protected: virtual void interface_pre_start() override; void set_screen(screen_device *screen) { m_screen = screen; } - screen_device *m_screen = nullptr; + screen_device *m_screen; private: astrocade_accessory_port_device *const m_port; diff --git a/src/devices/bus/astrocde/cassette.h b/src/devices/bus/astrocde/cassette.h index 06a116fe18a..d36e8a1bfd7 100644 --- a/src/devices/bus/astrocde/cassette.h +++ b/src/devices/bus/astrocde/cassette.h @@ -43,11 +43,11 @@ protected: private: required_device m_cassette; - double m_cass_wave = 0; - double m_cass_delta = 0; - uint32_t m_cass_wave_ticks = 0; - uint32_t m_cass_cycles = 0; - bool m_cass_mark = false; + double m_cass_wave; + double m_cass_delta; + uint32_t m_cass_wave_ticks; + uint32_t m_cass_cycles; + bool m_cass_mark; std::queue m_cass_data; }; diff --git a/src/devices/bus/ata/atapicdr.h b/src/devices/bus/ata/atapicdr.h index 5a164da35cc..c2ffbb92fee 100644 --- a/src/devices/bus/ata/atapicdr.h +++ b/src/devices/bus/ata/atapicdr.h @@ -37,7 +37,7 @@ protected: virtual void identify_packet_device() override; virtual void process_buffer() override; virtual void ExecCommand() override; - bool m_media_change = false; + bool m_media_change; uint16_t ultra_dma_mode; }; diff --git a/src/devices/bus/ata/cr589.h b/src/devices/bus/ata/cr589.h index 9c1f629cd8f..9b2f89d172c 100644 --- a/src/devices/bus/ata/cr589.h +++ b/src/devices/bus/ata/cr589.h @@ -38,9 +38,9 @@ protected: virtual bool nvram_write(util::write_stream &file) override; private: - int download = 0; - uint8_t buffer[ 65536 ]{}; - int bufferOffset = 0; + int download; + uint8_t buffer[ 65536 ]; + int bufferOffset; }; // device type definition diff --git a/src/devices/bus/ata/idehd.h b/src/devices/bus/ata/idehd.h index 23ca61b8b7a..4eb0edd3671 100644 --- a/src/devices/bus/ata/idehd.h +++ b/src/devices/bus/ata/idehd.h @@ -106,8 +106,8 @@ protected: virtual int write_sector(uint32_t lba, const void *buffer) override { return !m_disk ? 0 : m_disk->write(lba, buffer); } virtual uint8_t calculate_status() override; - chd_file *m_handle = nullptr; - hard_disk_file *m_disk = nullptr; + chd_file *m_handle; + hard_disk_file *m_disk; enum { @@ -117,7 +117,7 @@ protected: private: required_device m_image; - emu_timer * m_last_status_timer = nullptr; + emu_timer * m_last_status_timer; }; // device type definition diff --git a/src/devices/bus/bbc/1mhzbus/scsi.h b/src/devices/bus/bbc/1mhzbus/scsi.h index 57f2dc432f8..8a4dabbe113 100644 --- a/src/devices/bus/bbc/1mhzbus/scsi.h +++ b/src/devices/bus/bbc/1mhzbus/scsi.h @@ -44,8 +44,8 @@ protected: private: required_device m_scsi; - int m_irq_enable = 0; - int m_irq_state = 0; + int m_irq_enable; + int m_irq_state; }; diff --git a/src/devices/bus/bbc/fdc/acorn.h b/src/devices/bus/bbc/fdc/acorn.h index 6bb0e335b57..347368ff29f 100644 --- a/src/devices/bus/bbc/fdc/acorn.h +++ b/src/devices/bus/bbc/fdc/acorn.h @@ -79,7 +79,7 @@ private: required_device m_fdc; required_device_array m_floppy; - int m_fdc_ie = 0; + int m_fdc_ie; }; diff --git a/src/devices/bus/bbc/fdc/cumana.h b/src/devices/bus/bbc/fdc/cumana.h index 83ad6ca453e..d775a68e622 100644 --- a/src/devices/bus/bbc/fdc/cumana.h +++ b/src/devices/bus/bbc/fdc/cumana.h @@ -45,11 +45,11 @@ protected: required_device m_fdc; required_device_array m_floppy; - bool m_invert = false; + bool m_invert; private: int m_drive_control; - int m_fdc_ie = 0; + int m_fdc_ie; }; class bbc_cumana1_device : public bbc_cumanafdc_device diff --git a/src/devices/bus/bbc/internal/aries.h b/src/devices/bus/bbc/internal/aries.h index 6bae19cde89..9dc7383ff21 100644 --- a/src/devices/bus/bbc/internal/aries.h +++ b/src/devices/bus/bbc/internal/aries.h @@ -48,7 +48,7 @@ protected: optional_device_array m_rom; - uint8_t m_romsel = 0; + uint8_t m_romsel; }; @@ -73,7 +73,7 @@ protected: private: void control_w(offs_t offset, uint8_t data); - bool m_shadow = false; + bool m_shadow; std::unique_ptr m_ram; }; @@ -102,9 +102,9 @@ protected: private: required_memory_region m_aries_rom; - bool m_shadow = false; + bool m_shadow; std::unique_ptr m_ram; - uint8_t m_ramsel = 0; + uint8_t m_ramsel; }; diff --git a/src/devices/bus/bbc/internal/atpl.h b/src/devices/bus/bbc/internal/atpl.h index 0c0ebade65e..fe10ebb3a76 100644 --- a/src/devices/bus/bbc/internal/atpl.h +++ b/src/devices/bus/bbc/internal/atpl.h @@ -46,7 +46,7 @@ private: optional_device_array m_rom; required_ioport m_wp; - uint8_t m_romsel = 0; + uint8_t m_romsel; }; @@ -73,7 +73,7 @@ protected: private: optional_device_array m_rom; - uint8_t m_romsel = 0; + uint8_t m_romsel; }; diff --git a/src/devices/bus/bbc/internal/overlay.h b/src/devices/bus/bbc/internal/overlay.h index 9c667321ba3..3800687f5ac 100644 --- a/src/devices/bus/bbc/internal/overlay.h +++ b/src/devices/bus/bbc/internal/overlay.h @@ -46,7 +46,7 @@ private: required_device_array m_rom; required_ioport_array<3> m_link_rom; - uint8_t m_romsel = 0; + uint8_t m_romsel; }; diff --git a/src/devices/bus/bbc/internal/peartree.h b/src/devices/bus/bbc/internal/peartree.h index 4ba6573e9ab..9f9ed683396 100644 --- a/src/devices/bus/bbc/internal/peartree.h +++ b/src/devices/bus/bbc/internal/peartree.h @@ -43,7 +43,7 @@ protected: virtual uint8_t paged_r(offs_t offset) override; virtual void paged_w(offs_t offset, uint8_t data) override; - uint8_t m_romsel = 0; + uint8_t m_romsel; }; @@ -90,7 +90,7 @@ protected: virtual uint8_t paged_r(offs_t offset) override; virtual void paged_w(offs_t offset, uint8_t data) override; - uint8_t m_romsel = 0; + uint8_t m_romsel; }; diff --git a/src/devices/bus/bbc/internal/raven20.h b/src/devices/bus/bbc/internal/raven20.h index e716d617554..0e04137afa6 100644 --- a/src/devices/bus/bbc/internal/raven20.h +++ b/src/devices/bus/bbc/internal/raven20.h @@ -40,7 +40,7 @@ private: void enable_w(offs_t offset, uint8_t data); void disable_w(offs_t offset, uint8_t data); - bool m_shadow = false; + bool m_shadow; std::unique_ptr m_ram; }; diff --git a/src/devices/bus/bbc/internal/romex.h b/src/devices/bus/bbc/internal/romex.h index 59931349be7..b9542937ebf 100644 --- a/src/devices/bus/bbc/internal/romex.h +++ b/src/devices/bus/bbc/internal/romex.h @@ -42,7 +42,7 @@ protected: private: optional_device_array m_rom; - uint8_t m_romsel = 0; + uint8_t m_romsel; }; diff --git a/src/devices/bus/bbc/internal/stl4m32.h b/src/devices/bus/bbc/internal/stl4m32.h index 5ba7a2e38ee..ac939d6d4ff 100644 --- a/src/devices/bus/bbc/internal/stl4m32.h +++ b/src/devices/bus/bbc/internal/stl4m32.h @@ -54,9 +54,9 @@ protected: std::unique_ptr m_ram; - uint8_t m_romsel = 0; - uint8_t m_ramsel = 0; - uint8_t m_shadow = 0; + uint8_t m_romsel; + uint8_t m_ramsel; + uint8_t m_shadow; }; diff --git a/src/devices/bus/bbc/internal/stlswr.h b/src/devices/bus/bbc/internal/stlswr.h index b0779723412..db7e263ce28 100644 --- a/src/devices/bus/bbc/internal/stlswr.h +++ b/src/devices/bus/bbc/internal/stlswr.h @@ -44,8 +44,8 @@ protected: optional_device_array m_rom; - uint8_t m_romsel = 0; - uint8_t m_ramsel = 0; + uint8_t m_romsel; + uint8_t m_ramsel; }; diff --git a/src/devices/bus/bbc/internal/we32kram.h b/src/devices/bus/bbc/internal/we32kram.h index 65beb897ed5..aa10005292b 100644 --- a/src/devices/bus/bbc/internal/we32kram.h +++ b/src/devices/bus/bbc/internal/we32kram.h @@ -42,7 +42,7 @@ protected: private: void control_w(offs_t offset, uint8_t data); - uint8_t m_shadow = 0; + uint8_t m_shadow; std::unique_ptr m_ram; }; diff --git a/src/devices/bus/bbc/internal/werom.h b/src/devices/bus/bbc/internal/werom.h index 12c7e51febe..4e95ba120d8 100644 --- a/src/devices/bus/bbc/internal/werom.h +++ b/src/devices/bus/bbc/internal/werom.h @@ -37,7 +37,7 @@ protected: virtual bool overrides_rom() override { return true; } virtual void romsel_w(offs_t offset, uint8_t data) override { m_romsel = data & 0x0f; } - uint8_t m_romsel = 0; + uint8_t m_romsel; }; diff --git a/src/devices/bus/bbc/internal/weromram.h b/src/devices/bus/bbc/internal/weromram.h index 657eb712d62..b85c9d031ab 100644 --- a/src/devices/bus/bbc/internal/weromram.h +++ b/src/devices/bus/bbc/internal/weromram.h @@ -44,8 +44,8 @@ private: void ramsel_w(offs_t offset, uint8_t data); - uint8_t m_romsel = 0; - uint8_t m_ramsel = 0; + uint8_t m_romsel; + uint8_t m_ramsel; }; diff --git a/src/devices/bus/bbc/modem/scsiaiv.h b/src/devices/bus/bbc/modem/scsiaiv.h index c28a9578677..0b244bb71e3 100644 --- a/src/devices/bus/bbc/modem/scsiaiv.h +++ b/src/devices/bus/bbc/modem/scsiaiv.h @@ -44,8 +44,8 @@ protected: private: required_device m_scsi; - int m_irq_enable = 0; - int m_irq_state = 0; + int m_irq_enable; + int m_irq_state; }; diff --git a/src/devices/bus/bbc/rom/slot.h b/src/devices/bus/bbc/rom/slot.h index 6565b2799eb..986d796dd0d 100644 --- a/src/devices/bus/bbc/rom/slot.h +++ b/src/devices/bus/bbc/rom/slot.h @@ -58,7 +58,7 @@ protected: // device-level overrides virtual void device_start() override; - uint32_t m_slot_size = 0; + uint32_t m_slot_size; private: device_bbc_rom_interface* m_cart; @@ -136,7 +136,7 @@ public: protected: device_bbc_rom_interface(const machine_config &mconfig, device_t &device); - bbc_romslot_device *m_slot = nullptr; + bbc_romslot_device *m_slot; private: // internal state diff --git a/src/devices/bus/bbc/tube/tube_rc6502.h b/src/devices/bus/bbc/tube/tube_rc6502.h index 89e2949894f..5636e8694ef 100644 --- a/src/devices/bus/bbc/tube/tube_rc6502.h +++ b/src/devices/bus/bbc/tube/tube_rc6502.h @@ -66,10 +66,10 @@ protected: private: void tube_rc6502_mem(address_map &map); - uint8_t m_default = 0; - uint8_t m_divider = 0; - uint8_t m_banking = 0; - uint8_t m_banknum = 0; + uint8_t m_default; + uint8_t m_divider; + uint8_t m_banking; + uint8_t m_banknum; }; diff --git a/src/devices/bus/bbc/userport/usersplit.h b/src/devices/bus/bbc/userport/usersplit.h index c1da2da51f0..27ce11a9fde 100644 --- a/src/devices/bus/bbc/userport/usersplit.h +++ b/src/devices/bus/bbc/userport/usersplit.h @@ -50,7 +50,7 @@ private: DECLARE_WRITE_LINE_MEMBER(cb2b_w); required_device_array m_userport; - uint8_t m_selected = 0; + uint8_t m_selected; }; diff --git a/src/devices/bus/bml3/bml3mp1805.h b/src/devices/bus/bml3/bml3mp1805.h index 81709579e3a..f3c4de448d3 100644 --- a/src/devices/bus/bml3/bml3mp1805.h +++ b/src/devices/bus/bml3/bml3mp1805.h @@ -47,7 +47,7 @@ protected: private: uint8_t *m_rom; - uint8_t m_control = 0; + uint8_t m_control; static void floppy_drives(device_slot_interface &device); }; diff --git a/src/devices/bus/bml3/bml3rtc.h b/src/devices/bus/bml3/bml3rtc.h index 19f416bec27..16c6cbd0e9c 100644 --- a/src/devices/bus/bml3/bml3rtc.h +++ b/src/devices/bus/bml3/bml3rtc.h @@ -42,8 +42,8 @@ protected: private: required_device m_rtc; - uint8_t m_addr_latch = 0; - uint8_t m_data_latch = 0; + uint8_t m_addr_latch; + uint8_t m_data_latch; }; // device type definition diff --git a/src/devices/bus/c64/dela_ep256.h b/src/devices/bus/c64/dela_ep256.h index a412e903033..bb6806f4d8e 100644 --- a/src/devices/bus/c64/dela_ep256.h +++ b/src/devices/bus/c64/dela_ep256.h @@ -46,8 +46,8 @@ protected: private: required_device_array m_eproms; - uint8_t m_bank = 0, m_socket = 0; - int m_reset = 0; + uint8_t m_bank, m_socket; + int m_reset; }; diff --git a/src/devices/bus/c64/dela_ep7x8.h b/src/devices/bus/c64/dela_ep7x8.h index f39340a43a0..50e1b3af01e 100644 --- a/src/devices/bus/c64/dela_ep7x8.h +++ b/src/devices/bus/c64/dela_ep7x8.h @@ -46,7 +46,7 @@ protected: private: required_device_array m_eprom; - uint8_t m_bank = 0; + uint8_t m_bank; }; diff --git a/src/devices/bus/c64/rex_ep256.h b/src/devices/bus/c64/rex_ep256.h index 25198bd9ee1..e06a2c71d17 100644 --- a/src/devices/bus/c64/rex_ep256.h +++ b/src/devices/bus/c64/rex_ep256.h @@ -46,8 +46,8 @@ protected: private: required_device_array m_eproms; - uint8_t m_bank = 0, m_socket = 0; - int m_reset = 0; + uint8_t m_bank, m_socket; + int m_reset; }; diff --git a/src/devices/bus/cbus/pc9801_118.h b/src/devices/bus/cbus/pc9801_118.h index dace4e9496e..94ac3bfe24c 100644 --- a/src/devices/bus/cbus/pc9801_118.h +++ b/src/devices/bus/cbus/pc9801_118.h @@ -50,7 +50,7 @@ private: required_device m_bus; required_device m_opn3; - uint8_t m_ext_reg = 0; + uint8_t m_ext_reg; DECLARE_WRITE_LINE_MEMBER(sound_irq); }; diff --git a/src/devices/bus/cbus/pc9801_26.h b/src/devices/bus/cbus/pc9801_26.h index a7681395e3b..80cd57a20cd 100644 --- a/src/devices/bus/cbus/pc9801_26.h +++ b/src/devices/bus/cbus/pc9801_26.h @@ -46,7 +46,7 @@ private: required_device m_opn; DECLARE_WRITE_LINE_MEMBER(sound_irq); - u32 m_rom_base = 0; + u32 m_rom_base; }; diff --git a/src/devices/bus/cbus/pc9801_86.h b/src/devices/bus/cbus/pc9801_86.h index f3b6a2516ae..858a1193c75 100644 --- a/src/devices/bus/cbus/pc9801_86.h +++ b/src/devices/bus/cbus/pc9801_86.h @@ -57,19 +57,19 @@ protected: u8 pcm_r(offs_t offset); void pcm_w(offs_t offset, u8 data); - u8 m_mask = 0; + u8 m_mask; private: int queue_count(); u8 queue_pop(); - u8 m_pcm_mode = 0, m_vol[7]{}, m_pcm_ctrl = 0, m_pcm_mute = 0; - uint16_t m_head = 0, m_tail = 0, m_count = 0, m_irq_rate = 0; - bool m_pcmirq = 0, m_fmirq = 0, m_pcm_clk = 0, m_init = 0; + u8 m_pcm_mode, m_vol[7], m_pcm_ctrl, m_pcm_mute; + uint16_t m_head, m_tail, m_count, m_irq_rate; + bool m_pcmirq, m_fmirq, m_pcm_clk, m_init; required_device m_ldac; required_device m_rdac; std::vector m_queue; - emu_timer *m_dac_timer = nullptr; + emu_timer *m_dac_timer; }; class pc9801_speakboard_device : public pc9801_86_device diff --git a/src/devices/bus/cbus/pc9801_amd98.h b/src/devices/bus/cbus/pc9801_amd98.h index 3a8e407bd0d..f26246c768b 100644 --- a/src/devices/bus/cbus/pc9801_amd98.h +++ b/src/devices/bus/cbus/pc9801_amd98.h @@ -44,7 +44,7 @@ private: void ay3_address_w(uint8_t data); void ay3_data_latch_w(uint8_t data); - uint8_t m_ay3_latch = 0; + uint8_t m_ay3_latch; required_device m_bus; required_device m_ay1; diff --git a/src/devices/bus/cbus/pc9801_snd.h b/src/devices/bus/cbus/pc9801_snd.h index 5c431831eb5..0c9c694a4e3 100644 --- a/src/devices/bus/cbus/pc9801_snd.h +++ b/src/devices/bus/cbus/pc9801_snd.h @@ -20,11 +20,11 @@ public: protected: u8 opn_porta_r(); void opn_portb_w(u8 data); - u16 m_io_base = 0; + u16 m_io_base; virtual u16 read_io_base() = 0; private: - u8 m_joy_sel = 0; + u8 m_joy_sel; }; //DECLARE_DEVICE_TYPE(PC9801_SND, pc9801_snd_device) diff --git a/src/devices/bus/centronics/epson_lx810l.h b/src/devices/bus/centronics/epson_lx810l.h index 4f69711736d..82ec40cc1c2 100644 --- a/src/devices/bus/centronics/epson_lx810l.h +++ b/src/devices/bus/centronics/epson_lx810l.h @@ -142,7 +142,7 @@ private: TIMER_CR }; - emu_timer *m_cr_timer = nullptr; + emu_timer *m_cr_timer; }; // ======================> epson_ap2000_t diff --git a/src/devices/bus/centronics/printer.h b/src/devices/bus/centronics/printer.h index 1d2f1ca4927..7d2e1623ae9 100644 --- a/src/devices/bus/centronics/printer.h +++ b/src/devices/bus/centronics/printer.h @@ -45,8 +45,8 @@ private: TIMER_BUSY }; - emu_timer *m_ack_timer = nullptr; - emu_timer *m_busy_timer = nullptr; + emu_timer *m_ack_timer; + emu_timer *m_busy_timer; int m_strobe; uint8_t m_data; diff --git a/src/devices/bus/coco/coco_fdc.h b/src/devices/bus/coco/coco_fdc.h index ccf3dcd522c..786d30c2f68 100644 --- a/src/devices/bus/coco/coco_fdc.h +++ b/src/devices/bus/coco/coco_fdc.h @@ -56,9 +56,9 @@ protected: private: // registers - u8 m_dskreg = 0; - bool m_intrq = false; - bool m_drq = false; + u8 m_dskreg; + bool m_intrq; + bool m_drq; }; // device type definitions - CoCo FDC diff --git a/src/devices/bus/coco/coco_psg.h b/src/devices/bus/coco/coco_psg.h index a0aa73a819c..34c344c26e7 100644 --- a/src/devices/bus/coco/coco_psg.h +++ b/src/devices/bus/coco/coco_psg.h @@ -47,8 +47,8 @@ private: void flash5555_w(offs_t offset, u8 data); std::unique_ptr m_sram; - u8 m_bank[2]{}; - u8 m_control = 0; + u8 m_bank[2]; + u8 m_control; }; diff --git a/src/devices/bus/coco/coco_ssc.cpp b/src/devices/bus/coco/coco_ssc.cpp index 94a946cb82e..7c8d497a224 100644 --- a/src/devices/bus/coco/coco_ssc.cpp +++ b/src/devices/bus/coco/coco_ssc.cpp @@ -107,12 +107,12 @@ namespace virtual void set_sound_enable(bool sound_enable) override; private: - u8 m_reset_line = 0; - bool m_tms7000_busy = false; - u8 m_tms7000_porta = 0; - u8 m_tms7000_portb = 0; - u8 m_tms7000_portc = 0; - u8 m_tms7000_portd = 0; + u8 m_reset_line; + bool m_tms7000_busy; + u8 m_tms7000_porta; + u8 m_tms7000_portb; + u8 m_tms7000_portc; + u8 m_tms7000_portd; required_device m_tms7040; required_device m_staticram; required_device m_ay; diff --git a/src/devices/bus/compis/hrg.h b/src/devices/bus/compis/hrg.h index 28c781416a2..98ef784df14 100644 --- a/src/devices/bus/compis/hrg.h +++ b/src/devices/bus/compis/hrg.h @@ -48,7 +48,7 @@ protected: required_device m_palette; required_shared_ptr m_video_ram; - uint8_t m_unk_video = 0; + uint8_t m_unk_video; private: UPD7220_DISPLAY_PIXELS_MEMBER( display_pixels ); diff --git a/src/devices/bus/compucolor/floppy.h b/src/devices/bus/compucolor/floppy.h index b3237661aa5..8342a3668ed 100644 --- a/src/devices/bus/compucolor/floppy.h +++ b/src/devices/bus/compucolor/floppy.h @@ -104,7 +104,7 @@ private: compucolor_floppy_port_device *m_owner; - emu_timer *m_timer = nullptr; + emu_timer *m_timer; }; diff --git a/src/devices/bus/electron/cart/peg400.h b/src/devices/bus/electron/cart/peg400.h index 89e7034f339..141cc1fe02f 100644 --- a/src/devices/bus/electron/cart/peg400.h +++ b/src/devices/bus/electron/cart/peg400.h @@ -46,7 +46,7 @@ private: required_device m_floppy0; required_device m_floppy1; - int m_fdc_ie = 0; + int m_fdc_ie; }; diff --git a/src/devices/bus/electron/cart/romp144.h b/src/devices/bus/electron/cart/romp144.h index 5eed4caa375..45916a3ab38 100644 --- a/src/devices/bus/electron/cart/romp144.h +++ b/src/devices/bus/electron/cart/romp144.h @@ -48,8 +48,8 @@ private: required_device_array m_romslot; - uint8_t m_rom_select = 0; - uint8_t m_rom_latch = 0; + uint8_t m_rom_select; + uint8_t m_rom_latch; }; diff --git a/src/devices/bus/gba/gba_slot.h b/src/devices/bus/gba/gba_slot.h index 115082a5b8d..70fad8e4581 100644 --- a/src/devices/bus/gba/gba_slot.h +++ b/src/devices/bus/gba/gba_slot.h @@ -70,8 +70,8 @@ protected: // internal state uint32_t *m_rom; // this points to the cart rom region uint32_t m_rom_size; // this is the actual game size, not the rom region size! - uint32_t *m_romhlp = nullptr; - uint32_t m_romhlp_size = 0; + uint32_t *m_romhlp; + uint32_t m_romhlp_size; std::vector m_nvram; }; diff --git a/src/devices/bus/gba/rom.h b/src/devices/bus/gba/rom.h index c5272cc0e5f..3a1ac4005a1 100644 --- a/src/devices/bus/gba/rom.h +++ b/src/devices/bus/gba/rom.h @@ -107,8 +107,8 @@ protected: virtual void device_reset() override; private: - uint16_t m_gpio_regs[4]{}; - uint8_t m_gpio_write_only = 0, m_gpio_dirs = 0; + uint16_t m_gpio_regs[4]; + uint8_t m_gpio_write_only, m_gpio_dirs; }; @@ -380,7 +380,7 @@ protected: virtual void device_reset() override; private: - uint32_t m_src = 0, m_dst = 0, m_nblock = 0; + uint32_t m_src, m_dst, m_nblock; }; diff --git a/src/devices/bus/gio64/gio64.h b/src/devices/bus/gio64/gio64.h index 48592c7eef4..df99dc70dd9 100644 --- a/src/devices/bus/gio64/gio64.h +++ b/src/devices/bus/gio64/gio64.h @@ -120,7 +120,7 @@ protected: virtual void device_start() override; // internal state - device_gio64_card_interface *m_device_list[3]{}; + device_gio64_card_interface *m_device_list[3]; private: devcb_write_line::array<3> m_interrupt_cb; diff --git a/src/devices/bus/gio64/newport.h b/src/devices/bus/gio64/newport.h index 78b940310a0..3dd1a27ba40 100644 --- a/src/devices/bus/gio64/newport.h +++ b/src/devices/bus/gio64/newport.h @@ -56,14 +56,14 @@ private: // Initializers void set_revision(uint32_t revision) { m_revision = revision; } - uint32_t m_config = 0; - uint32_t m_revision = 0; - uint32_t m_fifo_available = 0; - //uint32_t m_entries = 0; - uint32_t m_cursor_cmap = 0; - uint32_t m_popup_cmap = 0; - uint32_t m_mode_table_idx = 0; - uint32_t m_mode_table[0x20]{}; + uint32_t m_config; + uint32_t m_revision; + uint32_t m_fifo_available; + //uint32_t m_entries; + uint32_t m_cursor_cmap; + uint32_t m_popup_cmap; + uint32_t m_mode_table_idx; + uint32_t m_mode_table[0x20]; }; DECLARE_DEVICE_TYPE(XMAP9, xmap9_device) @@ -107,10 +107,10 @@ private: // Initializers void set_revision(uint32_t revision) { m_revision = revision; } - uint32_t m_status = 0; - uint32_t m_revision = 0; - uint16_t m_palette_idx = 0; - uint32_t m_palette[0x10000]{}; + uint32_t m_status; + uint32_t m_revision; + uint16_t m_palette_idx; + uint32_t m_palette[0x10000]; }; DECLARE_DEVICE_TYPE(CMAP, cmap_device) @@ -255,21 +255,21 @@ private: void set_global_mask(uint32_t global_mask) { m_global_mask = global_mask; } - uint32_t m_global_mask = 0; - uint32_t m_write_mask = 0; - bool m_blend = false; - bool m_fast_clear = false; - bool m_rgbmode = false; - bool m_dblsrc = false; - uint8_t m_plane_enable = 0; - uint8_t m_draw_depth = 0; - uint32_t m_draw_bpp = 0; - uint8_t m_logicop = 0; - uint8_t m_src_shift = 0; - uint8_t m_dst_shift = 0; - - uint32_t *m_dest_buf = nullptr; - uint32_t *m_buf_ptr = nullptr; + uint32_t m_global_mask; + uint32_t m_write_mask; + bool m_blend; + bool m_fast_clear; + bool m_rgbmode; + bool m_dblsrc; + uint8_t m_plane_enable; + uint8_t m_draw_depth; + uint32_t m_draw_bpp; + uint8_t m_logicop; + uint8_t m_src_shift; + uint8_t m_dst_shift; + + uint32_t *m_dest_buf; + uint32_t *m_buf_ptr; std::unique_ptr m_rgbci; std::unique_ptr m_cidaux; diff --git a/src/devices/bus/hexbus/hexbus.h b/src/devices/bus/hexbus/hexbus.h index c7e1fe73a2b..1d225c55749 100644 --- a/src/devices/bus/hexbus/hexbus.h +++ b/src/devices/bus/hexbus/hexbus.h @@ -69,7 +69,7 @@ protected: hexbus_device *m_hexbus_outbound; // Common AND of all private values - uint8_t m_current_bus_value = 0; + uint8_t m_current_bus_value; // From device_ti_hexbus_interface virtual uint8_t bus_read(int dir) override; diff --git a/src/devices/bus/hexbus/hx5102.h b/src/devices/bus/hexbus/hx5102.h index e28c4bba096..15d717bd028 100644 --- a/src/devices/bus/hexbus/hx5102.h +++ b/src/devices/bus/hexbus/hx5102.h @@ -89,7 +89,7 @@ private: bool m_mspeed_on; bool m_pending_int; - bool m_pending_drq = false; + bool m_pending_drq; bool m_dcs; @@ -101,7 +101,7 @@ private: void update_readyff_input(); // Link to the attached floppy drives - floppy_image_device* m_floppy[2]{}; + floppy_image_device* m_floppy[2]; floppy_image_device* m_current_floppy; int m_floppy_select, m_floppy_select_last; @@ -117,8 +117,8 @@ private: required_device m_ram2; // System ROM - uint8_t* m_rom1 = nullptr; - uint8_t* m_rom2 = nullptr; + uint8_t* m_rom1; + uint8_t* m_rom2; }; } // end namespace bus::hexbus diff --git a/src/devices/bus/hp80_io/82900.h b/src/devices/bus/hp80_io/82900.h index 9ace998f4cd..613783cbc3f 100644 --- a/src/devices/bus/hp80_io/82900.h +++ b/src/devices/bus/hp80_io/82900.h @@ -48,8 +48,8 @@ private: // RAM std::unique_ptr m_ram; - bool m_rom_enabled = 0; - uint8_t m_addr_latch = 0; + bool m_rom_enabled; + uint8_t m_addr_latch; DECLARE_WRITE_LINE_MEMBER(reset_w); uint8_t cpu_mem_r(offs_t offset); diff --git a/src/devices/bus/hp9845_io/98032.h b/src/devices/bus/hp9845_io/98032.h index 37f78038ac2..059b0248ae9 100644 --- a/src/devices/bus/hp9845_io/98032.h +++ b/src/devices/bus/hp9845_io/98032.h @@ -38,15 +38,15 @@ protected: private: required_device m_gpio; - uint16_t m_output = 0; - uint16_t m_input = 0; - bool m_int_en = false; - bool m_dma_en = false; - bool m_busy = false; // U5B - bool m_pready = false; - bool m_flag = false; - bool m_auto_ah = false; - bool m_eir = false; + uint16_t m_output; + uint16_t m_input; + bool m_int_en; + bool m_dma_en; + bool m_busy; // U5B + bool m_pready; + bool m_flag; + bool m_auto_ah; + bool m_eir; DECLARE_WRITE_LINE_MEMBER(pflg_w); DECLARE_WRITE_LINE_MEMBER(psts_w); @@ -181,9 +181,9 @@ protected: virtual void device_reset() override; private: - uint16_t m_output = 0; - uint8_t m_ext_control = 0; - bool m_io = false; + uint16_t m_output; + uint8_t m_ext_control; + bool m_io; }; // device type definitions diff --git a/src/devices/bus/hp9845_io/98035.h b/src/devices/bus/hp9845_io/98035.h index 7c783c67ed4..48091cf24e3 100644 --- a/src/devices/bus/hp9845_io/98035.h +++ b/src/devices/bus/hp9845_io/98035.h @@ -63,27 +63,27 @@ private: required_device m_cpu; // Internal RAM & I/F - uint8_t m_np_ram[ 256 ]{}; - uint8_t m_ram_addr = 0; - uint8_t m_ram_data_in = 0; + uint8_t m_np_ram[ 256 ]; + uint8_t m_ram_addr; + uint8_t m_ram_data_in; // DC lines - uint8_t m_dc = 0; + uint8_t m_dc; // NP interrupt - bool m_np_irq = false; + bool m_np_irq; // Periodic interrupt - emu_timer *m_msec_timer = nullptr; + emu_timer *m_msec_timer; // Interface state - bool m_flg = false; - bool m_inten = false; - bool m_intflag = false; - bool m_irq = false; - bool m_idr_full = false; - uint8_t m_idr = 0; // Input Data Register - uint8_t m_odr = 0; // Output Data Register + bool m_flg; + bool m_inten; + bool m_intflag; + bool m_irq; + bool m_idr_full; + uint8_t m_idr; // Input Data Register + uint8_t m_odr; // Output Data Register // Clock chip emulation typedef enum { @@ -96,15 +96,15 @@ private: CLOCK_DOM, // Show :DD } clock_state_t; - emu_timer *m_clock_timer = nullptr; - unsigned m_clock_1s_div = 0; - clock_state_t m_clock_state{}; - uint8_t m_clock_digits[ 3 ]{}; - uint8_t m_clock_mux = 0; - bool m_clock_segh = false; - uint8_t m_clock_keys = 0; - uint8_t m_prev_clock_keys = 0; - unsigned m_clock_key_cnt = 0; + emu_timer *m_clock_timer; + unsigned m_clock_1s_div; + clock_state_t m_clock_state; + uint8_t m_clock_digits[ 3 ]; + uint8_t m_clock_mux; + bool m_clock_segh; + uint8_t m_clock_keys; + uint8_t m_prev_clock_keys; + unsigned m_clock_key_cnt; void half_init(); void set_flg(bool value); diff --git a/src/devices/bus/hp9845_io/hp9885.h b/src/devices/bus/hp9845_io/hp9885.h index eedae889e5c..a782df5d7df 100644 --- a/src/devices/bus/hp9845_io/hp9885.h +++ b/src/devices/bus/hp9845_io/hp9885.h @@ -76,32 +76,32 @@ private: }; required_device m_drive_connector; - floppy_image_device *m_drive = nullptr; - uint16_t m_input = 0; - uint16_t m_output = 0; - uint16_t m_status = 0; - int m_fsm_state = 0; - int m_head_state = 0; - int m_op = 0; - bool m_pctl = false; - bool m_ibf = false; - bool m_obf = false; - bool m_outputting = false; - bool m_had_transition = false; - bool m_dskchg = false; - unsigned m_track = 0; - unsigned m_seek_track = 0; - unsigned m_seek_sector = 0; - unsigned m_sector_cnt = 0; - unsigned m_word_cnt = 0; - unsigned m_rev_cnt = 0; - uint32_t m_am_detector = 0; - uint16_t m_crc = 0; // x^15 is stored in LSB + floppy_image_device *m_drive; + uint16_t m_input; + uint16_t m_output; + uint16_t m_status; + int m_fsm_state; + int m_head_state; + int m_op; + bool m_pctl; + bool m_ibf; + bool m_obf; + bool m_outputting; + bool m_had_transition; + bool m_dskchg; + unsigned m_track; + unsigned m_seek_track; + unsigned m_seek_sector; + unsigned m_sector_cnt; + unsigned m_word_cnt; + unsigned m_rev_cnt; + uint32_t m_am_detector; + uint16_t m_crc; // x^15 is stored in LSB // Timers - emu_timer *m_fsm_timer = nullptr; - emu_timer *m_head_timer = nullptr; - emu_timer *m_bit_byte_timer = nullptr; + emu_timer *m_fsm_timer; + emu_timer *m_head_timer; + emu_timer *m_bit_byte_timer; // PLL fdc_pll_t m_pll; diff --git a/src/devices/bus/hp_dio/hp98550.h b/src/devices/bus/hp_dio/hp98550.h index c0fcb5c2286..eca4da5bed6 100644 --- a/src/devices/bus/hp_dio/hp98550.h +++ b/src/devices/bus/hp_dio/hp98550.h @@ -62,7 +62,7 @@ protected: required_region_ptr m_rom; required_shared_ptr_array m_vram; - uint16_t m_plane_mask = 0; + uint16_t m_plane_mask; uint8_t m_intreg; uint8_t m_ints; }; diff --git a/src/devices/bus/hp_dio/hp98603a.h b/src/devices/bus/hp_dio/hp98603a.h index e97eedcada1..15cccb7ab3d 100644 --- a/src/devices/bus/hp_dio/hp98603a.h +++ b/src/devices/bus/hp_dio/hp98603a.h @@ -32,7 +32,7 @@ protected: virtual const tiny_rom_entry *device_rom_region() const override; private: - uint8_t *m_rom = nullptr; + uint8_t *m_rom; }; } // namespace bus::hp_dio diff --git a/src/devices/bus/hp_dio/hp98643.h b/src/devices/bus/hp_dio/hp98643.h index ed173731ae9..c1944bb1b8f 100644 --- a/src/devices/bus/hp_dio/hp98643.h +++ b/src/devices/bus/hp_dio/hp98643.h @@ -79,8 +79,8 @@ private: std::array m_ram; - uint16_t m_sc = 0; - bool m_installed_io = false; + uint16_t m_sc; + bool m_installed_io; }; } // namespace bus::hp_dio diff --git a/src/devices/bus/hp_dio/hp_dio.h b/src/devices/bus/hp_dio/hp_dio.h index 37aa6af3c21..c3ad5e0d178 100644 --- a/src/devices/bus/hp_dio/hp_dio.h +++ b/src/devices/bus/hp_dio/hp_dio.h @@ -222,7 +222,7 @@ protected: private: void set_bus(dio16_device & bus); device_dio16_card_interface *m_next; - unsigned int m_index = 0; + unsigned int m_index; }; class dio32_device; diff --git a/src/devices/bus/hp_hil/hp_hil.h b/src/devices/bus/hp_hil/hp_hil.h index 7aaa6845c8b..c50c4742340 100644 --- a/src/devices/bus/hp_hil/hp_hil.h +++ b/src/devices/bus/hp_hil/hp_hil.h @@ -178,7 +178,7 @@ protected: hp_hil_mlc_device *m_hp_hil_mlc; - hp_hil_slot_device *m_slot = nullptr; + hp_hil_slot_device *m_slot; int m_device_id; uint16_t m_device_id16; diff --git a/src/devices/bus/ieee488/grid2102.h b/src/devices/bus/ieee488/grid2102.h index c99f4715587..8bc475d6f84 100644 --- a/src/devices/bus/ieee488/grid2102.h +++ b/src/devices/bus/ieee488/grid2102.h @@ -59,21 +59,21 @@ protected: private: int m_gpib_loop_state; int m_floppy_loop_state; - uint8_t m_last_recv_byte = 0; - int m_last_recv_eoi = 0; - int m_last_recv_atn = 0; - uint8_t m_byte_to_send = 0; - int m_send_eoi = 0; + uint8_t m_last_recv_byte; + int m_last_recv_eoi; + int m_last_recv_atn; + uint8_t m_byte_to_send; + int m_send_eoi; bool listening, talking, serial_polling; bool has_srq; uint8_t serial_poll_byte; - uint32_t floppy_sector_number = 0; + uint32_t floppy_sector_number; int bus_addr; uint8_t *identify_response_ptr; std::vector m_data_buffer; std::queue m_output_data_buffer; - uint16_t io_size = 0; - emu_timer *m_delay_timer = nullptr; + uint16_t io_size; + emu_timer *m_delay_timer; protected: attotime read_delay; }; diff --git a/src/devices/bus/ieee488/remote488.h b/src/devices/bus/ieee488/remote488.h index 7651ebc9d07..9832c7d1d76 100644 --- a/src/devices/bus/ieee488/remote488.h +++ b/src/devices/bus/ieee488/remote488.h @@ -80,28 +80,28 @@ private: }; required_device m_stream; - uint8_t m_in_signals = 0; - uint8_t m_out_signals = 0; - bool m_no_propagation = false; - int m_sh_state = 0; - int m_ah_state = 0; - int m_rx_state = 0; - char m_rx_ch = 0; - uint8_t m_rx_data = 0; - bool m_flush_bytes = false; - bool m_ibf = false; - uint8_t m_ib = 0; - bool m_ib_eoi = false; - emu_timer *m_poll_timer = nullptr; - emu_timer *m_hb_timer = nullptr; - emu_timer *m_ah_timer = nullptr; - unsigned m_connect_cnt = 0; - bool m_connected = false; - uint8_t m_pp_data = 0; - bool m_pp_requested = false; - uint8_t m_pp_dio = 0; - uint8_t m_sh_dio = 0; - bool m_waiting_cp = false; + uint8_t m_in_signals; + uint8_t m_out_signals; + bool m_no_propagation; + int m_sh_state; + int m_ah_state; + int m_rx_state; + char m_rx_ch; + uint8_t m_rx_data; + bool m_flush_bytes; + bool m_ibf; + uint8_t m_ib; + bool m_ib_eoi; + emu_timer *m_poll_timer; + emu_timer *m_hb_timer; + emu_timer *m_ah_timer; + unsigned m_connect_cnt; + bool m_connected; + uint8_t m_pp_data; + bool m_pp_requested; + uint8_t m_pp_dio; + uint8_t m_sh_dio; + bool m_waiting_cp; void bus_reset(); void process_input_msgs(); diff --git a/src/devices/bus/interpro/keyboard/lle.h b/src/devices/bus/interpro/keyboard/lle.h index d2a91ee41a5..385f2484fab 100644 --- a/src/devices/bus/interpro/keyboard/lle.h +++ b/src/devices/bus/interpro/keyboard/lle.h @@ -48,13 +48,13 @@ private: output_finder<8> m_leds; - u8 m_txd = 0; - u8 m_p1 = 0; - u8 m_p2 = 0; - u8 m_bus = 0; + u8 m_txd; + u8 m_p1; + u8 m_p2; + u8 m_bus; - u8 m_row = 0; - u8 m_count = 0; + u8 m_row; + u8 m_count; }; class lle_en_us_device : public lle_device_base diff --git a/src/devices/bus/interpro/sr/edge.h b/src/devices/bus/interpro/sr/edge.h index 63a3d9d0aa4..d96896dd187 100644 --- a/src/devices/bus/interpro/sr/edge.h +++ b/src/devices/bus/interpro/sr/edge.h @@ -60,18 +60,18 @@ protected: required_device m_scc; private: - u32 m_reg0 = 0; + u32 m_reg0; - u32 m_control = 0; - u32 m_status = 0; - u32 m_fifo = 0; - u32 m_kernel = 0; - u32 m_attention = 0; + u32 m_control; + u32 m_status; + u32 m_fifo; + u32 m_kernel; + u32 m_attention; - u32 m_ififo_lwm = 0; - u32 m_ififo_hwm = 0; + u32 m_ififo_lwm; + u32 m_ififo_hwm; - u32 m_srx_master_control = 0; + u32 m_srx_master_control; }; class edge2_processor_device_base : public device_t, public device_srx_card_interface @@ -130,16 +130,16 @@ protected: private: - u32 m_control = 0; - u32 m_status = 0; - u32 m_attention = 0; - u32 m_mapping = 0; - u32 m_kernel = 0; + u32 m_control; + u32 m_status; + u32 m_attention; + u32 m_mapping; + u32 m_kernel; - u32 m_ififo_lwm = 0; - u32 m_ififo_hwm = 0; + u32 m_ififo_lwm; + u32 m_ififo_hwm; - u32 m_reg0 = 0; + u32 m_reg0; screen_device *m_screen; ram_device *m_sram; @@ -172,8 +172,8 @@ protected: required_device_array m_ramdac; private: - u32 m_unk_304 = 0; - u32 m_select = 0; + u32 m_unk_304; + u32 m_select; }; class mpcb828_device : public edge1_device_base diff --git a/src/devices/bus/interpro/sr/gt.h b/src/devices/bus/interpro/sr/gt.h index fd4ce7c244d..aeeb70941ea 100644 --- a/src/devices/bus/interpro/sr/gt.h +++ b/src/devices/bus/interpro/sr/gt.h @@ -208,38 +208,38 @@ protected: u16 m_bsga_width; u16 m_bsga_tmp; - u16 m_bsga_xmin = 0; // clipping boundary minimum x (left) - u16 m_bsga_ymin = 0; // clipping boundary minimum y (top) - u16 m_bsga_xmax = 0; // clipping boundary maximum x (right) - u16 m_bsga_ymax = 0; // clipping boundary maximum y (bottom) - - u16 m_bsga_status = 0; - - u16 m_bsga_xin1 = 0; - u16 m_bsga_yin1 = 0; - u16 m_bsga_xin2 = 0; - u16 m_bsga_yin2 = 0; - - u16 m_bsga_xin = 0; // most recently written xin1/xin2 - u16 m_bsga_yin = 0; // most recently written yin1/yin2 - - u32 m_ri_initial_distance = 0; - u32 m_ri_distance_both = 0; - u32 m_ri_distance_major = 0; - u32 m_ri_initial_address = 0; - u32 m_ri_address_both = 0; - u32 m_ri_address_major = 0; - u32 m_ri_initial_error = 0; - u32 m_ri_error_both = 0; - u32 m_ri_error_major = 0; - u32 m_ri_stop_count = 0; - u32 m_ri_control = 0; - u32 m_ri_xfer = 0; + u16 m_bsga_xmin; // clipping boundary minimum x (left) + u16 m_bsga_ymin; // clipping boundary minimum y (top) + u16 m_bsga_xmax; // clipping boundary maximum x (right) + u16 m_bsga_ymax; // clipping boundary maximum y (bottom) + + u16 m_bsga_status; + + u16 m_bsga_xin1; + u16 m_bsga_yin1; + u16 m_bsga_xin2; + u16 m_bsga_yin2; + + u16 m_bsga_xin; // most recently written xin1/xin2 + u16 m_bsga_yin; // most recently written yin1/yin2 + + u32 m_ri_initial_distance; + u32 m_ri_distance_both; + u32 m_ri_distance_major; + u32 m_ri_initial_address; + u32 m_ri_address_both; + u32 m_ri_address_major; + u32 m_ri_initial_error; + u32 m_ri_error_both; + u32 m_ri_error_major; + u32 m_ri_stop_count; + u32 m_ri_control; + u32 m_ri_xfer; private: - emu_timer *m_blit_timer = nullptr; - emu_timer *m_line_timer = nullptr; - emu_timer *m_done_timer = nullptr; + emu_timer *m_blit_timer; + emu_timer *m_line_timer; + emu_timer *m_done_timer; const bool m_double_buffered; const bool m_masked_reads; @@ -296,11 +296,11 @@ protected: required_device m_scc; private: - u8 m_mouse_int = 0; - u32 m_fifo_control = 0; + u8 m_mouse_int; + u32 m_fifo_control; - u8 m_mouse_x = 0; - u8 m_mouse_y = 0; + u8 m_mouse_x; + u8 m_mouse_y; }; class mpcb963_device : public gt_device diff --git a/src/devices/bus/intv_ctrl/ecs_ctrl.h b/src/devices/bus/intv_ctrl/ecs_ctrl.h index 10db91f0118..77fdfc72a92 100644 --- a/src/devices/bus/intv_ctrl/ecs_ctrl.h +++ b/src/devices/bus/intv_ctrl/ecs_ctrl.h @@ -152,7 +152,7 @@ protected: virtual void write_portA(uint8_t data) override; private: - uint8_t m_psg_portA = 0; + uint8_t m_psg_portA; required_ioport_array<7> m_synth; }; diff --git a/src/devices/bus/isa/3c503.h b/src/devices/bus/isa/3c503.h index 4c24b9c4688..f9597f00137 100644 --- a/src/devices/bus/isa/3c503.h +++ b/src/devices/bus/isa/3c503.h @@ -44,19 +44,19 @@ private: void set_drq(int state); struct { - uint8_t pstr = 0; - uint8_t pspr = 0; - uint8_t dqtr = 0; - uint8_t bcfr = 0; - uint8_t pcfr = 0; - uint8_t gacfr = 0; - uint8_t ctrl = 0; - uint8_t streg = 0; - uint8_t idcfr = 0; - uint16_t da = 0; - uint32_t vptr = 0; - uint8_t rfmsb = 0; - uint8_t rflsb = 0; + uint8_t pstr; + uint8_t pspr; + uint8_t dqtr; + uint8_t bcfr; + uint8_t pcfr; + uint8_t gacfr; + uint8_t ctrl; + uint8_t streg; + uint8_t idcfr; + uint16_t da; + uint32_t vptr; + uint8_t rfmsb; + uint8_t rflsb; } m_regs; }; diff --git a/src/devices/bus/isa/chessmdr.h b/src/devices/bus/isa/chessmdr.h index 536f72ebb4e..9f5d1bf270f 100644 --- a/src/devices/bus/isa/chessmdr.h +++ b/src/devices/bus/isa/chessmdr.h @@ -34,7 +34,7 @@ protected: private: required_device m_chessm; - bool m_installed = false; + bool m_installed; uint8_t chessmdr_r(offs_t offset); void chessmdr_w(offs_t offset, uint8_t data); diff --git a/src/devices/bus/isa/chessmsr.h b/src/devices/bus/isa/chessmsr.h index cfbb56ea662..6d4becc4b64 100644 --- a/src/devices/bus/isa/chessmsr.h +++ b/src/devices/bus/isa/chessmsr.h @@ -39,9 +39,9 @@ private: required_device m_sublatch; std::unique_ptr m_ram; - u8 m_ram_offset = 0; - bool m_suspended = false; - bool m_installed = false; + u8 m_ram_offset; + bool m_suspended; + bool m_installed; uint8_t chessmsr_r(offs_t offset); void chessmsr_w(offs_t offset, uint8_t data); diff --git a/src/devices/bus/isa/ega.h b/src/devices/bus/isa/ega.h index d7ee83e4b01..04ff53fc055 100644 --- a/src/devices/bus/isa/ega.h +++ b/src/devices/bus/isa/ega.h @@ -67,44 +67,44 @@ public: /* Video memory and related variables */ std::unique_ptr m_vram; - uint8_t *m_plane[4]{}; - uint8_t m_read_latch[4]{}; - uint8_t *m_videoram = nullptr; - uint8_t *m_charA = nullptr; - uint8_t *m_charB = nullptr; + uint8_t *m_plane[4]; + uint8_t m_read_latch[4]; + uint8_t *m_videoram; + uint8_t *m_charA; + uint8_t *m_charB; /* Registers */ - uint8_t m_misc_output = 0; - uint8_t m_feature_control = 0; + uint8_t m_misc_output; + uint8_t m_feature_control; /* Attribute registers AR00 - AR14 */ struct { - uint8_t index = 0; - uint8_t data[32]{}; - uint8_t index_write = 0; + uint8_t index; + uint8_t data[32]; + uint8_t index_write; } m_attribute; /* Sequencer registers SR00 - SR04 */ struct { - uint8_t index = 0; - uint8_t data[8]{}; + uint8_t index; + uint8_t data[8]; } m_sequencer; /* Graphics controller registers GR00 - GR08 */ struct { - uint8_t index = 0; - uint8_t data[16]{}; + uint8_t index; + uint8_t data[16]; } m_graphics_controller; - uint8_t m_frame_cnt = 0; - uint8_t m_hsync = 0; - uint8_t m_vsync = 0; - uint8_t m_vblank = 0; - uint8_t m_display_enable = 0; - int m_video_mode = 0; + uint8_t m_frame_cnt; + uint8_t m_hsync; + uint8_t m_vsync; + uint8_t m_vblank; + uint8_t m_display_enable; + int m_video_mode; required_device m_palette; }; diff --git a/src/devices/bus/isa/eis_hgb107x.h b/src/devices/bus/isa/eis_hgb107x.h index fba9e1b7758..6689e7db0a8 100644 --- a/src/devices/bus/isa/eis_hgb107x.h +++ b/src/devices/bus/isa/eis_hgb107x.h @@ -87,12 +87,12 @@ private: required_ioport m_io_monitor; required_region_ptr m_chargen; - uint8_t m_vmode = 0; - rgb_t (*m_pal)[4]{}; - rgb_t m_3111_pal[4]{}; - rgb_t m_371x_pal[4]{}; + uint8_t m_vmode; + rgb_t (*m_pal)[4]; + rgb_t m_3111_pal[4]; + rgb_t m_371x_pal[4]; bool m_installed; - hd6845s_device *m_hd6845s = nullptr; + hd6845s_device *m_hd6845s; public: int m_framecnt; diff --git a/src/devices/bus/isa/ex1280.h b/src/devices/bus/isa/ex1280.h index 4b725a6defb..a9637a1b1f6 100644 --- a/src/devices/bus/isa/ex1280.h +++ b/src/devices/bus/isa/ex1280.h @@ -52,7 +52,7 @@ protected: void main_map(address_map &map); std::vector m_vram; - uint16_t m_flags = 0; + uint16_t m_flags; }; diff --git a/src/devices/bus/isa/fdc.h b/src/devices/bus/isa/fdc.h index ff4ba2b83f1..00431ef3e5c 100644 --- a/src/devices/bus/isa/fdc.h +++ b/src/devices/bus/isa/fdc.h @@ -61,10 +61,10 @@ protected: DECLARE_WRITE_LINE_MEMBER( fdc_drq_w ); private: - bool irq = false, drq = false, fdc_drq = false, fdc_irq = false; + bool irq, drq, fdc_drq, fdc_irq; uint8_t dor; - floppy_image_device *floppy[4]{}; + floppy_image_device *floppy[4]; void check_irq(); void check_drq(); diff --git a/src/devices/bus/isa/finalchs.h b/src/devices/bus/isa/finalchs.h index 2b77a4efb08..2b04f69ec6b 100644 --- a/src/devices/bus/isa/finalchs.h +++ b/src/devices/bus/isa/finalchs.h @@ -39,7 +39,7 @@ private: required_device m_mainlatch; required_device m_sublatch; - bool m_installed = false; + bool m_installed; uint8_t finalchs_r(offs_t offset); void finalchs_w(offs_t offset, uint8_t data); diff --git a/src/devices/bus/isa/mach32.h b/src/devices/bus/isa/mach32.h index 58148c7ade3..38b4f673530 100644 --- a/src/devices/bus/isa/mach32.h +++ b/src/devices/bus/isa/mach32.h @@ -42,7 +42,7 @@ protected: uint16_t m_chip_ID; uint16_t m_membounds; - bool display_mode_change = false; + bool display_mode_change; }; @@ -170,18 +170,18 @@ protected: virtual uint16_t offset() override; // hardware pointer - bool m_cursor_enable = false; - uint32_t m_cursor_address = 0; - uint16_t m_cursor_horizontal = 0; - uint16_t m_cursor_vertical = 0; - uint8_t m_cursor_colour0_b = 0; - uint8_t m_cursor_colour0_r = 0; - uint8_t m_cursor_colour0_g = 0; - uint8_t m_cursor_colour1_b = 0; - uint8_t m_cursor_colour1_r = 0; - uint8_t m_cursor_colour1_g = 0; - uint8_t m_cursor_offset_horizontal = 0; - uint8_t m_cursor_offset_vertical = 0; + bool m_cursor_enable; + uint32_t m_cursor_address; + uint16_t m_cursor_horizontal; + uint16_t m_cursor_vertical; + uint8_t m_cursor_colour0_b; + uint8_t m_cursor_colour0_r; + uint8_t m_cursor_colour0_g; + uint8_t m_cursor_colour1_b; + uint8_t m_cursor_colour1_r; + uint8_t m_cursor_colour1_g; + uint8_t m_cursor_offset_horizontal; + uint8_t m_cursor_offset_vertical; }; diff --git a/src/devices/bus/isa/mcd.h b/src/devices/bus/isa/mcd.h index e134e4d0dce..4c2b7a0e636 100644 --- a/src/devices/bus/isa/mcd.h +++ b/src/devices/bus/isa/mcd.h @@ -39,28 +39,28 @@ private: bool read_sector(bool first = false); - bool m_change = false; - bool m_newstat = false; - bool m_data = false; - uint8_t m_stat = 0; - uint8_t m_buf[2352]{}; - int m_buf_count = 0; - int m_buf_idx = 0; - uint8_t m_cmdbuf[16]{}; - int m_cmdbuf_count = 0; - int m_cmdrd_count = 0; - int m_cmdbuf_idx = 0; - uint8_t m_mode = 0; - uint8_t m_cmd = 0; - uint8_t m_conf = 0; - uint8_t m_irq = 0; - uint8_t m_dma = 0; - uint16_t m_dmalen = 0; - uint32_t m_readmsf = 0; - uint32_t m_readcount = 0; - bool m_locked = false; - int m_drvmode = 0; - int m_curtoctrk = 0; + bool m_change; + bool m_newstat; + bool m_data; + uint8_t m_stat; + uint8_t m_buf[2352]; + int m_buf_count; + int m_buf_idx; + uint8_t m_cmdbuf[16]; + int m_cmdbuf_count; + int m_cmdrd_count; + int m_cmdbuf_idx; + uint8_t m_mode; + uint8_t m_cmd; + uint8_t m_conf; + uint8_t m_irq; + uint8_t m_dma; + uint16_t m_dmalen; + uint32_t m_readmsf; + uint32_t m_readcount; + bool m_locked; + int m_drvmode; + int m_curtoctrk; enum { STAT_CMD_CHECK = 0x01, STAT_PLAY_CDDA = 0x02, diff --git a/src/devices/bus/isa/myb3k_com.h b/src/devices/bus/isa/myb3k_com.h index 563f4f8793d..bdd591b5291 100644 --- a/src/devices/bus/isa/myb3k_com.h +++ b/src/devices/bus/isa/myb3k_com.h @@ -69,8 +69,8 @@ protected: required_device m_usart; bool m_installed; int m_irq; - int m_irq_tx = 0; - int m_irq_rx = 0; + int m_irq_tx; + int m_irq_rx; int m_control; int m_status; }; diff --git a/src/devices/bus/isa/myb3k_fdc.h b/src/devices/bus/isa/myb3k_fdc.h index 5ec79b42fbd..b2a645423d6 100644 --- a/src/devices/bus/isa/myb3k_fdc.h +++ b/src/devices/bus/isa/myb3k_fdc.h @@ -44,10 +44,10 @@ protected: required_device m_fdc; optional_device_array m_floppy_connectors; - offs_t io_base = 0; - int dma_channel = 0; + offs_t io_base; + int dma_channel; - bool has_motor_control = false; + bool has_motor_control; enum FDC_COMMAND { FDC_DRIVE_SEL = 0x03, diff --git a/src/devices/bus/isa/p1_sound.h b/src/devices/bus/isa/p1_sound.h index 608c2d5f4bc..3b7f1c40af9 100644 --- a/src/devices/bus/isa/p1_sound.h +++ b/src/devices/bus/isa/p1_sound.h @@ -51,8 +51,8 @@ protected: private: DECLARE_WRITE_LINE_MEMBER(sampler_sync); - uint8_t m_dac_data[16]{}; - int m_dac_ptr = 0; + uint8_t m_dac_data[16]; + int m_dac_ptr; required_device m_dac; optional_device m_filter; diff --git a/src/devices/bus/isa/pgc.h b/src/devices/bus/isa/pgc.h index dace5a076c5..d560dbdda09 100644 --- a/src/devices/bus/isa/pgc.h +++ b/src/devices/bus/isa/pgc.h @@ -64,9 +64,9 @@ private: std::unique_ptr m_vram; std::unique_ptr m_eram; - uint8_t m_stateparam[16]{}; - uint8_t m_lut[256 * 3]{}; - int m_accel = 0; + uint8_t m_stateparam[16]; + uint8_t m_lut[256 * 3]; + int m_accel; }; diff --git a/src/devices/bus/isa/s3virge.h b/src/devices/bus/isa/s3virge.h index 960667365e9..89023e3bafc 100644 --- a/src/devices/bus/isa/s3virge.h +++ b/src/devices/bus/isa/s3virge.h @@ -137,50 +137,50 @@ protected: struct { - uint32_t linear_address = 0; - uint8_t linear_address_size = 0; - uint32_t linear_address_size_full = 0; - bool linear_address_enable = false; - uint32_t interrupt_enable = 0; + uint32_t linear_address; + uint8_t linear_address_size; + uint32_t linear_address_size_full; + bool linear_address_enable; + uint32_t interrupt_enable; struct { - int state = 0; - bool busy = false; + int state; + bool busy; struct { - uint32_t reg[256]{}; - int op_type = 0; + uint32_t reg[256]; + int op_type; } cmd_fifo[16]; - int cmd_fifo_next_ptr = 0; // command added here in FIFO - int cmd_fifo_current_ptr = 0; // command currently being processed in FIFO - int cmd_fifo_slots_free = 0; + int cmd_fifo_next_ptr; // command added here in FIFO + int cmd_fifo_current_ptr; // command currently being processed in FIFO + int cmd_fifo_slots_free; - uint8_t pattern[0xc0]{}; - uint32_t reg[5][256]{}; + uint8_t pattern[0xc0]; + uint32_t reg[5][256]; // BitBLT command state - uint16_t bitblt_x_src = 0; - uint16_t bitblt_y_src = 0; - uint16_t bitblt_x_dst = 0; - uint16_t bitblt_y_dst = 0; - int16_t bitblt_x_current = 0; - int16_t bitblt_y_current = 0; - int16_t bitblt_x_src_current = 0; - int16_t bitblt_y_src_current = 0; - int8_t bitblt_pat_x = 0; - int8_t bitblt_pat_y = 0; - uint16_t bitblt_height = 0; - uint16_t bitblt_width = 0; - uint32_t bitblt_step_count = 0; - uint64_t bitblt_mono_pattern = 0; - uint32_t bitblt_current_pixel = 0; - uint32_t bitblt_pixel_pos = 0; // current position in a pixel (for packed 24bpp colour image transfers) - uint32_t image_xfer = 0; // source data via image transfer ports - uint16_t clip_l = 0; - uint16_t clip_r = 0; - uint16_t clip_t = 0; - uint16_t clip_b = 0; + uint16_t bitblt_x_src; + uint16_t bitblt_y_src; + uint16_t bitblt_x_dst; + uint16_t bitblt_y_dst; + int16_t bitblt_x_current; + int16_t bitblt_y_current; + int16_t bitblt_x_src_current; + int16_t bitblt_y_src_current; + int8_t bitblt_pat_x; + int8_t bitblt_pat_y; + uint16_t bitblt_height; + uint16_t bitblt_width; + uint32_t bitblt_step_count; + uint64_t bitblt_mono_pattern; + uint32_t bitblt_current_pixel; + uint32_t bitblt_pixel_pos; // current position in a pixel (for packed 24bpp colour image transfers) + uint32_t image_xfer; // source data via image transfer ports + uint16_t clip_l; + uint16_t clip_r; + uint16_t clip_t; + uint16_t clip_b; } s3d; } s3virge; @@ -243,7 +243,7 @@ protected: devcb_write_line m_linear_config_changed_cb; private: - emu_timer* m_draw_timer = nullptr; + emu_timer* m_draw_timer; void bitblt_step(); void bitblt_colour_step(); void bitblt_monosrc_step(); diff --git a/src/devices/bus/isa/sblaster.h b/src/devices/bus/isa/sblaster.h index a73b569dc7b..7d5d5775f91 100644 --- a/src/devices/bus/isa/sblaster.h +++ b/src/devices/bus/isa/sblaster.h @@ -73,35 +73,35 @@ protected: struct sb8_mixer { - uint8_t status = 0; - uint8_t main_vol = 0; - uint8_t dac_vol = 0; - uint8_t fm_vol = 0; - uint8_t mic_vol = 0; - uint8_t in_filter = 0; - uint8_t stereo_sel = 0; - uint8_t cd_vol = 0; - uint8_t line_vol = 0; + uint8_t status; + uint8_t main_vol; + uint8_t dac_vol; + uint8_t fm_vol; + uint8_t mic_vol; + uint8_t in_filter; + uint8_t stereo_sel; + uint8_t cd_vol; + uint8_t line_vol; }; struct sb16_mixer { - uint8_t data = 0; - uint8_t status = 0; - uint8_t main_vol[2]{}; - uint8_t dac_vol[2]{}; - uint8_t fm_vol[2]{}; - uint8_t cd_vol[2]{}; - uint8_t line_vol[2]{}; - uint8_t mic_vol = 0; - uint8_t pc_speaker_vol = 0; - uint8_t output_ctl = 0; - uint8_t input_ctl[2]{}; - uint8_t input_gain[2]{}; - uint8_t output_gain[2]{}; - uint8_t agc = 0; - uint8_t treble[2]{}; - uint8_t bass[2]{}; + uint8_t data; + uint8_t status; + uint8_t main_vol[2]; + uint8_t dac_vol[2]; + uint8_t fm_vol[2]; + uint8_t cd_vol[2]; + uint8_t line_vol[2]; + uint8_t mic_vol; + uint8_t pc_speaker_vol; + uint8_t output_ctl; + uint8_t input_ctl[2]; + uint8_t input_gain[2]; + uint8_t output_gain[2]; + uint8_t agc; + uint8_t treble[2]; + uint8_t bass[2]; }; // construction/destruction diff --git a/src/devices/bus/isa/svga_s3.h b/src/devices/bus/isa/svga_s3.h index d6dea54ec0d..a07b0e039c6 100644 --- a/src/devices/bus/isa/svga_s3.h +++ b/src/devices/bus/isa/svga_s3.h @@ -87,9 +87,9 @@ protected: private: required_device m_vga; - bool m_lfb_enable = false; - uint32_t m_lfb_start = 0; - uint32_t m_lfb_end = 0; + bool m_lfb_enable; + uint32_t m_lfb_start; + uint32_t m_lfb_end; }; class isa16_stealth3d2kpro_device : diff --git a/src/devices/bus/isa/trident.h b/src/devices/bus/isa/trident.h index 7ce6853c778..3dc8f63947c 100644 --- a/src/devices/bus/isa/trident.h +++ b/src/devices/bus/isa/trident.h @@ -87,35 +87,35 @@ protected: uint8_t cursor_ctrl; // 2D acceleration - uint16_t accel_opermode = 0; - uint8_t accel_command = 0; - uint8_t accel_fmix = 0; - uint32_t accel_drawflags = 0; - uint32_t accel_fgcolour = 0; - uint32_t accel_bgcolour = 0; - uint16_t accel_pattern_loc = 0; - int16_t accel_source_x = 0; - int16_t accel_source_y = 0; - int16_t accel_dest_x = 0; - int16_t accel_dest_y = 0; - int16_t accel_dim_x = 0; - int16_t accel_dim_y = 0; - uint32_t accel_style = 0; - uint32_t accel_ckey = 0; - int16_t accel_source_x_clip = 0; - int16_t accel_source_y_clip = 0; - int16_t accel_dest_x_clip = 0; - int16_t accel_dest_y_clip = 0; - uint32_t accel_fg_pattern_colour = 0; - uint32_t accel_bg_pattern_colour = 0; - uint8_t accel_pattern[0x80]{}; - bool accel_busy = false; - bool accel_memwrite_active = false; // true when writing to VRAM will push data to an ongoing command (SRCMONO/PATMONO) - int16_t accel_mem_x = 0; - int16_t accel_mem_y = 0; - uint32_t accel_transfer = 0; + uint16_t accel_opermode; + uint8_t accel_command; + uint8_t accel_fmix; + uint32_t accel_drawflags; + uint32_t accel_fgcolour; + uint32_t accel_bgcolour; + uint16_t accel_pattern_loc; + int16_t accel_source_x; + int16_t accel_source_y; + int16_t accel_dest_x; + int16_t accel_dest_y; + int16_t accel_dim_x; + int16_t accel_dim_y; + uint32_t accel_style; + uint32_t accel_ckey; + int16_t accel_source_x_clip; + int16_t accel_source_y_clip; + int16_t accel_dest_x_clip; + int16_t accel_dest_y_clip; + uint32_t accel_fg_pattern_colour; + uint32_t accel_bg_pattern_colour; + uint8_t accel_pattern[0x80]; + bool accel_busy; + bool accel_memwrite_active; // true when writing to VRAM will push data to an ongoing command (SRCMONO/PATMONO) + int16_t accel_mem_x; + int16_t accel_mem_y; + uint32_t accel_transfer; } tri; - uint8_t m_version = 0; + uint8_t m_version; private: uint8_t trident_seq_reg_read(uint8_t index); void trident_seq_reg_write(uint8_t index, uint8_t data); diff --git a/src/devices/bus/isbx/isbc_218a.h b/src/devices/bus/isbx/isbc_218a.h index 597b80d07fb..c654c74aae8 100644 --- a/src/devices/bus/isbx/isbc_218a.h +++ b/src/devices/bus/isbx/isbc_218a.h @@ -56,7 +56,7 @@ private: required_device m_fdc; required_device m_floppy0; - bool m_reset, m_motor, m_fd8 = false; + bool m_reset, m_motor, m_fd8; }; diff --git a/src/devices/bus/lpci/i82439tx.h b/src/devices/bus/lpci/i82439tx.h index c3e124860f9..af5a0dcf757 100644 --- a/src/devices/bus/lpci/i82439tx.h +++ b/src/devices/bus/lpci/i82439tx.h @@ -51,14 +51,14 @@ private: // system management ram setup struct { int tseg_en; - int tseg_sz = 0; - int e_smerr = 0; + int tseg_sz; + int e_smerr; int h_smrame; - int c_base_seg = 0; - int g_smrame = 0; - int d_lck = 0; - int d_cls = 0; - int d_open = 0; + int c_base_seg; + int g_smrame; + int d_lck; + int d_cls; + int d_open; int smiact_n; int tseg_size; int mapping; diff --git a/src/devices/bus/lpci/southbridge.h b/src/devices/bus/lpci/southbridge.h index 8fb6f488419..92953a5df0f 100644 --- a/src/devices/bus/lpci/southbridge.h +++ b/src/devices/bus/lpci/southbridge.h @@ -78,7 +78,7 @@ protected: uint8_t m_channel_check; uint8_t m_nmi_enabled; bool m_ide_io_ports_enabled; - address_space *spaceio = nullptr; + address_space *spaceio; void pc_select_dma_channel(int channel, bool state); diff --git a/src/devices/bus/mc10/mcx128.cpp b/src/devices/bus/mc10/mcx128.cpp index cc004e68eec..d507ad612c5 100644 --- a/src/devices/bus/mc10/mcx128.cpp +++ b/src/devices/bus/mc10/mcx128.cpp @@ -101,8 +101,8 @@ private: memory_share_creator m_share; memory_view m_view; memory_bank_array_creator<8> m_bank; - uint8_t ram_bank_cr = 0; - uint8_t rom_map_cr = 0; + uint8_t ram_bank_cr; + uint8_t rom_map_cr; void update_banks(); diff --git a/src/devices/bus/megadrive/eeprom.h b/src/devices/bus/megadrive/eeprom.h index 9b7770445fc..7f5b0e450a4 100644 --- a/src/devices/bus/megadrive/eeprom.h +++ b/src/devices/bus/megadrive/eeprom.h @@ -204,20 +204,20 @@ private: std::vector m_sram; // EEPROM runtime vars - uint8_t m_eeprom_sda = 0; // current SDA - uint8_t m_eeprom_prev_sda = 0; // previous SDA - uint8_t m_eeprom_scl = 0; // current SCL - uint8_t m_eeprom_prev_scl = 0; // previous SCL - uint8_t m_eeprom_cnt = 0; // operation count in 0-9 - uint8_t m_eeprom_readwrite = 0; // read/write bit - uint16_t m_eeprom_slave_mask = 0; // dev addr - uint16_t m_eeprom_word_address = 0; // memory addr - uint16_t m_eeprom_devsel = 0; // selected device - uint16_t m_eeprom_byte = 0; // byte to be written - int m_eeprom_cur_state = 0; // current state + uint8_t m_eeprom_sda; // current SDA + uint8_t m_eeprom_prev_sda; // previous SDA + uint8_t m_eeprom_scl; // current SCL + uint8_t m_eeprom_prev_scl; // previous SCL + uint8_t m_eeprom_cnt; // operation count in 0-9 + uint8_t m_eeprom_readwrite; // read/write bit + uint16_t m_eeprom_slave_mask; // dev addr + uint16_t m_eeprom_word_address; // memory addr + uint16_t m_eeprom_devsel; // selected device + uint16_t m_eeprom_byte; // byte to be written + int m_eeprom_cur_state; // current state // EEPROM physical characteristics (configured at init) - uint16_t m_eeprom_mask = 0; // size of the memory - 1 - uint16_t m_eeprom_pagewrite_mask = 0; // max number of bytes that can be written in a single write cycle + uint16_t m_eeprom_mask; // size of the memory - 1 + uint16_t m_eeprom_pagewrite_mask; // max number of bytes that can be written in a single write cycle }; diff --git a/src/devices/bus/megadrive/rom.h b/src/devices/bus/megadrive/rom.h index b9899dc9b56..0acf73061ee 100644 --- a/src/devices/bus/megadrive/rom.h +++ b/src/devices/bus/megadrive/rom.h @@ -501,7 +501,7 @@ protected: virtual void device_reset() override; private: - uint16_t m_retvalue = 0; + uint16_t m_retvalue; }; diff --git a/src/devices/bus/msx_slot/ram_mm.h b/src/devices/bus/msx_slot/ram_mm.h index 49a2dd19900..55f13659a4c 100644 --- a/src/devices/bus/msx_slot/ram_mm.h +++ b/src/devices/bus/msx_slot/ram_mm.h @@ -30,7 +30,7 @@ private: uint32_t m_total_size; uint8_t m_bank_mask; uint8_t m_bank_selected[4]; - uint8_t *m_bank_base[4]{}; + uint8_t *m_bank_base[4]; uint8_t m_ramio_set_bits; }; diff --git a/src/devices/bus/multibus/isbc202.h b/src/devices/bus/multibus/isbc202.h index 38fbb0a8c48..c1f3b1d036d 100644 --- a/src/devices/bus/multibus/isbc202.h +++ b/src/devices/bus/multibus/isbc202.h @@ -100,38 +100,38 @@ private: cpu_device *m_cpu; // When != nullptr: CPU is suspended in wait state bool m_cpu_rd; uint8_t m_ready_in; - uint8_t m_ready_ff = 0; // I-A44 & I-A43 - bool m_gate_lower = false; // I-A58-9 - bool m_irq = false; // C-A37-9 - uint8_t m_data_low_out = 0; // C-A43 - uint8_t m_data_low_in = 0; // C-A25 - uint8_t m_cpu_data = 0; - uint8_t m_addr_low_out = 0; // C-A41 - bool m_mem_wrt = false; // I-A58-4 - bool m_wrt_inh = false; // I-A46-13 - bool m_direction = false; // I-A58-11 - bool m_ibus_cached = false; - uint8_t m_ibus = 0; - uint16_t m_crc = 0; // I-A62 - bool m_crc_enabled = false; // I-A58-13 - bool m_crc_out = false; // C-A16-2 - bool m_reading = false; // I-A46-9 - bool m_writing = false; // C-A16-4 - uint16_t m_data_sr = 0; // C-A36 & C-A29 (MSB), next byte in LSB - bool m_last_data_bit = false; // I-A48-6 - uint16_t m_clock_sr = 0; // C-A34 & C-A27 (MSB), next byte in LSB + uint8_t m_ready_ff; // I-A44 & I-A43 + bool m_gate_lower; // I-A58-9 + bool m_irq; // C-A37-9 + uint8_t m_data_low_out; // C-A43 + uint8_t m_data_low_in; // C-A25 + uint8_t m_cpu_data; + uint8_t m_addr_low_out; // C-A41 + bool m_mem_wrt; // I-A58-4 + bool m_wrt_inh; // I-A46-13 + bool m_direction; // I-A58-11 + bool m_ibus_cached; + uint8_t m_ibus; + uint16_t m_crc; // I-A62 + bool m_crc_enabled; // I-A58-13 + bool m_crc_out; // C-A16-2 + bool m_reading; // I-A46-9 + bool m_writing; // C-A16-4 + uint16_t m_data_sr; // C-A36 & C-A29 (MSB), next byte in LSB + bool m_last_data_bit; // I-A48-6 + uint16_t m_clock_sr; // C-A34 & C-A27 (MSB), next byte in LSB attotime m_last_f_time; - bool m_clock_gate = false; // I-A10-8 - bool m_amwrt = false; // I-A58-6 - bool m_dlyd_amwrt = false; + bool m_clock_gate; // I-A10-8 + bool m_amwrt; // I-A58-6 + bool m_dlyd_amwrt; // PLL fdc_pll_t m_pll; // Timers - emu_timer *m_timeout_timer = nullptr; - emu_timer *m_byte_timer = nullptr; - emu_timer *m_f_timer = nullptr; + emu_timer *m_timeout_timer; + emu_timer *m_byte_timer; + emu_timer *m_f_timer; void set_output(); unsigned selected_drive() const; diff --git a/src/devices/bus/neogeo/boot_kof10th.h b/src/devices/bus/neogeo/boot_kof10th.h index 72df63aba1c..8e422f6d6ec 100644 --- a/src/devices/bus/neogeo/boot_kof10th.h +++ b/src/devices/bus/neogeo/boot_kof10th.h @@ -36,10 +36,10 @@ protected: virtual void device_add_mconfig(machine_config &config) override; private: - uint8_t* m_fixed = nullptr; - uint32_t m_special_bank = 0; - uint16_t m_cart_ram[0x1000]{}; - uint16_t m_cart_ram2[0x10000]{}; + uint8_t* m_fixed; + uint32_t m_special_bank; + uint16_t m_cart_ram[0x1000]; + uint16_t m_cart_ram2[0x10000]; }; // device type definition diff --git a/src/devices/bus/neogeo/prot_kof2k3bl.h b/src/devices/bus/neogeo/prot_kof2k3bl.h index bff03feb276..c4c83d30e5d 100644 --- a/src/devices/bus/neogeo/prot_kof2k3bl.h +++ b/src/devices/bus/neogeo/prot_kof2k3bl.h @@ -29,9 +29,9 @@ protected: virtual void device_reset() override; private: - uint16_t m_overlay = 0; - uint32_t m_bank_base = 0; - uint16_t m_cartridge_ram[0x1000]{}; // bootlegs + uint16_t m_overlay; + uint32_t m_bank_base; + uint16_t m_cartridge_ram[0x1000]; // bootlegs }; #endif // MAME_BUS_NEOGEO_PROT_KOF2K3BL_H diff --git a/src/devices/bus/neogeo/slot.h b/src/devices/bus/neogeo/slot.h index bd9fdaff5bb..4c86456ff61 100644 --- a/src/devices/bus/neogeo/slot.h +++ b/src/devices/bus/neogeo/slot.h @@ -334,7 +334,7 @@ protected: virtual void device_start() override; private: - int m_type = 0; + int m_type; device_neogeo_cart_interface* m_cart; }; diff --git a/src/devices/bus/neogeo_ctrl/kizuna4p.h b/src/devices/bus/neogeo_ctrl/kizuna4p.h index 2539d5f764b..404055cdec6 100644 --- a/src/devices/bus/neogeo_ctrl/kizuna4p.h +++ b/src/devices/bus/neogeo_ctrl/kizuna4p.h @@ -40,7 +40,7 @@ protected: private: required_ioport_array<4> m_joy; required_ioport_array<2> m_ss; - uint8_t m_ctrl_sel = 0; + uint8_t m_ctrl_sel; }; diff --git a/src/devices/bus/nes/disksys.h b/src/devices/bus/nes/disksys.h index c7d3b6d0d3d..61bd9dd2048 100644 --- a/src/devices/bus/nes/disksys.h +++ b/src/devices/bus/nes/disksys.h @@ -57,7 +57,7 @@ private: uint16_t m_irq_count, m_irq_count_latch; int m_irq_enable, m_irq_repeat, m_irq_transfer; int m_disk_reg_enable; - bool m_sound_en = false; + bool m_sound_en; uint8_t m_fds_motor_on; uint8_t m_fds_door_closed; diff --git a/src/devices/bus/nes/jy.h b/src/devices/bus/nes/jy.h index 3a30cdcca15..ac4cf8e397e 100644 --- a/src/devices/bus/nes/jy.h +++ b/src/devices/bus/nes/jy.h @@ -42,27 +42,27 @@ protected: virtual void update_mirror() { update_mirror_typea(); } inline uint8_t unscramble(uint8_t bank); - uint8_t m_mul[2]{}; - uint8_t m_latch = 0; - uint8_t m_reg[4]{}; - uint8_t m_chr_latch[2]{}; // type C uses a more complex CHR 4K mode, and these vars are only changed for those games - uint8_t m_mmc_prg_bank[4]{}; - uint16_t m_mmc_nt_bank[4]{}; - uint16_t m_mmc_vrom_bank[8]{}; - uint16_t m_extra_chr_bank = 0; - uint16_t m_extra_chr_mask = 0; - int m_bank_6000 = 0; - - uint8_t m_irq_mode = 0; - uint8_t m_irq_count = 0; - uint8_t m_irq_prescale = 0; - uint8_t m_irq_prescale_mask = 0; - uint8_t m_irq_flip = 0; - int m_irq_enable = 0; - int m_irq_up = 0, m_irq_down = 0; + uint8_t m_mul[2]; + uint8_t m_latch; + uint8_t m_reg[4]; + uint8_t m_chr_latch[2]; // type C uses a more complex CHR 4K mode, and these vars are only changed for those games + uint8_t m_mmc_prg_bank[4]; + uint16_t m_mmc_nt_bank[4]; + uint16_t m_mmc_vrom_bank[8]; + uint16_t m_extra_chr_bank; + uint16_t m_extra_chr_mask; + int m_bank_6000; + + uint8_t m_irq_mode; + uint8_t m_irq_count; + uint8_t m_irq_prescale; + uint8_t m_irq_prescale_mask; + uint8_t m_irq_flip; + int m_irq_enable; + int m_irq_up, m_irq_down; static const device_timer_id TIMER_IRQ = 0; - emu_timer *irq_timer = nullptr; + emu_timer *irq_timer; attotime timer_freq; }; diff --git a/src/devices/bus/nes/kaiser.h b/src/devices/bus/nes/kaiser.h index 31bef65627b..5962a77dd13 100644 --- a/src/devices/bus/nes/kaiser.h +++ b/src/devices/bus/nes/kaiser.h @@ -23,7 +23,7 @@ protected: virtual void device_start() override; private: - u8 m_latch = 0; + u8 m_latch; }; @@ -63,7 +63,7 @@ protected: virtual void device_start() override; private: - uint8_t m_latch = 0; + uint8_t m_latch; }; @@ -88,11 +88,11 @@ protected: virtual void device_start() override; virtual void device_timer(emu_timer &timer, device_timer_id id, int param) override; - u8 m_reg[8]{}; + u8 m_reg[8]; private: void prg_update(); - u8 m_latch = 0; + u8 m_latch; u16 m_irq_count, m_irq_count_latch; int m_irq_enable; @@ -136,7 +136,7 @@ protected: virtual void device_start() override; private: - u8 m_latch = 0; + u8 m_latch; const u8 m_a15_flip; }; @@ -171,7 +171,7 @@ protected: virtual void device_timer(emu_timer &timer, device_timer_id id, int param) override; private: - uint8_t m_latch = 0; + uint8_t m_latch; uint16_t m_irq_count; uint8_t m_irq_status; @@ -218,7 +218,7 @@ protected: virtual void device_start() override; private: - u8 m_latch = 0; + u8 m_latch; }; @@ -327,7 +327,7 @@ protected: private: void update_prg(); - uint8_t m_latch = 0; + uint8_t m_latch; uint8_t m_reg[8]; }; diff --git a/src/devices/bus/nes/mmc3_clones.h b/src/devices/bus/nes/mmc3_clones.h index 87e57474143..d6da92864d6 100644 --- a/src/devices/bus/nes/mmc3_clones.h +++ b/src/devices/bus/nes/mmc3_clones.h @@ -187,7 +187,7 @@ protected: virtual void device_start() override; private: - int m_prot = 0; + int m_prot; }; @@ -320,7 +320,7 @@ protected: virtual void device_start() override; private: - uint8_t m_prot = 0; + uint8_t m_prot; }; diff --git a/src/devices/bus/nes/nes_slot.h b/src/devices/bus/nes/nes_slot.h index c5fd2021eef..63b562ecfee 100644 --- a/src/devices/bus/nes/nes_slot.h +++ b/src/devices/bus/nes/nes_slot.h @@ -315,7 +315,7 @@ public: // PRG inline int prg_8k_bank_num(int bank); inline void update_prg_banks(int prg_bank_start, int prg_bank_end); - memory_bank *m_prg_bank_mem[4]{}; + memory_bank *m_prg_bank_mem[4]; int m_prg_bank[4]; uint32_t m_prg_chunks; uint32_t m_prg_mask; @@ -338,7 +338,7 @@ public: //because some of these change multiple times per scanline! int m_chr_src[8]; //defines source of base pointer int m_chr_orig[8]; //defines offset of 0x400 byte segment at base pointer - uint8_t *m_chr_access[8]{}; //source translated + origin -> valid pointer! + uint8_t *m_chr_access[8]; //source translated + origin -> valid pointer! uint32_t m_vrom_chunks; uint32_t m_vram_chunks; @@ -372,7 +372,7 @@ public: int m_nt_src[4]; int m_nt_orig[4]; int m_nt_writable[4]; - uint8_t *m_nt_access[4]{}; //quick banking structure for a maximum of 4K of RAM/ROM/ExRAM + uint8_t *m_nt_access[4]; //quick banking structure for a maximum of 4K of RAM/ROM/ExRAM void set_nt_page(int page, int source, int bank, int writable); void set_nt_mirroring(int mirroring); diff --git a/src/devices/bus/nes/pirate.h b/src/devices/bus/nes/pirate.h index 6e11ca29255..a94f541b498 100644 --- a/src/devices/bus/nes/pirate.h +++ b/src/devices/bus/nes/pirate.h @@ -64,7 +64,7 @@ protected: virtual void device_start() override; private: - uint8_t m_latch = 0; + uint8_t m_latch; uint8_t m_ram[0xb00]; }; @@ -174,7 +174,7 @@ protected: virtual void device_start() override; private: - uint8_t m_latch = 0; + uint8_t m_latch; }; @@ -198,7 +198,7 @@ protected: private: void update_banks(); - u8 m_latch = 0; + u8 m_latch; u8 m_reg[6]; u16 m_irq_count, m_irq_count_latch; @@ -224,7 +224,7 @@ protected: virtual void device_start() override; private: - uint16_t m_latch = 0; + uint16_t m_latch; }; @@ -247,7 +247,7 @@ protected: private: u8 m_jumper; - u16 m_latch = 0; + u16 m_latch; u8 m_reg; }; @@ -272,7 +272,7 @@ protected: virtual void device_start() override; private: - uint8_t m_latch = 0; + uint8_t m_latch; }; #endif diff --git a/src/devices/bus/nes/vrc_clones.h b/src/devices/bus/nes/vrc_clones.h index a659c670701..780dc6ae0cb 100644 --- a/src/devices/bus/nes/vrc_clones.h +++ b/src/devices/bus/nes/vrc_clones.h @@ -148,7 +148,7 @@ protected: virtual void device_start() override; private: - u8 m_reg = 0; + u8 m_reg; }; @@ -203,7 +203,7 @@ protected: private: u16 m_irq_count; - u8 m_irq_latch = 0; + u8 m_irq_latch; int m_irq_enable; static const device_timer_id TIMER_IRQ = 0; @@ -230,7 +230,7 @@ protected: virtual void device_start() override; private: - u8 m_chr_mask = 0, m_chr_match; + u8 m_chr_mask, m_chr_match; }; // ======================> nes_hengg_shjy3_device diff --git a/src/devices/bus/newbrain/fdc.h b/src/devices/bus/newbrain/fdc.h index 17623f1e525..3ac24faffa6 100644 --- a/src/devices/bus/newbrain/fdc.h +++ b/src/devices/bus/newbrain/fdc.h @@ -62,12 +62,12 @@ private: void moton(int state); - int m_paging = 0; - int m_ma16 = 0; - int m_mpm = 0; - int m_fdc_att = 0; - int m_fdc_int = 0; - int m_pa15 = 0; + int m_paging; + int m_ma16; + int m_mpm; + int m_fdc_att; + int m_fdc_int; + int m_pa15; }; diff --git a/src/devices/bus/nscsi/cd.h b/src/devices/bus/nscsi/cd.h index aa7624cdb7a..1a87e150b13 100644 --- a/src/devices/bus/nscsi/cd.h +++ b/src/devices/bus/nscsi/cd.h @@ -46,13 +46,13 @@ private: uint32_t bytes_per_block; int lba, cur_sector; required_device image; - uint8_t mode_data[12]{}; + uint8_t mode_data[12]; - char manufacturer[8]{}; - char product[16]{}; - char revision[4]{}; - uint8_t inquiry_data = 0; - uint8_t compliance = 0; + char manufacturer[8]; + char product[16]; + char revision[4]; + uint8_t inquiry_data; + uint8_t compliance; void return_no_cd(); static int to_msf(int frame); diff --git a/src/devices/bus/nscsi/cw7501.h b/src/devices/bus/nscsi/cw7501.h index 772b247a518..0b785c4d3ba 100644 --- a/src/devices/bus/nscsi/cw7501.h +++ b/src/devices/bus/nscsi/cw7501.h @@ -32,7 +32,7 @@ private: required_device m_cdcpu; - u8 m_mystery_address = 0; + u8 m_mystery_address; }; class cdr4210_device : public cw7501_device diff --git a/src/devices/bus/nubus/laserview.h b/src/devices/bus/nubus/laserview.h index 196f8c19c3e..88131ca72ec 100644 --- a/src/devices/bus/nubus/laserview.h +++ b/src/devices/bus/nubus/laserview.h @@ -40,8 +40,8 @@ private: std::vector m_vram; uint32_t m_vbl_disable, m_palette[2]; - int m_prot_state = 0; - int m_toggle = 0; + int m_prot_state; + int m_toggle; }; // device type definition diff --git a/src/devices/bus/nubus/nubus_image.h b/src/devices/bus/nubus/nubus_image.h index dcfc1179fad..ae9257ac0c4 100644 --- a/src/devices/bus/nubus/nubus_image.h +++ b/src/devices/bus/nubus/nubus_image.h @@ -37,13 +37,13 @@ protected: struct nbfilectx { - uint32_t curcmd = 0; - char filename[128]{}; + uint32_t curcmd; + char filename[128]; std::string curdir; osd::directory::ptr dirp; osd_file::ptr fd; - uint64_t filelen = 0; - uint32_t bytecount = 0; + uint64_t filelen; + uint32_t bytecount; }; nubus_image_device(const machine_config &mconfig, device_type type, const char *tag, device_t *owner, uint32_t clock); diff --git a/src/devices/bus/pc_kbd/pcat101.h b/src/devices/bus/pc_kbd/pcat101.h index 902c8738e22..449947eccad 100644 --- a/src/devices/bus/pc_kbd/pcat101.h +++ b/src/devices/bus/pc_kbd/pcat101.h @@ -46,8 +46,8 @@ private: required_ioport_array<16> m_matrix; output_finder<3> m_leds; - u8 m_porta = 0; - u8 m_portc = 0; + u8 m_porta; + u8 m_portc; }; // device type definition diff --git a/src/devices/bus/pce/pce_rom.h b/src/devices/bus/pce/pce_rom.h index 0a5e386d585..43499851eb7 100644 --- a/src/devices/bus/pce/pce_rom.h +++ b/src/devices/bus/pce/pce_rom.h @@ -103,7 +103,7 @@ private: const uint32_t m_bram_size = 0x800*4; uint8_t m_bram[0x800*4]; - uint8_t m_bram_locked = false; + uint8_t m_bram_locked; }; diff --git a/src/devices/bus/pofo/hpc102.h b/src/devices/bus/pofo/hpc102.h index 54972df4d8f..c7168b12787 100644 --- a/src/devices/bus/pofo/hpc102.h +++ b/src/devices/bus/pofo/hpc102.h @@ -48,7 +48,7 @@ protected: private: required_device m_uart; - uint8_t m_vector = 0; + uint8_t m_vector; }; diff --git a/src/devices/bus/pofo/hpc104.h b/src/devices/bus/pofo/hpc104.h index 9272e31dda2..d5d1c36c3d3 100644 --- a/src/devices/bus/pofo/hpc104.h +++ b/src/devices/bus/pofo/hpc104.h @@ -60,8 +60,8 @@ private: memory_share_creator m_nvram; required_ioport m_io_sw1; - bool m_sw1 = false; - bool m_ncc1_out = false; + bool m_sw1; + bool m_ncc1_out; }; diff --git a/src/devices/bus/qbus/dvk_kgd.h b/src/devices/bus/qbus/dvk_kgd.h index 78a0cb8edfb..8ecd4ef23e2 100644 --- a/src/devices/bus/qbus/dvk_kgd.h +++ b/src/devices/bus/qbus/dvk_kgd.h @@ -50,12 +50,12 @@ protected: private: std::unique_ptr m_videoram_base; - uint8_t *m_videoram = nullptr; + uint8_t *m_videoram; - uint16_t m_cr = 0; - uint16_t m_dr = 0; - uint16_t m_ar = 0; - uint16_t m_ct = 0; + uint16_t m_cr; + uint16_t m_dr; + uint16_t m_ar; + uint16_t m_ct; }; diff --git a/src/devices/bus/qbus/pc11.h b/src/devices/bus/qbus/pc11.h index e8f35860ec3..8d32925f459 100644 --- a/src/devices/bus/qbus/pc11.h +++ b/src/devices/bus/qbus/pc11.h @@ -61,17 +61,17 @@ private: int m_rxvec; int m_txvec; - device_image_interface *m_fd = nullptr; + device_image_interface *m_fd; - line_state m_rxrdy{}; - line_state m_txrdy{}; + line_state m_rxrdy; + line_state m_txrdy; - uint16_t m_rcsr = 0; - uint16_t m_rbuf = 0; - uint16_t m_tcsr = 0; - uint16_t m_tbuf = 0; + uint16_t m_rcsr; + uint16_t m_rbuf; + uint16_t m_tcsr; + uint16_t m_tbuf; - const char *pc11_regnames[4]{}; + const char *pc11_regnames[4]; }; diff --git a/src/devices/bus/rs232/mboardd.cpp b/src/devices/bus/rs232/mboardd.cpp index 0b0b1717be2..b2b44a6db70 100644 --- a/src/devices/bus/rs232/mboardd.cpp +++ b/src/devices/bus/rs232/mboardd.cpp @@ -57,8 +57,8 @@ private: void c000_w(u8 data) { m_c000_latch = data; }; void m6803_mem(address_map &map); - int m_rx_state = 0; - u8 m_c000_latch = 0; + int m_rx_state; + u8 m_c000_latch; }; mockingboard_d_device::mockingboard_d_device(const machine_config &mconfig, const char *tag, device_t *owner, uint32_t clock) diff --git a/src/devices/bus/rtpc/kbd.h b/src/devices/bus/rtpc/kbd.h index c2794515bd0..860cb5c2218 100644 --- a/src/devices/bus/rtpc/kbd.h +++ b/src/devices/bus/rtpc/kbd.h @@ -36,10 +36,10 @@ private: required_ioport_array<8> m_matrix[4]; output_finder<3> m_leds; - bool m_t1 = false; - u8 m_bus = 0; - u8 m_p1 = 0; - u8 m_p2 = 0; + bool m_t1; + u8 m_bus; + u8 m_p1; + u8 m_p2; }; DECLARE_DEVICE_TYPE(RTPC_KBD, rtpc_kbd_device) diff --git a/src/devices/bus/sat_ctrl/ctrl.h b/src/devices/bus/sat_ctrl/ctrl.h index 97c2897207a..d17bed9b067 100644 --- a/src/devices/bus/sat_ctrl/ctrl.h +++ b/src/devices/bus/sat_ctrl/ctrl.h @@ -34,7 +34,7 @@ public: protected: device_saturn_control_port_interface(const machine_config &mconfig, device_t &device); - uint8_t m_ctrl_id = 0; + uint8_t m_ctrl_id; saturn_control_port_device *m_port; }; diff --git a/src/devices/bus/sbus/cgsix.h b/src/devices/bus/sbus/cgsix.h index 062982da739..b6f3fe7520d 100644 --- a/src/devices/bus/sbus/cgsix.h +++ b/src/devices/bus/sbus/cgsix.h @@ -470,36 +470,36 @@ protected: uint32_t m_itri_relx; uint32_t m_itri_rely; uint32_t m_itri_relz; - uint32_t m_itri_r = 0; - uint32_t m_itri_g = 0; - uint32_t m_itri_b = 0; - uint32_t m_itri_a = 0; - - uint32_t m_iquad_absx = 0; - uint32_t m_iquad_absy = 0; - uint32_t m_iquad_absz = 0; - uint32_t m_iquad_relx = 0; - uint32_t m_iquad_rely = 0; - uint32_t m_iquad_relz = 0; - uint32_t m_iquad_r = 0; - uint32_t m_iquad_g = 0; - uint32_t m_iquad_b = 0; - uint32_t m_iquad_a = 0; - - uint32_t m_irect_absx = 0; - uint32_t m_irect_absy = 0; - uint32_t m_irect_absz = 0; - uint32_t m_irect_relx = 0; - uint32_t m_irect_rely = 0; - uint32_t m_irect_relz = 0; - uint32_t m_irect_r = 0; - uint32_t m_irect_g = 0; - uint32_t m_irect_b = 0; - uint32_t m_irect_a = 0; + uint32_t m_itri_r; + uint32_t m_itri_g; + uint32_t m_itri_b; + uint32_t m_itri_a; + + uint32_t m_iquad_absx; + uint32_t m_iquad_absy; + uint32_t m_iquad_absz; + uint32_t m_iquad_relx; + uint32_t m_iquad_rely; + uint32_t m_iquad_relz; + uint32_t m_iquad_r; + uint32_t m_iquad_g; + uint32_t m_iquad_b; + uint32_t m_iquad_a; + + uint32_t m_irect_absx; + uint32_t m_irect_absy; + uint32_t m_irect_absz; + uint32_t m_irect_relx; + uint32_t m_irect_rely; + uint32_t m_irect_relz; + uint32_t m_irect_r; + uint32_t m_irect_g; + uint32_t m_irect_b; + uint32_t m_irect_a; std::unique_ptr m_prim_buf; - uint32_t m_vertex_count = 0; - uint32_t m_curr_prim_type = 0; + uint32_t m_vertex_count; + uint32_t m_curr_prim_type; }; uint32_t m_thc_misc; diff --git a/src/devices/bus/sbus/sbus.h b/src/devices/bus/sbus/sbus.h index 108b7ac7a05..2c66318c8aa 100644 --- a/src/devices/bus/sbus/sbus.h +++ b/src/devices/bus/sbus/sbus.h @@ -100,12 +100,12 @@ protected: // internal state required_device m_maincpu; required_address_space m_type1space; - address_space *m_space = nullptr; + address_space *m_space; devcb_write_line::array<7> m_irq_cb; devcb_write32 m_buserr; - device_sbus_card_interface *m_device_list[3]{}; + device_sbus_card_interface *m_device_list[3]; private: void slot1_timeout_map(address_map &map); @@ -148,7 +148,7 @@ protected: optional_device m_sbus_finder; sbus_device *m_sbus; - const char *m_sbus_slottag = nullptr; + const char *m_sbus_slottag; int m_slot; uint32_t m_base; }; diff --git a/src/devices/bus/scsi/omti5100.h b/src/devices/bus/scsi/omti5100.h index 9b3ab83405e..4b1e1dda59a 100644 --- a/src/devices/bus/scsi/omti5100.h +++ b/src/devices/bus/scsi/omti5100.h @@ -24,7 +24,7 @@ protected: private: required_device m_image0; required_device m_image1; - hard_disk_file::info m_param[2]{}; + hard_disk_file::info m_param[2]; }; DECLARE_DEVICE_TYPE(OMTI5100, omti5100_device) diff --git a/src/devices/bus/scsi/scsi.h b/src/devices/bus/scsi/scsi.h index b191d86b2e6..07e64d5f102 100644 --- a/src/devices/bus/scsi/scsi.h +++ b/src/devices/bus/scsi/scsi.h @@ -195,7 +195,7 @@ protected: int m_msg; int m_req; int m_ack; - int m_atn = 0; + int m_atn; int m_rst; int m_data0; int m_data1; diff --git a/src/devices/bus/scsi/scsicd512.h b/src/devices/bus/scsi/scsicd512.h index b416f21b0f8..0345a74ca9a 100644 --- a/src/devices/bus/scsi/scsicd512.h +++ b/src/devices/bus/scsi/scsicd512.h @@ -37,7 +37,7 @@ protected: char m_manufacturer[8]; char m_product[16]; char m_revision[4]; - uint8_t m_data = 0; + uint8_t m_data; }; class dec_rrd45_device : public scsicd512_device diff --git a/src/devices/bus/sega8/rom.h b/src/devices/bus/sega8/rom.h index 06e74634859..1af8cdb1c5b 100644 --- a/src/devices/bus/sega8/rom.h +++ b/src/devices/bus/sega8/rom.h @@ -392,8 +392,8 @@ protected: virtual void device_start() override; virtual void device_reset() override; - uint8_t m_gamesel = 0; - uint8_t m_readxor = 0; + uint8_t m_gamesel; + uint8_t m_readxor; }; @@ -420,7 +420,7 @@ protected: virtual void device_reset() override; private: - uint8_t m_block = 0; + uint8_t m_block; }; @@ -447,7 +447,7 @@ protected: virtual void device_reset() override; private: - uint8_t m_block = 0; + uint8_t m_block; }; class sega8_x_terminator_device : public sega8_rom_device diff --git a/src/devices/bus/sg1000_exp/sg1000exp.h b/src/devices/bus/sg1000_exp/sg1000exp.h index 75b33900f3c..d297e255d97 100644 --- a/src/devices/bus/sg1000_exp/sg1000exp.h +++ b/src/devices/bus/sg1000_exp/sg1000exp.h @@ -72,7 +72,7 @@ public: protected: device_sg1000_expansion_slot_interface(const machine_config &mconfig, device_t &device); - sg1000_expansion_slot_device *m_port = nullptr; + sg1000_expansion_slot_device *m_port; }; diff --git a/src/devices/bus/snes/sa1.h b/src/devices/bus/snes/sa1.h index 2ad641a8d83..fcc9bbd9dc1 100644 --- a/src/devices/bus/snes/sa1.h +++ b/src/devices/bus/snes/sa1.h @@ -139,8 +139,8 @@ private: u8 m_iram_write_snes, m_iram_write_sa1; // $2230-$2231 u8 m_dma_ctrl, m_dma_ccparam; - u8 m_dma_cconv_size = 0; - u8 m_dma_cconv_bits = 8; + u8 m_dma_cconv_size; + u8 m_dma_cconv_bits; // DMA Control (DCNT) inline const bool DCNT_DMAEN() { return BIT(m_dma_ctrl, 7); } // DMA Enable control //inline const bool DCNT_DPRIO() { return BIT(m_dma_ctrl, 6); } // Processing priority between SA-1 CPU and DMA; Not emulated currently diff --git a/src/devices/bus/snes/sdd1.h b/src/devices/bus/snes/sdd1.h index a7c92037111..5164a169f65 100644 --- a/src/devices/bus/snes/sdd1.h +++ b/src/devices/bus/snes/sdd1.h @@ -73,8 +73,8 @@ protected: struct SDD1_PEM_ContextInfo { - uint8_t status = 0; - uint8_t MPS = 0; + uint8_t status; + uint8_t MPS; }; class SDD1_PEM //Probability Estimation Module @@ -167,8 +167,8 @@ protected: struct { - uint32_t addr = 0; // $43x2-$43x4 -- DMA transfer address - uint16_t size = 0; // $43x5-$43x6 -- DMA transfer size + uint32_t addr; // $43x2-$43x4 -- DMA transfer address + uint16_t size; // $43x5-$43x6 -- DMA transfer size } m_dma[8]; std::unique_ptr m_sdd1emu; @@ -176,9 +176,9 @@ protected: struct { std::unique_ptr data; // pointer to decompressed S-DD1 data (65536 bytes) - uint16_t offset = 0; // read index into S-DD1 decompression buffer - uint32_t size = 0; // length of data buffer; reads decrement counter, set ready to false at 0 - uint8_t ready = 0; // 1 when data[] is valid; 0 to invoke sdd1emu.decompress() + uint16_t offset; // read index into S-DD1 decompression buffer + uint32_t size; // length of data buffer; reads decrement counter, set ready to false at 0 + uint8_t ready; // 1 when data[] is valid; 0 to invoke sdd1emu.decompress() } m_buffer; }; diff --git a/src/devices/bus/spectrum/beta.h b/src/devices/bus/spectrum/beta.h index c52ed588b7a..1827c741355 100644 --- a/src/devices/bus/spectrum/beta.h +++ b/src/devices/bus/spectrum/beta.h @@ -60,10 +60,10 @@ protected: required_device_array m_floppy; required_device m_exp; - int m_romcs = 0; - u8 m_masterdisable = 0; + int m_romcs; + u8 m_masterdisable; u8 m_control; - bool m_motor_active = false; + bool m_motor_active; void fdc_hld_w(int state); virtual void motors_control(); diff --git a/src/devices/bus/spectrum/d40.h b/src/devices/bus/spectrum/d40.h index 94b24963dfc..250b2feccd8 100644 --- a/src/devices/bus/spectrum/d40.h +++ b/src/devices/bus/spectrum/d40.h @@ -86,9 +86,9 @@ protected: void fdc_drq_w(int state); virtual void nmi_check() override; - uint8_t m_control = 0; - int m_intrq = 0; - int m_drq = 0; + uint8_t m_control; + int m_intrq; + int m_drq; }; class spectrum_d80_device : diff --git a/src/devices/bus/spectrum/kempdisc.h b/src/devices/bus/spectrum/kempdisc.h index c5475444206..3a3b5118402 100644 --- a/src/devices/bus/spectrum/kempdisc.h +++ b/src/devices/bus/spectrum/kempdisc.h @@ -56,8 +56,8 @@ protected: required_device_array m_floppy; required_device m_exp; - int m_romcs = 0; -// u8 m_control = 0; + int m_romcs; +// u8 m_control; }; class spectrum_spdos_device : diff --git a/src/devices/bus/spectrum/lprint.h b/src/devices/bus/spectrum/lprint.h index cb5dad32217..d58793607c6 100644 --- a/src/devices/bus/spectrum/lprint.h +++ b/src/devices/bus/spectrum/lprint.h @@ -46,8 +46,8 @@ protected: required_memory_region m_rom; required_device m_centronics; - int m_romcs = 0; - int m_busy = 0; + int m_romcs; + int m_busy; }; class spectrum_lprint3_device : @@ -87,8 +87,8 @@ protected: required_device m_rs232; required_device m_exp; - int m_romcs = 0; - int m_busy = 0; + int m_romcs; + int m_busy; }; class spectrum_kempcentrs_device : @@ -115,7 +115,7 @@ protected: required_device m_centronics; - int m_busy = 0; + int m_busy; }; class spectrum_kempcentre_device : @@ -150,9 +150,9 @@ protected: required_memory_region m_rom; required_device m_centronics; - int m_active = 0; - int m_romcs = 0; - int m_busy = 0; + int m_active; + int m_romcs; + int m_busy; }; class spectrum_kempcentreu_device : diff --git a/src/devices/bus/spectrum/mface.h b/src/devices/bus/spectrum/mface.h index 36b38c9dd82..7b3fbf03e72 100644 --- a/src/devices/bus/spectrum/mface.h +++ b/src/devices/bus/spectrum/mface.h @@ -53,8 +53,8 @@ protected: required_memory_region m_rom; required_device m_exp; - int m_romcs = 0; - int m_nmi_pending = 0; + int m_romcs; + int m_nmi_pending; std::unique_ptr m_ram; }; @@ -143,7 +143,7 @@ protected: virtual void device_start() override; virtual void device_reset() override; - int m_hidden = 0; + int m_hidden; }; class spectrum_mface128v1_device : public spectrum_mface128_base_device @@ -163,7 +163,7 @@ protected: virtual uint8_t iorq_r(offs_t offset) override; virtual void iorq_w(offs_t offset, uint8_t data) override; - int m_d3_ff = 0; // no initial state + int m_d3_ff; // no initial state }; class spectrum_mface128_device : public spectrum_mface128v1_device @@ -200,8 +200,8 @@ protected: virtual void iorq_w(offs_t offset, uint8_t data) override; private: - uint8_t m_reg_file[4]{}; // no initial state - int m_disable = 0; + uint8_t m_reg_file[4]; // no initial state + int m_disable; }; class spectrum_mprint_device : public spectrum_mface128_base_device @@ -227,7 +227,7 @@ private: required_device m_centronics; - int m_busy = 0; + int m_busy; }; diff --git a/src/devices/bus/spectrum/mgt.h b/src/devices/bus/spectrum/mgt.h index 25edfb6736e..628477c1f8a 100644 --- a/src/devices/bus/spectrum/mgt.h +++ b/src/devices/bus/spectrum/mgt.h @@ -60,7 +60,7 @@ protected: required_device_array m_floppy; required_device m_centronics; - int m_romcs = 0; + int m_romcs; uint8_t m_ram[8 * 1024]; bool m_centronics_busy; }; diff --git a/src/devices/bus/spectrum/sixword.h b/src/devices/bus/spectrum/sixword.h index 8933c6adb12..c11108454f6 100644 --- a/src/devices/bus/spectrum/sixword.h +++ b/src/devices/bus/spectrum/sixword.h @@ -64,10 +64,10 @@ protected: required_device m_rs232; required_ioport m_joy; - int m_romcs = 0; - u8 m_ram[0x2000]{}; - u16 m_rombank = 0; - u8 m_control = 0; + int m_romcs; + u8 m_ram[0x2000]; + u16 m_rombank; + u8 m_control; }; class spectrum_swiftdisc2_device : diff --git a/src/devices/bus/ss50/piaide.cpp b/src/devices/bus/ss50/piaide.cpp index d8e6aebdab0..a8ac76efdf6 100644 --- a/src/devices/bus/ss50/piaide.cpp +++ b/src/devices/bus/ss50/piaide.cpp @@ -70,8 +70,8 @@ private: optional_device m_pia; optional_device m_ide; - uint8_t m_pia_porta = 0; - uint8_t m_pia_portb = 0; + uint8_t m_pia_porta; + uint8_t m_pia_portb; uint8_t pia_a_r(); uint8_t pia_b_r(); diff --git a/src/devices/bus/tanbus/radisc.h b/src/devices/bus/tanbus/radisc.h index a6e1b708bb6..bbcfc2298ac 100644 --- a/src/devices/bus/tanbus/radisc.h +++ b/src/devices/bus/tanbus/radisc.h @@ -64,8 +64,8 @@ private: int m_beeper_state; uint8_t m_drive_control; - int m_irq_enable = 0; - int m_drq_enable = 0; + int m_irq_enable; + int m_drq_enable; }; diff --git a/src/devices/bus/tanbus/tanbus.h b/src/devices/bus/tanbus/tanbus.h index 33834af70c2..7f5e87eb0aa 100644 --- a/src/devices/bus/tanbus/tanbus.h +++ b/src/devices/bus/tanbus/tanbus.h @@ -51,7 +51,7 @@ protected: private: required_device m_tanbus; - int m_bus_num = 0; + int m_bus_num; }; // device type definition diff --git a/src/devices/bus/ti99/gromport/cartridges.h b/src/devices/bus/ti99/gromport/cartridges.h index c5eb988aa3e..be4a8840d84 100644 --- a/src/devices/bus/ti99/gromport/cartridges.h +++ b/src/devices/bus/ti99/gromport/cartridges.h @@ -112,7 +112,7 @@ private: const std::string m_pathname; }; - bool m_readrom = false; + bool m_readrom; int m_pcbtype; int m_slot; int get_index_from_tagname(); @@ -155,12 +155,12 @@ protected: template void logerror(Format &&fmt, Params &&... args) const { m_cart->logerror(fmt, args...); } ti99_cartridge_device* m_cart; - tmc0430_device* m_grom[5]{}; + tmc0430_device* m_grom[5]; bool m_grom_idle; int m_grom_size; int m_rom_size; int m_ram_size; - int m_bank_mask = 0; + int m_bank_mask; uint8_t* m_rom_ptr; uint8_t* m_ram_ptr; diff --git a/src/devices/bus/ti99/gromport/gromport.h b/src/devices/bus/ti99/gromport/gromport.h index 10d94cf432c..74c844d7ed7 100644 --- a/src/devices/bus/ti99/gromport/gromport.h +++ b/src/devices/bus/ti99/gromport/gromport.h @@ -99,7 +99,7 @@ protected: virtual void device_config_complete() override; gromport_device* m_gromport; - bool m_grom_selected = false; + bool m_grom_selected; }; } // end namespace bus::ti99::gromport diff --git a/src/devices/bus/ti99/gromport/multiconn.h b/src/devices/bus/ti99/gromport/multiconn.h index d41ea462e01..517224eff14 100644 --- a/src/devices/bus/ti99/gromport/multiconn.h +++ b/src/devices/bus/ti99/gromport/multiconn.h @@ -45,11 +45,11 @@ protected: virtual ioport_constructor device_input_ports() const override; private: - bool m_readrom = false; + bool m_readrom; int m_active_slot; int m_fixed_slot; int m_next_free_slot; - ti99_cartridge_device* m_cartridge[NUMBER_OF_CARTRIDGE_SLOTS]{}; + ti99_cartridge_device* m_cartridge[NUMBER_OF_CARTRIDGE_SLOTS]; void set_slot(int slotnumber); int get_active_slot(bool changebase, offs_t offset); diff --git a/src/devices/bus/ti99/internal/998board.h b/src/devices/bus/ti99/internal/998board.h index 410313d43bf..86c5da12787 100644 --- a/src/devices/bus/ti99/internal/998board.h +++ b/src/devices/bus/ti99/internal/998board.h @@ -236,7 +236,7 @@ private: video_waitstate_generator m_vidws; // Pointer to mainboard - mainboard8_device* m_mainboard = nullptr; + mainboard8_device* m_mainboard; }; /* @@ -323,7 +323,7 @@ private: int m_msast = 0; // Pointer to mainboard - mainboard8_device* m_mainboard = nullptr; + mainboard8_device* m_mainboard; }; /* @@ -381,7 +381,7 @@ private: uint8_t* m_sram = nullptr; // Pointer to mainboard - mainboard8_device* m_mainboard = nullptr; + mainboard8_device* m_mainboard; // Keep the system ready state int m_srdy = 0; diff --git a/src/devices/bus/ti99/internal/genkbd.h b/src/devices/bus/ti99/internal/genkbd.h index 147474c97e3..a54951e2134 100644 --- a/src/devices/bus/ti99/internal/genkbd.h +++ b/src/devices/bus/ti99/internal/genkbd.h @@ -40,8 +40,8 @@ protected: virtual DECLARE_WRITE_LINE_MEMBER( data_write ) override; private: - emu_timer *m_poll_timer = nullptr; - emu_timer *m_send_timer = nullptr; + emu_timer *m_poll_timer; + emu_timer *m_send_timer; static constexpr unsigned KEYQUEUESIZE = 256; static constexpr unsigned MAXKEYMSGLENGTH = 10; @@ -55,7 +55,7 @@ private: required_ioport_array<8> m_keys; int m_queue_length; - int m_queue_head = 0; + int m_queue_head; uint8_t m_queue[KEYQUEUESIZE]; uint32_t m_key_state_save[4]; int m_autorepeat_code; @@ -63,22 +63,22 @@ private: bool m_fake_shift_state; bool m_fake_unshift_state; - bool m_left_shift = false; - bool m_right_shift = false; - bool m_left_ctrl = false; - bool m_right_ctrl = false; - bool m_left_alt = false; - bool m_altgr = false; - bool m_numlock = false; + bool m_left_shift; + bool m_right_shift; + bool m_left_ctrl; + bool m_right_ctrl; + bool m_left_alt; + bool m_altgr; + bool m_numlock; bool m_resetting; line_state m_clock_line; line_state m_data_line; - int m_reset_timer = 0; + int m_reset_timer; - int m_shift_reg = 0; - int m_shift_count = 0; + int m_shift_reg; + int m_shift_count; }; diff --git a/src/devices/bus/ti99/peb/bwg.h b/src/devices/bus/ti99/peb/bwg.h index 17f17ca9ee3..671f584dc9a 100644 --- a/src/devices/bus/ti99/peb/bwg.h +++ b/src/devices/bus/ti99/peb/bwg.h @@ -113,7 +113,7 @@ private: required_device m_buffer_ram; // Link to the attached floppy drives - floppy_image_device* m_floppy[4]{}; + floppy_image_device* m_floppy[4]; // Currently selected floppy drive (1-4, 0=none) int m_sel_floppy; diff --git a/src/devices/bus/ti99/peb/cc_fdc.h b/src/devices/bus/ti99/peb/cc_fdc.h index fa22a2a68b6..e72bfa3ea57 100644 --- a/src/devices/bus/ti99/peb/cc_fdc.h +++ b/src/devices/bus/ti99/peb/cc_fdc.h @@ -90,7 +90,7 @@ protected: void operate_ready_line(); // Link to the attached floppy drives - floppy_image_device* m_floppy[4]{}; + floppy_image_device* m_floppy[4]; // Motor monoflop required_device m_motormf; diff --git a/src/devices/bus/ti99/peb/evpc.h b/src/devices/bus/ti99/peb/evpc.h index b32d8cbec94..683933a5780 100644 --- a/src/devices/bus/ti99/peb/evpc.h +++ b/src/devices/bus/ti99/peb/evpc.h @@ -42,11 +42,11 @@ public: protected: struct evpc_palette { - uint8_t read_index = 0, write_index = 0, mask = 0; - int read = 0; - int state = 0; - struct { uint8_t red = 0, green = 0, blue = 0; } color[0x100]; - //int dirty = 0; + uint8_t read_index, write_index, mask; + int read; + int state; + struct { uint8_t red, green, blue; } color[0x100]; + //int dirty; }; void device_start() override; @@ -66,7 +66,7 @@ private: DECLARE_WRITE_LINE_MEMBER( video_interrupt_in ); - int m_address = 0; + int m_address; int m_dsr_page; bool m_inDsrArea; bool m_novram_accessed; diff --git a/src/devices/bus/ti99/peb/hfdc.h b/src/devices/bus/ti99/peb/hfdc.h index e6db9687738..c7c17834b79 100644 --- a/src/devices/bus/ti99/peb/hfdc.h +++ b/src/devices/bus/ti99/peb/hfdc.h @@ -100,10 +100,10 @@ private: required_device m_clock; // Link to the attached floppy drives - floppy_image_device* m_floppy_unit[4]{}; + floppy_image_device* m_floppy_unit[4]; // Link to the attached hard disks - mfm_harddisk_device* m_harddisk_unit[3]{}; + mfm_harddisk_device* m_harddisk_unit[3]; // Currently selected floppy drive floppy_image_device* m_current_floppy; diff --git a/src/devices/bus/ti99/peb/horizon.h b/src/devices/bus/ti99/peb/horizon.h index 53177486603..72ab43a08fc 100644 --- a/src/devices/bus/ti99/peb/horizon.h +++ b/src/devices/bus/ti99/peb/horizon.h @@ -77,8 +77,8 @@ private: int m_cru_base_phoenix; // Debugging - int m_current_bank = 0; - int m_current_page = 0; + int m_current_bank; + int m_current_page; }; } // end namespace bus::ti99::peb diff --git a/src/devices/bus/ti99/peb/memex.h b/src/devices/bus/ti99/peb/memex.h index 7e4231bd71a..32c56326d47 100644 --- a/src/devices/bus/ti99/peb/memex.h +++ b/src/devices/bus/ti99/peb/memex.h @@ -39,7 +39,7 @@ protected: private: bool access_enabled(offs_t offset); required_device m_ram; - uint8_t m_switches = 0; + uint8_t m_switches; }; } // end namespace bus::ti99::peb diff --git a/src/devices/bus/ti99/peb/myarcfdc.h b/src/devices/bus/ti99/peb/myarcfdc.h index f5cab180943..7eacdd79f26 100644 --- a/src/devices/bus/ti99/peb/myarcfdc.h +++ b/src/devices/bus/ti99/peb/myarcfdc.h @@ -86,7 +86,7 @@ private: uint8_t* m_dsrrom; // Link to the attached floppy drives - floppy_image_device* m_floppy[4]{}; + floppy_image_device* m_floppy[4]; // Debugger accessors void debug_read(offs_t offset, uint8_t* value); diff --git a/src/devices/bus/ti99/peb/peribox.h b/src/devices/bus/ti99/peb/peribox.h index e78e8cba459..157c2099106 100644 --- a/src/devices/bus/ti99/peb/peribox.h +++ b/src/devices/bus/ti99/peb/peribox.h @@ -191,7 +191,7 @@ protected: device_ti99_peribox_card_interface(const machine_config &mconfig, device_t &device); virtual void interface_config_complete() override; - peribox_slot_device *m_slot = nullptr; // using a link to the slot for callbacks + peribox_slot_device *m_slot; // using a link to the slot for callbacks int m_senila; int m_senilb; diff --git a/src/devices/bus/ti99/peb/pgram.h b/src/devices/bus/ti99/peb/pgram.h index 04c24848c19..d050c3deac7 100644 --- a/src/devices/bus/ti99/peb/pgram.h +++ b/src/devices/bus/ti99/peb/pgram.h @@ -43,9 +43,9 @@ private: void device_add_mconfig(machine_config &config) override; // Settings - bool m_active = false; - uint16_t m_crubase = 0; - bool m_pgramplus = false; + bool m_active; + uint16_t m_crubase; + bool m_pgramplus; ioport_constructor device_input_ports() const override; diff --git a/src/devices/bus/ti99/peb/scsicard.h b/src/devices/bus/ti99/peb/scsicard.h index adee7f9dbcf..a55ad228886 100644 --- a/src/devices/bus/ti99/peb/scsicard.h +++ b/src/devices/bus/ti99/peb/scsicard.h @@ -61,13 +61,13 @@ private: required_device m_scsibus; // DSR ROM - uint8_t* m_eprom = nullptr; + uint8_t* m_eprom; // Recent address - int m_address = 0; + int m_address; // Settings - int m_sw2 = 0; + int m_sw2; // Latches for the lines // Should be removed and accessor functions be added to ncr5380 diff --git a/src/devices/bus/ti99/peb/ti_fdc.h b/src/devices/bus/ti99/peb/ti_fdc.h index df3f37cda62..81c2324dbc9 100644 --- a/src/devices/bus/ti99/peb/ti_fdc.h +++ b/src/devices/bus/ti99/peb/ti_fdc.h @@ -87,7 +87,7 @@ private: bool m_inDsrArea; // When true the CPU is halted while DRQ/IRQ are true. - bool m_WAITena = false; + bool m_WAITena; // WD chip selected bool m_WDsel; @@ -105,7 +105,7 @@ private: uint8_t* m_dsrrom; // Link to the attached floppy drives - floppy_image_device* m_floppy[3]{}; + floppy_image_device* m_floppy[3]; // Currently selected floppy drive int m_sel_floppy; diff --git a/src/devices/bus/ti99/peb/tipi.h b/src/devices/bus/ti99/peb/tipi.h index 0b45672b8b6..609b9d491df 100644 --- a/src/devices/bus/ti99/peb/tipi.h +++ b/src/devices/bus/ti99/peb/tipi.h @@ -64,23 +64,23 @@ private: bool m_portaccess; // DSR ROM - uint8_t* m_eprom = nullptr; + uint8_t* m_eprom; // Websocket support std::unique_ptr m_wsclient; std::shared_ptr m_send_stream; std::unique_ptr m_rpimessage; - int m_msgindex = 0; - int m_msglength = 0; - emu_timer* m_restart_timer = nullptr; - int m_attempts = 0; - bool m_connected = 0; + int m_msgindex; + int m_msglength; + emu_timer* m_restart_timer; + int m_attempts; + bool m_connected; // Computer interface - u8 m_tc = 0; - u8 m_td = 0; - u8 m_rc = 0; - u8 m_rd = 0; + u8 m_tc; + u8 m_td; + u8 m_rc; + u8 m_rd; }; /* diff --git a/src/devices/bus/ti99/peb/tn_ide.h b/src/devices/bus/ti99/peb/tn_ide.h index 189e794c6ca..f3174e2c0ee 100644 --- a/src/devices/bus/ti99/peb/tn_ide.h +++ b/src/devices/bus/ti99/peb/tn_ide.h @@ -63,7 +63,7 @@ private: int m_page; // Is the SRAM buffered? - bool m_srammap = false; + bool m_srammap; // RTC type int m_rtctype; @@ -77,7 +77,7 @@ private: void decode(offs_t offset, bool& mmap, bool& sramsel, bool& xramsel, bool& rtcsel, bool& cs1fx, bool& cs3fx); - int m_rtc_int = 0; + int m_rtc_int; }; } // end namespace bus::ti99::peb diff --git a/src/devices/bus/tmc600/euro.h b/src/devices/bus/tmc600/euro.h index 8d9badda1dc..699de5b8383 100644 --- a/src/devices/bus/tmc600/euro.h +++ b/src/devices/bus/tmc600/euro.h @@ -91,7 +91,7 @@ protected: // device-level overrides virtual void device_start() override; - device_tmc600_eurobus_card_interface *m_card = nullptr; + device_tmc600_eurobus_card_interface *m_card; }; diff --git a/src/devices/bus/vcs/dpc.h b/src/devices/bus/vcs/dpc.h index 378b2ab9af3..40dd844e800 100644 --- a/src/devices/bus/vcs/dpc.h +++ b/src/devices/bus/vcs/dpc.h @@ -30,13 +30,13 @@ protected: static constexpr device_timer_id TIMER_OSC = 0; struct df_t { - uint8_t top = 0; - uint8_t bottom = 0; - uint8_t low = 0; - uint8_t high = 0; - uint8_t flag = 0; - uint8_t music_mode = 0; /* Only used by data fetchers 5,6, and 7 */ - uint8_t osc_clk = 0; /* Only used by data fetchers 5,6, and 7 */ + uint8_t top; + uint8_t bottom; + uint8_t low; + uint8_t high; + uint8_t flag; + uint8_t music_mode; /* Only used by data fetchers 5,6, and 7 */ + uint8_t osc_clk; /* Only used by data fetchers 5,6, and 7 */ }; // device-level overrides diff --git a/src/devices/bus/vme/vme.h b/src/devices/bus/vme/vme.h index e68f4a9a125..e49b23cbbbe 100644 --- a/src/devices/bus/vme/vme.h +++ b/src/devices/bus/vme/vme.h @@ -118,7 +118,7 @@ protected: // callbacks devcb_write_line m_vme_j1_callback; - device_vme_card_interface *m_card = nullptr; + device_vme_card_interface *m_card; }; DECLARE_DEVICE_TYPE(VME, vme_device) @@ -195,12 +195,12 @@ protected: virtual space_config_vector memory_space_config() const override; // internal state - cpu_device *m_maincpu = nullptr; + cpu_device *m_maincpu; // address spaces - address_space *m_prgspace = nullptr; - int m_prgwidth = 0; - bool m_allocspaces = false; + address_space *m_prgspace; + int m_prgwidth; + bool m_allocspaces; const char *m_cputag; diff --git a/src/devices/bus/vme/vme_cp31.h b/src/devices/bus/vme/vme_cp31.h index 0fd806b9b36..5921eef9fe8 100644 --- a/src/devices/bus/vme/vme_cp31.h +++ b/src/devices/bus/vme/vme_cp31.h @@ -46,11 +46,11 @@ private: // Pointer to System ROMs needed by bootvect_r and masking RAM buffer for post reset accesses memory_passthrough_handler m_rom_shadow_tap; - bool m_bus_error = false; - emu_timer *m_bus_error_timer = nullptr; + bool m_bus_error; + emu_timer *m_bus_error_timer; - uint8_t bim_irq_state = 0; - int bim_irq_level = 0; + uint8_t bim_irq_state; + int bim_irq_level; DECLARE_WRITE_LINE_MEMBER(bim_irq_callback); void update_irq_to_maincpu(); diff --git a/src/devices/bus/vme/vme_fccpu20.h b/src/devices/bus/vme/vme_fccpu20.h index d45443165ce..ae26d07eccc 100644 --- a/src/devices/bus/vme/vme_fccpu20.h +++ b/src/devices/bus/vme/vme_fccpu20.h @@ -49,10 +49,10 @@ protected: virtual void device_add_mconfig(machine_config &config) override; virtual const tiny_rom_entry *device_rom_region() const override; - uint8_t bim_irq_state = 0; - int bim_irq_level = 0; + uint8_t bim_irq_state; + int bim_irq_level; - emu_timer *m_arbiter_start = nullptr; // Need a startup delay because it is hooked up to the sense inputs of the PIT + emu_timer *m_arbiter_start; // Need a startup delay because it is hooked up to the sense inputs of the PIT required_device m_maincpu; @@ -78,7 +78,7 @@ private: required_device m_mpcc3; // Pointer to System ROMs needed by bootvect_r and masking RAM buffer for post reset accesses - uint32_t *m_sysrom = nullptr; + uint32_t *m_sysrom; uint32_t m_sysram[2]; void update_irq_to_maincpu(); const fc_board_t m_board_id; diff --git a/src/devices/bus/vme/vme_fcisio.h b/src/devices/bus/vme/vme_fcisio.h index 1f1e8f43a95..6ffecb0e6af 100644 --- a/src/devices/bus/vme/vme_fcisio.h +++ b/src/devices/bus/vme/vme_fcisio.h @@ -48,7 +48,7 @@ private: required_device m_bim; // Pointer to System ROMs needed by bootvect_r - uint16_t *m_sysrom = nullptr; + uint16_t *m_sysrom; }; #endif // MAME_BUS_VME_VME_FCISIO_H diff --git a/src/devices/bus/vme/vme_fcscsi.h b/src/devices/bus/vme/vme_fcscsi.h index 32b39687a18..58c57c88fdc 100644 --- a/src/devices/bus/vme/vme_fcscsi.h +++ b/src/devices/bus/vme/vme_fcscsi.h @@ -30,8 +30,8 @@ protected: void update_irq_to_maincpu(); - uint8_t fdc_irq_state = 0; - uint8_t dmac_irq_state = 0; + uint8_t fdc_irq_state; + uint8_t dmac_irq_state; private: //dmac @@ -66,7 +66,7 @@ private: uint8_t m_tcr; // Pointer to System ROMs needed by bootvect_r - uint16_t *m_sysrom = nullptr; + uint16_t *m_sysrom; }; #endif // MAME_BUS_VME_VME_FCSCSI_H diff --git a/src/devices/bus/vme/vme_hcpu30.h b/src/devices/bus/vme/vme_hcpu30.h index b210f9f03f3..656e8b716b6 100644 --- a/src/devices/bus/vme/vme_hcpu30.h +++ b/src/devices/bus/vme/vme_hcpu30.h @@ -62,13 +62,13 @@ private: // Pointer to System ROMs needed by bootvect_r and masking RAM buffer for post reset accesses memory_passthrough_handler m_rom_shadow_tap; - uint16_t m_irq_state = 0; - uint16_t m_irq_mask = 0; - uint8_t m_rtc_reg[16]{}; - bool m_rtc_hack = false; - int m_fdcdrq_hack = 0; - bool m_bus_error = false; - emu_timer *m_bus_error_timer = nullptr; + uint16_t m_irq_state; + uint16_t m_irq_mask; + uint8_t m_rtc_reg[16]; + bool m_rtc_hack; + int m_fdcdrq_hack; + bool m_bus_error; + emu_timer *m_bus_error_timer; uint32_t irq_state_r(offs_t offset); void irq_mask_w(offs_t offset, uint32_t data, uint32_t mem_mask = ~0); diff --git a/src/devices/bus/vsmile/rom.h b/src/devices/bus/vsmile/rom.h index 4374fa028f7..b9ac8ef0b07 100644 --- a/src/devices/bus/vsmile/rom.h +++ b/src/devices/bus/vsmile/rom.h @@ -31,7 +31,7 @@ protected: virtual void device_start() override; virtual void device_resolve_objects() override; - uint32_t m_bank_offset = 0; + uint32_t m_bank_offset; }; diff --git a/src/devices/bus/vtech/ioexp/ioexp.h b/src/devices/bus/vtech/ioexp/ioexp.h index 0ebcd9410ee..c851d0e0d48 100644 --- a/src/devices/bus/vtech/ioexp/ioexp.h +++ b/src/devices/bus/vtech/ioexp/ioexp.h @@ -66,7 +66,7 @@ protected: private: required_address_space m_iospace; - device_vtech_ioexp_interface *m_module = nullptr; + device_vtech_ioexp_interface *m_module; }; // class representing interface-specific live ioexp device diff --git a/src/devices/bus/vtech/memexp/memexp.h b/src/devices/bus/vtech/memexp/memexp.h index 02d00bce172..5fd3ee6a449 100644 --- a/src/devices/bus/vtech/memexp/memexp.h +++ b/src/devices/bus/vtech/memexp/memexp.h @@ -89,7 +89,7 @@ private: devcb_write_line m_nmi_handler; devcb_write_line m_reset_handler; - device_vtech_memexp_interface *m_module = nullptr; + device_vtech_memexp_interface *m_module; }; // class representing interface-specific live memexp device diff --git a/src/devices/bus/wswan/rom.h b/src/devices/bus/wswan/rom.h index a7d8ba4c113..6a99f98e3a4 100644 --- a/src/devices/bus/wswan/rom.h +++ b/src/devices/bus/wswan/rom.h @@ -34,7 +34,7 @@ protected: u16 m_io_regs[8]; u32 m_base20, m_base30, m_base40; - u32 m_rom_mask = 0; + u32 m_rom_mask; // RTC u8 m_rtc_setting; /* Timer setting byte */ @@ -122,14 +122,14 @@ private: READ_MODE = 0, COMMAND_MODE }; - u8 m_flash_seq = 0; - u8 m_flash_command = 0; - bool m_write_flash = false; - bool m_writing_flash = false; - bool m_write_resetting = false; - u8 m_flash_mode = 0; - u8 m_flash_status = 0; - u8 m_flash_count = 0; + u8 m_flash_seq; + u8 m_flash_command; + bool m_write_flash; + bool m_writing_flash; + bool m_write_resetting; + u8 m_flash_mode; + u8 m_flash_status; + u8 m_flash_count; }; diff --git a/src/devices/machine/53c810.h b/src/devices/machine/53c810.h index e6e28bcf06c..b6ecd035072 100644 --- a/src/devices/machine/53c810.h +++ b/src/devices/machine/53c810.h @@ -72,36 +72,36 @@ private: uint32_t lsi53c810_dasm_fetch(uint32_t pc); unsigned lsi53c810_dasm(char *buf, uint32_t pc); - uint8_t scntl0 = 0; - uint8_t scntl1 = 0; - uint8_t scntl2 = 0; - uint8_t scntl3 = 0; - uint8_t scid = 0; - uint8_t sxfer = 0; - uint8_t socl = 0; - uint8_t istat = 0; - uint8_t dstat = 0; - uint8_t sstat0 = 0; - uint8_t sstat1 = 0; - uint8_t sstat2 = 0; - uint8_t dien = 0; - uint8_t dcntl = 0; - uint8_t dmode = 0; - uint32_t temp = 0; - uint32_t dsa = 0; - uint32_t dsp = 0; - uint32_t dsps = 0; - uint32_t dcmd = 0; - uint8_t sien0 = 0; - uint8_t sien1 = 0; - uint8_t stime0 = 0; - uint8_t respid = 0; - uint8_t stest1 = 0; - uint8_t scratch_a[4]{}; - uint8_t scratch_b[4]{}; - int dma_icount = 0; - int halted = 0; - int carry = 0; + uint8_t scntl0; + uint8_t scntl1; + uint8_t scntl2; + uint8_t scntl3; + uint8_t scid; + uint8_t sxfer; + uint8_t socl; + uint8_t istat; + uint8_t dstat; + uint8_t sstat0; + uint8_t sstat1; + uint8_t sstat2; + uint8_t dien; + uint8_t dcntl; + uint8_t dmode; + uint32_t temp; + uint32_t dsa; + uint32_t dsp; + uint32_t dsps; + uint32_t dcmd; + uint8_t sien0; + uint8_t sien1; + uint8_t stime0; + uint8_t respid; + uint8_t stest1; + uint8_t scratch_a[4]; + uint8_t scratch_b[4]; + int dma_icount; + int halted; + int carry; }; // device type definition diff --git a/src/devices/machine/68340ser.h b/src/devices/machine/68340ser.h index 62a9401c4cc..b9775f2ad86 100644 --- a/src/devices/machine/68340ser.h +++ b/src/devices/machine/68340ser.h @@ -30,13 +30,13 @@ public: void module_reset(); protected: - m68340_cpu_device *m_cpu = nullptr; + m68340_cpu_device *m_cpu; // Module registers not in the DUART part - uint8_t m_mcrh = 0; - uint8_t m_mcrl = 0; - uint8_t m_ilr = 0; - uint8_t m_ivr = 0; + uint8_t m_mcrh; + uint8_t m_mcrl; + uint8_t m_ilr; + uint8_t m_ivr; enum { REG_MCRH = 0, diff --git a/src/devices/machine/acorn_memc.h b/src/devices/machine/acorn_memc.h index 75354f65cd1..930e7477b19 100644 --- a/src/devices/machine/acorn_memc.h +++ b/src/devices/machine/acorn_memc.h @@ -71,28 +71,28 @@ private: optional_device m_vidc; const address_space_config m_space_config; - address_space * m_space = nullptr; + address_space * m_space; devcb_write_line m_abort_w; devcb_write_line m_sirq_w; - bool m_output_dram_rowcol = false; - int m_spvmd = 0; - uint8_t m_pagesize = 0; - bool m_latchrom = false; - bool m_video_dma_on = false; - bool m_sound_dma_on = false; - bool m_cursor_enabled = false; - bool m_os_mode = false; - uint32_t m_vidinit = 0; - uint32_t m_vidstart = 0; - uint32_t m_vidend = 0; - uint32_t m_vidcur = 0; - uint32_t m_cinit = 0; - uint32_t m_sndstart = 0; - uint32_t m_sndend = 0; - uint32_t m_sndcur = 0; - uint32_t m_sndendcur = 0; - int16_t m_pages[0x2000]{}; // the logical RAM area is 32 megs, and the smallest page size is 4k - uint8_t m_pages_ppl[0x2000]{}; + bool m_output_dram_rowcol; + int m_spvmd; + uint8_t m_pagesize; + bool m_latchrom; + bool m_video_dma_on; + bool m_sound_dma_on; + bool m_cursor_enabled; + bool m_os_mode; + uint32_t m_vidinit; + uint32_t m_vidstart; + uint32_t m_vidend; + uint32_t m_vidcur; + uint32_t m_cinit; + uint32_t m_sndstart; + uint32_t m_sndend; + uint32_t m_sndcur; + uint32_t m_sndendcur; + int16_t m_pages[0x2000]; // the logical RAM area is 32 megs, and the smallest page size is 4k + uint8_t m_pages_ppl[0x2000]; }; diff --git a/src/devices/machine/acorn_vidc.h b/src/devices/machine/acorn_vidc.h index a2fdf7bae6b..5b68aefc559 100644 --- a/src/devices/machine/acorn_vidc.h +++ b/src/devices/machine/acorn_vidc.h @@ -179,13 +179,13 @@ private: void vidc20_sound_control_w(u32 data); void fsynreg_w(u32 data); - u8 m_pal_data_index = 0; + u8 m_pal_data_index; inline void update_8bpp_palette(u16 index, u32 paldata); - bool m_dac_serial_mode = false; - u8 m_pixel_source = 0; - u8 m_pixel_rate = 0; - u8 m_vco_r_modulo = 0; - u8 m_vco_v_modulo = 0; + bool m_dac_serial_mode; + u8 m_pixel_source; + u8 m_pixel_rate; + u8 m_vco_r_modulo; + u8 m_vco_v_modulo; }; DECLARE_DEVICE_TYPE(ARM_VIDC20, arm_vidc20_device) diff --git a/src/devices/machine/adc083x.h b/src/devices/machine/adc083x.h index be1ed368a44..babde2515b1 100644 --- a/src/devices/machine/adc083x.h +++ b/src/devices/machine/adc083x.h @@ -67,7 +67,7 @@ private: int32_t m_clk; int32_t m_di; int32_t m_se; - int32_t m_sars = 0; + int32_t m_sars; int32_t m_do; int32_t m_sgl; int32_t m_odd; diff --git a/src/devices/machine/adc1213x.h b/src/devices/machine/adc1213x.h index 89fef9396e7..7d3f69caccd 100644 --- a/src/devices/machine/adc1213x.h +++ b/src/devices/machine/adc1213x.h @@ -48,17 +48,17 @@ protected: private: // internal state - int m_cycle = 0; - int m_data_out = 0; - int m_data_in = 0; - int m_conv_mode = 0; - int m_auto_cal = 0; - int m_auto_zero = 0; - int m_acq_time = 0; - int m_data_out_sign = 0; - int m_input_shift_reg = 0; - int m_output_shift_reg = 0; - int m_end_conv = 0; + int m_cycle; + int m_data_out; + int m_data_in; + int m_conv_mode; + int m_auto_cal; + int m_auto_zero; + int m_acq_time; + int m_data_out_sign; + int m_input_shift_reg; + int m_output_shift_reg; + int m_end_conv; }; diff --git a/src/devices/machine/aic6250.h b/src/devices/machine/aic6250.h index e758745322b..048aa6de0c8 100644 --- a/src/devices/machine/aic6250.h +++ b/src/devices/machine/aic6250.h @@ -247,34 +247,34 @@ private: }; // internal state - emu_timer *m_state_timer = nullptr; - state_t m_state{}; - bool m_int_asserted = false; + emu_timer *m_state_timer; + state_t m_state; + bool m_int_asserted; - u32 m_scsi_ctrl_state = 0; + u32 m_scsi_ctrl_state; - u8 m_address_reg = 0; + u8 m_address_reg; // registers - u32 m_dma_count = 0; - bool m_offset_count_zero = false; - u8 m_rev_cntrl = 0; - u8 m_status_reg_0 = 0; - u8 m_status_reg_1 = 0; - u8 m_scsi_signal_reg = 0; - u8 m_scsi_id_data = 0; - u8 m_source_dest_id = 0; - u8 m_memory_data = 0; - u8 m_port_a_latch = 0; - u8 m_port_b_latch = 0; - u8 m_scsi_latch_data = 0; - - u8 m_int_msk_reg_0 = 0; - u8 m_offset_cntrl = 0; - u8 m_dma_cntrl = 0; - u8 m_int_msk_reg_1 = 0; - u8 m_control_reg_0 = 0; - u8 m_control_reg_1 = 0; + u32 m_dma_count; + bool m_offset_count_zero; + u8 m_rev_cntrl; + u8 m_status_reg_0; + u8 m_status_reg_1; + u8 m_scsi_signal_reg; + u8 m_scsi_id_data; + u8 m_source_dest_id; + u8 m_memory_data; + u8 m_port_a_latch; + u8 m_port_b_latch; + u8 m_scsi_latch_data; + + u8 m_int_msk_reg_0; + u8 m_offset_cntrl; + u8 m_dma_cntrl; + u8 m_int_msk_reg_1; + u8 m_control_reg_0; + u8 m_control_reg_1; util::fifo m_fifo; }; diff --git a/src/devices/machine/am9517a.h b/src/devices/machine/am9517a.h index f252a6c6f36..e1dcec9576e 100644 --- a/src/devices/machine/am9517a.h +++ b/src/devices/machine/am9517a.h @@ -94,30 +94,30 @@ protected: virtual int transfer_size(int const channel) const { return 1; } int m_icount; - uint32_t m_address_mask = 0; + uint32_t m_address_mask; struct { - uint32_t m_address = 0; - uint32_t m_count = 0; - uint32_t m_base_address = 0; - uint32_t m_base_count = 0; - uint8_t m_mode = 0; + uint32_t m_address; + uint32_t m_count; + uint32_t m_base_address; + uint32_t m_base_count; + uint8_t m_mode; } m_channel[4]; - int m_msb = 0; - int m_hreq = 0; - int m_hack = 0; - int m_ready = 0; - int m_eop = 0; - int m_state = 0; - int m_current_channel = 0; - int m_last_channel = 0; - uint8_t m_command = 0; - uint8_t m_mask = 0; - uint8_t m_status = 0; - uint16_t m_temp = 0; - uint8_t m_request = 0; + int m_msb; + int m_hreq; + int m_hack; + int m_ready; + int m_eop; + int m_state; + int m_current_channel; + int m_last_channel; + uint8_t m_command; + uint8_t m_mask; + uint8_t m_status; + uint16_t m_temp; + uint8_t m_request; private: void dma_request(int channel, bool state); diff --git a/src/devices/machine/appldriv.h b/src/devices/machine/appldriv.h index 3a2fcc44b74..86f7c1658bf 100644 --- a/src/devices/machine/appldriv.h +++ b/src/devices/machine/appldriv.h @@ -53,16 +53,16 @@ public: unsigned int tween_tracks : 1; unsigned int track_loaded : 1; unsigned int track_dirty : 1; - int position = 0; - int spin_count = 0; /* simulate drive spin to fool RWTS test at $BD34 */ + int position; + int spin_count; /* simulate drive spin to fool RWTS test at $BD34 */ uint8_t track_data[APPLE2_NIBBLE_SIZE * APPLE2_SECTOR_COUNT]; protected: virtual void device_start() override; private: - int m_dividend = 0; - int m_divisor = 0; + int m_dividend; + int m_divisor; }; // device type definition diff --git a/src/devices/machine/applefdc.h b/src/devices/machine/applefdc.h index 3dc9a78f3d9..30a2bb50fc2 100644 --- a/src/devices/machine/applefdc.h +++ b/src/devices/machine/applefdc.h @@ -90,15 +90,15 @@ protected: private: // data that is constant for the lifetime of the emulation - emu_timer * m_motor_timer = nullptr; + emu_timer * m_motor_timer; applefdc_t m_type; const applefdc_interface *m_interface; // data that changes at emulation time - uint8_t m_write_byte = 0; - uint8_t m_lines = 0; /* flags from IWM_MOTOR - IWM_Q7 */ - uint8_t m_mode = 0; /* 0-31; see above */ - uint8_t m_handshake_hack = 0; /* not sure what this is for */ + uint8_t m_write_byte; + uint8_t m_lines; /* flags from IWM_MOTOR - IWM_Q7 */ + uint8_t m_mode; /* 0-31; see above */ + uint8_t m_handshake_hack; /* not sure what this is for */ // functions const applefdc_interface *get_interface(); diff --git a/src/devices/machine/at28c16.h b/src/devices/machine/at28c16.h index a1c7a876c1d..cdfe55243f1 100644 --- a/src/devices/machine/at28c16.h +++ b/src/devices/machine/at28c16.h @@ -48,7 +48,7 @@ protected: private: // internal state address_space_config m_space_config; - emu_timer *m_write_timer = nullptr; + emu_timer *m_write_timer; int m_a9_12v; int m_oe_12v; int m_last_write; diff --git a/src/devices/machine/at28c64b.h b/src/devices/machine/at28c64b.h index 7b18986b1e7..83d74cda5a4 100644 --- a/src/devices/machine/at28c64b.h +++ b/src/devices/machine/at28c64b.h @@ -57,7 +57,7 @@ private: }; address_space_config m_space_config; - emu_timer *m_write_timer = nullptr; + emu_timer *m_write_timer; int m_a9_12v; int m_oe_12v; int m_last_write; diff --git a/src/devices/machine/at29x.h b/src/devices/machine/at29x.h index 8a8697a3a70..d32c159b8b6 100644 --- a/src/devices/machine/at29x.h +++ b/src/devices/machine/at29x.h @@ -44,8 +44,8 @@ protected: int m_cycle_time; // ms int m_boot_block_size; int m_version; - int m_address_mask = 0; - int m_sector_mask = 0; + int m_address_mask; + int m_sector_mask; private: enum s_cmd_t @@ -67,22 +67,22 @@ private: std::unique_ptr m_eememory; - bool m_lower_bbl = false; // set when lower boot block lockout is enabled - bool m_higher_bbl = false; // set when upper boot block lockout is enabled - bool m_sdp = false; // set when in software data protect mode + bool m_lower_bbl; // set when lower boot block lockout is enabled + bool m_higher_bbl; // set when upper boot block lockout is enabled + bool m_sdp; // set when in software data protect mode - bool m_id_mode = false; // set when in chip id mode - s_cmd_t m_cmd{}; // command state - bool m_enabling_bbl = false; // set when a boot block lockout command is expecting its parameter - bool m_long_sequence = false; // set if 0x80 command has just been executed (some command require this prefix) - s_pgm_t m_pgm{}; // programming state - bool m_enabling_sdb = false; // set when a sdp enable command is in progress - bool m_disabling_sdb = false; // set when a sdp disable command is in progress - bool m_toggle_bit = false; // indicates flashing in progress (toggles for each query) + bool m_id_mode; // set when in chip id mode + s_cmd_t m_cmd; // command state + bool m_enabling_bbl; // set when a boot block lockout command is expecting its parameter + bool m_long_sequence; // set if 0x80 command has just been executed (some command require this prefix) + s_pgm_t m_pgm; // programming state + bool m_enabling_sdb; // set when a sdp enable command is in progress + bool m_disabling_sdb; // set when a sdp disable command is in progress + bool m_toggle_bit; // indicates flashing in progress (toggles for each query) std::unique_ptr m_programming_buffer; - int m_programming_last_offset = 0; - emu_timer* m_programming_timer = nullptr; + int m_programming_last_offset; + emu_timer* m_programming_timer; }; /* diff --git a/src/devices/machine/at45dbxx.h b/src/devices/machine/at45dbxx.h index ceebf2a4d33..2521ac10acc 100644 --- a/src/devices/machine/at45dbxx.h +++ b/src/devices/machine/at45dbxx.h @@ -61,38 +61,38 @@ protected: // internal state std::vector m_data; - uint32_t m_size = 0; - uint8_t m_mode = 0; - uint8_t m_status = 0; + uint32_t m_size; + uint8_t m_mode; + uint8_t m_status; std::vector m_buffer1; //std::vector m_buffer2; - uint8_t m_si_byte = 0; - uint8_t m_si_bits = 0; - uint8_t m_so_byte = 0; - uint8_t m_so_bits = 0; + uint8_t m_si_byte; + uint8_t m_si_bits; + uint8_t m_so_byte; + uint8_t m_so_bits; struct AT45DBXX_PINS { - int cs = 0; // chip select - int sck = 0; // serial clock - int si = 0; // serial input - int so = 0; // serial output - int wp = 0; // write protect - int reset = 0; // reset - int busy = 0; // busy + int cs; // chip select + int sck; // serial clock + int si; // serial input + int so; // serial output + int wp; // write protect + int reset; // reset + int busy; // busy } m_pin; struct AT45DBXX_IO { - uint8_t *data = nullptr; - uint32_t size = 0; - uint32_t pos = 0; + uint8_t *data; + uint32_t size; + uint32_t pos; } m_io; struct AT45DBXX_CMD { - uint8_t data[8]{}; - uint8_t size = 0; + uint8_t data[8]; + uint8_t size; } m_cmd; }; diff --git a/src/devices/machine/ataflash.h b/src/devices/machine/ataflash.h index 9a402845a02..e52c78ee27a 100644 --- a/src/devices/machine/ataflash.h +++ b/src/devices/machine/ataflash.h @@ -30,10 +30,10 @@ protected: uint8_t calculate_status() override { return ata_hle_device::calculate_status(); } private: - uint8_t m_cis[512]{}; - uint8_t m_configuration_option = 0; - uint8_t m_configuration_and_status = 0; - uint8_t m_pin_replacement = 0; + uint8_t m_cis[512]; + uint8_t m_configuration_option; + uint8_t m_configuration_and_status; + uint8_t m_pin_replacement; }; DECLARE_DEVICE_TYPE(TAITO_PCCARD1, taito_pccard1_device) diff --git a/src/devices/machine/bl_handhelds_menucontrol.h b/src/devices/machine/bl_handhelds_menucontrol.h index af0f59ff60c..747a60db76b 100644 --- a/src/devices/machine/bl_handhelds_menucontrol.h +++ b/src/devices/machine/bl_handhelds_menucontrol.h @@ -32,17 +32,17 @@ private: bool m_is_unsp_type_hack; // internal state - uint16_t m_menupos = 0; + uint16_t m_menupos; // command handling - uint8_t m_clockstate = 0; - uint8_t m_datashifterpos = 0; + uint8_t m_clockstate; + uint8_t m_datashifterpos; - uint8_t m_responsebit = 0; - uint8_t m_response = 0; + uint8_t m_responsebit; + uint8_t m_response; - uint8_t m_commandbit = 0; - uint8_t m_command = 0; + uint8_t m_commandbit; + uint8_t m_command; void handle_command(); diff --git a/src/devices/machine/bq4847.h b/src/devices/machine/bq4847.h index 94d6fe0bc91..2658e207962 100644 --- a/src/devices/machine/bq4847.h +++ b/src/devices/machine/bq4847.h @@ -70,7 +70,7 @@ private: void update_int(); void set_wdo(int state); - emu_timer *m_update_timer = nullptr; + emu_timer *m_update_timer; emu_timer *m_periodic_timer; emu_timer *m_watchdog_timer; diff --git a/src/devices/machine/cop452.h b/src/devices/machine/cop452.h index 99a6295b98f..048c8c7d5cd 100644 --- a/src/devices/machine/cop452.h +++ b/src/devices/machine/cop452.h @@ -49,24 +49,24 @@ private: devcb_write_line::array<2> m_out_handlers; // Timers - emu_timer *m_timers[ 2 ]{}; + emu_timer *m_timers[ 2 ]; // State - uint8_t m_mode = 0; - bool m_clk_div_4 = false; - bool m_cs = false; - bool m_sk = false; - bool m_di = false; - bool m_out[ 2 ]{}; - bool m_regA_b16 = false; - uint16_t m_reg[ 2 ]{}; - uint16_t m_cnt[ 2 ]{}; + uint8_t m_mode; + bool m_clk_div_4; + bool m_cs; + bool m_sk; + bool m_di; + bool m_out[ 2 ]; + bool m_regA_b16; + uint16_t m_reg[ 2 ]; + uint16_t m_cnt[ 2 ]; // 0 : idle // 1..5 : shifting instruction in // 6..21: shifting register in // >= 22: done - unsigned m_spi_state = 0; - uint8_t m_sr = 0; + unsigned m_spi_state; + uint8_t m_sr; // Operating modes enum : uint8_t { diff --git a/src/devices/machine/corvushd.h b/src/devices/machine/corvushd.h index 5f304c0b5d1..01af8f2bd52 100644 --- a/src/devices/machine/corvushd.h +++ b/src/devices/machine/corvushd.h @@ -71,8 +71,8 @@ private: // Timing-related values uint16_t m_last_cylinder; // Last cylinder accessed - for calculating seek times uint32_t m_delay; // Delay in microseconds for callback - emu_timer *m_timeout_timer = nullptr; // Four-second timer for timeouts - emu_timer *m_cmd_timer = nullptr; + emu_timer *m_timeout_timer; // Four-second timer for timeouts + emu_timer *m_cmd_timer; bool m_invalid_command_flag; // I hate this, but it saves a lot more tests // @@ -344,8 +344,8 @@ private: // Command size structure (number of bytes to xmit and recv for each command) struct corvus_cmd_t { - uint16_t recv_bytes = 0; // Number of bytes from host for this command - uint16_t xmit_bytes = 0; // Number of bytes to return to host + uint16_t recv_bytes; // Number of bytes from host for this command + uint16_t xmit_bytes; // Number of bytes to return to host }; void dump_buffer(uint8_t *buffer, uint16_t length); diff --git a/src/devices/machine/cs8221.h b/src/devices/machine/cs8221.h index c6e3778894e..63b3102d5e9 100644 --- a/src/devices/machine/cs8221.h +++ b/src/devices/machine/cs8221.h @@ -58,9 +58,9 @@ private: uint8_t m_address; bool m_address_valid; - const char *m_cputag = nullptr; - const char *m_isatag = nullptr; - const char *m_biostag = nullptr; + const char *m_cputag; + const char *m_isatag; + const char *m_biostag; uint8_t m_registers[0x10]; diff --git a/src/devices/machine/dp8573.h b/src/devices/machine/dp8573.h index 59e793d9054..6a184ae8c6b 100644 --- a/src/devices/machine/dp8573.h +++ b/src/devices/machine/dp8573.h @@ -133,12 +133,12 @@ protected: ICR1_COMPARE_MASK = 0x3f }; - uint8_t m_ram[32]{}; - uint8_t m_tscr = 0; - uint8_t m_pfr = 0; - uint8_t m_millis = 0; + uint8_t m_ram[32]; + uint8_t m_tscr; + uint8_t m_pfr; + uint8_t m_millis; - emu_timer *m_timer = nullptr; + emu_timer *m_timer; devcb_write_line m_intr_cb; devcb_write_line m_mfo_cb; diff --git a/src/devices/machine/ds1302.h b/src/devices/machine/ds1302.h index a0dd44c4174..ea0a0d4e809 100644 --- a/src/devices/machine/ds1302.h +++ b/src/devices/machine/ds1302.h @@ -64,21 +64,21 @@ private: const uint8_t m_ram_size; - int m_ce = 0; - int m_clk = 0; - int m_io = 0; - int m_state = 0; - int m_bits = 0; - uint8_t m_cmd = 0; - uint8_t m_data = 0; - int m_addr = 0; - - uint8_t m_reg[9]{}; - uint8_t m_user[9]{}; - uint8_t m_ram[31]{}; + int m_ce; + int m_clk; + int m_io; + int m_state; + int m_bits; + uint8_t m_cmd; + uint8_t m_data; + int m_addr; + + uint8_t m_reg[9]; + uint8_t m_user[9]; + uint8_t m_ram[31]; // timers - emu_timer *m_clock_timer = nullptr; + emu_timer *m_clock_timer; }; // ======================> ds1202_device diff --git a/src/devices/machine/ds1994.h b/src/devices/machine/ds1994.h index dfb22bce905..df5c5216e30 100644 --- a/src/devices/machine/ds1994.h +++ b/src/devices/machine/ds1994.h @@ -120,7 +120,7 @@ class ds1994_device : public device_t, public device_nvram_interface uint8_t m_regs[REGS_SIZE]; int m_state[6]; int m_state_ptr; - bool m_auth = false; + bool m_auth; bool m_offs_ro; attotime t_samp, t_rdv, t_rstl, t_pdh, t_pdl; diff --git a/src/devices/machine/ds2404.h b/src/devices/machine/ds2404.h index 61096942dca..4301c2a050f 100644 --- a/src/devices/machine/ds2404.h +++ b/src/devices/machine/ds2404.h @@ -84,7 +84,7 @@ private: uint8_t m_sram[512]; /* 4096 bits */ uint8_t m_ram[32]; /* scratchpad ram, 256 bits */ uint8_t m_rtc[5]; /* 40-bit RTC counter */ - STATE m_state[8]{}; + STATE m_state[8]; int m_state_ptr; }; diff --git a/src/devices/machine/ds6417.h b/src/devices/machine/ds6417.h index d7200354b4a..94d5e109426 100644 --- a/src/devices/machine/ds6417.h +++ b/src/devices/machine/ds6417.h @@ -43,19 +43,19 @@ private: CMD_READMASK = 0x18, CMD_READCRC = 0x03 }; - bool m_reset = false; - bool m_clk = false; - bool m_data = false; - bool m_read = false; - bool m_start = false; - u8 m_count = 0; - u8 m_shiftreg = 0; - u8 m_command = 0; - u8 m_crc = 0; - u8 m_selbits = 0; - u32 m_addr = 0; - u16 m_select = 0; - u16 m_selectval = 0; + bool m_reset; + bool m_clk; + bool m_data; + bool m_read; + bool m_start; + u8 m_count; + u8 m_shiftreg; + u8 m_command; + u8 m_crc; + u8 m_selbits; + u32 m_addr; + u16 m_select; + u16 m_selectval; }; DECLARE_DEVICE_TYPE(DS6417, ds6417_device) diff --git a/src/devices/machine/edlc.h b/src/devices/machine/edlc.h index 6e8beca1d42..1a57841212a 100644 --- a/src/devices/machine/edlc.h +++ b/src/devices/machine/edlc.h @@ -119,21 +119,21 @@ protected: TXC_B = 0x60, // register bank select (80c03 only) }; - emu_timer *m_tx_timer = nullptr; - emu_timer *m_int_timer = nullptr; + emu_timer *m_tx_timer; + emu_timer *m_int_timer; // device state devcb_write_line m_out_int; devcb_write_line m_out_rxrdy; devcb_write_line m_out_txrdy; - int m_int_state = 0; - int m_reset_state = 0; - u8 m_station_address[6]{}; - u8 m_rx_status = 0; - u8 m_tx_status = 0; - u8 m_rx_command = 0; - u8 m_tx_command = 0; + int m_int_state; + int m_reset_state; + u8 m_station_address[6]; + u8 m_rx_status; + u8 m_tx_status; + u8 m_rx_command; + u8 m_tx_command; util::fifo m_rx_fifo; util::fifo m_tx_fifo; @@ -210,14 +210,14 @@ protected: CFG_RXC = 0x40, // receive crc CFG_FRD = 0x80, // fast receive discard }; - u16 m_tx_cc = 0; - u16 m_cc = 0; - u8 m_flags = 0; + u16 m_tx_cc; + u16 m_cc; + u8 m_flags; - u8 m_control = 0; - u8 m_config = 0; + u8 m_control; + u8 m_config; - u64 m_multicast_filter = 0; + u64 m_multicast_filter; }; DECLARE_DEVICE_TYPE(SEEQ8003, seeq8003_device) diff --git a/src/devices/machine/eepromser.h b/src/devices/machine/eepromser.h index ac61f8f4aa9..d3d33db19d6 100644 --- a/src/devices/machine/eepromser.h +++ b/src/devices/machine/eepromser.h @@ -198,10 +198,10 @@ protected: void copy_ram_to_eeprom(); void copy_eeprom_to_ram(); void device_start() override; - uint8_t m_ram_length = 0; - uint16_t m_ram_data[16]{}; - uint16_t m_reading = 0; - uint8_t m_store_latch = 0; + uint8_t m_ram_length; + uint16_t m_ram_data[16]; + uint16_t m_reading; + uint8_t m_store_latch; }; diff --git a/src/devices/machine/er1400.h b/src/devices/machine/er1400.h index 2945fb3763f..f8c6edb5614 100644 --- a/src/devices/machine/er1400.h +++ b/src/devices/machine/er1400.h @@ -81,7 +81,7 @@ private: // timing attotime m_write_time; attotime m_erase_time; - emu_timer *m_data_propagation_timer = nullptr; + emu_timer *m_data_propagation_timer; // internal registers u16 m_data_register; diff --git a/src/devices/machine/f3853.h b/src/devices/machine/f3853.h index 0654d58e8e9..f7d6adb3b5c 100644 --- a/src/devices/machine/f3853.h +++ b/src/devices/machine/f3853.h @@ -159,9 +159,9 @@ protected: virtual void timer_start(uint8_t value) override; - u8 m_timer_count = 0; - u8 m_timer_modulo = 0; - bool m_timer_start = false; + u8 m_timer_count; + u8 m_timer_modulo; + bool m_timer_start; }; class f38t56_device : public f3856_device diff --git a/src/devices/machine/generalplus_gpl16250soc.h b/src/devices/machine/generalplus_gpl16250soc.h index 757b6151967..e3dfd6aeb20 100644 --- a/src/devices/machine/generalplus_gpl16250soc.h +++ b/src/devices/machine/generalplus_gpl16250soc.h @@ -149,49 +149,49 @@ protected: uint16_t m_7863_porta_attribute; uint16_t m_786a_portb_direction; - uint16_t m_786b_portb_attribute = 0; + uint16_t m_786b_portb_attribute; - uint16_t m_7872_portc_direction = 0; - uint16_t m_7873_portc_attribute = 0; + uint16_t m_7872_portc_direction; + uint16_t m_7873_portc_attribute; - uint16_t m_787a_portd_direction = 0; - uint16_t m_787b_portd_attribute = 0; + uint16_t m_787a_portd_direction; + uint16_t m_787b_portd_attribute; - uint16_t m_7870 = 0; + uint16_t m_7870; - //uint16_t m_7871 = 0; + //uint16_t m_7871; - uint16_t m_7882 = 0; - uint16_t m_7883 = 0; + uint16_t m_7882; + uint16_t m_7883; - uint16_t m_78a0 = 0; + uint16_t m_78a0; - uint16_t m_78a4 = 0; - uint16_t m_78a5 = 0; - uint16_t m_78a6 = 0; + uint16_t m_78a4; + uint16_t m_78a5; + uint16_t m_78a6; - uint16_t m_78a8 = 0; + uint16_t m_78a8; - uint16_t m_78b0 = 0; - uint16_t m_78b1 = 0; - uint16_t m_78b2 = 0; + uint16_t m_78b0; + uint16_t m_78b1; + uint16_t m_78b2; - uint16_t m_78b8 = 0; + uint16_t m_78b8; - uint16_t m_78f0 = 0; + uint16_t m_78f0; - uint16_t m_78fb = 0; + uint16_t m_78fb; // unk 79xx - uint16_t m_7934 = 0; - uint16_t m_7935 = 0; - uint16_t m_7936 = 0; + uint16_t m_7934; + uint16_t m_7935; + uint16_t m_7936; - uint16_t m_7960 = 0; - uint16_t m_7961 = 0; + uint16_t m_7960; + uint16_t m_7961; - uint16_t m_system_dma_memtype = 0; + uint16_t m_system_dma_memtype; devcb_read16 m_nand_read_cb; uint32_t m_csbase; @@ -359,7 +359,7 @@ private: void checkirq6(); - emu_timer *m_unk_timer = nullptr; + emu_timer *m_unk_timer; virtual void device_timer(emu_timer &timer, device_timer_id id, int param) override; inline uint16_t read_space(uint32_t offset); @@ -423,21 +423,21 @@ private: void nand_785d_w(uint16_t data); uint16_t nand_785e_r(); - uint16_t m_nandcommand = 0; + uint16_t m_nandcommand; - uint16_t m_nand_addr_low = 0; - uint16_t m_nand_addr_high = 0; + uint16_t m_nand_addr_low; + uint16_t m_nand_addr_high; - uint16_t m_nand_dma_ctrl = 0; - uint16_t m_nand_7850 = 0; - uint16_t m_nand_785d = 0; - uint16_t m_nand_785c = 0; - uint16_t m_nand_785b = 0; - uint16_t m_nand_7856 = 0; - uint16_t m_nand_7857 = 0; + uint16_t m_nand_dma_ctrl; + uint16_t m_nand_7850; + uint16_t m_nand_785d; + uint16_t m_nand_785c; + uint16_t m_nand_785b; + uint16_t m_nand_7856; + uint16_t m_nand_7857; - int m_curblockaddr = 0; - uint32_t m_effectiveaddress = 0; + int m_curblockaddr; + uint32_t m_effectiveaddress; }; @@ -497,7 +497,7 @@ private: void spi_direct_78e8_w(uint16_t data); uint16_t spi_direct_79f4_r(); - uint16_t m_7af0 = 0; + uint16_t m_7af0; }; diff --git a/src/devices/machine/glukrs.h b/src/devices/machine/glukrs.h index bce641a5444..74c581ff068 100644 --- a/src/devices/machine/glukrs.h +++ b/src/devices/machine/glukrs.h @@ -28,7 +28,7 @@ protected: private: u8 m_cmos[0x100]; required_device m_nvram; - emu_timer *m_timer = nullptr; + emu_timer *m_timer; }; DECLARE_DEVICE_TYPE(GLUKRS, glukrs_device) diff --git a/src/devices/machine/gt64xxx.h b/src/devices/machine/gt64xxx.h index c2be80af604..0126dac306f 100644 --- a/src/devices/machine/gt64xxx.h +++ b/src/devices/machine/gt64xxx.h @@ -95,7 +95,7 @@ private: { uint32_t low_addr; uint32_t high_addr; - address_space* space = nullptr; + address_space* space; galileo_addr_map() : low_addr(0xffffffff), high_addr(0x0) {} }; diff --git a/src/devices/machine/gt913_io.h b/src/devices/machine/gt913_io.h index 866d4155fca..5bfed441c64 100644 --- a/src/devices/machine/gt913_io.h +++ b/src/devices/machine/gt913_io.h @@ -56,15 +56,15 @@ private: const char *m_intc_tag; /* timers */ - uint8_t m_timer_control[2]{}; - uint16_t m_timer_rate[2]{}; - int m_timer_irq[2]{}; - bool m_timer_irq_pending[2]{}; - emu_timer *m_timer[2]{}; + uint8_t m_timer_control[2]; + uint16_t m_timer_rate[2]; + int m_timer_irq[2]; + bool m_timer_irq_pending[2]; + emu_timer *m_timer[2]; /* 2x ADC */ - bool m_adc_enable = false, m_adc_channel = false; - uint8_t m_adc_data[2]{}; + bool m_adc_enable, m_adc_channel; + uint8_t m_adc_data[2]; }; diff --git a/src/devices/machine/gt913_snd.h b/src/devices/machine/gt913_snd.h index dfc5f4dcff1..5e0912ae5d2 100644 --- a/src/devices/machine/gt913_snd.h +++ b/src/devices/machine/gt913_snd.h @@ -44,7 +44,7 @@ protected: virtual void rom_bank_updated() override; private: - sound_stream *m_stream = nullptr; + sound_stream *m_stream; u8 m_gain; u16 m_data[3]; diff --git a/src/devices/machine/i82439hx.h b/src/devices/machine/i82439hx.h index e620b5e308b..e6a833c6cfb 100644 --- a/src/devices/machine/i82439hx.h +++ b/src/devices/machine/i82439hx.h @@ -38,15 +38,15 @@ protected: virtual void config_map(address_map &map) override; private: - int ram_size = 0; + int ram_size; required_device cpu; std::vector ram; - uint8_t latency_timer = 0, bist = 0; - uint8_t acon = 0, pcon = 0, cc = 0, dramec = 0, dramc = 0, dramt = 0; - uint8_t pam[7]{}, drb[8]{}; - uint8_t drt = 0, drat = 0, smram = 0, errcmd = 0, errsts = 0, errsyn = 0; - int smiact_n = 0; + uint8_t latency_timer, bist; + uint8_t acon, pcon, cc, dramec, dramc, dramt; + uint8_t pam[7], drb[8]; + uint8_t drt, drat, smram, errcmd, errsts, errsyn; + int smiact_n; virtual uint8_t header_type_r() override; void status_w(offs_t offset, uint16_t data, uint16_t mem_mask); diff --git a/src/devices/machine/i8251.h b/src/devices/machine/i8251.h index 60dcb6c0c7d..2bda850958e 100644 --- a/src/devices/machine/i8251.h +++ b/src/devices/machine/i8251.h @@ -109,44 +109,44 @@ private: bool calc_parity(u8 ch); /* flags controlling how i8251_control_w operates */ - uint8_t m_flags = 0; + uint8_t m_flags; /* number of sync bytes programmed for sync mode (1 or 2) ; 0 = async mode */ - uint8_t m_sync_byte_count = 0; + uint8_t m_sync_byte_count; /* the sync bytes written */ - u8 m_sync1 = 0; - u16 m_sync2 = 0; + u8 m_sync1; + u16 m_sync2; /* status of i8251 */ - uint8_t m_status = 0; - uint8_t m_command = 0; + uint8_t m_status; + uint8_t m_command; /* mode byte - bit definitions depend on mode - e.g. synchronous, asynchronous */ - uint8_t m_mode_byte = 0; - bool m_delayed_tx_en = false; + uint8_t m_mode_byte; + bool m_delayed_tx_en; bool m_cts; bool m_dsr; bool m_rxd; bool m_rxc; bool m_txc; - int m_rxc_count = 0; - int m_txc_count = 0; - int m_br_factor = 0; + int m_rxc_count; + int m_txc_count; + int m_br_factor; /* data being received */ - uint8_t m_rx_data = 0; + uint8_t m_rx_data; /* tx buffer */ - uint8_t m_tx_data = 0; + uint8_t m_tx_data; void sync1_w(uint8_t data); void sync2_w(uint8_t data); - uint8_t m_sync8 = 0; - uint16_t m_sync16 = 0; + uint8_t m_sync8; + uint16_t m_sync16; // 1 = ext sync enabled via command - bool m_syndet_pin = false; - bool m_hunt_on = false; + bool m_syndet_pin; + bool m_hunt_on; // 1 = ext syndet pin has been set high; 0 = hunt mode activated - bool m_ext_syn_set = false; + bool m_ext_syn_set; // count of rxd bits - u8 m_rxd_bits = 0; - u8 m_data_bits_count = 0; + u8 m_rxd_bits; + u8 m_data_bits_count; }; class v5x_scu_device : public i8251_device @@ -167,7 +167,7 @@ protected: void simk_w(u8 data) { m_simk = data; } private: - u8 m_simk = 0; + u8 m_simk; }; diff --git a/src/devices/machine/i82586.h b/src/devices/machine/i82586.h index 63615f1de5d..65ecff63329 100644 --- a/src/devices/machine/i82586.h +++ b/src/devices/machine/i82586.h @@ -296,7 +296,7 @@ private: virtual void cfg_set(int offset, u8 data) override { m_cfg_bytes[offset] = data; } u8 m_cfg_bytes[CFG_SIZE]; - u16 m_rbd_offset = 0; // next available receive buffer descriptor + u16 m_rbd_offset; // next available receive buffer descriptor }; class i82596_device : public i82586_base_device @@ -362,10 +362,10 @@ private: inline sysbus_mode mode() const { return (sysbus_mode)(m_sysbus & SYSBUS_M); } u8 m_cfg_bytes[CFG_SIZE]; - u8 m_sysbus = 0; + u8 m_sysbus; - u32 m_rbd_address = 0; // next available receive buffer descriptor - u64 m_mac_multi_ia = 0; // multi-ia address hash table + u32 m_rbd_address; // next available receive buffer descriptor + u64 m_mac_multi_ia; // multi-ia address hash table }; class i82596_le16_device : public i82596_device diff --git a/src/devices/machine/i82875p.h b/src/devices/machine/i82875p.h index f782f4daaaf..ecd252b35ef 100644 --- a/src/devices/machine/i82875p.h +++ b/src/devices/machine/i82875p.h @@ -41,14 +41,14 @@ protected: private: void agp_translation_map(address_map &map); - int ram_size = 0; + int ram_size; required_device cpu; std::vector ram; - uint8_t agpm = 0, fpllcont = 0, pam[8]{}, smram = 0, esmramc = 0; - uint8_t apsize = 0, amtt = 0, lptt = 0; - uint16_t toud = 0, mchcfg = 0, errcmd = 0, smicmd = 0, scicmd = 0, skpd = 0; - uint32_t agpctrl = 0, attbase = 0; + uint8_t agpm, fpllcont, pam[8], smram, esmramc; + uint8_t apsize, amtt, lptt; + uint16_t toud, mchcfg, errcmd, smicmd, scicmd, skpd; + uint32_t agpctrl, attbase; uint8_t agpm_r(); void agpm_w(uint8_t data); @@ -130,8 +130,8 @@ protected: private: void overflow_map(address_map &map); - uint8_t dram_row_boundary[8]{}, dram_row_attribute[4]{}; - uint32_t dram_timing = 0, dram_controller_mode = 0; + uint8_t dram_row_boundary[8], dram_row_attribute[4]; + uint32_t dram_timing, dram_controller_mode; }; DECLARE_DEVICE_TYPE(I82875P_HOST, i82875p_host_device) diff --git a/src/devices/machine/ie15.h b/src/devices/machine/ie15.h index be24c980d16..496874c5a86 100644 --- a/src/devices/machine/ie15.h +++ b/src/devices/machine/ie15.h @@ -106,32 +106,32 @@ private: std::unique_ptr m_tmpbmp; - emu_timer *m_hblank_timer = nullptr; + emu_timer *m_hblank_timer; - uint8_t m_long_beep = 0; - uint8_t m_kb_control = 0; - uint8_t m_kb_data = 0; - uint8_t m_kb_flag0 = 0; - uint8_t m_kb_flag = 0; - uint8_t m_kb_ruslat = 0; - uint8_t m_latch = 0; + uint8_t m_long_beep; + uint8_t m_kb_control; + uint8_t m_kb_data; + uint8_t m_kb_flag0; + uint8_t m_kb_flag; + uint8_t m_kb_ruslat; + uint8_t m_latch; struct { - uint8_t cursor = 0; - uint8_t enable = 0; - uint8_t line25 = 0; - uint32_t ptr1 = 0; - uint32_t ptr2 = 0; + uint8_t cursor; + uint8_t enable; + uint8_t line25; + uint32_t ptr1; + uint32_t ptr2; } m_video; - uint8_t m_serial_rx_ready = 0; - uint8_t m_serial_rx_char = 0; - uint8_t m_serial_tx_ready = 0; - int m_hblank = 0; - int m_vpos = 0; - int m_marker_scanline = 0; - bool m_kbd_sdv = false; + uint8_t m_serial_rx_ready; + uint8_t m_serial_rx_char; + uint8_t m_serial_tx_ready; + int m_hblank; + int m_vpos; + int m_marker_scanline; + bool m_kbd_sdv; required_device m_maincpu; required_region_ptr m_p_videoram; diff --git a/src/devices/machine/ie15_kbd.h b/src/devices/machine/ie15_kbd.h index 6e6e5e8ecb0..3302bbda8a2 100644 --- a/src/devices/machine/ie15_kbd.h +++ b/src/devices/machine/ie15_kbd.h @@ -52,8 +52,8 @@ protected: required_ioport m_io_kbdc; private: - bool m_ruslat = false; - uint8_t *m_rom = nullptr; + bool m_ruslat; + uint8_t *m_rom; devcb_write16 m_keyboard_cb; devcb_write_line m_sdv_cb; diff --git a/src/devices/machine/im6402.h b/src/devices/machine/im6402.h index 80210f4a3fe..d36853353c2 100644 --- a/src/devices/machine/im6402.h +++ b/src/devices/machine/im6402.h @@ -110,28 +110,28 @@ private: devcb_write_line m_write_tre; // status - int m_dr = 0; - int m_tbre = 0; - int m_tre = 0; - int m_pe = 0; - int m_fe = 0; - int m_oe = 0; + int m_dr; + int m_tbre; + int m_tre; + int m_pe; + int m_fe; + int m_oe; // control - int m_cls1 = 0; - int m_cls2 = 0; - int m_sbs = 0; - int m_sfd = 0; - int m_epe = 0; - int m_pi = 0; + int m_cls1; + int m_cls2; + int m_sbs; + int m_sfd; + int m_epe; + int m_pi; // receiver - uint8_t m_rbr = 0; + uint8_t m_rbr; int m_rrc; int m_rrc_count; // transmitter - uint8_t m_tbr = 0; + uint8_t m_tbr; int m_trc; int m_trc_count; }; diff --git a/src/devices/machine/ins8250.h b/src/devices/machine/ins8250.h index 59e5ab717ad..b40ff23ef65 100644 --- a/src/devices/machine/ins8250.h +++ b/src/devices/machine/ins8250.h @@ -125,13 +125,13 @@ protected: virtual u8 pop_rx() override; private: void set_timer() { m_timeout->adjust(attotime::from_hz((clock()*4*8)/(m_regs.dl*16))); } - int m_rintlvl = 0; - u8 m_rfifo[16]{}; - u8 m_efifo[16]{}; - u8 m_tfifo[16]{}; - int m_rhead = 0, m_rtail = 0, m_rnum = 0; - int m_thead = 0, m_ttail = 0; - emu_timer *m_timeout = nullptr; + int m_rintlvl; + u8 m_rfifo[16]; + u8 m_efifo[16]; + u8 m_tfifo[16]; + int m_rhead, m_rtail, m_rnum; + int m_thead, m_ttail; + emu_timer *m_timeout; }; class pc16552_device : public device_t @@ -146,8 +146,8 @@ protected: virtual void device_start() override; private: - ns16550_device *m_chan0 = nullptr; - ns16550_device *m_chan1 = nullptr; + ns16550_device *m_chan0; + ns16550_device *m_chan1; }; DECLARE_DEVICE_TYPE(PC16552D, pc16552_device) diff --git a/src/devices/machine/iopcdvd.h b/src/devices/machine/iopcdvd.h index c19cb063f83..194933eb3d9 100644 --- a/src/devices/machine/iopcdvd.h +++ b/src/devices/machine/iopcdvd.h @@ -55,12 +55,12 @@ protected: struct drive_channel_t { - uint8_t m_buffer[0x10]{}; // Buffer size is a total guess - uint8_t m_curr = 0; - uint8_t m_end = 0; + uint8_t m_buffer[0x10]; // Buffer size is a total guess + uint8_t m_curr; + uint8_t m_end; - uint8_t m_status = 0; - uint8_t m_command = 0; + uint8_t m_status; + uint8_t m_command; }; drive_channel_t m_channel[2]; diff --git a/src/devices/machine/iopdma.h b/src/devices/machine/iopdma.h index c531b11e5b4..2e84ec44aaa 100644 --- a/src/devices/machine/iopdma.h +++ b/src/devices/machine/iopdma.h @@ -64,9 +64,9 @@ public: protected: struct intctrl_t { - uint8_t m_mask = 0; - uint8_t m_status = 0; - bool m_enabled = false; + uint8_t m_mask; + uint8_t m_status; + bool m_enabled; }; class channel_t @@ -155,8 +155,8 @@ protected: channel_t m_channels[16]; intctrl_t m_int_ctrl[2]; - uint32_t m_running_mask = 0; - uint32_t m_last_serviced = 0; + uint32_t m_running_mask; + uint32_t m_last_serviced; }; DECLARE_DEVICE_TYPE(SONYIOP_DMA, iop_dma_device) diff --git a/src/devices/machine/iopintc.h b/src/devices/machine/iopintc.h index 2c5499ff225..5ead2c505fe 100644 --- a/src/devices/machine/iopintc.h +++ b/src/devices/machine/iopintc.h @@ -51,9 +51,9 @@ protected: void update_interrupts(); required_device m_iop; - uint32_t m_status = 0; - uint32_t m_mask = 0; - bool m_enabled = false; + uint32_t m_status; + uint32_t m_mask; + bool m_enabled; }; DECLARE_DEVICE_TYPE(SONYIOP_INTC, iop_intc_device) diff --git a/src/devices/machine/iopsio2.h b/src/devices/machine/iopsio2.h index 219e7c5cbc9..67fc395b6f3 100644 --- a/src/devices/machine/iopsio2.h +++ b/src/devices/machine/iopsio2.h @@ -63,24 +63,24 @@ protected: required_device m_mc0; // HACK: Buffer size is a guess. - uint8_t m_buffer[512]{}; - uint32_t m_curr_byte = 0; - uint32_t m_end_byte = 0; - uint32_t m_ctrl = 0; + uint8_t m_buffer[512]; + uint32_t m_curr_byte; + uint32_t m_end_byte; + uint32_t m_ctrl; - uint32_t m_unknown_0x6c = 0; // Device status? - uint32_t m_unknown_0x70 = 0; - uint32_t m_unknown_0x74 = 0; + uint32_t m_unknown_0x6c; // Device status? + uint32_t m_unknown_0x70; + uint32_t m_unknown_0x74; - uint32_t m_cmdbuf[16]{}; - uint32_t m_curr_port = 0; - uint32_t m_cmd_size = 0; - uint32_t m_cmd_length = 0; - uint32_t m_databuf[4][2]{}; + uint32_t m_cmdbuf[16]; + uint32_t m_curr_port; + uint32_t m_cmd_size; + uint32_t m_cmd_length; + uint32_t m_databuf[4][2]; - uint32_t m_target_device = 0; + uint32_t m_target_device; - emu_timer *m_response_timer = nullptr; + emu_timer *m_response_timer; static const size_t BUFFER_SIZE; }; diff --git a/src/devices/machine/iwm.h b/src/devices/machine/iwm.h index 1c8fed9190f..5bae4443791 100644 --- a/src/devices/machine/iwm.h +++ b/src/devices/machine/iwm.h @@ -58,17 +58,17 @@ private: }; floppy_image_device *m_floppy; - emu_timer *m_timer = nullptr; + emu_timer *m_timer; double m_q3_fclk_ratio, m_fclk_q3_ratio; - u64 m_last_sync = 0, m_next_state_change = 0, m_sync_update = 0, m_async_update = 0; - u64 m_flux_write_start = 0; + u64 m_last_sync, m_next_state_change, m_sync_update, m_async_update; + u64 m_flux_write_start; std::array m_flux_write; - u32 m_flux_write_count = 0; - u32 m_q3_clock = 0; - int m_active = 0, m_rw = 0, m_rw_state = 0; - u8 m_data = 0, m_whd = 0, m_mode = 0, m_status = 0, m_control = 0, m_rw_bit_count = 0; - u8 m_rsh = 0, m_wsh = 0; - u8 m_devsel = 0; + u32 m_flux_write_count; + u32 m_q3_clock; + int m_active, m_rw, m_rw_state; + u8 m_data, m_whd, m_mode, m_status, m_control, m_rw_bit_count; + u8 m_rsh, m_wsh; + u8 m_devsel; u8 control(int offset, u8 data); u64 time_to_cycles(const attotime &tm) const; diff --git a/src/devices/machine/k054321.h b/src/devices/machine/k054321.h index 55d6501423c..6c66659372d 100644 --- a/src/devices/machine/k054321.h +++ b/src/devices/machine/k054321.h @@ -37,8 +37,8 @@ private: std::unique_ptr m_left_gains; std::unique_ptr m_right_gains; - u8 m_volume = 0; - u8 m_active = 0; + u8 m_volume; + u8 m_active; void propagate_volume(); diff --git a/src/devices/machine/laserdsc.h b/src/devices/machine/laserdsc.h index 0a9678bbb60..15a107804f1 100644 --- a/src/devices/machine/laserdsc.h +++ b/src/devices/machine/laserdsc.h @@ -290,7 +290,7 @@ private: // async operations osd_work_queue * m_work_queue; // work queue - uint32_t m_queued_hunknum = 0; // queued hunk + uint32_t m_queued_hunknum; // queued hunk // core states uint8_t m_audiosquelch; // audio squelch state: bit 0 = audio 1, bit 1 = audio 2 diff --git a/src/devices/machine/ldp1000.h b/src/devices/machine/ldp1000.h index 24343f53bc2..2fd79a6a6fc 100644 --- a/src/devices/machine/ldp1000.h +++ b/src/devices/machine/ldp1000.h @@ -61,17 +61,17 @@ protected: }; private: - uint8_t m_command = 0; - ldp1000_status m_status{}; - ldp1000_player_state m_player_state{}; - bool m_audio_enable[2]{}; + uint8_t m_command; + ldp1000_status m_status; + ldp1000_player_state m_player_state; + bool m_audio_enable[2]; // TODO: sub-class into a specific internal player state void set_new_player_state(ldp1000_player_state which); void set_new_player_bcd(uint8_t data); uint32_t bcd_to_raw(); void exec_enter_cmd(); - uint8_t m_internal_bcd[0x10]{}; - uint8_t m_index_state = 0; + uint8_t m_internal_bcd[0x10]; + uint8_t m_index_state; }; diff --git a/src/devices/machine/ldp1450.h b/src/devices/machine/ldp1450.h index 4508934b4ec..67a429845e1 100644 --- a/src/devices/machine/ldp1450.h +++ b/src/devices/machine/ldp1450.h @@ -44,11 +44,11 @@ protected: virtual int32_t player_update(const vbi_metadata &vbi, int fieldnum, const attotime &curtime) override; virtual void player_overlay(bitmap_yuy16 &bitmap) override { } - uint8_t m_ld_frame_index = 0; - uint8_t m_ld_frame[5]{}; - uint8_t m_ld_command_current_byte = 0; - uint8_t m_ld_command_to_send[5]{}; - uint8_t m_ld_command_total_bytes = 0; + uint8_t m_ld_frame_index; + uint8_t m_ld_frame[5]; + uint8_t m_ld_command_current_byte; + uint8_t m_ld_command_to_send[5]; + uint8_t m_ld_command_total_bytes; enum LD_INPUT_STATE { @@ -71,16 +71,16 @@ protected: }; private: - uint8_t m_command = 0; - uint8_t m_status = 0; - ldp1450_player_state m_player_state{}; - bool m_audio_enable[2]{}; + uint8_t m_command; + uint8_t m_status; + ldp1450_player_state m_player_state; + bool m_audio_enable[2]; void set_new_player_state(ldp1450_player_state which); void set_new_player_bcd(uint8_t data); uint32_t bcd_to_raw(); void exec_enter_cmd(); - uint8_t m_internal_bcd[0x10]{}; - uint8_t m_index_state = 0; + uint8_t m_internal_bcd[0x10]; + uint8_t m_index_state; }; diff --git a/src/devices/machine/ldpr8210.h b/src/devices/machine/ldpr8210.h index 5703cd6ce32..79453d5604b 100644 --- a/src/devices/machine/ldpr8210.h +++ b/src/devices/machine/ldpr8210.h @@ -87,15 +87,15 @@ protected: class pioneer_pia { public: - uint8_t frame[7]{}; // (20-26) 7 characters for the chapter/frame - uint8_t text[17]{}; // (20-30) 17 characters for the display - uint8_t control = 0; // (40) control lines - uint8_t latchdisplay = 0; // flag: set if the display was latched - uint8_t portb = 0; // (60) port B value (LEDs) - uint8_t display = 0; // (80) display enable - uint8_t porta = 0; // (A0) port A value (from serial decoder) - uint8_t vbi1 = 0; // (C0) VBI decoding state 1 - uint8_t vbi2 = 0; // (E0) VBI decoding state 2 + uint8_t frame[7]; // (20-26) 7 characters for the chapter/frame + uint8_t text[17]; // (20-30) 17 characters for the display + uint8_t control; // (40) control lines + uint8_t latchdisplay; // flag: set if the display was latched + uint8_t portb; // (60) port B value (LEDs) + uint8_t display; // (80) display enable + uint8_t porta; // (A0) port A value (from serial decoder) + uint8_t vbi1; // (C0) VBI decoding state 1 + uint8_t vbi2; // (E0) VBI decoding state 2 }; // internal overlay helpers diff --git a/src/devices/machine/locomo.h b/src/devices/machine/locomo.h index f2d80c12ad7..ac240959d9f 100644 --- a/src/devices/machine/locomo.h +++ b/src/devices/machine/locomo.h @@ -23,10 +23,10 @@ protected: virtual void device_start() override; virtual void device_reset() override; - uint16_t m_kbd_cmd = 0; - uint16_t m_kbd_row = 0; - uint16_t m_kbd_col = 0; - uint16_t m_kbd_level = 0; + uint16_t m_kbd_cmd; + uint16_t m_kbd_row; + uint16_t m_kbd_col; + uint16_t m_kbd_level; }; DECLARE_DEVICE_TYPE(LOCOMO, locomo_device) diff --git a/src/devices/machine/lpc-acpi.h b/src/devices/machine/lpc-acpi.h index 179567b4145..1cd64636a10 100644 --- a/src/devices/machine/lpc-acpi.h +++ b/src/devices/machine/lpc-acpi.h @@ -19,11 +19,11 @@ protected: void device_reset() override; private: - uint32_t pm1_cnt = 0, proc_cnt = 0, gpe0_sts = 0, gpe0_en = 0, smi_en = 0, smi_sts = 0; - uint16_t pm1_sts = 0, pm1_en = 0, alt_gp_smi_en = 0, alt_gp_smi_sts = 0, devact_sts = 0, devtrap_en = 0; - uint16_t tco1_sts = 0, tco2_sts = 0, tco1_cnt = 0, tco2_cnt = 0; - uint8_t tco_rld = 0, tco_tmr = 0, tco_dat_in = 0, tco_dat_out = 0, tco_message1 = 0, tco_message2 = 0; - uint8_t tco_wdstatus = 0, sw_irq_gen = 0; + uint32_t pm1_cnt, proc_cnt, gpe0_sts, gpe0_en, smi_en, smi_sts; + uint16_t pm1_sts, pm1_en, alt_gp_smi_en, alt_gp_smi_sts, devact_sts, devtrap_en; + uint16_t tco1_sts, tco2_sts, tco1_cnt, tco2_cnt; + uint8_t tco_rld, tco_tmr, tco_dat_in, tco_dat_out, tco_message1, tco_message2; + uint8_t tco_wdstatus, sw_irq_gen; void map(address_map &map); diff --git a/src/devices/machine/lpci.h b/src/devices/machine/lpci.h index 4183ff0319e..fb289d5538f 100644 --- a/src/devices/machine/lpci.h +++ b/src/devices/machine/lpci.h @@ -67,7 +67,7 @@ protected: virtual void device_post_load() override; private: - uint8_t m_busnum = 0; + uint8_t m_busnum; pci_bus_legacy_read_delegate::array<32> m_read_callback; pci_bus_legacy_write_delegate::array<32> m_write_callback; optional_device m_father; @@ -75,10 +75,10 @@ private: uint8_t m_siblings_busnum[8]; int m_siblings_count; - offs_t m_address = 0; - int8_t m_devicenum = 0; // device number we are addressing - int8_t m_busnumber = 0; // pci bus number we are addressing - pci_bus_legacy_device * m_busnumaddr = nullptr; // pci bus we are addressing + offs_t m_address; + int8_t m_devicenum; // device number we are addressing + int8_t m_busnumber; // pci bus number we are addressing + pci_bus_legacy_device * m_busnumaddr; // pci bus we are addressing }; // device type definition diff --git a/src/devices/machine/m950x0.h b/src/devices/machine/m950x0.h index 7f84acc02c8..0eceb6fab21 100644 --- a/src/devices/machine/m950x0.h +++ b/src/devices/machine/m950x0.h @@ -67,9 +67,9 @@ protected: const uint16_t m_addr_mask; uint32_t m_state; - bool m_selected = false; - uint8_t m_status = 0; - uint16_t m_addr = 0; + bool m_selected; + uint8_t m_status; + uint16_t m_addr; }; class m95010_device : public m950x0_device diff --git a/src/devices/machine/mb87030.h b/src/devices/machine/mb87030.h index e852f601f15..d2e90a506f4 100644 --- a/src/devices/machine/mb87030.h +++ b/src/devices/machine/mb87030.h @@ -138,8 +138,8 @@ private: constexpr static uint8_t SDGC_DIAG_ACK = 0x40; constexpr static uint8_t SDGC_DIAG_REQ = 0x80; - emu_timer *m_timer = nullptr; - emu_timer *m_delay_timer = nullptr; + emu_timer *m_timer; + emu_timer *m_delay_timer; enum TimerId { Delay, @@ -188,33 +188,33 @@ private: TIMER_CALLBACK_MEMBER(timeout); // registers - uint8_t m_bdid = 0; - uint8_t m_sctl = 0; - uint8_t m_scmd = 0; - uint8_t m_tmod = 0; - uint8_t m_ints = 0; - uint8_t m_sdgc = 0; - uint8_t m_ssts = 0; - uint8_t m_serr = 0; - uint8_t m_pctl = 0; - uint8_t m_mbc = 0; - uint8_t m_dreg = 0; - uint8_t m_temp = 0; - uint8_t m_tch = 0; - uint8_t m_tcm = 0; - uint32_t m_tc = 0; - uint8_t m_exbf = 0; - - uint8_t m_bus_data = 0; - uint8_t m_hdb = 0; - bool m_hdb_loaded = false; - bool m_send_atn_during_selection = false; + uint8_t m_bdid; + uint8_t m_sctl; + uint8_t m_scmd; + uint8_t m_tmod; + uint8_t m_ints; + uint8_t m_sdgc; + uint8_t m_ssts; + uint8_t m_serr; + uint8_t m_pctl; + uint8_t m_mbc; + uint8_t m_dreg; + uint8_t m_temp; + uint8_t m_tch; + uint8_t m_tcm; + uint32_t m_tc; + uint8_t m_exbf; + + uint8_t m_bus_data; + uint8_t m_hdb; + bool m_hdb_loaded; + bool m_send_atn_during_selection; util::fifo m_fifo; - uint8_t m_scsi_phase = 0; - uint32_t m_scsi_ctrl = 0; + uint8_t m_scsi_phase; + uint32_t m_scsi_ctrl; - bool m_dma_transfer = false; + bool m_dma_transfer; }; diff --git a/src/devices/machine/mc14411.h b/src/devices/machine/mc14411.h index 94382dba85c..47d081b128b 100644 --- a/src/devices/machine/mc14411.h +++ b/src/devices/machine/mc14411.h @@ -83,10 +83,10 @@ protected: private: void arm_timer(int i); - emu_timer *m_fx_timer[16]{}; - emu_timer *m_reset_timer = nullptr; + emu_timer *m_fx_timer[16]; + emu_timer *m_reset_timer; - uint32_t m_fx_state[16]{}; // F1-F16 output line states + uint32_t m_fx_state[16]; // F1-F16 output line states // divider matrix static const int s_counter_divider[16]; diff --git a/src/devices/machine/mc68681.h b/src/devices/machine/mc68681.h index e16962ccea5..b47e7276cd8 100644 --- a/src/devices/machine/mc68681.h +++ b/src/devices/machine/mc68681.h @@ -51,15 +51,15 @@ public: private: /* Registers */ - uint8_t CR = 0; /* Command register */ - uint8_t CSR = 0; /* Clock select register */ + uint8_t CR; /* Command register */ + uint8_t CSR; /* Clock select register */ uint8_t MR1; /* Mode register 1 */ uint8_t MR2; /* Mode register 2 */ - uint8_t MR_ptr = 0; /* Mode register pointer */ + uint8_t MR_ptr; /* Mode register pointer */ uint8_t SR; /* Status register */ /* State */ - int tx_baud_rate = 0, rx_baud_rate = 0; + int tx_baud_rate, rx_baud_rate; /* Receiver */ uint8_t rx_enabled; @@ -68,18 +68,18 @@ private: int rx_fifo_write_ptr; int rx_fifo_num; - int m_ch = 0; + int m_ch; /* Transmitter */ uint8_t tx_enabled; - uint8_t tx_data = 0; - uint8_t tx_ready = 0; + uint8_t tx_data; + uint8_t tx_ready; bool m_tx_break; /* Rx/Tx clocking */ - uint8_t m_rx_prescaler = 0, m_tx_prescaler = 0; + uint8_t m_rx_prescaler , m_tx_prescaler; - duart_base_device *m_uart = nullptr; + duart_base_device *m_uart; void write_MR(uint8_t data); void write_CR(uint8_t data); @@ -219,7 +219,7 @@ protected: private: bool m_read_vector; // if this is read and IRQ is active, it counts as pulling IACK - uint8_t IVR = 0; /* Interrupt Vector Register */ + uint8_t IVR; /* Interrupt Vector Register */ }; class sc28c94_device : public duart_base_device diff --git a/src/devices/machine/mcf5206e.h b/src/devices/machine/mcf5206e.h index f71e6b6d831..d4ec0dd7980 100644 --- a/src/devices/machine/mcf5206e.h +++ b/src/devices/machine/mcf5206e.h @@ -173,31 +173,31 @@ private: uint8_t m_ICR[MAX_ICR]; - uint16_t m_CSAR[8]{}; - uint32_t m_CSMR[8]{}; - uint16_t m_CSCR[8]{}; + uint16_t m_CSAR[8]; + uint32_t m_CSMR[8]; + uint16_t m_CSCR[8]; - uint16_t m_DMCR = 0; - uint16_t m_PAR = 0; + uint16_t m_DMCR; + uint16_t m_PAR; - emu_timer *m_timer1 = nullptr; - uint16_t m_TMR1 = 0; - uint16_t m_TRR1 = 0; - uint8_t m_TER1 = 0; - uint16_t m_TCN1 = 0; + emu_timer *m_timer1; + uint16_t m_TMR1; + uint16_t m_TRR1; + uint8_t m_TER1; + uint16_t m_TCN1; - uint8_t m_PPDDR = 0; - uint8_t m_PPDAT = 0; + uint8_t m_PPDDR; + uint8_t m_PPDAT; - uint16_t m_IMR = 0; + uint16_t m_IMR; - uint8_t m_MBCR = 0; - uint8_t m_MBSR = 0; - uint8_t m_MFDR = 0; - uint8_t m_MBDR = 0; + uint8_t m_MBCR; + uint8_t m_MBSR; + uint8_t m_MFDR; + uint8_t m_MBDR; - uint32_t m_coldfire_regs[0x400/4]{}; + uint32_t m_coldfire_regs[0x400/4]; }; diff --git a/src/devices/machine/mm58174.h b/src/devices/machine/mm58174.h index 13742bcdf7a..01db657255d 100644 --- a/src/devices/machine/mm58174.h +++ b/src/devices/machine/mm58174.h @@ -40,22 +40,22 @@ private: int m_int_ctl; /* interrupt control register */ - int m_years = 0; - int m_wday = 0; /* day of the week (1-7 (1=day1 as set in init)) */ - int m_months1 = 0; /* months (BCD: 1-12) */ - int m_months2 = 0; - int m_days1 = 0; /* days (BCD: 1-31) */ - int m_days2 = 0; - int m_hours1 = 0; /* hours (BCD : 0-23) */ - int m_hours2 = 0; - int m_minutes1 = 0; /* minutes (BCD : 0-59) */ - int m_minutes2 = 0; - int m_seconds1 = 0; /* seconds (BCD : 0-59) */ - int m_seconds2 = 0; + int m_years; + int m_wday; /* day of the week (1-7 (1=day1 as set in init)) */ + int m_months1; /* months (BCD: 1-12) */ + int m_months2; + int m_days1; /* days (BCD: 1-31) */ + int m_days2; + int m_hours1; /* hours (BCD : 0-23) */ + int m_hours2; + int m_minutes1; /* minutes (BCD : 0-59) */ + int m_minutes2; + int m_seconds1; /* seconds (BCD : 0-59) */ + int m_seconds2; int m_tenths; /* tenths of second (BCD : 0-9) */ - emu_timer *m_increment_rtc = nullptr; - emu_timer *m_interrupt_timer = nullptr; + emu_timer *m_increment_rtc; + emu_timer *m_interrupt_timer; }; DECLARE_DEVICE_TYPE(MM58174, mm58174_device) diff --git a/src/devices/machine/mm58274c.cpp b/src/devices/machine/mm58274c.cpp index 09c3cf770af..c7e7f49a78e 100644 --- a/src/devices/machine/mm58274c.cpp +++ b/src/devices/machine/mm58274c.cpp @@ -154,7 +154,7 @@ attotime mm58274c_device::interrupt_period_table(int val) uint8_t mm58274c_device::read(offs_t offset) { - int reply = 0; + int reply; offset &= 0xf; diff --git a/src/devices/machine/mm58274c.h b/src/devices/machine/mm58274c.h index 13a3466a1f8..c6fcbee3c46 100644 --- a/src/devices/machine/mm58274c.h +++ b/src/devices/machine/mm58274c.h @@ -39,29 +39,29 @@ private: attotime interrupt_period_table(int val); - int m_status = 0; /* status register (*read* from address 0 = control register) */ - int m_control = 0; /* control register (*write* to address 0) */ + int m_status; /* status register (*read* from address 0 = control register) */ + int m_control; /* control register (*write* to address 0) */ - int m_clk_set = 0; /* clock setting register */ - int m_int_ctl = 0; /* interrupt control register */ + int m_clk_set; /* clock setting register */ + int m_int_ctl; /* interrupt control register */ - int m_wday = 0; /* day of the week (1-7 (1=day1 as set in init)) */ - int m_years1 = 0; /* years (BCD: 0-99) */ - int m_years2 = 0; - int m_months1 = 0; /* months (BCD: 1-12) */ - int m_months2 = 0; - int m_days1 = 0; /* days (BCD: 1-31) */ - int m_days2 = 0; - int m_hours1 = 0; /* hours (BCD : 0-23) */ - int m_hours2 = 0; - int m_minutes1 = 0; /* minutes (BCD : 0-59) */ - int m_minutes2 = 0; - int m_seconds1 = 0; /* seconds (BCD : 0-59) */ - int m_seconds2 = 0; - int m_tenths = 0; /* tenths of second (BCD : 0-9) */ + int m_wday; /* day of the week (1-7 (1=day1 as set in init)) */ + int m_years1; /* years (BCD: 0-99) */ + int m_years2; + int m_months1; /* months (BCD: 1-12) */ + int m_months2; + int m_days1; /* days (BCD: 1-31) */ + int m_days2; + int m_hours1; /* hours (BCD : 0-23) */ + int m_hours2; + int m_minutes1; /* minutes (BCD : 0-59) */ + int m_minutes2; + int m_seconds1; /* seconds (BCD : 0-59) */ + int m_seconds2; + int m_tenths; /* tenths of second (BCD : 0-9) */ - emu_timer *m_increment_rtc = nullptr; - emu_timer *m_interrupt_timer = nullptr; + emu_timer *m_increment_rtc; + emu_timer *m_interrupt_timer; }; DECLARE_DEVICE_TYPE(MM58274C, mm58274c_device) diff --git a/src/devices/machine/mos6526.h b/src/devices/machine/mos6526.h index f37f51d6e6e..f86cf960461 100644 --- a/src/devices/machine/mos6526.h +++ b/src/devices/machine/mos6526.h @@ -181,34 +181,34 @@ protected: int m_count_a0; int m_count_a1; int m_count_a2; - int m_count_a3 = 0; - int m_load_a0 = 0; - int m_load_a1 = 0; - int m_load_a2 = 0; - int m_oneshot_a0 = 0; - int m_count_b0 = 0; - int m_count_b1 = 0; - int m_count_b2 = 0; - int m_count_b3 = 0; - int m_load_b0 = 0; - int m_load_b1 = 0; - int m_load_b2 = 0; - int m_oneshot_b0 = 0; - uint16_t m_ta = 0; - uint16_t m_tb = 0; - uint16_t m_ta_latch = 0; - uint16_t m_tb_latch = 0; - uint8_t m_cra = 0; - uint8_t m_crb = 0; + int m_count_a3; + int m_load_a0; + int m_load_a1; + int m_load_a2; + int m_oneshot_a0; + int m_count_b0; + int m_count_b1; + int m_count_b2; + int m_count_b3; + int m_load_b0; + int m_load_b1; + int m_load_b2; + int m_oneshot_b0; + uint16_t m_ta; + uint16_t m_tb; + uint16_t m_ta_latch; + uint16_t m_tb_latch; + uint8_t m_cra; + uint8_t m_crb; // time-of-day - int m_tod_count = 0; - uint32_t m_tod = 0; - uint32_t m_tod_latch = 0; - uint32_t m_alarm = 0; - bool m_tod_stopped = false; - bool m_tod_latched = false; - emu_timer *m_tod_timer = nullptr; + int m_tod_count; + uint32_t m_tod; + uint32_t m_tod_latch; + uint32_t m_alarm; + bool m_tod_stopped; + bool m_tod_latched; + emu_timer *m_tod_timer; }; diff --git a/src/devices/machine/msm6242.h b/src/devices/machine/msm6242.h index 6dc68512740..17afe8794d2 100644 --- a/src/devices/machine/msm6242.h +++ b/src/devices/machine/msm6242.h @@ -76,15 +76,15 @@ private: static constexpr u8 IRQ_HOUR = 3; // state - u8 m_reg[3]{}; - u8 m_irq_flag = 0; - u8 m_irq_type = 0; - u16 m_tick = 0; + u8 m_reg[3]; + u8 m_irq_flag; + u8 m_irq_type; + u16 m_tick; // incidentals devcb_write_line m_out_int_handler; - emu_timer * m_timer = 0; - u64 m_last_update_time = 0; // last update time, in clock cycles + emu_timer * m_timer; + u64 m_last_update_time; // last update time, in clock cycles // methods void rtc_timer_callback(); diff --git a/src/devices/machine/myb3k_kbd.h b/src/devices/machine/myb3k_kbd.h index 250c5372f45..752c8e32546 100644 --- a/src/devices/machine/myb3k_kbd.h +++ b/src/devices/machine/myb3k_kbd.h @@ -70,9 +70,9 @@ protected: u8 m_io_kbd_state[12][8]; int m_x, m_y; - u8 m_first_byte = 0; - u8 m_second_byte = 0; - u8 m_modifier_keys = 0; + u8 m_first_byte; + u8 m_second_byte; + u8 m_modifier_keys; }; class jb3000_keyboard_device : public myb3k_keyboard_device diff --git a/src/devices/machine/ncr5380.h b/src/devices/machine/ncr5380.h index ba30cbc6629..e7107ae285e 100644 --- a/src/devices/machine/ncr5380.h +++ b/src/devices/machine/ncr5380.h @@ -132,7 +132,7 @@ private: devcb_write_line m_drq_handler; // state machine - emu_timer *m_state_timer = nullptr; + emu_timer *m_state_timer; enum state : uint32_t { IDLE, @@ -152,17 +152,17 @@ private: m_state; // registers - u8 m_odata = 0; - u8 m_icmd = 0; - u8 m_mode = 0; - u8 m_tcmd = 0; - u8 m_bas = 0; - u8 m_idata = 0; + u8 m_odata; + u8 m_icmd; + u8 m_mode; + u8 m_tcmd; + u8 m_bas; + u8 m_idata; // line state - u32 m_scsi_ctrl = 0; - bool m_irq_state = false; - bool m_drq_state = false; + u32 m_scsi_ctrl; + bool m_irq_state; + bool m_drq_state; bool const m_has_lbs; }; diff --git a/src/devices/machine/ncr5390.h b/src/devices/machine/ncr5390.h index 54bc71a577c..98a4cb40701 100644 --- a/src/devices/machine/ncr5390.h +++ b/src/devices/machine/ncr5390.h @@ -203,7 +203,7 @@ protected: int dma_dir; bool irq, drq; - bool dma_command = false; + bool dma_command; bool test_mode; void dma_set(int dir); @@ -322,7 +322,7 @@ protected: private: u8 config3; - u8 fifo_align = 0; + u8 fifo_align; busmd_t m_busmd; }; diff --git a/src/devices/machine/nmc9306.h b/src/devices/machine/nmc9306.h index 2c871251e71..98566a9ab82 100644 --- a/src/devices/machine/nmc9306.h +++ b/src/devices/machine/nmc9306.h @@ -54,16 +54,16 @@ private: uint16_t m_register[16]; - int m_bits = 0; - int m_state = 0; - uint8_t m_command = 0; - uint8_t m_address = 0; - uint16_t m_data = 0; - bool m_ewen = false; - int m_cs = 0; - int m_sk = 0; - int m_do = 0; - int m_di = 0; + int m_bits; + int m_state; + uint8_t m_command; + uint8_t m_address; + uint16_t m_data; + bool m_ewen; + int m_cs; + int m_sk; + int m_do; + int m_di; }; diff --git a/src/devices/machine/ns32081.h b/src/devices/machine/ns32081.h index ee2cfcfdaef..e73fa8013f6 100644 --- a/src/devices/machine/ns32081.h +++ b/src/devices/machine/ns32081.h @@ -32,27 +32,27 @@ protected: void complete(s32 param); private: - emu_timer *m_complete = nullptr; + emu_timer *m_complete; // registers - u32 m_fsr = 0; - u32 m_f[8]{}; + u32 m_fsr; + u32 m_f[8]; // operating state - u8 m_idbyte = 0; - u16 m_opword = 0; + u8 m_idbyte; + u16 m_opword; struct operand { - unsigned expected = 0; - unsigned issued = 0; + unsigned expected; + unsigned issued; u64 value; } - m_op[3]{}; - u16 m_status = 0; + m_op[3]; + u16 m_status; // implementation state - unsigned m_state = 0; - unsigned m_tcy = 0; + unsigned m_state; + unsigned m_tcy; }; DECLARE_DEVICE_TYPE(NS32081, ns32081_device) diff --git a/src/devices/machine/ns32082.h b/src/devices/machine/ns32082.h index fb43504359a..83238529e6b 100644 --- a/src/devices/machine/ns32082.h +++ b/src/devices/machine/ns32082.h @@ -47,20 +47,20 @@ private: u32 m_eia; // operating state - u8 m_idbyte = 0; - u16 m_opword = 0; + u8 m_idbyte; + u16 m_opword; struct operand { - unsigned expected = 0; - unsigned issued = 0; - u64 value = 0; + unsigned expected; + unsigned issued; + u64 value; } - m_op[3]{}; - u16 m_status = 0; + m_op[3]; + u16 m_status; // implementation state - unsigned m_state = 0; - unsigned m_tcy = 0; + unsigned m_state; + unsigned m_tcy; }; DECLARE_DEVICE_TYPE(NS32082, ns32082_device) diff --git a/src/devices/machine/ns32382.h b/src/devices/machine/ns32382.h index 678fcb74f6d..d7730a70d68 100644 --- a/src/devices/machine/ns32382.h +++ b/src/devices/machine/ns32382.h @@ -36,29 +36,29 @@ protected: private: // registers - u32 m_bar = 0; // breakpoint address register - u32 m_bdr = 0; // breakpoint data register - u32 m_bear = 0; // bus error address register - u32 m_bmr = 0; // breakpoint mask register - u32 m_mcr = 0; // memory management control register - u32 m_msr = 0; // memory management status register - u32 m_ptb[2]{}; // page table base registers - u32 m_tear = 0; // translation exception address register + u32 m_bar; // breakpoint address register + u32 m_bdr; // breakpoint data register + u32 m_bear; // bus error address register + u32 m_bmr; // breakpoint mask register + u32 m_mcr; // memory management control register + u32 m_msr; // memory management status register + u32 m_ptb[2]; // page table base registers + u32 m_tear; // translation exception address register // operating state - u16 m_opword = 0; + u16 m_opword; struct operand { - u32 expected = 0; - u32 issued = 0; - u64 value = 0; + u32 expected; + u32 issued; + u64 value; } - m_op[3]{}; - u16 m_status = 0; + m_op[3]; + u16 m_status; // implementation state - u32 m_state = 0; - u32 m_tcy = 0; + u32 m_state; + u32 m_tcy; }; DECLARE_DEVICE_TYPE(NS32382, ns32382_device) diff --git a/src/devices/machine/nscsi_bus.h b/src/devices/machine/nscsi_bus.h index 841bc421dcf..997844c4342 100644 --- a/src/devices/machine/nscsi_bus.h +++ b/src/devices/machine/nscsi_bus.h @@ -397,8 +397,8 @@ protected: virtual attotime scsi_fast_negation_period(); uint8_t scsi_cmdbuf[4096], scsi_sense_buffer[18]; - int scsi_cmdsize = 0; - uint8_t scsi_identify = 0; + int scsi_cmdsize; + uint8_t scsi_identify; private: enum { @@ -440,19 +440,19 @@ private: }; struct control { - int action = 0; - int param1 = 0, param2 = 0; + int action; + int param1, param2; }; - emu_timer *scsi_timer = nullptr; + emu_timer *scsi_timer; - int scsi_state = 0, scsi_substate = 0; - int scsi_initiator_id = 0; - int data_buffer_id = 0, data_buffer_size = 0, data_buffer_pos = 0; + int scsi_state, scsi_substate; + int scsi_initiator_id; + int data_buffer_id, data_buffer_size, data_buffer_pos; control buf_control[32]; - int buf_control_rpos = 0; - int buf_control_wpos = 0; + int buf_control_rpos; + int buf_control_wpos; control *buf_control_push(); control *buf_control_pop(); diff --git a/src/devices/machine/pcf8593.h b/src/devices/machine/pcf8593.h index 8ef30d8b123..419aebad224 100644 --- a/src/devices/machine/pcf8593.h +++ b/src/devices/machine/pcf8593.h @@ -49,17 +49,17 @@ private: static const device_timer_id TIMER_UPDATE_COUNTER = 0; // internal state - uint8_t m_data[16]{}; - int m_pin_scl = 0; - int m_pin_sda = 0; - int m_inp = 0; - int m_active = 0; - int m_bits = 0; - uint8_t m_data_recv_index = 0; - uint8_t m_data_recv[50]{}; - uint8_t m_mode = 0; - uint8_t m_pos = 0; - emu_timer * m_timer = nullptr; + uint8_t m_data[16]; + int m_pin_scl; + int m_pin_sda; + int m_inp; + int m_active; + int m_bits; + uint8_t m_data_recv_index; + uint8_t m_data_recv[50]; + uint8_t m_mode; + uint8_t m_pos; + emu_timer * m_timer; enum { RTC_MODE_NONE, RTC_MODE_SEND, RTC_MODE_RECV }; }; diff --git a/src/devices/machine/pci-smbus.h b/src/devices/machine/pci-smbus.h index 7400c667131..9c7cd79aa74 100644 --- a/src/devices/machine/pci-smbus.h +++ b/src/devices/machine/pci-smbus.h @@ -57,11 +57,11 @@ private: uint8_t notify_dlow_r(); uint8_t notify_dhigh_r(); - uint16_t slv_data = 0; + uint16_t slv_data; - uint8_t hst_sts = 0, hst_cnt = 0, hst_cmd = 0, xmit_slva = 0, hst_d0 = 0, hst_d1 = 0; - uint8_t host_block_db = 0, pec = 0, rcv_slva = 0, aux_sts = 0, aux_ctl = 0; - uint8_t smlink_pin_ctl = 0, smbus_pin_ctl = 0, slv_sts = 0, slv_cmd = 0, notify_daddr = 0, notify_dlow = 0, notify_dhigh = 0; + uint8_t hst_sts, hst_cnt, hst_cmd, xmit_slva, hst_d0, hst_d1; + uint8_t host_block_db, pec, rcv_slva, aux_sts, aux_ctl; + uint8_t smlink_pin_ctl, smbus_pin_ctl, slv_sts, slv_cmd, notify_daddr, notify_dlow, notify_dhigh; }; DECLARE_DEVICE_TYPE(SMBUS, smbus_device) diff --git a/src/devices/machine/pci.h b/src/devices/machine/pci.h index d798d5210a2..0a0a570b451 100644 --- a/src/devices/machine/pci.h +++ b/src/devices/machine/pci.h @@ -217,13 +217,13 @@ protected: void propagate_config_write(uint8_t bus, uint8_t device, uint16_t reg, uint32_t data, uint32_t mem_mask); void config_write(uint8_t bus, uint8_t device, uint16_t reg, uint32_t data, uint32_t mem_mask); - pci_device *sub_devices[32*8]{}; + pci_device *sub_devices[32*8]; std::vector all_devices; std::vector all_bridges; - uint32_t prefetch_baseu = 0, prefetch_limitu = 0; - uint16_t bridge_control = 0, memory_base = 0, memory_limit = 0, prefetch_base = 0, prefetch_limit = 0, iobaseu = 0, iolimitu = 0; - uint8_t primary_bus = 0, secondary_bus = 0, subordinate_bus = 0, iobase = 0, iolimit = 0; + uint32_t prefetch_baseu, prefetch_limitu; + uint16_t bridge_control, memory_base, memory_limit, prefetch_base, prefetch_limit, iobaseu, iolimitu; + uint8_t primary_bus, secondary_bus, subordinate_bus, iobase, iolimit; private: address_space_config configure_space_config; @@ -259,12 +259,12 @@ protected: void regenerate_mapping(); - address_space *memory_space = nullptr, *io_space = nullptr; + address_space *memory_space, *io_space; - uint64_t memory_window_start = 0, memory_window_end = 0, memory_offset = 0; - uint64_t io_window_start = 0, io_window_end = 0, io_offset = 0; + uint64_t memory_window_start, memory_window_end, memory_offset; + uint64_t io_window_start, io_window_end, io_offset; - uint32_t config_address = 0; + uint32_t config_address; }; class pci_root_device : public device_t { diff --git a/src/devices/machine/pckeybrd.h b/src/devices/machine/pckeybrd.h index e5220f72362..eb685ec175e 100644 --- a/src/devices/machine/pckeybrd.h +++ b/src/devices/machine/pckeybrd.h @@ -112,7 +112,7 @@ private: output_finder<3> m_leds; int m_scan_code_set; - int m_input_state = 0; + int m_input_state; }; INPUT_PORTS_EXTERN( pc_keyboard ); diff --git a/src/devices/machine/pit8253.h b/src/devices/machine/pit8253.h index 19b4b32efb1..430563ebebf 100644 --- a/src/devices/machine/pit8253.h +++ b/src/devices/machine/pit8253.h @@ -82,31 +82,31 @@ private: void set_clockin(double new_clockin); // internal state - int m_index = 0; // index number of the timer - double m_clockin = 0; // input clock frequency in Hz - attotime m_clock_period; // precomputed input clock period - int m_clock_signal = 0; // clock signal when clockin is 0 - - attotime m_last_updated; // time when last updated - attotime m_next_update; // time of next update - - emu_timer *m_updatetimer = nullptr; // MAME timer to process updates - - uint16_t m_value = 0; // current counter value ("CE" in Intel docs) - uint16_t m_latch = 0; // latched counter value ("OL" in Intel docs) - uint16_t m_count = 0; // new counter value ("CR" in Intel docs) - uint8_t m_control = 0; // 6-bit control byte - uint8_t m_status = 0; // status byte - 8254 only - uint8_t m_lowcount = 0; // LSB of new counter value for 16-bit writes - bool m_rmsb = 0; // true = Next read is MSB of 16-bit value - bool m_wmsb = 0; // true = Next write is MSB of 16-bit value - int m_output = 0; // 0 = low, 1 = high - - int m_gate = 0; // gate input (0 = low, 1 = high) - int m_latched_count = 0; // number of bytes of count latched - int m_latched_status = 0; // 1 = status latched (8254 only) - int m_null_count = 0; // 1 = mode control or count written, 0 = count loaded - int m_phase = 0; // see phase definition tables in simulate2(), below + int m_index; // index number of the timer + double m_clockin; // input clock frequency in Hz + attotime m_clock_period; // precomputed input clock period + int m_clock_signal; // clock signal when clockin is 0 + + attotime m_last_updated; // time when last updated + attotime m_next_update; // time of next update + + emu_timer *m_updatetimer; // MAME timer to process updates + + uint16_t m_value; // current counter value ("CE" in Intel docs) + uint16_t m_latch; // latched counter value ("OL" in Intel docs) + uint16_t m_count; // new counter value ("CR" in Intel docs) + uint8_t m_control; // 6-bit control byte + uint8_t m_status; // status byte - 8254 only + uint8_t m_lowcount; // LSB of new counter value for 16-bit writes + bool m_rmsb; // true = Next read is MSB of 16-bit value + bool m_wmsb; // true = Next write is MSB of 16-bit value + int m_output; // 0 = low, 1 = high + + int m_gate; // gate input (0 = low, 1 = high) + int m_latched_count; // number of bytes of count latched + int m_latched_status; // 1 = status latched (8254 only) + int m_null_count; // 1 = mode control or count written, 0 = count loaded + int m_phase; // see phase definition tables in simulate2(), below }; DECLARE_DEVICE_TYPE(PIT_COUNTER, pit_counter_device) diff --git a/src/devices/machine/ps2dma.h b/src/devices/machine/ps2dma.h index 7d80e1e2f2b..b602999de28 100644 --- a/src/devices/machine/ps2dma.h +++ b/src/devices/machine/ps2dma.h @@ -115,7 +115,7 @@ protected: uint32_t m_addr; uint32_t m_qwc; - uint32_t m_tag_addr = 0; + uint32_t m_tag_addr; }; void transfer_vif1(); @@ -134,16 +134,16 @@ protected: int m_icount; - uint32_t m_ctrl = 0; - uint32_t m_mem_drain = 0; - bool m_enabled = false; + uint32_t m_ctrl; + uint32_t m_mem_drain; + bool m_enabled; - uint32_t m_disable_mask = 0; + uint32_t m_disable_mask; - uint32_t m_istat = 0; - uint32_t m_imask = 0; + uint32_t m_istat; + uint32_t m_imask; - uint32_t m_last_serviced = 0; + uint32_t m_last_serviced; channel_t m_channels[10]; }; diff --git a/src/devices/machine/ps2intc.h b/src/devices/machine/ps2intc.h index 8d54e50e94f..111c343372f 100644 --- a/src/devices/machine/ps2intc.h +++ b/src/devices/machine/ps2intc.h @@ -63,8 +63,8 @@ protected: required_device m_ee; - uint32_t m_status = 0; - uint32_t m_mask = 0; + uint32_t m_status; + uint32_t m_mask; }; DECLARE_DEVICE_TYPE(SONYPS2_INTC, ps2_intc_device) diff --git a/src/devices/machine/ps2mc.h b/src/devices/machine/ps2mc.h index 05b3df51987..ef38dea72c2 100644 --- a/src/devices/machine/ps2mc.h +++ b/src/devices/machine/ps2mc.h @@ -53,17 +53,17 @@ protected: CMD_UNKNOWN_F3 = 0xf3, }; - uint8_t m_recv_buf[512]{}; // Buffer size is a guess - uint8_t m_xmit_buf[512]{}; - uint32_t m_curr_recv = 0; - uint32_t m_curr_xmit = 0; - uint32_t m_end_recv = 0; - uint32_t m_end_xmit = 0; - - uint8_t m_cmd = 0; - uint32_t m_cmd_size = 0; - uint8_t m_terminator = 0; - uint8_t m_status = 0; + uint8_t m_recv_buf[512]; // Buffer size is a guess + uint8_t m_xmit_buf[512]; + uint32_t m_curr_recv; + uint32_t m_curr_xmit; + uint32_t m_end_recv; + uint32_t m_end_xmit; + + uint8_t m_cmd; + uint32_t m_cmd_size; + uint8_t m_terminator; + uint8_t m_status; static const size_t BUFFER_SIZE; static const uint8_t DEFAULT_TERMINATOR; diff --git a/src/devices/machine/ps2pad.h b/src/devices/machine/ps2pad.h index 94fc3359673..2b384fd0818 100644 --- a/src/devices/machine/ps2pad.h +++ b/src/devices/machine/ps2pad.h @@ -58,16 +58,16 @@ protected: CMD_GET_MODE = 0x4c, }; - uint8_t m_recv_buf[64]{}; // Buffer size is a guess - uint8_t m_xmit_buf[64]{}; - uint8_t m_curr_recv = 0; - uint8_t m_curr_xmit = 0; - uint8_t m_end_recv = 0; - uint8_t m_end_xmit = 0; + uint8_t m_recv_buf[64]; // Buffer size is a guess + uint8_t m_xmit_buf[64]; + uint8_t m_curr_recv; + uint8_t m_curr_xmit; + uint8_t m_end_recv; + uint8_t m_end_xmit; - uint8_t m_cmd = 0; - uint8_t m_cmd_size = 0; - bool m_configuring = false; + uint8_t m_cmd; + uint8_t m_cmd_size; + bool m_configuring; static const size_t BUFFER_SIZE; }; diff --git a/src/devices/machine/ps2sif.h b/src/devices/machine/ps2sif.h index 61be8c2d905..83fe5f4a076 100644 --- a/src/devices/machine/ps2sif.h +++ b/src/devices/machine/ps2sif.h @@ -46,14 +46,14 @@ protected: required_device m_intc; - uint32_t m_ms_mailbox = 0; - uint32_t m_sm_mailbox = 0; - uint32_t m_ms_flag = 0; - uint32_t m_sm_flag = 0; - uint32_t m_ctrl = 0; + uint32_t m_ms_mailbox; + uint32_t m_sm_mailbox; + uint32_t m_ms_flag; + uint32_t m_sm_flag; + uint32_t m_ctrl; std::unique_ptr m_fifo[2]; - uint32_t m_fifo_curr[2]{}; + uint32_t m_fifo_curr[2]; }; DECLARE_DEVICE_TYPE(SONYPS2_SIF, ps2_sif_device) diff --git a/src/mame/drivers/s7.cpp b/src/mame/drivers/s7.cpp index d5bd588067a..dce45e9e33f 100644 --- a/src/mame/drivers/s7.cpp +++ b/src/mame/drivers/s7.cpp @@ -48,7 +48,6 @@ Thunderball 508 1 unknown HyperBall 509 1 unknown Barracora 510 ASD hit 1 ASD Varkon 512 AX hit 1 AX -Spellbinder (unreleased) 513 Reflex (unreleased) 514 Time Fantasy 515 1 X Warlok 516 1 X -- cgit v1.2.3