From 49c3b8a8b32003f3c6fda21b08369c271ef2ad53 Mon Sep 17 00:00:00 2001 From: Robbbert Date: Wed, 30 Mar 2022 16:51:44 +1100 Subject: init vars for coverity (drivers) --- src/mame/drivers/atarisy4.cpp | 2 +- src/mame/drivers/bionicc.cpp | 4 ++-- src/mame/drivers/dvk_ksm.cpp | 8 +++---- src/mame/drivers/ecoinfr.cpp | 4 ++-- src/mame/drivers/ghosteo.cpp | 10 ++++---- src/mame/drivers/hapyfish.cpp | 2 +- src/mame/drivers/hp16500.cpp | 2 +- src/mame/drivers/macpdm.cpp | 10 ++++---- src/mame/drivers/magic10.cpp | 6 ++--- src/mame/drivers/magicfly.cpp | 4 ++-- src/mame/drivers/magictg.cpp | 28 +++++++++++----------- src/mame/drivers/marinedt.cpp | 16 ++++++------- src/mame/drivers/mgavegas.cpp | 54 +++++++++++++++++++++--------------------- src/mame/drivers/notetaker.cpp | 24 +++++++++---------- src/mame/drivers/pasopia7.cpp | 2 +- src/mame/drivers/positron.cpp | 2 +- src/mame/drivers/smc777.cpp | 2 +- src/mame/drivers/ssfindo.cpp | 2 +- src/mame/drivers/ttchamp.cpp | 2 +- src/mame/drivers/vgmplay.cpp | 2 +- src/mame/drivers/vis.cpp | 2 +- src/mame/includes/nforcepc.h | 34 +++++++++++++------------- 22 files changed, 111 insertions(+), 111 deletions(-) diff --git a/src/mame/drivers/atarisy4.cpp b/src/mame/drivers/atarisy4.cpp index fe67920df48..17d1afb1600 100644 --- a/src/mame/drivers/atarisy4.cpp +++ b/src/mame/drivers/atarisy4.cpp @@ -338,7 +338,7 @@ void atarisy4_state::atarisy4_renderer::draw_scanline(int32_t scanline, const ex void atarisy4_state::atarisy4_renderer::draw_polygon(uint16_t color) { rectangle clip; - vertex_t v1, v2, v3; + vertex_t v1{}, v2{}, v3{}; atarisy4_polydata &extradata = object_data().next(); render_delegate rd_scan = render_delegate(&atarisy4_renderer::draw_scanline, this); diff --git a/src/mame/drivers/bionicc.cpp b/src/mame/drivers/bionicc.cpp index 370a85a7950..d3dbb6663c1 100644 --- a/src/mame/drivers/bionicc.cpp +++ b/src/mame/drivers/bionicc.cpp @@ -164,8 +164,8 @@ private: void audiocpu_nmi_w(u8 data); // protection mcu - u8 m_audiocpu_to_mcu; // ls374 at 4a - u8 m_mcu_to_audiocpu; // ls374 at 5a + u8 m_audiocpu_to_mcu = 0; // ls374 at 4a + u8 m_mcu_to_audiocpu = 0; // ls374 at 5a u8 m_mcu_p1 = 0; u8 m_mcu_p3; diff --git a/src/mame/drivers/dvk_ksm.cpp b/src/mame/drivers/dvk_ksm.cpp index a0d1c776757..0a558016f64 100644 --- a/src/mame/drivers/dvk_ksm.cpp +++ b/src/mame/drivers/dvk_ksm.cpp @@ -136,8 +136,8 @@ private: struct { - uint8_t line; - uint16_t ptr; + uint8_t line = 0; + uint16_t ptr = 0; } m_video; enum @@ -145,8 +145,8 @@ private: TIMER_ID_BRG = 0 }; - bool brg_state; - int brga, brgb, brgc; + bool brg_state = false; + int brga = 0, brgb = 0, brgc = 0; emu_timer *m_brg = nullptr; void update_brg(bool a, bool b, int c); diff --git a/src/mame/drivers/ecoinfr.cpp b/src/mame/drivers/ecoinfr.cpp index 8c0d0a6291a..667824d27e2 100644 --- a/src/mame/drivers/ecoinfr.cpp +++ b/src/mame/drivers/ecoinfr.cpp @@ -116,8 +116,8 @@ private: virtual void machine_start() override { m_digits.resolve(); } TIMER_DEVICE_CALLBACK_MEMBER(ecoinfr_irq_timer); - uint8_t m_banksel; - uint8_t m_credsel; + uint8_t m_banksel = 0; + uint8_t m_credsel = 0; required_device m_maincpu; required_device_array m_reel; diff --git a/src/mame/drivers/ghosteo.cpp b/src/mame/drivers/ghosteo.cpp index 6ce3b6c92b9..4875b160fc0 100644 --- a/src/mame/drivers/ghosteo.cpp +++ b/src/mame/drivers/ghosteo.cpp @@ -81,10 +81,10 @@ enum nand_mode_t struct nand_t { - nand_mode_t mode; - int page_addr; - int byte_addr; - int addr_load_ptr; + nand_mode_t mode{}; + int page_addr = 0; + int byte_addr = 0; + int addr_load_ptr = 0; }; @@ -135,7 +135,7 @@ private: void qs1000_p2_w(uint8_t data); void qs1000_p3_w(uint8_t data); - int m_rom_pagesize; + int m_rom_pagesize = 0; uint32_t s3c2410_gpio_port_r(offs_t offset); void s3c2410_gpio_port_w(offs_t offset, uint32_t data); uint32_t s3c2410_core_pin_r(offs_t offset); diff --git a/src/mame/drivers/hapyfish.cpp b/src/mame/drivers/hapyfish.cpp index 6ae0209ae13..00518350289 100644 --- a/src/mame/drivers/hapyfish.cpp +++ b/src/mame/drivers/hapyfish.cpp @@ -114,7 +114,7 @@ private: bool m_i2c_scl = false; bool m_i2c_scl_pulse_started = false; bool m_i2c_started = false; - i2c_mode m_i2c_mode; + i2c_mode m_i2c_mode{}; uint8_t m_i2c_addr = 0; uint8_t m_i2c_addr_bits = 0; uint8_t m_i2c_data = 0; diff --git a/src/mame/drivers/hp16500.cpp b/src/mame/drivers/hp16500.cpp index a65ba307de9..86e6e4ee4ef 100644 --- a/src/mame/drivers/hp16500.cpp +++ b/src/mame/drivers/hp16500.cpp @@ -109,7 +109,7 @@ private: void hp1650_map(address_map &map); void hp1651_map(address_map &map); - uint32_t m_palette[256], m_colors[3], m_count, m_clutoffs; + uint32_t m_palette[256]{}, m_colors[3]{}, m_count = 0, m_clutoffs = 0; }; uint32_t hp16500_state::vbl_state_r() diff --git a/src/mame/drivers/macpdm.cpp b/src/mame/drivers/macpdm.cpp index 7bb07d0b8eb..f21d326a46e 100644 --- a/src/mame/drivers/macpdm.cpp +++ b/src/mame/drivers/macpdm.cpp @@ -47,13 +47,13 @@ private: required_device_array m_floppy; required_device m_video; - floppy_image_device *m_cur_floppy; + floppy_image_device *m_cur_floppy = nullptr; - uint32_t m_model_id; - uint64_t m_hmc_reg, m_hmc_buffer; - uint8_t m_hmc_bit; + uint32_t m_model_id = 0; + uint64_t m_hmc_reg = 0, m_hmc_buffer = 0; + uint8_t m_hmc_bit = 0; - uint8_t m_irq_control; + uint8_t m_irq_control = 0; uint8_t m_via2_ier = 0, m_via2_ifr = 0, m_via2_sier = 0, m_via2_sifr = 0; diff --git a/src/mame/drivers/magic10.cpp b/src/mame/drivers/magic10.cpp index 1725d7862fd..9f7483c93d2 100644 --- a/src/mame/drivers/magic10.cpp +++ b/src/mame/drivers/magic10.cpp @@ -162,9 +162,9 @@ protected: TILE_GET_INFO_MEMBER(get_layer2_tile_info); uint32_t screen_update(screen_device &screen, bitmap_ind16 &bitmap, const rectangle &cliprect); - tilemap_t *m_tilemap[3]; + tilemap_t *m_tilemap[3]{}; required_shared_ptr_array m_videoram; - int8_t m_layer2_offset[2]; + int8_t m_layer2_offset[2]{}; required_shared_ptr m_vregs; required_device m_maincpu; @@ -222,7 +222,7 @@ protected: private: uint16_t r(); - uint16_t m_ret; + uint16_t m_ret = 0; void map(address_map &map); }; diff --git a/src/mame/drivers/magicfly.cpp b/src/mame/drivers/magicfly.cpp index b0e1d704ccd..a40c756f628 100644 --- a/src/mame/drivers/magicfly.cpp +++ b/src/mame/drivers/magicfly.cpp @@ -476,8 +476,8 @@ protected: private: required_shared_ptr m_videoram; required_shared_ptr m_colorram; - tilemap_t *m_bg_tilemap; - int m_input_selector; + tilemap_t *m_bg_tilemap = nullptr; + int m_input_selector = 0; required_device m_maincpu; required_device m_dac; required_device m_gfxdecode; diff --git a/src/mame/drivers/magictg.cpp b/src/mame/drivers/magictg.cpp index 4c8726b6549..64cb652ec87 100644 --- a/src/mame/drivers/magictg.cpp +++ b/src/mame/drivers/magictg.cpp @@ -174,10 +174,10 @@ private: /* ASIC */ struct { - uint32_t src_addr; - uint32_t dst_addr; - uint32_t ctrl; - uint32_t count; + uint32_t src_addr = 0; + uint32_t dst_addr = 0; + uint32_t ctrl = 0; + uint32_t count = 0; } m_dma_ch[3]; @@ -186,10 +186,10 @@ private: struct { - uint16_t bdma_internal_addr; - uint16_t bdma_external_addr; - uint16_t bdma_control; - uint16_t bdma_word_count; + uint16_t bdma_internal_addr = 0; + uint16_t bdma_external_addr = 0; + uint16_t bdma_control = 0; + uint16_t bdma_word_count = 0; } m_adsp_regs; @@ -199,21 +199,21 @@ private: struct { /* PCI */ - uint32_t command; - uint32_t base_addr; + uint32_t command = 0; + uint32_t base_addr = 0; - uint32_t init_enable; + uint32_t init_enable = 0; } m_voodoo_pci_regs[2]; struct { /* PCI */ - uint32_t command; - uint32_t base_addr; + uint32_t command = 0; + uint32_t base_addr = 0; /* Memory-mapped */ - uint32_t as_regs[0x200]; // was 19, increased to 0x200 for coverity 315123, needed for zr36120_r/w, to stop crash at start. + uint32_t as_regs[0x200]{}; // was 19, increased to 0x200 for coverity 315123, needed for zr36120_r/w, to stop crash at start. } m_zr36120; diff --git a/src/mame/drivers/marinedt.cpp b/src/mame/drivers/marinedt.cpp index b0a4bdfdb75..8f1bfcd27fd 100644 --- a/src/mame/drivers/marinedt.cpp +++ b/src/mame/drivers/marinedt.cpp @@ -157,20 +157,20 @@ private: required_device m_gfxdecode; required_ioport_array<4> m_in_track; - tilemap_t *m_tilemap; + tilemap_t *m_tilemap = nullptr; std::unique_ptr m_seabitmap[2]; struct { - uint8_t offs; - uint8_t x; - uint8_t y; + uint8_t offs = 0; + uint8_t x = 0; + uint8_t y = 0; bitmap_ind16 bitmap; }m_obj[2]; - uint8_t m_layer_en; - uint8_t m_in_select; - bool m_screen_flip; - uint8_t m_sea_bank; + uint8_t m_layer_en = 0; + uint8_t m_in_select = 0; + bool m_screen_flip = false; + uint8_t m_sea_bank = 0; void init_seabitmap(); void obj_reg_w(uint8_t which,uint8_t reg, uint8_t data); diff --git a/src/mame/drivers/mgavegas.cpp b/src/mame/drivers/mgavegas.cpp index 609f1208a30..6b9a9e35df9 100644 --- a/src/mame/drivers/mgavegas.cpp +++ b/src/mame/drivers/mgavegas.cpp @@ -69,41 +69,41 @@ public: void init_mgavegas133(); private: - uint8_t m_int; + uint8_t m_int = 0; //OUT1 - uint8_t m_ckmod; - uint8_t m_dmod; - uint8_t m_emod; - uint8_t m_inh; - uint8_t m_hop; - uint8_t m_seg; - uint8_t m_printer; - uint8_t m_auxp; + uint8_t m_ckmod = 0; + uint8_t m_dmod = 0; + uint8_t m_emod = 0; + uint8_t m_inh = 0; + uint8_t m_hop = 0; + uint8_t m_seg = 0; + uint8_t m_printer = 0; + uint8_t m_auxp = 0; //helper... - uint8_t m_old_ckmod; - uint8_t m_old_emod; + uint8_t m_old_ckmod = 0; + uint8_t m_old_emod = 0; //OUT2 - uint8_t m_bobina_ctrl; - uint8_t m_timbre; - uint8_t m_coil_1; - uint8_t m_coil_2; - uint8_t m_coil_3; - uint8_t m_cont_ent; - uint8_t m_cont_sal; - uint8_t m_cont_caj; + uint8_t m_bobina_ctrl = 0; + uint8_t m_timbre = 0; + uint8_t m_coil_1 = 0; + uint8_t m_coil_2 = 0; + uint8_t m_coil_3 = 0; + uint8_t m_cont_ent = 0; + uint8_t m_cont_sal = 0; + uint8_t m_cont_caj = 0; //lamps out - uint64_t m_custom_data; - uint8_t m_auxs; - uint8_t m_anal; - uint8_t m_anacl; - uint8_t m_anacr; - uint8_t m_anar; - uint8_t m_pl; - uint8_t m_pc; + uint64_t m_custom_data = 0L; + uint8_t m_auxs = 0; + uint8_t m_anal = 0; + uint8_t m_anacl = 0; + uint8_t m_anacr = 0; + uint8_t m_anar = 0; + uint8_t m_pl = 0; + uint8_t m_pc = 0; uint8_t m_pr = 0; uint8_t m_luz_250_rul = 0; uint8_t m_luz_100_rul = 0; diff --git a/src/mame/drivers/notetaker.cpp b/src/mame/drivers/notetaker.cpp index 911b0ac28f5..7b9e4ca7510 100644 --- a/src/mame/drivers/notetaker.cpp +++ b/src/mame/drivers/notetaker.cpp @@ -185,18 +185,18 @@ private: void ep_mainram_w(offs_t offset, uint16_t data, uint16_t mem_mask); //variables // IPConReg - uint8_t m_BootSeqDone; - uint8_t m_ProcLock; - uint8_t m_CharCtr; - uint8_t m_DisableROM; - uint8_t m_CorrOn_q; - uint8_t m_LedInd6; - uint8_t m_LedInd7; - uint8_t m_LedInd8; + uint8_t m_BootSeqDone = 0; + uint8_t m_ProcLock = 0; + uint8_t m_CharCtr = 0; + uint8_t m_DisableROM = 0; + uint8_t m_CorrOn_q = 0; + uint8_t m_LedInd6 = 0; + uint8_t m_LedInd7 = 0; + uint8_t m_LedInd8 = 0; // FIFOReg - uint8_t m_TabletYOn; - uint8_t m_TabletXOn; - uint8_t m_FrSel2; + uint8_t m_TabletYOn = 0; + uint8_t m_TabletXOn = 0; + uint8_t m_FrSel2 = 0; uint8_t m_FrSel1 = 0; uint8_t m_FrSel0 = 0; uint8_t m_SHConB = 0; @@ -228,7 +228,7 @@ private: emu_timer *m_FIFO_timer = nullptr; TIMER_CALLBACK_MEMBER(timer_fifoclk); // framebuffer display starting address - uint16_t m_DispAddr; + uint16_t m_DispAddr = 0; // separate cpu resets void iop_reset(); diff --git a/src/mame/drivers/pasopia7.cpp b/src/mame/drivers/pasopia7.cpp index 6410f9fc773..eb41c2e2a37 100644 --- a/src/mame/drivers/pasopia7.cpp +++ b/src/mame/drivers/pasopia7.cpp @@ -137,7 +137,7 @@ private: uint8_t m_nmi_reset = 0; uint8_t m_screen_type = 0; void pasopia_nmi_trap(); - uint8_t m_mux_data; + uint8_t m_mux_data = 0; u8 m_porta_2 = 0; bool m_spr_sw = false; emu_timer *m_pio_timer = nullptr; diff --git a/src/mame/drivers/positron.cpp b/src/mame/drivers/positron.cpp index d04b2409080..5f35367ebab 100644 --- a/src/mame/drivers/positron.cpp +++ b/src/mame/drivers/positron.cpp @@ -113,7 +113,7 @@ private: memory_passthrough_handler m_mmu_shadow_tap; - uint8_t m_prev_opcode; + uint8_t m_prev_opcode = 0; }; diff --git a/src/mame/drivers/smc777.cpp b/src/mame/drivers/smc777.cpp index 01d5fb00d57..a5d4256ac3e 100644 --- a/src/mame/drivers/smc777.cpp +++ b/src/mame/drivers/smc777.cpp @@ -143,7 +143,7 @@ private: uint8_t m_fdc_drq_flag = 0; uint8_t m_system_data = 0; struct { uint8_t r = 0, g = 0, b = 0; } m_pal; - uint8_t m_raminh,m_raminh_pending_change = 0; //bankswitch + uint8_t m_raminh = 0, m_raminh_pending_change = 0; //bankswitch uint8_t m_raminh_prefetch = 0; uint8_t m_pal_mode = 0; uint8_t m_keyb_cmd = 0; diff --git a/src/mame/drivers/ssfindo.cpp b/src/mame/drivers/ssfindo.cpp index 361aa65e82a..c653b76e3a8 100644 --- a/src/mame/drivers/ssfindo.cpp +++ b/src/mame/drivers/ssfindo.cpp @@ -172,7 +172,7 @@ protected: virtual void machine_reset() override; typedef void (ssfindo_state::*speedup_func)(); - speedup_func m_speedup; + speedup_func m_speedup{}; uint32_t m_flashType = 0; diff --git a/src/mame/drivers/ttchamp.cpp b/src/mame/drivers/ttchamp.cpp index 06a7240c9dd..db8268c0b13 100644 --- a/src/mame/drivers/ttchamp.cpp +++ b/src/mame/drivers/ttchamp.cpp @@ -104,7 +104,7 @@ private: SET_READLATCH = 4 }; - picmode m_picmodex; + picmode m_picmodex{}; int m_pic_readaddr = 0; int m_pic_writeaddr = 0; diff --git a/src/mame/drivers/vgmplay.cpp b/src/mame/drivers/vgmplay.cpp index aa107e29af4..653d023d8d5 100644 --- a/src/mame/drivers/vgmplay.cpp +++ b/src/mame/drivers/vgmplay.cpp @@ -473,7 +473,7 @@ public: private: virtual void machine_start() override; - uint32_t m_held_clock; + uint32_t m_held_clock = 0; std::vector m_file_data; required_device m_vgmplay; required_device m_mixer; diff --git a/src/mame/drivers/vis.cpp b/src/mame/drivers/vis.cpp index 2b33ee077f4..80241d6f625 100644 --- a/src/mame/drivers/vis.cpp +++ b/src/mame/drivers/vis.cpp @@ -252,7 +252,7 @@ private: int m_extcnt = 0; uint8_t m_extreg = 0U; uint8_t m_interlace = 0U; - uint16_t m_wina, m_winb = 0U; + uint16_t m_wina = 0U, m_winb = 0U; uint8_t m_shift256 = 0U, m_dw = 0U, m_8bit_640 = 0U; uint8_t m_crtc_regs[0x32]{}; }; diff --git a/src/mame/includes/nforcepc.h b/src/mame/includes/nforcepc.h index efc255aaf51..cca0d9a8eaa 100644 --- a/src/mame/includes/nforcepc.h +++ b/src/mame/includes/nforcepc.h @@ -52,7 +52,7 @@ protected: private: required_device cpu; required_device biosrom; - uint32_t ram_size; + uint32_t ram_size = 0; virtual uint8_t header_type_r() override; uint8_t unknown_r(); @@ -83,9 +83,9 @@ protected: private: int ddr_ram_size = 0; - std::vector ram; - crush11_host_device *host; - address_space *ram_space; + std::vector ram{}; + crush11_host_device *host = nullptr; + address_space *ram_space = nullptr; }; DECLARE_DEVICE_TYPE(CRUSH11_MEMORY, crush11_memory_device) @@ -274,11 +274,11 @@ private: ACPI, // ACPI Gpio567 = 12 // GPIO set 5, 6 and 7 }; - int config_key_step; - int config_index; - int logical_device; - uint8_t global_configuration_registers[0x30]; - uint8_t configuration_registers[13][0x100]; + int config_key_step = 0; + int config_index = 0; + int logical_device = 0; + uint8_t global_configuration_registers[0x30]{}; + uint8_t configuration_registers[13][0x100]{}; devcb_write_line pin_reset_callback; devcb_write_line pin_gatea20_callback; devcb_write_line m_txd1_callback; @@ -292,14 +292,14 @@ private: required_device pc_serial1_comdev; required_device pc_serial2_comdev; required_device m_kbdc; - bool enabled_logical[13]; - bool enabled_game_port; - bool enabled_midi_port; - - lpcbus_host_interface *lpchost; - int lpcindex; - address_space *memspace; - address_space *iospace; + bool enabled_logical[13]{}; + bool enabled_game_port = false; + bool enabled_midi_port = false; + + lpcbus_host_interface *lpchost = nullptr; + int lpcindex = 0; + address_space *memspace = nullptr; + address_space *iospace = nullptr; void internal_memory_map(address_map &map); void internal_io_map(address_map &map); -- cgit v1.2.3