From 49a50ae2ae5d12ac857a962438ef1457144975aa Mon Sep 17 00:00:00 2001 From: MooglyGuy Date: Sun, 20 Jan 2019 19:30:14 +0100 Subject: -spg2xx: Fade control register is 8 bits wide, not 7. Fixes flickery fading in rad_fb2. [Ryan Holtz] --- src/devices/machine/spg2xx.cpp | 6 +++--- src/mame/drivers/vii.cpp | 2 -- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/devices/machine/spg2xx.cpp b/src/devices/machine/spg2xx.cpp index e2591637367..97865eac853 100644 --- a/src/devices/machine/spg2xx.cpp +++ b/src/devices/machine/spg2xx.cpp @@ -52,10 +52,10 @@ DEFINE_DEVICE_TYPE(SPG28X, spg28x_device, "spg28x", "SPG280-series System-on-a-C #define LOG_PPU (LOG_PPU_READS | LOG_PPU_WRITES | LOG_UNKNOWN_PPU) #define LOG_ALL (LOG_IO | LOG_SPU | LOG_PPU | LOG_VLINES | LOG_SEGMENT | LOG_FIQ) -#define VERBOSE (0) +#define VERBOSE (LOG_ALL & ~LOG_SPU) #include "logmacro.h" -#define SPG_DEBUG_VIDEO (0) +#define SPG_DEBUG_VIDEO (1) #define SPG_DEBUG_AUDIO (0) #define IO_IRQ_ENABLE m_io_regs[0x21] @@ -634,7 +634,7 @@ void spg2xx_device::apply_saturation(const rectangle &cliprect) void spg2xx_device::apply_fade(const rectangle &cliprect) { - const uint16_t fade_offset = m_video_regs[0x30] << 1; + const uint16_t fade_offset = m_video_regs[0x30]; for (int y = cliprect.min_y; y <= cliprect.max_y; y++) { uint32_t *src = &m_screenbuf[cliprect.min_x + 320 * y]; diff --git a/src/mame/drivers/vii.cpp b/src/mame/drivers/vii.cpp index 244887640dd..1c15c0df476 100644 --- a/src/mame/drivers/vii.cpp +++ b/src/mame/drivers/vii.cpp @@ -232,7 +232,6 @@ void spg2xx_game_state::switch_bank(uint32_t bank) { if (bank != m_current_bank) { - printf("Switching bank to: %d\n", bank); fflush(stdout); m_current_bank = bank; m_bank->set_entry(bank); m_maincpu->invalidate_cache(); @@ -763,7 +762,6 @@ void spg2xx_game_state::machine_start() { m_bank->configure_entries(0, (memregion("maincpu")->bytes() + 0x7fffff) / 0x800000, memregion("maincpu")->base(), 0x800000); m_bank->set_entry(0); - printf("There are %d banks.\n", (memregion("maincpu")->bytes() + 0x7fffff) / 0x800000); m_serial_eeprom = std::make_unique(0x400); if (m_nvram) -- cgit v1.2.3