From 450395f838dd0d0bcec2d4568aa4ad2071062d65 Mon Sep 17 00:00:00 2001 From: hap Date: Sat, 1 Oct 2022 00:07:33 +0200 Subject: suprgolfj: remove old unneeded rompatch --- src/mame/nasco/suprgolf.cpp | 39 +++++---------------------------------- 1 file changed, 5 insertions(+), 34 deletions(-) diff --git a/src/mame/nasco/suprgolf.cpp b/src/mame/nasco/suprgolf.cpp index caf26aa974f..7cf3a5d720c 100644 --- a/src/mame/nasco/suprgolf.cpp +++ b/src/mame/nasco/suprgolf.cpp @@ -7,8 +7,7 @@ driver by Tomasz Slanina & Angelo Salese TODO: - - remove the patch and understand what needs to be modified for the gfxs, game - doesn't crash anymore (note: I suspect it's actually a ppi port C bug); + - understand what needs to be modified for the gfxs; - Some weird framebuffer vertical gaps with some object, namely the green and the trees (zooming?) - not sure if the analog inputs are handled correctly; @@ -49,8 +48,6 @@ public: void suprgolf(machine_config &config); - void init_suprgolf(); - protected: virtual void machine_start() override; virtual void machine_reset() override; @@ -71,12 +68,10 @@ private: std::unique_ptr m_fg_fb; uint8_t m_rom_bank = 0; uint8_t m_bg_bank = 0; - uint8_t m_vreg_bank = 0; uint8_t m_msm5205next = 0; uint8_t m_msm_nmi_mask = 0; uint8_t m_vreg_pen = 0; uint8_t m_palette_switch = 0; - uint8_t m_bg_vreg_test = 0; uint8_t m_toggle = 0; uint8_t videoram_r(offs_t offset); @@ -86,7 +81,6 @@ private: void pen_w(uint8_t data); void adpcm_data_w(uint8_t data); void rom2_bank_select_w(uint8_t data); - uint8_t vregs_r(); void vregs_w(uint8_t data); uint8_t rom_bank_select_r(); void rom_bank_select_w(uint8_t data); @@ -126,10 +120,8 @@ void suprgolf_state::video_start() m_tilemap->set_transparent_pen(15); save_item(NAME(m_bg_bank)); - save_item(NAME(m_vreg_bank)); save_item(NAME(m_vreg_pen)); save_item(NAME(m_palette_switch)); - save_item(NAME(m_bg_vreg_test)); save_pointer(NAME(m_paletteram), 0x1000); save_pointer(NAME(m_bg_vram), 0x2000*0x20); save_pointer(NAME(m_bg_fb), 0x2000*0x20); @@ -205,22 +197,14 @@ void suprgolf_state::videoram_w(offs_t offset, uint8_t data) } } -uint8_t suprgolf_state::vregs_r() -{ - return m_vreg_bank; -} - void suprgolf_state::vregs_w(uint8_t data) { //printf("%02x\n",data); //bits 0,1,2 and probably 3 controls the background vram banking - m_vreg_bank = data; m_palette_switch = (data & 0x80); m_bg_bank = (data & 0x1f); - m_bg_vreg_test = data & 0x20; - //if(data & 0x60) // printf("Video regs with data %02x activated\n",data); } @@ -361,7 +345,7 @@ void suprgolf_state::io_map(address_map &map) map(0x04, 0x07).rw("ppi8255_1", FUNC(i8255_device::read), FUNC(i8255_device::write)); map(0x08, 0x09).rw("ymsnd", FUNC(ym2203_device::read), FUNC(ym2203_device::write)); map(0x0c, 0x0c).w(FUNC(suprgolf_state::adpcm_data_w)); - } +} static INPUT_PORTS_START( suprgolf ) PORT_START("P1") @@ -501,7 +485,6 @@ void suprgolf_state::suprgolf(machine_config &config) ppi1.in_pa_callback().set_ioport("SYSTEM"); ppi1.in_pb_callback().set(FUNC(suprgolf_state::rom_bank_select_r)); ppi1.out_pb_callback().set(FUNC(suprgolf_state::rom_bank_select_w)); - ppi1.in_pc_callback().set(FUNC(suprgolf_state::vregs_r)); ppi1.out_pc_callback().set(FUNC(suprgolf_state::vregs_w)); /* video hardware */ @@ -662,21 +645,9 @@ ROM_START( albatross ) ROM_LOAD( "chr4.3d", 0x030000, 0x010000, CRC(0fb88270) SHA1(d85a7f1bc5b3c4b13bbd887cea4c055541cbb737) ) ROM_END - - - -void suprgolf_state::init_suprgolf() -{ - uint8_t *ROM = memregion("user2")->base(); - - ROM[0x74f4-0x4000] = 0x00; - ROM[0x74f5-0x4000] = 0x00; - ROM[0x6d72+(0x4000*3)-0x4000] = 0x20; //patch ROM check -} - } // Anonymous namespace -GAME( 1989, suprgolf, 0, suprgolf, suprgolf, suprgolf_state, empty_init, ROT0, "Nasco", "Super Crowns Golf (World)", MACHINE_IMPERFECT_GRAPHICS | MACHINE_NO_COCKTAIL | MACHINE_SUPPORTS_SAVE ) -GAME( 1989, suprgolfj, suprgolf, suprgolf, suprgolf, suprgolf_state, init_suprgolf, ROT0, "Nasco", "Super Crowns Golf (Japan)", MACHINE_IMPERFECT_GRAPHICS | MACHINE_NO_COCKTAIL | MACHINE_SUPPORTS_SAVE ) -GAME( 1989, albatross, suprgolf, suprgolf, suprgolf, suprgolf_state, empty_init, ROT0, "Nasco", "Albatross (US Prototype?)", MACHINE_NOT_WORKING | MACHINE_IMPERFECT_GRAPHICS | MACHINE_NO_COCKTAIL| MACHINE_SUPPORTS_SAVE ) +GAME( 1989, suprgolf, 0, suprgolf, suprgolf, suprgolf_state, empty_init, ROT0, "Nasco", "Super Crowns Golf (World)", MACHINE_IMPERFECT_GRAPHICS | MACHINE_NO_COCKTAIL | MACHINE_SUPPORTS_SAVE ) +GAME( 1989, suprgolfj, suprgolf, suprgolf, suprgolf, suprgolf_state, empty_init, ROT0, "Nasco", "Super Crowns Golf (Japan)", MACHINE_IMPERFECT_GRAPHICS | MACHINE_NO_COCKTAIL | MACHINE_SUPPORTS_SAVE ) +GAME( 1989, albatross, suprgolf, suprgolf, suprgolf, suprgolf_state, empty_init, ROT0, "Nasco", "Albatross (US Prototype?)", MACHINE_NOT_WORKING | MACHINE_IMPERFECT_GRAPHICS | MACHINE_NO_COCKTAIL| MACHINE_SUPPORTS_SAVE ) -- cgit v1.2.3