From 23c70e8b601969b4a827b79dba5840bcdb442315 Mon Sep 17 00:00:00 2001 From: hap Date: Thu, 1 Aug 2019 17:53:21 +0200 Subject: coreutil: remove single-use (and savestate unsafe) rand_memory function (nw) --- src/devices/cpu/cosmac/cosmac.cpp | 4 +++- src/lib/util/coreutil.cpp | 23 ----------------------- src/lib/util/coreutil.h | 2 -- src/mame/drivers/debut.cpp | 2 +- src/mame/drivers/mephisto_glasgow.cpp | 16 ++++++++-------- 5 files changed, 12 insertions(+), 35 deletions(-) diff --git a/src/devices/cpu/cosmac/cosmac.cpp b/src/devices/cpu/cosmac/cosmac.cpp index 6398be4f64e..64e20182c45 100644 --- a/src/devices/cpu/cosmac/cosmac.cpp +++ b/src/devices/cpu/cosmac/cosmac.cpp @@ -391,7 +391,9 @@ void cosmac_device::device_reset() set_q_flag(0); m_df = 0; m_p = 0; - rand_memory(m_r, sizeof(m_r)); + + for (int i = 0; i < ARRAY_LENGTH(m_r); i++) + m_r[i] = machine().rand() & 0xffff; } diff --git a/src/lib/util/coreutil.cpp b/src/lib/util/coreutil.cpp index bd10802ef5a..d973080e354 100644 --- a/src/lib/util/coreutil.cpp +++ b/src/lib/util/coreutil.cpp @@ -62,29 +62,6 @@ uint32_t bcd_2_dec(uint32_t a) MISC ***************************************************************************/ -/** - * @fn void rand_memory(void *memory, size_t length) - * - * @brief Random memory. - * - * @param [in,out] memory If non-null, the memory. - * @param length The length. - */ - -void rand_memory(void *memory, size_t length) -{ - static uint32_t seed = 0; - uint8_t *bytes = (uint8_t *) memory; - size_t i; - - for (i = 0; i < length; i++) - { - seed = seed * 214013 + 2531011; - bytes[i] = (uint8_t) (seed >> 16); - } -} - - uint32_t core_crc32(uint32_t crc, const uint8_t *buf, uint32_t len) { return crc32(crc, buf, len); diff --git a/src/lib/util/coreutil.h b/src/lib/util/coreutil.h index cf5106f953d..a0166818da8 100644 --- a/src/lib/util/coreutil.h +++ b/src/lib/util/coreutil.h @@ -77,8 +77,6 @@ inline int gregorian_days_in_month(int month, int year) MISC ***************************************************************************/ -void rand_memory(void *memory, size_t length); - uint32_t core_crc32(uint32_t crc, const uint8_t *buf, uint32_t len); #endif // MAME_UTIL_COREUTIL_H diff --git a/src/mame/drivers/debut.cpp b/src/mame/drivers/debut.cpp index 300427dc098..540f5fdb756 100644 --- a/src/mame/drivers/debut.cpp +++ b/src/mame/drivers/debut.cpp @@ -17,7 +17,7 @@ TODO: Hardware notes: - КР1810ВМ86 (i8086 clone), 16200K XTAL - КР1810ГФ84 (i8284 clock divider /3) -- 2*КР537РУ10 (2KB*8 RAM), 2*8KB ROM +- 2*КР537РУ10 (2KB*8 RAM), 2*КС573РФ4А or similar (8KB ROM) - lcd panel (4 7seg digits), 64 chessboard buttons, 16 leds A bit more detailed, list of other Soviet standard TTL chips used and their equivalents: diff --git a/src/mame/drivers/mephisto_glasgow.cpp b/src/mame/drivers/mephisto_glasgow.cpp index 92360f65a22..3321ae73d0a 100644 --- a/src/mame/drivers/mephisto_glasgow.cpp +++ b/src/mame/drivers/mephisto_glasgow.cpp @@ -408,11 +408,11 @@ ROM_END Game drivers ***************************************************************************/ -/* YEAR, NAME, PARENT COMPAT MACHINE INPUT CLASS INIT COMPANY FULLNAME FLAGS */ -CONS( 1984, glasgow, 0, 0, glasgow, old_keyboard, glasgow_state, empty_init, "Hegener & Glaser Muenchen", "Mephisto III S Glasgow", MACHINE_SUPPORTS_SAVE | MACHINE_CLICKABLE_ARTWORK ) -CONS( 1985, amsterd, 0, 0, amsterd, new_keyboard, amsterd_state, empty_init, "Hegener & Glaser Muenchen", "Mephisto Amsterdam", MACHINE_SUPPORTS_SAVE | MACHINE_CLICKABLE_ARTWORK ) -CONS( 1986, dallas, glasgow, 0, glasgow, old_keyboard, glasgow_state, empty_init, "Hegener & Glaser Muenchen", "Mephisto Dallas", MACHINE_SUPPORTS_SAVE | MACHINE_CLICKABLE_ARTWORK ) -CONS( 1986, dallas16, amsterd, 0, amsterd, new_keyboard, amsterd_state, empty_init, "Hegener & Glaser Muenchen", "Mephisto Dallas 16 Bit", MACHINE_SUPPORTS_SAVE | MACHINE_CLICKABLE_ARTWORK ) -CONS( 1986, dallas32, amsterd, 0, dallas32, new_keyboard, amsterd_state, empty_init, "Hegener & Glaser Muenchen", "Mephisto Dallas 32 Bit", MACHINE_SUPPORTS_SAVE | MACHINE_CLICKABLE_ARTWORK ) -CONS( 1987, roma, amsterd, 0, amsterd, new_keyboard, amsterd_state, empty_init, "Hegener & Glaser Muenchen", "Mephisto Roma", MACHINE_SUPPORTS_SAVE | MACHINE_CLICKABLE_ARTWORK ) -CONS( 1987, roma32, amsterd, 0, dallas32, new_keyboard, amsterd_state, empty_init, "Hegener & Glaser Muenchen", "Mephisto Roma 32 Bit", MACHINE_SUPPORTS_SAVE | MACHINE_CLICKABLE_ARTWORK ) +/* YEAR, NAME, PARENT COMPAT MACHINE INPUT CLASS INIT COMPANY FULLNAME FLAGS */ +CONS( 1984, glasgow, 0, 0, glasgow, old_keyboard, glasgow_state, empty_init, "Hegener & Glaser", "Mephisto III-S Glasgow", MACHINE_SUPPORTS_SAVE | MACHINE_CLICKABLE_ARTWORK ) +CONS( 1985, amsterd, 0, 0, amsterd, new_keyboard, amsterd_state, empty_init, "Hegener & Glaser", "Mephisto Amsterdam", MACHINE_SUPPORTS_SAVE | MACHINE_CLICKABLE_ARTWORK ) +CONS( 1986, dallas, glasgow, 0, glasgow, old_keyboard, glasgow_state, empty_init, "Hegener & Glaser", "Mephisto Dallas", MACHINE_SUPPORTS_SAVE | MACHINE_CLICKABLE_ARTWORK ) +CONS( 1986, dallas16, amsterd, 0, amsterd, new_keyboard, amsterd_state, empty_init, "Hegener & Glaser", "Mephisto Dallas 16 Bit", MACHINE_SUPPORTS_SAVE | MACHINE_CLICKABLE_ARTWORK ) +CONS( 1986, dallas32, amsterd, 0, dallas32, new_keyboard, amsterd_state, empty_init, "Hegener & Glaser", "Mephisto Dallas 32 Bit", MACHINE_SUPPORTS_SAVE | MACHINE_CLICKABLE_ARTWORK ) +CONS( 1987, roma, amsterd, 0, amsterd, new_keyboard, amsterd_state, empty_init, "Hegener & Glaser", "Mephisto Roma", MACHINE_SUPPORTS_SAVE | MACHINE_CLICKABLE_ARTWORK ) +CONS( 1987, roma32, amsterd, 0, dallas32, new_keyboard, amsterd_state, empty_init, "Hegener & Glaser", "Mephisto Roma 32 Bit", MACHINE_SUPPORTS_SAVE | MACHINE_CLICKABLE_ARTWORK ) -- cgit v1.2.3