summaryrefslogtreecommitdiffstatshomepage
diff options
context:
space:
mode:
author Joakim Larsson Edstrom <Joakim.Edstrom@edstromious.se>2019-09-29 22:05:52 +0200
committer Joakim Larsson Edstrom <Joakim.Edstrom@edstromious.se>2019-09-29 22:05:52 +0200
commit5dc9cca08d7d92f2ad00d55b1fa36c683f6cc454 (patch)
tree1d216a84137ff0f1f4b4e83d2b65fd4ea082ad92
parent3245b9d3bac834814e6b4253c7b56cd63e6a023d (diff)
eispc_kb.cpp: experiment with removing direct calls to resume/suspend
-rw-r--r--src/devices/bus/isa/mda.cpp8
-rw-r--r--src/mame/machine/eispc_kb.cpp7
2 files changed, 5 insertions, 10 deletions
diff --git a/src/devices/bus/isa/mda.cpp b/src/devices/bus/isa/mda.cpp
index 1f0cd0b6b11..f660b48a1dd 100644
--- a/src/devices/bus/isa/mda.cpp
+++ b/src/devices/bus/isa/mda.cpp
@@ -1060,13 +1060,7 @@ MC6845_UPDATE_ROW( isa8_ec1840_0002_device::crtc_update_row )
Trivia: https://www.pinterest.se/pin/203084264425177097/
*/
-#define EPC_MDA_SCREEN "epc_mda_screen"
-
-#if 0
-static GFXDECODE_START( pcepc )
- GFXDECODE_ENTRY( "gfx1", 0x0000, pc_16_charlayout, 1, 1 )
-GFXDECODE_END
-#endif
+#define EPC_MDA_SCREEN "epc_mda_screen" // TODO: use a device finder reference instead
ROM_START( epc )
ROM_REGION(0x2000,"chargen", 0)
diff --git a/src/mame/machine/eispc_kb.cpp b/src/mame/machine/eispc_kb.cpp
index 5f8a2e76e2f..a1ac3a64626 100644
--- a/src/mame/machine/eispc_kb.cpp
+++ b/src/mame/machine/eispc_kb.cpp
@@ -297,11 +297,14 @@ WRITE_LINE_MEMBER(eispc_keyboard_device::rst_line_w)
if (state == CLEAR_LINE)
{
m_mcu->resume(SUSPEND_REASON_RESET);
+ //m_mcu->set_input_line(INPUT_LINE_RESET, CLEAR_LINE);
LOGRST("KBD: Keyboard mcu reset line is cleared\n");
}
else
{
- m_mcu->suspend(SUSPEND_REASON_RESET, 0);
+ // set_input_line suspends with a true argument which causes "Keyboard error"
+ m_mcu->suspend(SUSPEND_REASON_RESET, false);
+ //m_mcu->set_input_line(INPUT_LINE_RESET, ASSERT_LINE);
LOGRST("KBD: Keyboard mcu reset line is asserted\n");
}
@@ -313,8 +316,6 @@ WRITE_LINE_MEMBER(eispc_keyboard_device::rst_line_w)
void eispc_keyboard_device::device_reset()
{
- LOGRST("KBD: Keyboard is in reset until host computer explicitly releases the reset line\n");
- m_mcu->suspend(SUSPEND_REASON_RESET, 0);
for (auto & elem : m_keys) elem = 0;
}